danger-compose_compiler_metrics 0.0.1 → 0.0.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 0a4e4fdbd974ca9e26bf31a9d9d458a24701fba13e2cf50294ae0787573931f4
-  data.tar.gz: 88b1ab8dacfa22cb954b930ffa589e8a3066e949d66c2275f93391a1bf829b44
+  metadata.gz: 2cc60271478af15e0a283d10f7d2b5e1cd1ecc5d899496b6ee3e0ed9b1f58da5
+  data.tar.gz: dc17d7971fae2598ef76c779cd120f3a87bcb943fbd2e9645717c20654885bdd
 SHA512:
-  metadata.gz: bba795ff85c82cd20464458c407375dfbeeca2bcdc0f42b54cdf1842d3fb6b60507ff24e8b1ae796d753a83eab882b90d7f5e742bddd3d65187675099484c63f
-  data.tar.gz: 53b535436b8654a60e2cbb43a42fa4aec95bae0a8cf684627e6ef40b8a063b14145e18d1560b22ef05e350efa99291a4af2d9e0f5bfb14ba7a5f4d050d00e9e3
+  metadata.gz: 9c5bc88d19bf7f84dc09a03f14d8ebc1f211afc6036646f9a6f1a5b469260036fce31d5c4e306d0f2033399d07bd38a5c81804dbfd89b071a3ee47d2a071fe6e
+  data.tar.gz: '085f7761b5f940d85af421a44877a0cd5db43b263412b17f822019189b86bd6ea044c080ed7048f8e0c599da8e9e1ed3985b0bd628d32f122e266854adb9d61f'

data/.github/workflows/test.yml

@@ -0,0 +1,47 @@
+name: test
+on: [push]
+jobs:
+  run:
+    runs-on: ubuntu-latest
+    timeout-minutes: 5
+
+    container:
+      image: ruby:3.0
+      options: --user 1001
+
+    permissions:
+      contents: read
+
+    steps:
+      - name: Checkout
+        uses: actions/checkout@v4
+
+      - name: Restore gem cache
+        uses: actions/cache/restore@v4
+        with:
+          key: ${{ runner.os }}-gem-${{ hashFiles('**/Gemfile.lock') }}
+          path: |
+            vendor/bundle
+          restore-keys: |
+            ${{ runner.os }}-gem-${{ hashFiles('**/Gemfile.lock') }}
+            ${{ runner.os }}-gem-
+            ${{ runner.os }}-
+
+      - name: Bundle install
+        run: |
+          bundle config set path 'vendor/bundle'
+          bundle config set clean 'true'
+          bundle install --jobs 4 --retry 3
+
+      - name: Save gem cache
+        uses: actions/cache/save@v4
+        with:
+          path: |
+            vendor/bundle
+          key: ${{ runner.os }}-gem-${{ hashFiles('**/Gemfile.lock') }}
+
+      - name: Run rubocop
+        run: bundle exec rubocop
+
+      - name: Run rspec
+        run: bundle exec rspec

data/.rubocop.yml

@@ -3,7 +3,7 @@
 # If you don't like these settings, just delete this file :)
 
 AllCops:
-  TargetRubyVersion: 2.7
+  TargetRubyVersion: 3.0
 
 Style/StringLiterals:
   EnforcedStyle: double_quotes

data/.ruby-version

@@ -0,0 +1 @@
+3.0.6

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    danger-compose_compiler_metrics (0.0.1)
+    danger-compose_compiler_metrics (0.0.3)
       csv
       danger-plugin-api (~> 1.0)
       json
@@ -98,7 +98,7 @@ GEM
     public_suffix (5.0.4)
     racc (1.7.3)
     rainbow (3.1.1)
-    rake (10.5.0)
+    rake (13.1.0)
     rb-fsevent (0.11.2)
     rb-inotify (0.10.1)
       ffi (~> 1.0)
@@ -154,7 +154,7 @@ DEPENDENCIES
   guard-rspec (~> 4.7)
   listen (= 3.0.7)
   pry
-  rake (~> 10.0)
+  rake
   rspec (~> 3.4)
   rubocop
   yard

data/danger-compose_compiler_metrics.gemspec

@@ -19,13 +19,15 @@ Gem::Specification.new do |spec|
   spec.test_files    = spec.files.grep(%r{^(test|spec|features)/})
   spec.require_paths = ["lib"]
 
+  spec.required_ruby_version = "~> 3.0"
+
+  spec.add_runtime_dependency "csv"
   spec.add_runtime_dependency "danger-plugin-api", "~> 1.0"
   spec.add_runtime_dependency "json"
-  spec.add_runtime_dependency "csv"
 
   # General ruby development
   spec.add_development_dependency "bundler", "~> 2.0"
-  spec.add_development_dependency "rake", "~> 10.0"
+  spec.add_development_dependency "rake"
 
   # Testing support
   spec.add_development_dependency "rspec", "~> 3.4"

data/lib/compose_compiler_metrics/gem_version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module ComposeCompilerMetrics
-  VERSION = "0.0.1"
+  VERSION = "0.0.3"
 end

data/lib/compose_compiler_metrics/helper.rb

@@ -1,7 +1,9 @@
+# frozen_string_literal: true
+
 module Helper
   def build_variants(dir)
     Dir.glob("#{dir}/*").
-      map { |s| File.basename(s).split(/[_\-]/).take(2) }.
+      map { |s| File.basename(s).split(/[_-]/).take(2) }.
       uniq
   end
 
@@ -45,4 +47,8 @@ module Helper
     </details>
     HTML
   end
+
+  def installed?(command)
+    system("which #{command} > /dev/null")
+  end
 end

data/lib/compose_compiler_metrics/metrics.rb

@@ -0,0 +1,96 @@
+# frozen_string_literal: true
+
+require "json"
+
+class Metrics
+  attr_reader :hash
+
+  def initialize(hash)
+    @hash = hash
+  end
+
+  def keys
+    to_h.keys
+  end
+
+  def grouping_keys
+    keys.map { |key| grouping_key(key) }.uniq
+  end
+
+  def grouped_metrics
+    hash.
+      group_by { |k, _| grouping_key(k) }.
+      transform_values { |array| Metrics.new(array.to_h) }
+  end
+
+  def to_h
+    hash
+  end
+
+  def respond_to_missing?(method_name, include_private)
+    hash.key?(method_name.to_s) || hash.key?(convert_to_metrics_key(method_name)) || super
+  end
+
+  def method_missing(method_name)
+    return hash[method_name.to_s] if hash.key?(method_name.to_s)
+
+    key = convert_to_metrics_key(method_name)
+    return hash[key] if hash.key?(key)
+
+    super method_name
+  end
+
+  def self.load(path)
+    Loader.new(path).load
+  end
+
+  def ==(other)
+    hash == other.hash
+  end
+
+  class Loader
+    attr_reader :path
+
+    def initialize(path)
+      @path = path
+    end
+
+    def metrics_hash
+      @metrics_hash ||= JSON.parse(File.read(path))
+    end
+
+    def load
+      advanced_metrics_hash = metrics_hash.each.with_object({}) do |(k, v), h|
+        h[k] = v
+
+        case k
+        when "skippableComposables"
+          h["unskippableComposables"] = metrics_hash["totalComposables"] - metrics_hash["skippableComposables"]
+        when "restartableComposables"
+          h["unrestartableComposables"] = metrics_hash["totalComposables"] - metrics_hash["restartableComposables"]
+        end
+      end
+
+      Metrics.new(advanced_metrics_hash)
+    end
+  end
+
+  private
+
+  def grouping_key(key)
+    to_snake_case(key).split("_").last.capitalize
+  end
+
+  def to_small_camel_case(str)
+    str.to_s.split("_").each_with_index.map { |s, i| i.zero? ? s : s.capitalize }.join
+  end
+  alias convert_to_metrics_key to_small_camel_case
+
+  def to_snake_case(str)
+    str.gsub(/::/, "/")
+      .gsub(/([A-Z]+)([A-Z][a-z])/, "\\1_\\2")
+      .gsub(/([a-z\d])([A-Z])/, "\\1_\\2")
+      .tr("-", "_")
+      .downcase
+  end
+end

data/lib/compose_compiler_metrics/plugin.rb

@@ -1,113 +1,137 @@
 # frozen_string_literal: true
 
-require 'json'
-require 'csv'
+require "json"
+require "csv"
 
-require_relative './helper'
+require_relative "./helper"
+require_relative "./metrics"
 
 module Danger
   class DangerComposeCompilerMetrics < Plugin
     include Helper
 
-    def report_difference(metrics_dir, base_metrics_dir)
-      markdown('# Compose Compiler Metrics Difference Report')
+    def report_difference(metrics_dir, reference_metrics_dir)
+      unless installed?("diff")
+        failure "diff command not found. Please install diff command."
+        return
+      end
+
+      markdown("# Compose Compiler Metrics Difference Report")
       build_variants(metrics_dir).each do |module_name, build_variant|
         markdown("## #{module_name} - #{build_variant}")
 
         # Metrics Report
         metrics_path = File.join(metrics_dir, metrics_filename(module_name, build_variant))
-        base_metrics_path = File.join(base_metrics_dir, metrics_filename(module_name, build_variant))
-        report = `diff -u #{base_metrics_path} #{metrics_path}`
+        reference_metrics_path = File.join(reference_metrics_dir, metrics_filename(module_name, build_variant))
 
-        markdown(
-          folding(
-            '### Metrics',
-            if report.empty?
-              'No difference found.'
-            else
-              <<~MARKDOWN
-              ```diff
-              #{report}
-              ```
-              MARKDOWN
-            end
-          )
-        )
+        report_metrics_report("Metrics Summary", metrics_path, reference_metrics_path)
+        report_file_difference("Metrics", metrics_path, reference_metrics_path)
 
         # Composable Stats Report
         composable_stats_report_path = File.join(metrics_dir, composable_stats_report_path(module_name, build_variant))
-        base_composable_stats_report_path = File.join(base_metrics_dir, composable_stats_report_path(module_name, build_variant))
-        report = `diff -u #{base_composable_stats_report_path} #{composable_stats_report_path}`
-
-        markdown(
-          folding(
-            '### Composable Stats Report',
-            if report.empty?
-              'No difference found.'
-            else
-              <<~MARKDOWN
-              ```diff
-              #{report}
-              ```
-              MARKDOWN
-            end
-          )
-        )
+        reference_composable_stats_report_path = File.join(reference_metrics_dir, composable_stats_report_path(module_name, build_variant))
+        report_file_difference("Composable Stats Report", composable_stats_report_path, reference_composable_stats_report_path)
 
         # Composable Report
         composable_report_path = File.join(metrics_dir, composable_report_path(module_name, build_variant))
-        base_composable_report_path = File.join(base_metrics_dir, composable_report_path(module_name, build_variant))
-        report = `diff -u #{base_composable_report_path} #{composable_report_path}`
-
-        markdown(
-          folding(
-            '### Composable Report',
-            if report.empty?
-              'No difference found.'
-            else
-              <<~MARKDOWN
-              ```diff
-              #{report}
-              ```
-              MARKDOWN
-            end
-          )
-        )
+        reference_composable_report_path = File.join(reference_metrics_dir, composable_report_path(module_name, build_variant))
+        report_file_difference("Composable Report", composable_report_path, reference_composable_report_path)
 
         # Class Report
         class_report_path = File.join(metrics_dir, class_report_path(module_name, build_variant))
-        base_class_report_path = File.join(base_metrics_dir, class_report_path(module_name, build_variant))
-        report = `diff -u #{base_class_report_path} #{class_report_path}`
-        markdown(
-          folding(
-            '### Class Report',
-            if report.empty?
-              'No difference found.'
-            else
-              <<~MARKDOWN
-              ```diff
-              #{report}
-              ```
-              MARKDOWN
-            end
-          )
+        reference_class_report_path = File.join(reference_metrics_dir, class_report_path(module_name, build_variant))
+        report_file_difference("Class Report", class_report_path, reference_class_report_path)
+      end
+    end
+
+    def report_metrics_report(title, metrics_path, reference_metrics_path)
+      unless File.exist?(metrics_path)
+        warn "DangerComposeCompilerMetrics: new file not found at #{metrics_path}. Skipping file difference report."
+        return
+      end
+
+      unless File.exist?(reference_metrics_path)
+        warn "DangerComposeCompilerMetrics: reference file not found at #{reference_metrics_path}. Skipping file difference report."
+        return
+      end
+
+      metrics = Metrics.load(metrics_path)
+      reference_metrics = Metrics.load(reference_metrics_path)
+
+      tables = reference_metrics.grouped_metrics.map do |group_key, grouped_reference_metrics|
+        grouped_metrics = metrics.grouped_metrics[group_key]
+
+        table_headers = %w(name reference new diff)
+        table_rows = grouped_reference_metrics.keys.map do |key|
+          new_value = grouped_metrics.send(key.to_sym)
+          reference_value = grouped_reference_metrics.send(key.to_sym)
+          diff_value = (new_value - reference_value).then do |v|
+            next "+#{v}" if v.positive?
+
+            next v.to_s if v.negative?
+
+            ""
+          end
+
+          [key, reference_value, new_value, diff_value]
+        end
+
+        [
+          "#### #{group_key}",
+          build_markdown_table(table_headers, table_rows)
+        ].join("\n\n")
+      end
+
+      markdown(
+        folding(
+          "### #{title}",
+          tables.join("\n\n")
         )
+      )
+    end
+
+    def report_file_difference(title, metrics_path, reference_metrics_path)
+      unless File.exist?(metrics_path)
+        warn "DangerComposeCompilerMetrics: new file not found at #{metrics_path}. Skipping file difference report."
+        return
       end
+
+      unless File.exist?(reference_metrics_path)
+        warn "DangerComposeCompilerMetrics: reference file not found at #{reference_metrics_path}. Skipping file difference report."
+        return
+      end
+
+      report = `diff -u #{reference_metrics_path} #{metrics_path}`
+
+      markdown(
+        folding(
+          "### #{title}",
+          if report.empty?
+            "No difference found."
+          else
+            <<~MARKDOWN
+            ```diff
+            #{report}
+            ```
+            MARKDOWN
+          end
+        )
+      )
     end
 
     def report(metrics_dir)
-      markdown('# Compose Compiler Metrics Report')
+      markdown("# Compose Compiler Metrics Report")
       build_variants(metrics_dir).each do |module_name, build_variant|
         markdown("## #{module_name} - #{build_variant}")
 
         # Metrics Report
         metrics_path = File.join(metrics_dir, metrics_filename(module_name, build_variant))
-        table_headers = %w[name value]
+        table_headers = %w(name value)
         table_rows = JSON.load_file(metrics_path).to_a
 
         markdown(
           folding(
-            '### Metrics',
+            "### Metrics",
             build_markdown_table(table_headers, table_rows)
           )
         )
@@ -118,7 +142,7 @@ module Danger
 
         markdown(
           folding(
-            '### Composable Stats Report',
+            "### Composable Stats Report",
             build_markdown_table(csv.headers, csv.map(&:fields))
           )
         )
@@ -127,7 +151,7 @@ module Danger
         composable_report_path = File.join(metrics_dir, composable_report_path(module_name, build_variant))
         markdown(
           folding(
-            '### Composable Report',
+            "### Composable Report",
             <<~MARKDOWN
             ```kotlin
             #{File.read(composable_report_path)}
@@ -140,7 +164,7 @@ module Danger
         class_report_path = File.join(metrics_dir, class_report_path(module_name, build_variant))
         markdown(
           folding(
-            '### Class Report',
+            "### Class Report",
             <<~MARKDOWN
             ```kotlin
             #{File.read(class_report_path)}