danger-cobertura 1.0.0 → 1.1.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 82b28e2ecb8f0383f89f977bc3a1b073b0be37076a3e5f97e66679abd8790102
-  data.tar.gz: b44ee503e7b9588a4d385f008cd26a293f32075f34a4ee726053d2dee659b518
+  metadata.gz: 581a9da17cf4517347df716589c098c219abcdac2fdd5887a6cb8ac9626119de
+  data.tar.gz: 97f48312f384759df2a674ba129501597becba3afb5a3b1a168a8a6697ce41d2
 SHA512:
-  metadata.gz: 4616f102f79dbe73922f317efc478cadb10fa5c8584f5d0f214d1b1ae3d869eb2e89163b198d05f883b3f36c885e8f3cb8ac9c6f0410acd4b32f7b8f057fee1b
-  data.tar.gz: 047a27612a80b13e93410a422574c2b32e39c186eec49b095710cbfaa8d9b8884fec0ef7d0b8e73383d3b8e77bef1a393ab493e35710aa90f3a341bcbfb4cf13
+  metadata.gz: 858d10f14d3e5c422787929b97c85a02f0616544ba121788d4a90bc650bf05cb722b758243c51fb4e3e83674dcb94d2abe8161a44a67616f5bd0c527ece52652
+  data.tar.gz: a209e03077a94489ac9110048a98f43f9013f9ae85bdebb40e0997afeddf3b46608050b37beca56561babb1b1be9ad9092adbcee39e2c06af40005e84a2715a0

data/.codeclimate.yml

@@ -0,0 +1,5 @@
+plugins:
+  rubocop:
+    enabled: true
+    config:
+      file: .rubocop.yml

data/.gitignore

@@ -4,3 +4,4 @@ pkg
 .yardoc
 Gemfile.lock
 .vscode
+coverage

data/.rubocop.yml

@@ -3,7 +3,7 @@
 # If you don't like these settings, just delete this file :)
 
 AllCops:
-  TargetRubyVersion: 2.5
+  TargetRubyVersion: 2.2
 
 Style/StringLiterals:
   EnforcedStyle: double_quotes
@@ -150,3 +150,6 @@ PercentLiteralDelimiters:
 
 Security/YAMLLoad:
   Enabled: false
+
+Metrics/ModuleLength:
+  Max: 500

data/.travis.yml

@@ -5,11 +5,26 @@ cache:
   - bundle
 
 rvm:
-  - 2.5.2
+  - 2.2
+  - 2.3
+  - 2.4
+  - 2.5
+
+env:
+  global:
+    - CC_TEST_REPORTER_ID=7cfcaf05ab26fd0e7088ab0b16e902559a6d0c0c6f6785fa908e20efeba53c64
+
+before_script:
+  - curl -L https://codeclimate.com/downloads/test-reporter/test-reporter-latest-linux-amd64 > ./cc-test-reporter
+  - chmod +x ./cc-test-reporter
+  - ./cc-test-reporter before-build
 
 script:
   - bundle exec rake spec
 
+after_script:
+  - ./cc-test-reporter after-build --exit-code $TRAVIS_TEST_RESULT
+
 deploy:
   provider: rubygems
   api_key:

data/CHANGELOG.md

@@ -6,6 +6,15 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [Unreleased]
 
+## [1.1.0] - 2018-11-28
+### Added
+- Option to add branch and line rate information
+- Add a filename prefix
+
+### Changed
+- Exclude all files with "$" sign in name
+- Support ruby 2.2 - 2.5
+
 ## [1.0.0] - 2018-11-25
 ### Added
 - Initial release.

data/README.md

@@ -1,3 +1,10 @@
+[![Gem Version](https://badge.fury.io/rb/danger-cobertura.svg)](https://badge.fury.io/rb/danger-cobertura)
+[![Build Status](https://travis-ci.org/Kyaak/danger-cobertura.svg?branch=master)](https://travis-ci.org/Kyaak/danger-cobertura)
+[![Maintainability](https://api.codeclimate.com/v1/badges/2e657e2a49ddf9696ece/maintainability)](https://codeclimate.com/github/Kyaak/danger-cobertura/maintainability)
+[![Test Coverage](https://api.codeclimate.com/v1/badges/2e657e2a49ddf9696ece/test_coverage)](https://codeclimate.com/github/Kyaak/danger-cobertura/test_coverage)
+[![Inline docs](http://inch-ci.org/github/Kyaak/danger-cobertura.svg?branch=master)](http://inch-ci.org/github/Kyaak/danger-cobertura)
+[![Gem](https://img.shields.io/gem/dt/danger-cobertura.svg)](https://rubygems.org/gems/danger-cobertura)
+
 # danger-cobertura
 
 A [cobertura](http://cobertura.github.io/cobertura/) report plugin for [danger](https://danger.systems/ruby).
@@ -27,12 +34,20 @@ _It inspects only modified and added files, deleted ones are not considered usef
 
 ### Coverage report
 
-File | Coverage
+#### Minimum 
+ 
+File | Total
 -----|-----
 example_one.py | 50.00
 example_two.py | 35.60
 example_three.py | 10.48
 
+#### Maximum 
+ 
+File | Total | Line | Branch
+-----|-----|-----|-----
+example_one.py | 50.00 | 75.00 | 25.00
+example_two.py | 35.50 | 20.50 | 50.50
 
 ## Installation
 
@@ -50,9 +65,25 @@ cobertura.warn_if_file_less_than(percentage: 50.0)
 </pre>
 </blockquote>    
 
-<blockquote>Show coverage of all files 
+<blockquote>Show default coverage of all files 
+<pre>
+cobertura.report = build/reports/coverage.xml
+cobertura.show_coverage
+</pre>
+</blockquote>   
+
+<blockquote>Use filename prefix to find your files - find your files in your filesystem. e.g Java projects are under "src/main/java".
+<pre>
+cobertura.report = build/reports/coverage.xml
+cobertura.filename_prefix = "src/main/java"
+cobertura.show_coverage
+</pre>
+</blockquote>   
+
+<blockquote>Show coverage of all files including line and branch rate
 <pre>
 cobertura.report = build/reports/coverage.xml
+cobertura.additional_headers = [:line, :branch]
 cobertura.show_coverage
 </pre>
 </blockquote>   
@@ -68,6 +99,8 @@ cobertura.show_coverage
 ## Attributes
 
 __`report`__ - Path to the cobertura xml report, e.g. `build/reports/coverage.xml`
+__`additional_headers`__ - Array of symbols to include in the coverage report. Available options are `:line`, `:branch`
+__`filename_prefix`__ - Path prefix to be added to the cobertura class filename attribute. e.g. `src/main/java`
 
 ## Methods
 

data/danger-cobertura.gemspec

@@ -19,6 +19,8 @@ Gem::Specification.new do |spec|
   spec.test_files    = spec.files.grep(%r{^(test|spec|features)/})
   spec.require_paths = ["lib"]
 
+  spec.required_ruby_version = ">=2.2.0"
+
   spec.add_runtime_dependency "danger-plugin-api", "~> 1.0"
   spec.add_runtime_dependency "oga", "~> 2.15"
 
@@ -29,9 +31,11 @@ Gem::Specification.new do |spec|
   # Testing support
   spec.add_development_dependency "mocha", "~> 1.2"
   spec.add_development_dependency "rspec", "~> 3.4"
+  spec.add_development_dependency "simplecov", "~> 0.16"
+  spec.add_development_dependency "simplecov-console", "~> 0.4"
 
   # Linting code and docs
-  spec.add_development_dependency "rubocop", "~> 0.6"
+  spec.add_development_dependency "rubocop", "~> 0.60"
   spec.add_development_dependency "yard", "~> 0.9"
 
   # Makes testing easy via `bundle exec guard`

data/lib/cobertura/coverage_item.rb

@@ -1,26 +1,33 @@
-# frozen_string_literal: true
-
+# Container item for cobertura <class> entries
 class CoverageItem
+  # Initialize an object using an xml node set containing the class information of a cobertura report.
+  #
+  # @param node [Oga::XML::NodeSet] NodeSet of a class
   def initialize(node)
     @node = node
   end
 
+  # @return [Float] The combined coverage of branch and line rate
   def total_percentage
-    @total_percentage ||= ((branch_rate + line_rate) / 2) * 100
+    @total_percentage ||= (branch_rate + line_rate) / 2
   end
 
+  # @return [Float] The branch coverage rate
   def branch_rate
-    @branch_rate ||= @node.attribute("branch-rate").value.to_f
+    @branch_rate ||= @node.attribute("branch-rate").value.to_f * 100
   end
 
+  # @return [Float] The line coverage rate
   def line_rate
-    @line_rate ||= @node.attribute("line-rate").value.to_f
+    @line_rate ||= @node.attribute("line-rate").value.to_f * 100
   end
 
-  def file_name
-    @file_name ||= @node.attribute("filename").value.to_s
+  # @return [String] Name of the class file with directory path
+  def filename
+    @filename ||= @node.attribute("filename").value.to_s
   end
 
+  # @return [String] Name of the class file with package structure
   def name
     @name ||= @node.attribute("name").value.to_s
   end

data/lib/cobertura/gem_version.rb

@@ -1,5 +1,3 @@
-# frozen_string_literal: true
-
 module Cobertura
-  VERSION = "1.0.0"
+  VERSION = "1.1.0".freeze
 end

data/lib/cobertura/plugin.rb

@@ -1,5 +1,3 @@
-# frozen_string_literal: true
-
 module Danger
   # Show code coverage of modified and added files.
   # Add warnings if minimum file coverage is not achieved.
@@ -13,19 +11,31 @@ module Danger
   # @tags cobertura, coverage
   #
   class DangerCobertura < Plugin
+    require "oga"
     require_relative "./coverage_item"
-    ERROR_FILE_NOT_SET = "Cobertura file not set. Use 'cobertura.file = \"path/to/my/report.xml\"'."
-    ERROR_FILE_NOT_FOUND = "No file found at %s"
+
+    ERROR_FILE_NOT_SET = "Cobertura file not set. Use 'cobertura.file = \"path/to/my/report.xml\"'.".freeze
+    ERROR_FILE_NOT_FOUND = "No file found at %s".freeze
+    TABLE_COLUMN_LINE = "-----".freeze
 
     # Path to the xml formatted cobertura report.
     #
-    # @return   [String]
+    # @return [String] Report file.
     attr_accessor :report
+    # Array of symbols which allows to extend the markdown report columns.
+    # Allowed symbols: :branch, :line
+    #
+    # @return [Array<Symbol>] Columns to add in the markdown report.
+    attr_accessor :additional_headers
+    # Path prefix to be added to the cobertura class filename attribute.
+    #
+    # @return [String] Prefix to add to filename path.
+    attr_accessor :filename_prefix
 
     # Warn if a modified file has a lower total coverage than defined.
     #
     # @param percentage [Float] The minimum code coverage required for a file.
-    # @return [Array<String>]
+    # @return [Array<String>] Warnings of files with a lower coverage.
     def warn_if_file_less_than(percentage:)
       filtered_items.each do |item|
         next unless item.total_percentage < percentage
@@ -36,58 +46,126 @@ module Danger
 
     # Show markdown table of modified and added files.
     #
-    # @return [Array<String>]
+    # @return [Array<String>] A markdown report of modified files and their coverage report.
     def show_coverage
       return if filtered_items.empty?
 
-      line = +"## Code coverage\n"
-      line << "File | Coverage\n"
-      line << "-----|-----\n"
+      table = "## Code coverage\n".dup
+      table << table_header
+      table << table_separation
+
       filtered_items.each do |item|
-        line << "#{item.name} | #{format('%.2f', item.total_percentage)}\n"
+        table << table_entry(item)
       end
-      markdown line
+      markdown table
     end
 
     private
 
+    # Create the show_coverage column headers.
+    #
+    # @return [String] Markdown for table headers.
+    def table_header
+      line = "File|Total".dup
+      line << "|Line" if header_line_rate?
+      line << "|Branch" if header_branch_rate?
+      line << "\n"
+    end
+
+    # Create the show_coverage table header separation line.
+    #
+    # @return [String] Markdown for table header separation.
+    def table_separation
+      line = "#{TABLE_COLUMN_LINE}|#{TABLE_COLUMN_LINE}".dup
+      line << "|#{TABLE_COLUMN_LINE}" if header_line_rate?
+      line << "|#{TABLE_COLUMN_LINE}" if header_branch_rate?
+      line << "\n"
+    end
+
+    # Create the show_coverage table rows.
+    #
+    # @param item [CoverageItem] Coverage item to put information in the table row.
+    # @return [String] Markdown for table rows.
+    def table_entry(item)
+      line = item.name.dup
+      line << "|#{format_coverage(item.total_percentage)}"
+      line << "|#{format_coverage(item.line_rate)}" if header_line_rate?
+      line << "|#{format_coverage(item.branch_rate)}" if header_branch_rate?
+      line << "\n"
+    end
+
+    # Check if additional_headers includes symbol :line
+    #
+    # @return [Boolean] :line header defined.
+    def header_line_rate?
+      !additional_headers.nil? && additional_headers.include?(:line)
+    end
+
+    # Check if additional_headers includes symbol :branch
+    #
+    # @return [Boolean] :branch header defined.
+    def header_branch_rate?
+      !additional_headers.nil? && additional_headers.include?(:branch)
+    end
+
+    # Format coverage output to two decimals.
+    #
+    # @param coverage [Float] Value to format.
+    # @return [String] Formatted coverage string.
+    def format_coverage(coverage)
+      format("%.2f", coverage)
+    end
+
     # Getter for coverage items of targeted files.
+    # Only coverage items contained in the targeted files list will be returned.
     #
-    # @return [Array<CoverageItem>]
+    # @return [Array<CoverageItem>] Filtered array of items
     def filtered_items
       @filtered_items ||= coverage_items.select do |item|
-        target_files.include? item.file_name
+        target_files.include?(item_filename(item)) && !item.name.include?("$")
+      end
+    end
+
+    # Combine item filename with prefix.
+    #
+    # @param item [CoverageItem] Coverage item to create the full filename.
+    # @return [String] Combined filename.
+    def item_filename(item)
+      result = "".dup
+      if filename_prefix
+        result << filename_prefix
+        result << "/" unless filename_prefix.chars.last == "/"
       end
+      result << item.filename
     end
 
-    # A getter for current updated files.
+    # A getter for current modified and added files.
     #
-    # @return [Array<String>]
+    # @return [Danger::FileList] Wrapper FileList object.
     def target_files
       @target_files ||= git.modified_files + git.added_files
     end
 
     # Parse the defined coverage report file.
     #
-    # @return [Oga::XML::Document]
+    # @return [Oga::XML::Document] The root xml object.
     def parse
-      require "oga"
       raise ERROR_FILE_NOT_SET if report.nil? || report.empty?
       raise format(ERROR_FILE_NOT_FOUND, report) unless File.exist?(report)
 
       Oga.parse_xml(File.read(report))
     end
 
-    # Get the xml cobertura report.
+    # Convenient method to not always parse the report but keep it in the memory.
     #
-    # @return [Oga::XML::Document]
+    # @return [Oga::XML::Document] The root xml object.
     def xml_report
       @xml_report ||= parse
     end
 
-    # Getter for all coverage data.
+    # Extract and create all class items from the xml report.
     #
-    # @return [Array<CoverageItem>]
+    # @return [Array<CoverageItem>] Items with cobertura class information.
     def coverage_items
       @coverage_items ||= xml_report.xpath("//class").map do |node|
         CoverageItem.new(node)

data/lib/danger_cobertura.rb

@@ -1,3 +1 @@
-# frozen_string_literal: true
-
 require "cobertura/gem_version"

data/lib/danger_plugin.rb

@@ -1,3 +1 @@
-# frozen_string_literal: true
-
 require "cobertura/plugin"

data/spec/assets/coverage.xml

@@ -277,6 +277,12 @@
 						<line branch="true" condition-coverage="0% (0/2)" hits="0" number="88"/>
 					</lines>
 				</class>
+				<class branch-rate="0" complexity="0" filename="sub_folder/sub_three.py" line-rate="0" name="sub_three$.py">
+					<methods/>
+					<lines>
+						<line branch="true" condition-coverage="0% (0/2)" hits="0" number="88"/>
+					</lines>
+				</class>
 			</classes>
 		</package>
 	</packages>

data/spec/cobertura_spec.rb

@@ -53,6 +53,65 @@ module Danger
 
           expect(@dangerfile.status_report[:warnings]).to be_empty
         end
+
+        it "adds warn for modified files" do
+          @dangerfile.git.stubs(:modified_files).returns(%w(sub_folder/sub_two.py))
+          @my_plugin.warn_if_file_less_than(percentage: 90.0)
+
+          expect(@dangerfile.status_report[:warnings]).to include("sub_two.py has less than 90.0% coverage")
+        end
+
+        it "adds warn for added files" do
+          @dangerfile.git.stubs(:added_files).returns(%w(sub_folder/sub_two.py))
+          @my_plugin.warn_if_file_less_than(percentage: 90.0)
+
+          expect(@dangerfile.status_report[:warnings]).to include("sub_two.py has less than 90.0% coverage")
+        end
+
+        it "adds warn for added and modified files" do
+          @dangerfile.git.stubs(:added_files).returns(%w(sub_folder/sub_two.py))
+          @dangerfile.git.stubs(:modified_files).returns(%w(sub_folder/sub_one.py))
+          @my_plugin.warn_if_file_less_than(percentage: 90.0)
+
+          expect(@dangerfile.status_report[:warnings]).to include("sub_two.py has less than 90.0% coverage")
+          expect(@dangerfile.status_report[:warnings]).to include("sub_one.py has less than 90.0% coverage")
+        end
+
+        it "does not add if filename missing prefix" do
+          # sub_folder/sub_two.py in xml
+          @dangerfile.git.stubs(:added_files).returns(%w(my_prefix_dir/sub_folder/sub_two.py))
+          expect(@my_plugin.filename_prefix).to be_nil
+
+          @my_plugin.warn_if_file_less_than(percentage: 90.0)
+
+          expect(@dangerfile.status_report[:warnings]).not_to include("sub_two.py has less than 90.0% coverage")
+        end
+
+        it "does add if filename prefix set" do
+          # sub_folder/sub_two.py in xml
+          @dangerfile.git.stubs(:added_files).returns(%w(my_prefix_dir/sub_folder/sub_two.py))
+          @my_plugin.filename_prefix = "my_prefix_dir"
+          @my_plugin.warn_if_file_less_than(percentage: 90.0)
+
+          expect(@dangerfile.status_report[:warnings]).to include("sub_two.py has less than 90.0% coverage")
+        end
+
+        it "ignores filename prefix slash" do
+          # sub_folder/sub_two.py in xml
+          @dangerfile.git.stubs(:added_files).returns(%w(my_prefix_dir/sub_folder/sub_two.py))
+          @my_plugin.filename_prefix = "my_prefix_dir/"
+          @my_plugin.warn_if_file_less_than(percentage: 90.0)
+
+          expect(@dangerfile.status_report[:warnings]).to include("sub_two.py has less than 90.0% coverage")
+        end
+
+        it "should not add name with $" do
+          @dangerfile.git.stubs(:added_files).returns(%w(sub_folder/sub_three.py))
+          @my_plugin.warn_if_file_less_than(percentage: 90.0)
+
+          expect(@dangerfile.status_report[:warnings]).to include("sub_three.py has less than 90.0% coverage")
+          expect(@dangerfile.status_report[:warnings]).not_to include("sub_three$.py has less than 90.0% coverage")
+        end
       end
 
       describe "show_coverage" do
@@ -77,13 +136,109 @@ module Danger
           end.to raise_error(/#{@my_plugin.report}/)
         end
 
-        it "prints coverage" do
+        it "adds coverage for modified files" do
+          @dangerfile.git.stubs(:modified_files).returns(%w(sub_folder/sub_two.py))
+          @my_plugin.show_coverage
+
+          expect(@dangerfile.status_report[:markdowns]).not_to be_empty
+        end
+
+        it "adds coverage for added files" do
+          @dangerfile.git.stubs(:added_files).returns(%w(sub_folder/sub_two.py))
+          @my_plugin.show_coverage
+
+          expect(@dangerfile.status_report[:markdowns]).not_to be_empty
+        end
+
+        it "adds coverage for added and modified files" do
+          @dangerfile.git.stubs(:added_files).returns(%w(sub_folder/sub_two.py))
+          @dangerfile.git.stubs(:modified_files).returns(%w(sub_folder/sub_one.py))
+          @my_plugin.show_coverage
+
+          expect(@dangerfile.status_report[:markdowns]).not_to be_empty
+        end
+
+        it "default does not add branch and line" do
+          @dangerfile.git.stubs(:modified_files).returns(["sub_folder/sub_three.py"])
+          @my_plugin.show_coverage
+
+          expect(@dangerfile.status_report[:markdowns][0].message).to include("File")
+          expect(@dangerfile.status_report[:markdowns][0].message).to include("Total")
+          expect(@dangerfile.status_report[:markdowns][0].message).to include(table_column_line(2))
+          expect(@dangerfile.status_report[:markdowns][0].message).not_to include("Branch")
+          expect(@dangerfile.status_report[:markdowns][0].message).not_to include("Line")
+          expect(@dangerfile.status_report[:markdowns][0].message).not_to include(table_column_line(4))
+          expect(@dangerfile.status_report[:markdowns][0].message).to include("0.00")
+        end
+
+        it "additional_header line adds line rate" do
+          @dangerfile.git.stubs(:modified_files).returns(["sub_folder/sub_three.py"])
+          @my_plugin.additional_headers = [:line]
+          @my_plugin.show_coverage
+
+          expect(@dangerfile.status_report[:markdowns][0].message).to include("File")
+          expect(@dangerfile.status_report[:markdowns][0].message).to include("Total")
+          expect(@dangerfile.status_report[:markdowns][0].message).to include("Line")
+          expect(@dangerfile.status_report[:markdowns][0].message).to include(table_column_line(3))
+          expect(@dangerfile.status_report[:markdowns][0].message).not_to include("Branch")
+          expect(@dangerfile.status_report[:markdowns][0].message).not_to include(table_column_line(4))
+          expect(@dangerfile.status_report[:markdowns][0].message).to include("0.00")
+        end
+
+        it "additional_header branch adds branch rate" do
           @dangerfile.git.stubs(:modified_files).returns(["sub_folder/sub_three.py"])
+          @my_plugin.additional_headers = [:branch]
           @my_plugin.show_coverage
 
-          expect(@dangerfile.status_report[:markdowns][0].message).to include("sub_three.py")
+          expect(@dangerfile.status_report[:markdowns][0].message).to include("File")
+          expect(@dangerfile.status_report[:markdowns][0].message).to include("Total")
+          expect(@dangerfile.status_report[:markdowns][0].message).to include("Branch")
+          expect(@dangerfile.status_report[:markdowns][0].message).to include(table_column_line(3))
+          expect(@dangerfile.status_report[:markdowns][0].message).not_to include("Line")
+          expect(@dangerfile.status_report[:markdowns][0].message).not_to include(table_column_line(4))
           expect(@dangerfile.status_report[:markdowns][0].message).to include("0.00")
         end
+
+        it "additional_header line and branch adds rate" do
+          @dangerfile.git.stubs(:modified_files).returns(["sub_folder/sub_three.py"])
+          @my_plugin.additional_headers = %i(branch line)
+          @my_plugin.show_coverage
+
+          expect(@dangerfile.status_report[:markdowns][0].message).to include("File")
+          expect(@dangerfile.status_report[:markdowns][0].message).to include("Total")
+          expect(@dangerfile.status_report[:markdowns][0].message).to include("Branch")
+          expect(@dangerfile.status_report[:markdowns][0].message).to include("Line")
+          expect(@dangerfile.status_report[:markdowns][0].message).to include(table_column_line(4))
+          expect(@dangerfile.status_report[:markdowns][0].message).to include("0.00")
+        end
+
+        it "does not show coverage if filename prefix missing" do
+          # sub_folder/sub_two.py in xml
+          @dangerfile.git.stubs(:added_files).returns(%w(my_prefix_dir/sub_folder/sub_two.py))
+          expect(@my_plugin.filename_prefix).to be_nil
+
+          @my_plugin.show_coverage
+
+          expect(@dangerfile.status_report[:markdowns]).to be_empty
+        end
+
+        it "does show coverage if filename prefix matches" do
+          # sub_folder/sub_two.py in xml
+          @dangerfile.git.stubs(:added_files).returns(%w(my_prefix_dir/sub_folder/sub_two.py))
+          @my_plugin.filename_prefix = "my_prefix_dir"
+          @my_plugin.show_coverage
+
+          expect(@dangerfile.status_report[:markdowns]).not_to be_empty
+        end
+
+        it "ignores filename prefix slash" do
+          # sub_folder/sub_two.py in xml
+          @dangerfile.git.stubs(:added_files).returns(%w(my_prefix_dir/sub_folder/sub_two.py))
+          @my_plugin.filename_prefix = "my_prefix_dir/"
+          @my_plugin.show_coverage
+
+          expect(@dangerfile.status_report[:markdowns]).not_to be_empty
+        end
       end
     end
   end

data/spec/helper/cobertura_helper.rb

@@ -0,0 +1,12 @@
+module Helpers
+  def table_column_line(columns)
+    result = "".dup
+    (1..columns).each do |i|
+      result << "-----"
+      if i < columns
+        result << "|"
+      end
+    end
+    result
+  end
+end

data/spec/spec_helper.rb

@@ -11,6 +11,13 @@ require "pry"
 require "rspec"
 require "danger"
 require "mocha"
+require "simplecov"
+require "simplecov-console"
+
+require_relative "./helper/cobertura_helper"
+
+SimpleCov.formatter = SimpleCov::Formatter::Console
+SimpleCov.start
 
 if `git remote -v` == ""
   puts "You cannot run tests without setting a local git remote on this repo"
@@ -24,6 +31,7 @@ RSpec.configure do |config|
   config.color = true
   config.tty = true
   config.mock_with :mocha
+  config.include Helpers
 end
 
 require "danger_plugin"

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: danger-cobertura
 version: !ruby/object:Gem::Version
-  version: 1.0.0
+  version: 1.1.0
 platform: ruby
 authors:
 - Kyaak
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-11-25 00:00:00.000000000 Z
+date: 2018-11-28 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: danger-plugin-api
@@ -94,20 +94,48 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '3.4'
+- !ruby/object:Gem::Dependency
+  name: simplecov
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '0.16'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '0.16'
+- !ruby/object:Gem::Dependency
+  name: simplecov-console
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '0.4'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '0.4'
 - !ruby/object:Gem::Dependency
   name: rubocop
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.6'
+        version: '0.60'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.6'
+        version: '0.60'
 - !ruby/object:Gem::Dependency
   name: yard
   requirement: !ruby/object:Gem::Requirement
@@ -185,6 +213,7 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
+- ".codeclimate.yml"
 - ".gitignore"
 - ".rubocop.yml"
 - ".travis.yml"
@@ -202,6 +231,7 @@ files:
 - lib/danger_plugin.rb
 - spec/assets/coverage.xml
 - spec/cobertura_spec.rb
+- spec/helper/cobertura_helper.rb
 - spec/spec_helper.rb
 homepage: https://github.com/Kyaak/danger-cobertura
 licenses:
@@ -215,7 +245,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: '0'
+      version: 2.2.0
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
@@ -223,7 +253,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.7.8
+rubygems_version: 2.7.7
 signing_key: 
 specification_version: 4
 summary: This plugin allows parsing of an xml coverage report generated by cobertura
@@ -231,4 +261,5 @@ summary: This plugin allows parsing of an xml coverage report generated by cober
 test_files:
 - spec/assets/coverage.xml
 - spec/cobertura_spec.rb
+- spec/helper/cobertura_helper.rb
 - spec/spec_helper.rb