danger-checkstyle_xml 0.0.3 → 0.0.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 258f42658fb6340318ebe52c9f7cb905ced63c26399d375b83a4b5f74818ac30
-  data.tar.gz: 9f8d3825b0d46a4f3c01e92d52df5d3a60c49c16bec72d3c561d14cc84329842
+  metadata.gz: cd740ce3fb5ca517dc3568735af078687506142537344f1ce5ae60f74f130a10
+  data.tar.gz: 5470bd1a659ec87a018802f9b86dd79e1ba7a819ace0b7a6751b648130967a86
 SHA512:
-  metadata.gz: 9d5c58ea3c4e369bd5c825d0148880231107ab0cdffd644f4c0a6983f6fcf57c36045ee45fad1a44a7fe241b76aaf95393a72e3d357d1b6d8cc945a150b69eb4
-  data.tar.gz: 5fdb28f9d9cf07fc3aa1462c9932e96b1bd3b98f2f5ed2c7451a66a5f4fc9c2e6a8e9cae0d38c05c1e06302477cfedfeab361af5ad1149db5c1374e7bbb2decc
+  metadata.gz: d8b7bfb39e30907edf9f64b2b16645631a1ef457403c1d25ad0f9daa0171e00fc11dcb6e675a1d910e7a855e8ea164409c63b868d9e65ae9a990cc8f968fec86
+  data.tar.gz: ffe9414bd5b548a51f536e43cfa33e578dfedf9435373a588c1cf6b79c289438a2489f19c734752be27f22be4df3ce48d0bc2685fcb56f89f3454061cbbd00cc

data/.rubocop.yml

@@ -17,13 +17,16 @@ Lint/UselessAssignment:
   Exclude:
     - '**/spec/**/*'
 
-# We could potentially enable the 2 below:
+# We could potentially enable the 3 below:
 Layout/FirstHashElementIndentation:
   Enabled: false
 
 Layout/HashAlignment:
   Enabled: false
 
+Layout/EndOfLine:
+  Enabled: false
+
 # HoundCI doesn't like this rule
 Layout/DotPosition:
   Enabled: false

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    danger-checkstyle_xml (0.0.1)
+    danger-checkstyle_xml (0.0.5)
       danger-plugin-api (~> 1.0)
       ox (~> 2.14)
 

data/lib/checkstyle_format/checkstyle_error.rb

@@ -1,13 +1,8 @@
 # frozen_string_literal: true
 
 CheckstyleError = Struct.new(:file_name, :line, :column, :severity, :message, :source) do
-  def self.generate(node, parent_node, base_path)
-    # Print base path, full path, and relative path
-    puts "Base path: #{base_path}"
-    puts "Parent node path: #{parent_node[:name]}"
-    
-    relative_path = parent_node[:name].sub(/^#{base_path}/, "")
-    puts "Relative path: #{relative_path}"
+  def self.generate(node, parent_node, sub_regex)
+    relative_path = parent_node[:name].sub(sub_regex, "")
 
     CheckstyleError.new(
       relative_path,

data/lib/checkstyle_format/gem_version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module CheckstyleFormat
-  VERSION = "0.0.3".freeze
+  VERSION = "0.0.5"
 end

data/lib/checkstyle_format/plugin.rb

@@ -7,22 +7,22 @@ module Danger
   #
   # @example Parse the XML file, and let the plugin do your reporting
   #
-  #          checkstyle_format.base_path = Dir.pwd
+  #          checkstyle_format.base_regex = %r{^.*?\/src\/}
   #          checkstyle_format.report 'app/build/reports/checkstyle/checkstyle.xml'
   #
   # @example Parse the XML text, and let the plugin do your reporting
   #
-  #          checkstyle_format.base_path = Dir.pwd
+  #          checkstyle_format.base_regex = %r{^.*?\/src\/}
   #          checkstyle_format.report_by_text '<?xml ...'
   #
   # @see  noboru-i/danger-checkstyle_format
   # @tags lint, reporting
   #
   class DangerCheckstyleFormat < Plugin
-    # Base path of `name` attributes in `file` tag.
+    # Base regex for converting the full paths into relative paths.
     # Defaults to nil.
     # @return [String]
-    attr_accessor :base_path
+    attr_accessor :base_regex
 
     # Report checkstyle warnings
     #
@@ -57,14 +57,10 @@ module Danger
       present_elements = doc.nodes.first.nodes.reject do |test|
         test.nodes.empty?
       end
-      
-      base_path_suffix = @base_path.end_with?("/") ? "" : "/"
-      
-      base_path = @base_path + base_path_suffix
 
       present_elements.flat_map do |parent|
         parent.nodes.map do |child|
-          CheckstyleError.generate(child, parent, base_path)
+          CheckstyleError.generate(child, parent, @base_regex)
         end
       end
     end
@@ -73,13 +69,14 @@ module Danger
       if inline_mode
         send_inline_comment(errors)
       else
-        raise "not implemented." # TODO: not implemented.
+        # TODO: not implemented.
+        raise "Not implemented."
       end
     end
 
     def send_inline_comment(errors)
       errors.each do |error|
-        puts "Sending inline comment to file #{error.file_name}, line #{error.line}"
+        # puts "Sending inline comment to file #{error.file_name}, line #{error.line}"
         warn(error.message, file: error.file_name, line: error.line)
       end
     end

data/spec/checkstyle_format_spec.rb

@@ -29,7 +29,7 @@ module Danger
 
       describe ".parse" do
         subject(:errors) do
-          @checkstyle_format.base_path = "/path/to"
+          @checkstyle_format.base_regex = %r{^.*?/to/}
           @checkstyle_format.send(:parse, File.read("spec/fixtures/checkstyle.xml"))
         end
         it "have 4 items" do

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: danger-checkstyle_xml
 version: !ruby/object:Gem::Version
-  version: 0.0.3
+  version: 0.0.5
 platform: ruby
 authors:
 - noboru-i