danger-app_size_report 0.0.3 → 1.1.0

data/lib/converter/models/variant_model.rb

@@ -1,6 +1,8 @@
 # frozen_string_literal: true
 
 require_relative '../helper/json_converter'
+
+# Variant Model
 class VariantModel < JSONConverter
   attr_reader :variant, :supported_variant_descriptors, :app_on_demand_resources_size, :app_size,
               :on_demand_resources_size

data/lib/converter/parser/app_size_parser.rb

@@ -4,6 +4,7 @@ require_relative '../models/app_size_model'
 require_relative '../helper/memory_size'
 require_relative './model_parser'
 
+# Parser for App Size section of App Thinning Size Report
 class AppSizeParser < ModelParser
   attr_reader :standardized_unit
 

data/lib/converter/parser/model_parser.rb

@@ -1,5 +1,6 @@
 # frozen_string_literal: false
 
+# Parent class for parsers
 class ModelParser
   attr_reader :text, :result
 

data/lib/converter/parser/report_parser.rb

@@ -4,6 +4,7 @@ require 'securerandom'
 require_relative '../models/variant_model'
 require_relative '../helper/result_factory'
 
+# Parses App Thinning Size Report in its entirety
 class ReportParser
   def self.parse(text)
     splitter_id = SecureRandom.uuid

data/lib/converter/parser/variant_descriptor_parser.rb

@@ -4,6 +4,7 @@ require_relative '../models/device_model'
 require 'securerandom'
 require_relative './model_parser'
 
+# Parser for Variant descriptor section of App Thinning Size Report
 class VariantDescriptorParser < ModelParser
   def parse
     @text = @text.strip

data/lib/converter/parser/variant_parser.rb

@@ -2,6 +2,8 @@
 
 require_relative './model_parser'
 
+# Parse Variant section of App Thinning Size Report.
+# Example: 'Variant: ChargePointAppClip-35AD0331-EA57-4B82-B8E6-029D7786B9B7.ipa'
 class VariantParser < ModelParser
   def parse
     @text = @text.strip

data/spec/app_size_report_spec.rb

@@ -15,22 +15,50 @@ module Danger
       end
 
       it 'Converts App Size Report to JSON' do
-        json_string = @app_size_report.report_json("#{File.dirname(__dir__)}/Resources/App\ Thinning\ Size\ Report.txt")
+        json_string = @app_size_report.report_json("#{File.dirname(__dir__)}/Resources/App\ Thinning\ Size\ Report\ CPClip.txt")
 
         expected_json = File.read("#{File.dirname(__dir__)}/Resources/expectedReportJSON.json")
 
         expect(json_string).to eq(expected_json)
       end
 
-      it 'Generates App Size Danger Report' do
-        @app_size_report.flag_violations(
-          "#{File.dirname(__dir__)}/Resources/App\ Thinning\ Size\ Report.txt",
+      it 'Generates IOS App Size Danger Report for Clip' do
+        @app_size_report.flag_ios_violations(
+          "#{File.dirname(__dir__)}/Resources/App\ Thinning\ Size\ Report\ CPClip.txt",
           build_type: 'Clip',
-          size_limit: 12,
+          limit_size: 12,
           limit_unit: 'MB'
         )
 
-        expect(@dangerfile.status_report[:warnings]).to eq(['The size limit of 10 MB has been exceeded by one or more variants'])
+        expect(@dangerfile.status_report[:warnings]).to eq(['The size limit of 12 MB has been exceeded by one or more variants'])
+      end
+
+      it 'Generates IOS App Size Danger Report for App' do
+        @app_size_report.flag_ios_violations(
+          "#{File.dirname(__dir__)}/Resources/App\ Thinning\ Size\ Report\ CP.txt",
+          build_type: 'App',
+          limit_size: 45,
+          limit_unit: 'MB'
+        )
+
+        expect(@dangerfile.status_report[:warnings]).to eq(['The size limit of 45 MB has been exceeded by one or more variants', 'The optimal cellular size limit of 200 MB has been exceeded by one or more variants'])
+      end
+
+      it 'Generates Android App Size Danger Report' do
+        @app_size_report.flag_android_violations(
+          "#{File.dirname(__dir__)}/Resources/app.aab",
+          "#{File.dirname(__dir__)}/Resources/testKey1",
+          'testKey1',
+          'testKey1',
+          'testKey1',
+          screen_densities: %w[MDPI HDPI XHDPI XXHDPI XXXHDPI],
+          languages: %w[en de da es fr it nb nl sv],
+          build_type: 'Instant',
+          limit_size: 1.459,
+          limit_unit: 'MB'
+        )
+
+        expect(@dangerfile.status_report[:warnings]).to eq(['The size limit of 1.459 MB has been exceeded by 18 variants'])
       end
     end
   end

data/spec/spec_helper.rb

@@ -22,6 +22,7 @@ RSpec.configure do |config|
   config.filter_gems_from_backtrace 'bundler'
   config.color = true
   config.tty = true
+  config.formatter = :documentation
 end
 
 require 'danger_plugin'

metadata

@@ -1,14 +1,16 @@
 --- !ruby/object:Gem::Specification
 name: danger-app_size_report
 version: !ruby/object:Gem::Version
-  version: 0.0.3
+  version: 1.1.0
 platform: ruby
 authors:
 - Rishab Sukumar
+- Bharath Thakkallapally
+- Vido Shaweddy
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2022-02-03 00:00:00.000000000 Z
+date: 2023-12-12 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: danger-plugin-api
@@ -44,14 +46,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '10.0'
+        version: '13.0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '10.0'
+        version: '13.0'
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
@@ -150,28 +152,37 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: 0.14.1
-description: A Danger plugin for reporting iOS app size violations.
+description: A Danger plugin for reporting iOS and Android app size violations.
 email:
 - rishab.sukumar@chargepoint.com
 executables: []
 extensions: []
 extra_rdoc_files: []
 files:
+- ".github/PULL_REQUEST_TEMPLATE.md"
 - ".gitignore"
+- ".rubocop.yml"
 - Gemfile
 - Gemfile.lock
 - Guardfile
 - LICENSE
 - README.md
 - Rakefile
-- Resources/App Thinning Size Report.txt
+- Resources/App Thinning Size Report CP.txt
+- Resources/App Thinning Size Report CPClip.txt
+- Resources/Images/android_instant_size_report.png
+- Resources/Images/app_thinning_size_report.png
+- Resources/app.aab
 - Resources/expectedReportJSON.json
+- Resources/testKey1
 - danger-app_size_report.gemspec
 - lib/app_size_report/gem_version.rb
 - lib/app_size_report/plugin.rb
+- lib/converter/helper/android_utils.rb
 - lib/converter/helper/json_converter.rb
 - lib/converter/helper/memory_size.rb
 - lib/converter/helper/result_factory.rb
+- lib/converter/models/android_variant_model.rb
 - lib/converter/models/app_size_model.rb
 - lib/converter/models/device_model.rb
 - lib/converter/models/variant_model.rb
@@ -187,7 +198,8 @@ files:
 homepage: https://github.com/ChargePoint/danger-app_size_report
 licenses:
 - MIT
-metadata: {}
+metadata:
+  rubygems_mfa_required: 'true'
 post_install_message:
 rdoc_options: []
 require_paths:
@@ -196,7 +208,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: '0'
+      version: 2.6.0
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
@@ -206,8 +218,9 @@ requirements: []
 rubygems_version: 3.3.6
 signing_key:
 specification_version: 4
-summary: A Danger plugin for reporting iOS app size violations. A valid App Thinning
-  Size Report must be passed to the plugin for accurate functionality.
+summary: A Danger plugin for reporting iOS and Android app size violations. A valid
+  App Thinning Size Report or Android App Bundle must be passed to the plugin for
+  accurate functionality.
 test_files:
 - spec/app_size_report_spec.rb
 - spec/spec_helper.rb