danger-app_size_report 0.0.1 → 0.0.3

data/lib/converter/parser/variant_descriptor_parser.rb

@@ -0,0 +1,53 @@
+# frozen_string_literal: false
+
+require_relative '../models/device_model'
+require 'securerandom'
+require_relative './model_parser'
+
+class VariantDescriptorParser < ModelParser
+  def parse
+    @text = @text.strip
+
+    if @text.empty?
+      @result = nil
+    elsif @text == 'Universal'
+      @result = [parse_to_device_model(@text)]
+    else
+      models = []
+      splitter_id = SecureRandom.uuid
+      @text.sub!('and ', '')
+      @text.gsub!('],', "],#{splitter_id}")
+      descriptors = @text.split(",#{splitter_id} ")
+
+      descriptors.each do |descriptor|
+        descriptor = descriptor[/\[(.*?)\]/m, 1]
+        model = parse_to_device_model(descriptor)
+        models.append(model) if model
+      end
+
+      @result = models
+    end
+  end
+
+  def parse_to_device_model(text)
+    return nil unless text
+
+    return DeviceModel.new(text, '') if text == 'Universal'
+
+    attributes = text.split(', ')
+    parsing_keys = DeviceModel::PARSING_KEYS
+    dict = {}
+    attributes.each do |attribute|
+      parsing_keys.each do |_property, key|
+        next unless attribute.include? key
+
+        # clean the key from the text
+        parseable_text = attribute.gsub(key, '')
+        dict[key] = parseable_text
+      end
+    end
+
+    DeviceModel.new(dict.fetch(parsing_keys[:device], 'Unknown'),
+                    dict.fetch(parsing_keys[:os_version], 'Unknown'))
+  end
+end

data/lib/converter/parser/variant_parser.rb

@@ -0,0 +1,10 @@
+# frozen_string_literal: false
+
+require_relative './model_parser'
+
+class VariantParser < ModelParser
+  def parse
+    @text = @text.strip
+    @result = (@text.strip unless @text.empty?)
+  end
+end

data/lib/danger_app_size_report.rb

@@ -1 +1,3 @@
-require "app_size_report/gem_version"
+# frozen_string_literal: true
+
+require 'app_size_report/gem_version'

data/lib/danger_plugin.rb

@@ -1 +1,3 @@
-require "app_size_report/plugin"
+# frozen_string_literal: true
+
+require 'app_size_report/plugin'

data/spec/app_size_report_spec.rb

@@ -1,46 +1,37 @@
-require File.expand_path("../spec_helper", __FILE__)
+# frozen_string_literal: false
+
+require File.expand_path('spec_helper', __dir__)
 
 module Danger
   describe Danger::DangerAppSizeReport do
-    it "should be a plugin" do
+    it 'should be a plugin' do
       expect(Danger::DangerAppSizeReport.new(nil)).to be_a Danger::Plugin
     end
 
-    #
-    # You should test your custom attributes and methods here
-    #
-    describe "with Dangerfile" do
+    describe 'with Dangerfile' do
       before do
         @dangerfile = testing_dangerfile
-        @my_plugin = @dangerfile.app_size_report
-
-        # mock the PR data
-        # you can then use this, eg. github.pr_author, later in the spec
-        json = File.read(File.dirname(__FILE__) + '/support/fixtures/github_pr.json') # example json: `curl https://api.github.com/repos/danger/danger-plugin-template/pulls/18 > github_pr.json`
-        allow(@my_plugin.github).to receive(:pr_json).and_return(json)
+        @app_size_report = @dangerfile.app_size_report
       end
 
-      # Some examples for writing tests
-      # You should replace these with your own.
-
-      it "Warns on a monday" do
-        monday_date = Date.parse("2016-07-11")
-        allow(Date).to receive(:today).and_return monday_date
+      it 'Converts App Size Report to JSON' do
+        json_string = @app_size_report.report_json("#{File.dirname(__dir__)}/Resources/App\ Thinning\ Size\ Report.txt")
 
-        @my_plugin.warn_on_mondays
+        expected_json = File.read("#{File.dirname(__dir__)}/Resources/expectedReportJSON.json")
 
-        expect(@dangerfile.status_report[:warnings]).to eq(["Trying to merge code on a Monday"])
+        expect(json_string).to eq(expected_json)
       end
 
-      it "Does nothing on a tuesday" do
-        monday_date = Date.parse("2016-07-12")
-        allow(Date).to receive(:today).and_return monday_date
+      it 'Generates App Size Danger Report' do
+        @app_size_report.flag_violations(
+          "#{File.dirname(__dir__)}/Resources/App\ Thinning\ Size\ Report.txt",
+          build_type: 'Clip',
+          size_limit: 12,
+          limit_unit: 'MB'
+        )
 
-        @my_plugin.warn_on_mondays
-
-        expect(@dangerfile.status_report[:warnings]).to eq([])
+        expect(@dangerfile.status_report[:warnings]).to eq(['The size limit of 10 MB has been exceeded by one or more variants'])
       end
-
     end
   end
 end

data/spec/spec_helper.rb

@@ -1,28 +1,30 @@
-require "pathname"
-ROOT = Pathname.new(File.expand_path("../../", __FILE__))
-$:.unshift((ROOT + "lib").to_s)
-$:.unshift((ROOT + "spec").to_s)
+# frozen_string_literal: true
 
-require "bundler/setup"
-require "pry"
+require 'pathname'
+ROOT = Pathname.new(File.expand_path('..', __dir__))
+$LOAD_PATH.unshift("#{ROOT}lib".to_s)
+$LOAD_PATH.unshift("#{ROOT}spec".to_s)
 
-require "rspec"
-require "danger"
+require 'bundler/setup'
+require 'pry'
+
+require 'rspec'
+require 'danger'
 
 if `git remote -v` == ''
-  puts "You cannot run tests without setting a local git remote on this repo"
+  puts 'You cannot run tests without setting a local git remote on this repo'
   puts "It's a weird side-effect of Danger's internals."
   exit(0)
 end
 
 # Use coloured output, it's the best.
 RSpec.configure do |config|
-  config.filter_gems_from_backtrace "bundler"
+  config.filter_gems_from_backtrace 'bundler'
   config.color = true
   config.tty = true
 end
 
-require "danger_plugin"
+require 'danger_plugin'
 
 # These functions are a subset of https://github.com/danger/danger/blob/master/spec/spec_helper.rb
 # If you are expanding these files, see if it's already been done ^.
@@ -40,7 +42,7 @@ def testing_ui
 
   cork = Cork::Board.new(out: @output)
   def cork.string
-    out.string.gsub(/\e\[([;\d]+)?m/, "")
+    out.string.gsub(/\e\[([;\d]+)?m/, '')
   end
   cork
 end
@@ -50,11 +52,11 @@ end
 # running a PR on TravisCI
 def testing_env
   {
-    "HAS_JOSH_K_SEAL_OF_APPROVAL" => "true",
-    "TRAVIS_PULL_REQUEST" => "800",
-    "TRAVIS_REPO_SLUG" => "artsy/eigen",
-    "TRAVIS_COMMIT_RANGE" => "759adcbd0d8f...13c4dc8bb61d",
-    "DANGER_GITHUB_API_TOKEN" => "123sbdq54erfsd3422gdfio"
+    'HAS_JOSH_K_SEAL_OF_APPROVAL' => 'true',
+    'TRAVIS_PULL_REQUEST' => '800',
+    'TRAVIS_REPO_SLUG' => 'artsy/eigen',
+    'TRAVIS_COMMIT_RANGE' => '759adcbd0d8f...13c4dc8bb61d',
+    'DANGER_GITHUB_API_TOKEN' => '123sbdq54erfsd3422gdfio'
   }
 end
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: danger-app_size_report
 version: !ruby/object:Gem::Version
-  version: 0.0.1
+  version: 0.0.3
 platform: ruby
 authors:
-- Vido Shaweddy
+- Rishab Sukumar
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2021-04-27 00:00:00.000000000 Z
+date: 2022-02-03 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: danger-plugin-api
@@ -70,30 +70,30 @@ dependencies:
   name: rubocop
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 1.25.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 1.25.0
 - !ruby/object:Gem::Dependency
   name: yard
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 0.9.27
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 0.9.27
 - !ruby/object:Gem::Dependency
   name: guard
   requirement: !ruby/object:Gem::Requirement
@@ -140,32 +140,46 @@ dependencies:
   name: pry
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 0.14.1
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
-description: A danger plugin for reporting app sizes.
+        version: 0.14.1
+description: A Danger plugin for reporting iOS app size violations.
 email:
-- vido.shaweddy@chargepoint.com
+- rishab.sukumar@chargepoint.com
 executables: []
 extensions: []
 extra_rdoc_files: []
 files:
 - ".gitignore"
 - Gemfile
+- Gemfile.lock
 - Guardfile
-- LICENSE.txt
+- LICENSE
 - README.md
 - Rakefile
+- Resources/App Thinning Size Report.txt
+- Resources/expectedReportJSON.json
 - danger-app_size_report.gemspec
 - lib/app_size_report/gem_version.rb
 - lib/app_size_report/plugin.rb
+- lib/converter/helper/json_converter.rb
+- lib/converter/helper/memory_size.rb
+- lib/converter/helper/result_factory.rb
+- lib/converter/models/app_size_model.rb
+- lib/converter/models/device_model.rb
+- lib/converter/models/variant_model.rb
+- lib/converter/parser/app_size_parser.rb
+- lib/converter/parser/model_parser.rb
+- lib/converter/parser/report_parser.rb
+- lib/converter/parser/variant_descriptor_parser.rb
+- lib/converter/parser/variant_parser.rb
 - lib/danger_app_size_report.rb
 - lib/danger_plugin.rb
 - spec/app_size_report_spec.rb
@@ -189,11 +203,11 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.2.3
+rubygems_version: 3.3.6
 signing_key:
 specification_version: 4
-summary: Validates variant sizes of app thinning report json within a Pull Request
-  and generates a brief report.
+summary: A Danger plugin for reporting iOS app size violations. A valid App Thinning
+  Size Report must be passed to the plugin for accurate functionality.
 test_files:
 - spec/app_size_report_spec.rb
 - spec/spec_helper.rb

data/LICENSE.txt

@@ -1,22 +0,0 @@
-Copyright (c) 2021 Vido Shaweddy <vido.shaweddy@chargepoint.com>
-
-MIT License
-
-Permission is hereby granted, free of charge, to any person obtaining
-a copy of this software and associated documentation files (the
-"Software"), to deal in the Software without restriction, including
-without limitation the rights to use, copy, modify, merge, publish,
-distribute, sublicense, and/or sell copies of the Software, and to
-permit persons to whom the Software is furnished to do so, subject to
-the following conditions:
-
-The above copyright notice and this permission notice shall be
-included in all copies or substantial portions of the Software.
-
-THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
-EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
-MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
-NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE
-LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION
-OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION
-WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.