danger-apkstats 0.1.0 → 0.3.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 06da284025d85c4baf756df842fef7ed035bbc6a4b51e3869b03df48f851b480
-  data.tar.gz: ed4436f89c1b65211bd338aa4e48095df59c7f518c69a185836cdde7655d2149
+  metadata.gz: 7e3766086cf1f908f3a553259ce56b77077cb25af31cb6f1d2c36c565d4fc62a
+  data.tar.gz: a8592f39aa1288898076e59e0586c3ac941a92294d65123eaad05236e9d78588
 SHA512:
-  metadata.gz: d67745379004649774230e918514f09ac792050190540f23efab90c29308b9b3fe098884288c975f2c74a37e1aab2d9434881224a4e9682a0be1bf58859a17a4
-  data.tar.gz: 869be5736265bffec15b3468846b346a6a45c3b4796e7a80b4cf1448845009f22d9c6e5fb12bebc4c4d7a6e363bffa62a386cd4be18b39eeeeb9c31de139cd8c
+  metadata.gz: 0a93c60400f8692df2701b939cd840d740990da627c530e015ef4012f652de3770d10fb339fe1db7795fb313cbfdd2854c2ac7b5e0580b69add6995e1d1ac980
+  data.tar.gz: b77a1fa1c2c6cff74fdeeba07b6e4d41db76cda9b691f2d702dfdd69138d15a75fcb7897cbe4a8371de9e55ed984b8ea41389efe32fbb83c10498c247f661090

data/.circleci/android-sdk-license

@@ -0,0 +1,3 @@
+
+d56f5187479451eabf01fb78af6dfcb131a6481e
+24333f8a63b6825ea9c5514f83c2829b004d1fee

data/.circleci/config.yml

@@ -0,0 +1,104 @@
+version: 2.1
+
+executors:
+  base:
+    docker:
+    - image: circleci/android:api-29
+    working_directory: ~/workspace
+    environment:
+      ANDROID_SDK_ROOT: /home/circleci/sdk
+      APKANALYZER_PATH: /home/circleci/sdk/cmdline-tools/tools/bin/apkanalyzer
+
+  ruby:
+    docker:
+      - image: circleci/ruby:2.7.1
+    working_directory: ~/workspace
+
+commands:
+  install-android-sdk:
+    parameters:
+      zip-version:
+        type: string
+        description: the version of the zip archive
+      build-tools:
+        type: string
+    steps:
+      - restore_cache:
+          key: v1-android-sdk-{{ arch }}-<< parameters.zip-version >>-<< parameters.build-tools >>
+      - run: |
+          version="<< parameters.zip-version >>"
+          if [ "$(cat $ANDROID_SDK_ROOT/.sdk_tools_version || echo)" != "$version" ]; then	
+            rm -fr $ANDROID_SDK_ROOT || :
+            mkdir -p $ANDROID_SDK_ROOT/licenses	$ANDROID_SDK_ROOT/cmdline-tools
+            curl -o sdk-tools-linux.zip "https://dl.google.com/android/repository/commandlinetools-linux-${version}_latest.zip"	
+            unzip "sdk-tools-linux.zip" -d $ANDROID_SDK_ROOT/cmdline-tools
+            echo "$version" > $ANDROID_SDK_ROOT/.sdk_tools_version
+          fi
+          mkdir -p $ANDROID_SDK_ROOT/licenses
+          cp .circleci/android-sdk-license $ANDROID_SDK_ROOT/licenses/
+          $ANDROID_SDK_ROOT/cmdline-tools/tools/bin/sdkmanager "build-tools;<< parameters.build-tools >>" 
+      - save_cache:
+          key: v1-android-sdk-{{ arch }}-<< parameters.zip-version >>-<< parameters.build-tools >>
+          paths:
+            - ~/sdk
+  install-ruby:
+    parameters:
+      ruby-version:
+        type: string
+    steps:
+      - run: |
+          sudo apt-get update && \
+          cd /tmp && wget -O ruby-install-0.6.1.tar.gz https://github.com/postmodern/ruby-install/archive/v0.6.1.tar.gz && \
+          tar -xzvf ruby-install-0.6.1.tar.gz && \
+          cd ruby-install-0.6.1 && \
+          sudo make install && \
+          ruby-install --cleanup ruby << parameters.ruby-version >> && \
+          rm -r /tmp/ruby-install-* && \
+          sudo rm -rf /var/lib/apt/lists/*
+
+          echo "export PATH=${HOME}/.rubies/ruby-<< parameters.ruby-version >>/bin:\${PATH}" >> $BASH_ENV
+      - run: ruby --version
+  bundle-install:
+    steps:
+      - restore_cache:
+          key: v1-bundle-{{ arch }}-{{ checksum "./Gemfile.lock" }}
+      - run: gem install bundler -v 2.1.4
+      - run: bundle install --path=vendor/bundle
+      - save_cache:
+          key: v1-bundle-{{ arch }}-{{ checksum "./Gemfile.lock" }}
+          paths:
+            - vendor/bundle
+
+jobs:
+  lint:
+    executor: ruby
+    steps:
+      - checkout
+      - bundle-install
+      - run: bundle exec rake rubocop
+
+  test:
+    parameters:
+      ruby_version:
+        type: string
+        description: 'Ruby version to be used'
+    executor: base
+    
+    steps:
+      - checkout
+      - install-ruby:
+          ruby-version: << parameters.ruby_version >>
+      - install-android-sdk:
+          zip-version: "6514223"
+          build-tools: 29.0.2
+      - bundle-install
+      - run: bundle exec rake specs spec_docs
+
+workflows:
+  materix_test:
+    jobs:
+      - lint
+      - test:
+          matrix:
+            parameters:
+              ruby_version: [2.5.8, 2.6.6, 2.7.1]

data/.gitignore

@@ -4,3 +4,4 @@ pkg
 .yardoc
 **/vendor/bundle/
 *.gem
+.bundle/

data/.rubocop.yml

@@ -7,7 +7,7 @@ AllCops:
     - 'vendor/**/*'
     - 'spec/fixtures/**/*'
     - 'tmp/**/*'
-  TargetRubyVersion: 2.3.7
+  TargetRubyVersion: 2.7.1
 
 Metrics/ModuleLength:
   Exclude:
@@ -22,20 +22,16 @@ Style/StringLiterals:
 Style/ClassCheck:
   EnforcedStyle: kind_of?
 
-# It's better to be more explicit about the type
-Style/BracesAroundHashParameters:
-  Enabled: false
-
 # specs sometimes have useless assignments, which is fine
 Lint/UselessAssignment:
   Exclude:
     - '**/spec/**/*'
 
 # We could potentially enable the 2 below:
-Layout/IndentHash:
+Layout/FirstHashElementIndentation:
   Enabled: false
 
-Layout/AlignHash:
+Layout/HashAlignment:
   Enabled: false
 
 # HoundCI doesn't like this rule
@@ -85,7 +81,7 @@ Metrics/CyclomaticComplexity:
   Max: 17
 
 # Configuration parameters: AllowURI, URISchemes.
-Metrics/LineLength:
+Layout/LineLength:
   Max: 370
 
 # Configuration parameters: CountKeywordArgs.
@@ -136,16 +132,16 @@ Metrics/BlockLength:
 Style/MixinGrouping:
   Enabled: false
 
-Style/FileName:
+Naming/FileName:
   Enabled: false
 
-Layout/IndentHeredoc:
+Layout/HeredocIndentation:
   Enabled: false
 
 Style/SpecialGlobalVars:
   Enabled: false
 
-PercentLiteralDelimiters:
+Department/PercentLiteralDelimiters:
   PreferredDelimiters:
     "%":  ()
     "%i": ()
@@ -167,4 +163,43 @@ Style/TrailingCommaInArrayLiteral:
   Enabled: false
 
 Style/TrailingCommaInHashLiteral:
-  Enabled: false
+  Enabled: false
+
+Layout/EmptyLinesAroundAttributeAccessor:
+  Enabled: true
+
+Layout/SpaceAroundMethodCallOperator:
+  Enabled: false
+
+Lint/DeprecatedOpenSSLConstant:
+  Enabled: false
+
+Lint/MixedRegexpCaptureTypes:
+  Enabled: false
+
+Lint/RaiseException:
+  Enabled: true
+
+Lint/StructNewOverride:
+  Enabled: true
+
+Style/ExponentialNotation:
+  Enabled: false
+
+Style/HashEachMethods:
+  Enabled: true
+
+Style/HashTransformKeys:
+  Enabled: true
+
+Style/HashTransformValues:
+  Enabled: true
+
+Style/RedundantRegexpCharacterClass:
+  Enabled: true
+
+Style/RedundantRegexpEscape:
+  Enabled: true
+
+Style/SlicingWithRange:
+  Enabled: true

data/Dangerfile.sample

@@ -11,5 +11,7 @@ message(apkstats.non_required_features)
 message(apkstats.permissions)
 message(apkstats.min_sdk)
 message(apkstats.target_sdk)
+message("#{apkstats.reference_count}")
+message("#{apkstats.dex_count}")
 
 apkstats.compare_with('/spec/fixture/app-other5.apk', do_report: true)

data/Gemfile.lock

@@ -1,47 +1,49 @@
 PATH
   remote: .
   specs:
-    danger-apkstats (0.1.0)
+    danger-apkstats (0.3.1)
       danger-plugin-api (~> 1.0)
 
 GEM
   remote: https://rubygems.org/
   specs:
-    addressable (2.5.2)
-      public_suffix (>= 2.0.2, < 4.0)
-    ast (2.4.0)
-    claide (1.0.2)
+    addressable (2.7.0)
+      public_suffix (>= 2.0.2, < 5.0)
+    ast (2.4.1)
+    claide (1.0.3)
     claide-plugins (0.9.2)
       cork
       nap
       open4 (~> 1.3)
-    coderay (1.1.2)
+    coderay (1.1.3)
     colored2 (3.1.2)
     cork (0.3.0)
       colored2 (~> 3.1)
-    danger (5.6.4)
+    danger (8.0.1)
       claide (~> 1.0)
       claide-plugins (>= 0.9.2)
       colored2 (~> 3.1)
       cork (~> 0.1)
-      faraday (~> 0.9)
-      faraday-http-cache (~> 1.0)
-      git (~> 1)
-      kramdown (~> 1.5)
+      faraday (>= 0.9.0, < 2.0)
+      faraday-http-cache (~> 2.0)
+      git (~> 1.7)
+      kramdown (~> 2.0)
+      kramdown-parser-gfm (~> 1.0)
       no_proxy_fix
       octokit (~> 4.7)
       terminal-table (~> 1)
     danger-plugin-api (1.0.0)
       danger (> 2.0)
     diff-lcs (1.3)
-    faraday (0.15.2)
+    faraday (1.0.1)
       multipart-post (>= 1.2, < 3)
-    faraday-http-cache (1.3.1)
-      faraday (~> 0.8)
-    ffi (1.9.25)
+    faraday-http-cache (2.2.0)
+      faraday (>= 0.8)
+    ffi (1.13.1)
     formatador (0.2.5)
-    git (1.4.0)
-    guard (2.14.2)
+    git (1.7.0)
+      rchardet (~> 1.8)
+    guard (2.16.2)
       formatador (>= 0.2.4)
       listen (>= 2.7, < 4.0)
       lumberjack (>= 1.0.12, < 2.0)
@@ -55,82 +57,89 @@ GEM
       guard (~> 2.1)
       guard-compat (~> 1.1)
       rspec (>= 2.99.0, < 4.0)
-    jaro_winkler (1.5.1)
-    kramdown (1.17.0)
+    kramdown (2.3.0)
+      rexml
+    kramdown-parser-gfm (1.1.0)
+      kramdown (~> 2.0)
     listen (3.0.7)
       rb-fsevent (>= 0.9.3)
       rb-inotify (>= 0.9.7)
-    lumberjack (1.0.13)
-    method_source (0.9.0)
-    multipart-post (2.0.0)
+    lumberjack (1.2.5)
+    method_source (1.0.0)
+    multipart-post (2.1.1)
     nap (1.1.0)
     nenv (0.3.0)
     no_proxy_fix (0.1.2)
-    notiffany (0.1.1)
+    notiffany (0.1.3)
       nenv (~> 0.1)
       shellany (~> 0.0)
-    octokit (4.9.0)
+    octokit (4.18.0)
+      faraday (>= 0.9)
       sawyer (~> 0.8.0, >= 0.5.3)
     open4 (1.3.4)
-    parallel (1.12.1)
-    parser (2.5.1.2)
+    parallel (1.19.1)
+    parser (2.7.1.3)
       ast (~> 2.4.0)
-    powerpack (0.1.2)
-    pry (0.11.3)
-      coderay (~> 1.1.0)
-      method_source (~> 0.9.0)
-    public_suffix (3.0.2)
+    pry (0.13.1)
+      coderay (~> 1.1)
+      method_source (~> 1.0)
+    public_suffix (4.0.5)
     rainbow (3.0.0)
-    rake (10.5.0)
-    rb-fsevent (0.10.3)
-    rb-inotify (0.9.10)
-      ffi (>= 0.5.0, < 2)
-    rspec (3.7.0)
-      rspec-core (~> 3.7.0)
-      rspec-expectations (~> 3.7.0)
-      rspec-mocks (~> 3.7.0)
-    rspec-core (3.7.1)
-      rspec-support (~> 3.7.0)
-    rspec-expectations (3.7.0)
+    rake (13.0.1)
+    rb-fsevent (0.10.4)
+    rb-inotify (0.10.1)
+      ffi (~> 1.0)
+    rchardet (1.8.0)
+    regexp_parser (1.7.1)
+    rexml (3.2.4)
+    rspec (3.9.0)
+      rspec-core (~> 3.9.0)
+      rspec-expectations (~> 3.9.0)
+      rspec-mocks (~> 3.9.0)
+    rspec-core (3.9.2)
+      rspec-support (~> 3.9.3)
+    rspec-expectations (3.9.2)
       diff-lcs (>= 1.2.0, < 2.0)
-      rspec-support (~> 3.7.0)
-    rspec-mocks (3.7.0)
+      rspec-support (~> 3.9.0)
+    rspec-mocks (3.9.1)
       diff-lcs (>= 1.2.0, < 2.0)
-      rspec-support (~> 3.7.0)
-    rspec-support (3.7.1)
-    rubocop (0.58.2)
-      jaro_winkler (~> 1.5.1)
+      rspec-support (~> 3.9.0)
+    rspec-support (3.9.3)
+    rubocop (0.85.1)
       parallel (~> 1.10)
-      parser (>= 2.5, != 2.5.1.1)
-      powerpack (~> 0.1)
+      parser (>= 2.7.0.1)
       rainbow (>= 2.2.2, < 4.0)
+      regexp_parser (>= 1.7)
+      rexml
+      rubocop-ast (>= 0.0.3)
       ruby-progressbar (~> 1.7)
-      unicode-display_width (~> 1.0, >= 1.0.1)
-    ruby-progressbar (1.9.0)
-    sawyer (0.8.1)
-      addressable (>= 2.3.5, < 2.6)
-      faraday (~> 0.8, < 1.0)
+      unicode-display_width (>= 1.4.0, < 2.0)
+    rubocop-ast (0.0.3)
+      parser (>= 2.7.0.1)
+    ruby-progressbar (1.10.1)
+    sawyer (0.8.2)
+      addressable (>= 2.3.5)
+      faraday (> 0.8, < 2.0)
     shellany (0.0.1)
     terminal-table (1.8.0)
       unicode-display_width (~> 1.1, >= 1.1.1)
-    thor (0.20.0)
-    unicode-display_width (1.4.0)
-    yard (0.9.15)
+    thor (1.0.1)
+    unicode-display_width (1.7.0)
+    yard (0.9.25)
 
 PLATFORMS
   ruby
 
 DEPENDENCIES
-  bundler (~> 1.3)
   danger-apkstats!
   guard (~> 2.14)
   guard-rspec (~> 4.7)
   listen (= 3.0.7)
   pry
-  rake (~> 10.0)
+  rake (~> 13.0)
   rspec (~> 3.4)
   rubocop
   yard
 
 BUNDLED WITH
-   1.16.1
+   2.1.4

data/LICENSE.txt

@@ -1,4 +1,4 @@
-Copyright (c) 2018 Jumpei Matsuda <jmatsu.drm@gmail.com>
+Copyright (c) 2018-2020 Jumpei Matsuda <jmatsu.drm@gmail.com>
 
 MIT License
 

data/README.md

@@ -1,23 +1,35 @@
-[![Build Status](https://travis-ci.com/jmatsu/danger-apkstats.svg?branch=master)](https://travis-ci.com/jmatsu/danger-apkstats) [![Gem Version](https://badge.fury.io/rb/danger-apkstats.svg)](https://badge.fury.io/rb/danger-apkstats)
+[![jmatsu](https://circleci.com/gh/jmatsu/danger-apkstats.svg?style=shield)](https://circleci.com/gh/jmatsu/danger-apkstats) [![Gem Version](https://badge.fury.io/rb/danger-apkstats.svg)](https://badge.fury.io/rb/danger-apkstats)
 
 # danger-apkstats
 
-A description of danger-apkstats.
+This is a plugin of [Danger](https://github.com/danger/danger) for Android projects.
+This allows you to get attributes of your application file (apk) and report a summary of comparison between two application files.
 
 ## Installation
 
-    $ gem install danger-apkstats
+`gem install danger-apkstats` or add `danger-apkstats` to your Gemfile.
 
-## Usage
+Please specify the path of apkanalyzer in your Dangerfile.
+
+```ruby
+apkstats.apkanalyzer_path='/path/to/apkanalyzer'
+```
 
-    Methods and attributes from this plugin are available in
-    your `Dangerfile` under the `apkstats` namespace.
+`ANDROID_HOME` has been officially deprecated. `ANDROID_SDK_ROOT` is similar to `ANDROID_HOME` but differs actually. And also, the change indicated the possibility of further deprecations and/or breaking changes in the Android SDK structure.
 
-# Sample
+## Usage
+
+`apkstats` namespace is available under Dangerfile.
+    
+### Required preparation
 
 ```
 apkstats.apk_filepath='app-debug.apk' # required.
-apkstats.compare_with('app-other.apk', do_report: true)
+```
+
+### Show attributes
+
+```
 apkstats.file_size #=> Fixnum
 apkstats.download_size #=> Fixnum
 apkstats.required_features #=> Array<String> | Nil
@@ -25,22 +37,28 @@ apkstats.non_required_features #=> Array<String> | Nil
 apkstats.permissions #=> Array<String> | Nil
 apkstats.min_sdk #=> String | Nil
 apkstats.target_sdk #=> String | Nils
+apkstats.reference_count #=> Fixnum
+apkstats.dex_count #=> Fixnum
 ```
 
-## Compare apk files
+### Get a comparison report
 
-The report will be like below.
+```
+apkstats.compare_with(String, do_report: Boolean)
+```
 
-### Apk comparision results
+For example, the report will be like below.
 
 Property | Summary  
 :--- | :---
-New File Size | 1621248 Bytes. (1.55 MB
+New File Size | 1621248 Bytes. (1.55 MB)
 File Size Change | -13352 Bytes. (-13.04 KB)
 Download Size Change | +41141 Bytes. (+40.18 KB)
 Removed Required Features | - android.hardware.camera
 Removed Non-required Features | - android.hardware.camera.front (not-required)
 Removed Permissions | - android.permission.INTERNET<br>- android.permission.CAMERA
+New Number of dex file(s) | 15720
+Number of dex file(s) Change | 1
 
 ## Development
 
@@ -49,3 +67,9 @@ Removed Permissions | - android.permission.INTERNET<br>- android.permission.CAME
 3. Run `bundle exec rake spec` to run the tests.
 4. Use `bundle exec guard` to automatically have tests run as you make changes.
 5. Make your changes.
+
+### Supported ruby versions
+
+Support only versions which are in normal and/or security maintenance.
+
+ref: https://www.ruby-lang.org/en/downloads/branches/