danger-apkstats 0.0.2 → 0.1.0

data/spec/helper/bytes_spec.rb

@@ -0,0 +1,95 @@
+# frozen_string_literal: true
+
+require_relative "../spec_helper"
+
+module Apkstats::Helper
+  describe Apkstats::Helper::Bytes do
+    context "from_b" do
+      let(:byte) { Bytes.from_b(100_000) }
+      let(:negative_byte) { Bytes.from_b(-100_000) }
+
+      it "to_b" do
+        expect(byte.to_b).to be_within(0.01).of(100_000)
+        expect(byte.to_s_b).to eq("+#{byte.to_b}")
+        expect(negative_byte.to_b).to be_within(0.01).of(-100_000)
+        expect(negative_byte.to_s_b).to eq(negative_byte.to_b.to_s)
+      end
+
+      it "to_kb" do
+        expect(byte.to_kb).to be_within(0.01).of((100_000 / 1024.to_f).round(2))
+        expect(byte.to_s_kb).to eq("+#{byte.to_kb}")
+        expect(negative_byte.to_kb).to be_within(0.01).of((-100_000 / 1024.to_f).round(2))
+        expect(negative_byte.to_s_kb).to eq(negative_byte.to_kb.to_s)
+      end
+
+      it "to_mb" do
+        expect(byte.to_mb).to be_within(0.01).of(((100_000 / 1024.to_f).round(2) / 1024.to_f).round(2))
+        expect(byte.to_s_mb).to eq("+#{byte.to_mb}")
+        expect(negative_byte.to_mb).to be_within(0.01).of(((-100_000 / 1024.to_f).round(2) / 1024.to_f).round(2))
+        expect(negative_byte.to_s_mb).to eq(negative_byte.to_mb.to_s)
+      end
+    end
+
+    context "from_kb" do
+      let(:byte) { Bytes.from_kb(1234.56) }
+      let(:negative_byte) { Bytes.from_kb(-1234.56) }
+
+      it "to_b" do
+        expect(byte.to_b).to be_within(0.01).of(1234.56 * 1024)
+        expect(byte.to_s_b).to eq("+#{byte.to_b}")
+        expect(negative_byte.to_b).to be_within(0.01).of(-1234.56 * 1024)
+        expect(negative_byte.to_s_b).to eq(negative_byte.to_b.to_s)
+      end
+
+      it "to_kb" do
+        expect(byte.to_kb).to be_within(0.01).of(1234.56)
+        expect(byte.to_s_kb).to eq("+#{byte.to_kb}")
+        expect(negative_byte.to_kb).to be_within(0.01).of(-1234.56)
+        expect(negative_byte.to_s_kb).to eq(negative_byte.to_kb.to_s)
+      end
+
+      it "to_mb" do
+        expect(byte.to_mb).to be_within(0.01).of((1234.56 / 1024.to_f).round(2))
+        expect(byte.to_s_mb).to eq("+#{byte.to_mb}")
+        expect(negative_byte.to_mb).to be_within(0.01).of((-1234.56 / 1024.to_f).round(2))
+        expect(negative_byte.to_s_mb).to eq(negative_byte.to_mb.to_s)
+      end
+    end
+
+    context "from_mb" do
+      let(:byte) { Bytes.from_mb(12.34) }
+      let(:negative_byte) { Bytes.from_mb(-12.34) }
+
+      it "to_b" do
+        expect(byte.to_b).to be_within(0.01).of(12.34 * 1024 * 1024)
+        expect(byte.to_s_b).to eq("+#{byte.to_b}")
+        expect(negative_byte.to_b).to be_within(0.01).of(-12.34 * 1024 * 1024)
+        expect(negative_byte.to_s_b).to eq(negative_byte.to_b.to_s)
+      end
+
+      it "to_kb" do
+        expect(byte.to_kb).to be_within(0.01).of(12.34 * 1024)
+        expect(byte.to_s_kb).to eq("+#{byte.to_kb}")
+        expect(negative_byte.to_kb).to be_within(0.01).of(-12.34 * 1024)
+        expect(negative_byte.to_s_kb).to eq(negative_byte.to_kb.to_s)
+      end
+
+      it "to_mb" do
+        expect(byte.to_mb).to be_within(0.01).of(12.34)
+        expect(byte.to_s_mb).to eq("+#{byte.to_mb}")
+        expect(negative_byte.to_mb).to be_within(0.01).of(-12.34)
+        expect(negative_byte.to_s_mb).to eq(negative_byte.to_mb.to_s)
+      end
+    end
+
+    it "up_unit" do
+      expect(Bytes.up_unit(100)).to be_within(0.01).of(100.to_f / 1024)
+      expect(Bytes.up_unit(234)).to be_within(0.01).of(234.to_f / 1024)
+    end
+
+    it "down_unit" do
+      expect(Bytes.down_unit(100)).to eq(100 * 1024)
+      expect(Bytes.down_unit(234)).to eq(234 * 1024)
+    end
+  end
+end

data/spec/spec_helper.rb

@@ -1,15 +1,21 @@
+# frozen_string_literal: true
+
 require "pathname"
-ROOT = Pathname.new(File.expand_path("../../", __FILE__))
+ROOT = Pathname.new(File.expand_path("..", __dir__))
 $:.unshift((ROOT + "lib").to_s)
 $:.unshift((ROOT + "spec").to_s)
 
+def fixture_path
+  "#{(ROOT + 'spec' + 'fixture')}/"
+end
+
 require "bundler/setup"
 require "pry"
 
 require "rspec"
 require "danger"
 
-if `git remote -v` == ''
+if `git remote -v` == ""
   puts "You cannot run tests without setting a local git remote on this repo"
   puts "It's a weird side-effect of Danger's internals."
   exit(0)
@@ -63,3 +69,5 @@ def testing_dangerfile
   env = Danger::EnvironmentManager.new(testing_env)
   Danger::Dangerfile.new(env, testing_ui)
 end
+
+require_relative "stub/command"

data/spec/stub/command.rb

@@ -0,0 +1,20 @@
+# frozen_string_literal: true
+
+module Apkstats::Stub
+  class Command
+    include Apkstats::Command::Executable
+
+    def initialize(defaults = {})
+      @command_path = __FILE__
+      @defaults = defaults
+    end
+
+    def method_missing(name, *arguments, &block)
+      Apkstats::Entity::ApkInfo::KEYS.include?(name.to_sym) && !block && arguments.size == 1 && @defaults[name.to_sym] || super
+    end
+
+    def respond_to_missing?(method_name, _include_private = false)
+      Apkstats::Entity::ApkInfo::KEYS.include?(method_name.to_sym) || super
+    end
+  end
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: danger-apkstats
 version: !ruby/object:Gem::Version
-  version: 0.0.2
+  version: 0.1.0
 platform: ruby
 authors:
 - Jumpei Matsuda
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-07-27 00:00:00.000000000 Z
+date: 2018-07-31 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: danger-plugin-api
@@ -161,20 +161,41 @@ files:
 - ".gitignore"
 - ".rubocop.yml"
 - ".travis.yml"
+- Dangerfile.sample
 - Gemfile
+- Gemfile.lock
 - Guardfile
 - LICENSE.txt
 - README.md
 - Rakefile
 - danger-apkstats.gemspec
 - lib/apkstats/command/apk_analyzer.rb
-- lib/apkstats/command/executable_command.rb
+- lib/apkstats/command/executable.rb
+- lib/apkstats/entity/apk_info.rb
+- lib/apkstats/entity/apk_info_diff.rb
+- lib/apkstats/entity/feature.rb
+- lib/apkstats/entity/permission.rb
 - lib/apkstats/gem_version.rb
+- lib/apkstats/helper/bytes.rb
 - lib/apkstats/plugin.rb
 - lib/danger_apkstats.rb
 - lib/danger_plugin.rb
 - spec/apkstats_spec.rb
+- spec/command/apk_analyzer_spec.rb
+- spec/entity/apk_info_diff_spec.rb
+- spec/entity/apk_info_spec.rb
+- spec/entity/features_spec.rb
+- spec/entity/permissions_spec.rb
+- spec/fixture/app-base.apk
+- spec/fixture/app-other1.apk
+- spec/fixture/app-other2.apk
+- spec/fixture/app-other3.apk
+- spec/fixture/app-other4.apk
+- spec/fixture/app-other5.apk
+- spec/fixture/github_pr.json
+- spec/helper/bytes_spec.rb
 - spec/spec_helper.rb
+- spec/stub/command.rb
 homepage: https://github.com/jmatsu/danger-apkstats
 licenses:
 - MIT
@@ -201,4 +222,18 @@ specification_version: 4
 summary: This is a danger plugin to inspect android application file.
 test_files:
 - spec/apkstats_spec.rb
+- spec/command/apk_analyzer_spec.rb
+- spec/entity/apk_info_diff_spec.rb
+- spec/entity/apk_info_spec.rb
+- spec/entity/features_spec.rb
+- spec/entity/permissions_spec.rb
+- spec/fixture/app-base.apk
+- spec/fixture/app-other1.apk
+- spec/fixture/app-other2.apk
+- spec/fixture/app-other3.apk
+- spec/fixture/app-other4.apk
+- spec/fixture/app-other5.apk
+- spec/fixture/github_pr.json
+- spec/helper/bytes_spec.rb
 - spec/spec_helper.rb
+- spec/stub/command.rb

data/lib/apkstats/command/executable_command.rb

@@ -1,24 +0,0 @@
-module Danger::Apkstats
-  module ExecutableCommand
-    require "open3"
-    
-    # @return [String, String] ([ size, old_size, changed_by ].join(' '), err message)
-    def compare_with(apk_filepath, other_apk_filepath)
-        unsupported!
-    end
-
-    def filesize(apk_filepath)
-        unsupported!
-    end
-
-    def downloadsize(apk_filepath)
-        unsupported!
-    end
-
-    private
-
-    def unsupported!
-        raise "#{__method__} is not supported by #{self.class}"
-    end
-  end
-end