danger-android_lint 0.0.4 → 0.0.9

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: bc51ff27951c956c5534a2adc9219db6ef8b23ea
-  data.tar.gz: 162c31a66338d95c2d184864ad9cbbb02377668c
+SHA256:
+  metadata.gz: 9ada934a0418e182a4f33db8040b2ac2686b51062d9298bcafeec2641333c794
+  data.tar.gz: f083ac782badad37b3013f29326723662c6e30fa87d1f553e9049edb0d4308b0
 SHA512:
-  metadata.gz: e34ff70dab0f608b3bfd09aa5f3ec7e3a83812fa95f3597bbb88c67d6e3854991caf156f61ec652f7415509082731665c1bc8060dc912e98761e06f0a1728b6b
-  data.tar.gz: 53601dfb052fed83d66a369edfc6843759d47c9786f9bd477a65f84fb1208815f9c1a8cc66067b8de597755dfa3fb47848cff8f75ea08848737822f8d6e34374
+  metadata.gz: 9ad11c214c69b8705766e879b6bd37c436b9ab5f5c812a5f0defedcbdd14c8d1cc012f16b16461a1426eedbd5659bd6c89aa85c4b3dcb2162984831e369ddaaa
+  data.tar.gz: cca847253edd672cd61da0142cabdb6fb768315cf5fa44a824b0471f9f335df47700452f0b8deabe5a4fee80cec109bbfe4f8d193b695f56f8e30bedcd259460

data/.circleci/config.yml

@@ -0,0 +1,13 @@
+version: 2.1
+orbs:
+  ruby: circleci/ruby@1.0
+
+jobs:
+  build:
+    docker:
+      - image: circleci/ruby:2.7
+    steps:
+      - checkout
+      - run: gem install bundler:2.2.10
+      - run: bundle install
+      - run: bundle exec rake spec

data/.github/CODEOWNERS

@@ -0,0 +1 @@
+*	@barbosa

data/.gitignore

@@ -4,3 +4,5 @@ pkg
 .idea/
 .yardoc/
 *.gem
+.bundle/
+vendor/

data/.ruby-version

@@ -0,0 +1 @@
+2.3.5

data/CHANGELOG.md

@@ -1,3 +1,21 @@
+# 0.0.9
+- Add `filtering_lines` parameter, to show lint issues only on modified lines ([@ShivamPokhriyal](https://github.com/ShivamPokhriyal))
+
+# 0.0.8
+- Fix security issues ([@barbosa](https://github.com/barbosa))
+- Expose report message ([@adamstrange])(https://github.com/adamstrange))
+- Skip gradle task ([@mathroule])(https://github.com/mathroule))
+
+# 0.0.7
+- Fix security issues ([@barbosa](https://github.com/barbosa))
+
+# 0.0.6
+- Bump yarn and rubocop versions due to security issues ([@barbosa](https://github.com/barbosa))
+
+# 0.0.5
+- Fix count number for issues ([@jettbow](https://github.com/jettbow))
+- Add option for skipping gradle task ([@litmon](https://github.com/litmon))
+
 # 0.0.4
 - Add `filtering` parameter, default to false, to run lint only on modified files ([@leonhartX](https://github.com/leonhartX))
 - Add support for GitHub's inline comments ([@leonhartX](https://github.com/leonhartX))

data/Gemfile.lock

@@ -1,51 +1,65 @@
 PATH
   remote: .
   specs:
-    danger-android_lint (0.0.1)
+    danger-android_lint (0.0.9)
       danger-plugin-api (~> 1.0)
       oga
 
 GEM
   remote: https://rubygems.org/
   specs:
-    addressable (2.5.0)
-      public_suffix (~> 2.0, >= 2.0.2)
+    addressable (2.7.0)
+      public_suffix (>= 2.0.2, < 5.0)
     ansi (1.5.0)
-    ast (2.3.0)
-    claide (1.0.1)
+    ast (2.4.2)
+    claide (1.0.3)
     claide-plugins (0.9.2)
       cork
       nap
       open4 (~> 1.3)
-    coderay (1.1.1)
-    colored (1.2)
-    cork (0.2.0)
-      colored (~> 1.2)
-    danger (4.0.1)
+    coderay (1.1.3)
+    colored2 (3.1.2)
+    cork (0.3.0)
+      colored2 (~> 3.1)
+    danger (8.2.3)
       claide (~> 1.0)
       claide-plugins (>= 0.9.2)
-      colored (~> 1.2)
+      colored2 (~> 3.1)
       cork (~> 0.1)
-      faraday (~> 0.9)
-      faraday-http-cache (~> 1.0)
-      git (~> 1)
-      kramdown (~> 1.5)
-      octokit (~> 4.2)
-      terminal-table (~> 1)
+      faraday (>= 0.9.0, < 2.0)
+      faraday-http-cache (~> 2.0)
+      git (~> 1.7)
+      kramdown (~> 2.3)
+      kramdown-parser-gfm (~> 1.0)
+      no_proxy_fix
+      octokit (~> 4.7)
+      terminal-table (>= 1, < 4)
     danger-plugin-api (1.0.0)
       danger (> 2.0)
-    diff-lcs (1.2.5)
-    faraday (0.10.0)
+    diff-lcs (1.4.4)
+    faraday (1.4.2)
+      faraday-em_http (~> 1.0)
+      faraday-em_synchrony (~> 1.0)
+      faraday-excon (~> 1.1)
+      faraday-net_http (~> 1.0)
+      faraday-net_http_persistent (~> 1.1)
       multipart-post (>= 1.2, < 3)
-    faraday-http-cache (1.3.1)
-      faraday (~> 0.8)
-    ffi (1.9.14)
-    formatador (0.2.5)
-    git (1.3.0)
-    guard (2.14.0)
+      ruby2_keywords (>= 0.0.4)
+    faraday-em_http (1.0.0)
+    faraday-em_synchrony (1.0.0)
+    faraday-excon (1.1.0)
+    faraday-http-cache (2.2.0)
+      faraday (>= 0.8)
+    faraday-net_http (1.0.1)
+    faraday-net_http_persistent (1.1.0)
+    ffi (1.15.3)
+    formatador (0.3.0)
+    git (1.8.1)
+      rchardet (~> 1.8)
+    guard (2.17.0)
       formatador (>= 0.2.4)
       listen (>= 2.7, < 4.0)
-      lumberjack (~> 1.0)
+      lumberjack (>= 1.0.12, < 2.0)
       nenv (~> 0.1)
       notiffany (~> 0.0)
       pry (>= 0.9.12)
@@ -56,52 +70,61 @@ GEM
       guard (~> 2.1)
       guard-compat (~> 1.1)
       rspec (>= 2.99.0, < 4.0)
-    kramdown (1.13.0)
+    kramdown (2.3.1)
+      rexml
+    kramdown-parser-gfm (1.1.0)
+      kramdown (~> 2.0)
     listen (3.0.7)
       rb-fsevent (>= 0.9.3)
       rb-inotify (>= 0.9.7)
-    lumberjack (1.0.10)
-    method_source (0.8.2)
-    multipart-post (2.0.0)
+    lumberjack (1.2.8)
+    method_source (1.0.0)
+    multipart-post (2.1.1)
     nap (1.1.0)
     nenv (0.3.0)
-    notiffany (0.1.1)
+    no_proxy_fix (0.1.2)
+    notiffany (0.1.3)
       nenv (~> 0.1)
       shellany (~> 0.0)
-    octokit (4.6.2)
+    octokit (4.21.0)
+      faraday (>= 0.9)
       sawyer (~> 0.8.0, >= 0.5.3)
-    oga (2.7)
+    oga (3.3)
       ast
       ruby-ll (~> 2.1)
     open4 (1.3.4)
-    parser (2.3.1.4)
-      ast (~> 2.2)
-    powerpack (0.1.1)
-    pry (0.10.4)
-      coderay (~> 1.1.0)
-      method_source (~> 0.8.1)
-      slop (~> 3.4)
-    public_suffix (2.0.4)
-    rainbow (2.1.0)
-    rake (10.5.0)
-    rb-fsevent (0.9.8)
-    rb-inotify (0.9.7)
-      ffi (>= 0.5.0)
-    rspec (3.5.0)
-      rspec-core (~> 3.5.0)
-      rspec-expectations (~> 3.5.0)
-      rspec-mocks (~> 3.5.0)
-    rspec-core (3.5.4)
-      rspec-support (~> 3.5.0)
-    rspec-expectations (3.5.0)
+    parallel (1.20.1)
+    parser (2.7.2.0)
+      ast (~> 2.4.1)
+    powerpack (0.1.3)
+    pry (0.14.1)
+      coderay (~> 1.1)
+      method_source (~> 1.0)
+    public_suffix (4.0.6)
+    rainbow (2.2.2)
+      rake
+    rake (13.0.3)
+    rb-fsevent (0.11.0)
+    rb-inotify (0.10.1)
+      ffi (~> 1.0)
+    rchardet (1.8.0)
+    rexml (3.2.5)
+    rspec (3.10.0)
+      rspec-core (~> 3.10.0)
+      rspec-expectations (~> 3.10.0)
+      rspec-mocks (~> 3.10.0)
+    rspec-core (3.10.1)
+      rspec-support (~> 3.10.0)
+    rspec-expectations (3.10.1)
       diff-lcs (>= 1.2.0, < 2.0)
-      rspec-support (~> 3.5.0)
-    rspec-mocks (3.5.0)
+      rspec-support (~> 3.10.0)
+    rspec-mocks (3.10.2)
       diff-lcs (>= 1.2.0, < 2.0)
-      rspec-support (~> 3.5.0)
-    rspec-support (3.5.0)
-    rubocop (0.45.0)
-      parser (>= 2.3.1.1, < 3.0)
+      rspec-support (~> 3.10.0)
+    rspec-support (3.10.2)
+    rubocop (0.49.1)
+      parallel (~> 1.10)
+      parser (>= 2.3.3.1, < 3.0)
       powerpack (~> 0.1)
       rainbow (>= 1.99.1, < 3.0)
       ruby-progressbar (~> 1.7)
@@ -109,32 +132,32 @@ GEM
     ruby-ll (2.1.2)
       ansi
       ast
-    ruby-progressbar (1.8.1)
-    sawyer (0.8.1)
-      addressable (>= 2.3.5, < 2.6)
-      faraday (~> 0.8, < 1.0)
+    ruby-progressbar (1.11.0)
+    ruby2_keywords (0.0.4)
+    sawyer (0.8.2)
+      addressable (>= 2.3.5)
+      faraday (> 0.8, < 2.0)
     shellany (0.0.1)
-    slop (3.6.0)
-    terminal-table (1.7.3)
-      unicode-display_width (~> 1.1.1)
-    thor (0.19.1)
-    unicode-display_width (1.1.1)
-    yard (0.9.5)
+    terminal-table (3.0.1)
+      unicode-display_width (>= 1.1.1, < 3)
+    thor (1.1.0)
+    unicode-display_width (1.7.0)
+    yard (0.9.26)
 
 PLATFORMS
-  ruby
+  universal-darwin-20
 
 DEPENDENCIES
-  bundler (~> 1.3)
+  bundler (>= 2.2.10)
   danger-android_lint!
   guard (~> 2.14)
   guard-rspec (~> 4.7)
   listen (= 3.0.7)
   pry
-  rake (~> 10.0)
+  rake (~> 13.0)
   rspec (~> 3.4)
-  rubocop (~> 0.41)
-  yard (~> 0.8)
+  rubocop (~> 0.49.0)
+  yard (~> 0.9.11)
 
 BUNDLED WITH
-   1.12.5
+   2.2.10

data/README.md

@@ -49,6 +49,24 @@ android_lint.gradle_task = "lintMyFlavorDebug"
 android_lint.lint
 ```
 
+#### Skip gradle task execution
+
+If you want to skip the gradle task execution. You can achieve that by simply changing the value of `skip_gradle_task`. Default is `false`.
+
+```rb
+android_lint.skip_gradle_task = true
+android_lint.lint
+```
+
+#### Changing report's file path
+
+If you're using a path to output your report file other than the default one, you can specify it by setting a new value to `report_file`:
+
+```rb
+android_lint.report_file = "your/report/file.xml"
+android_lint.lint
+```
+
 #### Changing report's severity level
 
 If you want to filter lint issues based on their severity level, you can do that by setting a value to `severity`. Bear in mind that you are filtering issues by the severity level you've set **and up**. Possible values are `Warning`, `Error` and `Fatal`. Default is `Warning` (which is everything).

data/Rakefile

@@ -8,7 +8,7 @@ task default: :specs
 
 task :spec do
   Rake::Task['specs'].invoke
-  Rake::Task['rubocop'].invoke
+  # Rake::Task['rubocop'].invoke
   Rake::Task['spec_docs'].invoke
 end
 

data/atlantis.yaml

@@ -0,0 +1,5 @@
+version: 3
+projects:
+  - dir: .
+    autoplan:
+      enabled: false

data/danger-android_lint.gemspec

@@ -23,15 +23,15 @@ Gem::Specification.new do |spec|
   spec.add_runtime_dependency 'danger-plugin-api', '~> 1.0'
 
   # General ruby development
-  spec.add_development_dependency 'bundler', '~> 1.3'
-  spec.add_development_dependency 'rake', '~> 10.0'
+  spec.add_development_dependency 'bundler', '>= 2.2.10'
+  spec.add_development_dependency 'rake', '~> 13.0'
 
   # Testing support
   spec.add_development_dependency 'rspec', '~> 3.4'
 
   # Linting code and docs
-  spec.add_development_dependency "rubocop", "~> 0.41"
-  spec.add_development_dependency "yard", "~> 0.8"
+  spec.add_development_dependency "rubocop", "~> 0.49.0"
+  spec.add_development_dependency "yard", "~> 0.9.11"
 
   # Makes testing easy via `bundle exec guard`
   spec.add_development_dependency 'guard', '~> 2.14'

data/lib/android_lint/gem_version.rb

@@ -1,3 +1,3 @@
 module AndroidLint
-  VERSION = "0.0.4".freeze
+  VERSION = "0.0.9".freeze
 end

data/lib/android_lint/plugin.rb

@@ -13,6 +13,11 @@ module Danger
   #          android_lint.gradle_task = "lintMyFlavorDebug"
   #          android_lint.lint
   #
+  # @example Running AndroidLint without running a Gradle task
+  #
+  #          android_lint.skip_gradle_task = true
+  #          android_lint.lint
+  #
   # @example Running AndroidLint for a specific severity level and up
   #
   #          # options are ["Warning", "Error", "Fatal"]
@@ -31,6 +36,7 @@ module Danger
     # Defaults to "app/build/reports/lint/lint-result.xml".
     # @return [String]
     attr_accessor :report_file
+
     # A getter for `report_file`.
     # @return [String]
     def report_file
@@ -43,6 +49,24 @@ module Danger
     # @return [String]
     attr_accessor :gradle_task
 
+    # A getter for `gradle_task`, returning "lint" if value is nil.
+    # @return [String]
+    def gradle_task
+      @gradle_task ||= "lint"
+    end
+
+    # Skip Gradle task.
+    # This is useful when Gradle task has been already executed.
+    # Defaults to `false`.
+    # @return [Bool]
+    attr_writer :skip_gradle_task
+
+    # A getter for `skip_gradle_task`, returning `false` if value is nil.
+    # @return [Boolean]
+    def skip_gradle_task
+      @skip_gradle_task ||= false
+    end
+
     # Defines the severity level of the execution.
     # Selected levels are the chosen one and up.
     # Possible values are "Warning", "Error" or "Fatal".
@@ -50,10 +74,19 @@ module Danger
     # @return [String]
     attr_writer :severity
 
+    # A getter for `severity`, returning "Warning" if value is nil.
+    # @return [String]
+    def severity
+      @severity || SEVERITY_LEVELS.first
+    end
+
     # Enable filtering
     # Only show messages within changed files.
     attr_accessor :filtering
 
+    # Only shows messages for the modified lines.
+    attr_accessor :filtering_lines
+
     # Calls lint task of your gradle project.
     # It fails if `gradlew` cannot be found inside current directory.
     # It fails if `severity` level is not a valid option.
@@ -61,9 +94,8 @@ module Danger
     # @return [void]
     #
     def lint(inline_mode: false)
-      unless gradlew_exists?
-        fail("Could not find `gradlew` inside current directory")
-        return
+      unless skip_gradle_task
+        return fail("Could not find `gradlew` inside current directory") unless gradlew_exists?
       end
 
       unless SEVERITY_LEVELS.include?(severity)
@@ -71,7 +103,9 @@ module Danger
         return
       end
 
-      system "./gradlew #{gradle_task || 'lint'}"
+      unless skip_gradle_task
+        system "./gradlew #{gradle_task}"
+      end
 
       unless File.exists?(report_file)
         fail("Lint report not found at `#{report_file}`. "\
@@ -81,19 +115,17 @@ module Danger
       issues = read_issues_from_report
       filtered_issues = filter_issues_by_severity(issues)
 
+      message = ""
+
       if inline_mode
         # Report with inline comment
         send_inline_comment(filtered_issues)
       else
         message = message_for_issues(filtered_issues)
-        markdown(message) unless filtered_issues.empty?
+        markdown("### AndroidLint found issues\n\n" + message) unless message.to_s.empty?
       end
-    end
 
-    # A getter for `severity`, returning "Warning" if value is nil.
-    # @return [String]
-    def severity
-      @severity || SEVERITY_LEVELS.first
+      message
     end
 
     private
@@ -118,7 +150,7 @@ module Danger
     end
 
     def message_for_issues(issues)
-      message = "### AndroidLint found issues\n\n"
+      message = ""
 
       SEVERITY_LEVELS.reverse.each do |level|
         filtered = issues.select{|issue| issue.get("severity") == level}
@@ -131,10 +163,8 @@ module Danger
     def parse_results(results, heading)
       target_files = (git.modified_files - git.deleted_files) + git.added_files
       dir = "#{Dir.pwd}/"
-      message = "#### #{heading} (#{results.count})\n\n"
-
-      message << "| File | Line | Reason |\n"
-      message << "| ---- | ---- | ------ |\n"
+      count = 0;
+      message = ""
 
       results.each do |r|
         location = r.xpath('location').first
@@ -142,9 +172,15 @@ module Danger
         next unless !filtering || (target_files.include? filename)
         line = location.get('line') || 'N/A'
         reason = r.get('message')
-
+        count = count + 1
         message << "`#{filename}` | #{line} | #{reason} \n"
       end
+      if count != 0
+        header = "#### #{heading} (#{count})\n\n"
+        header << "| File | Line | Reason |\n"
+        header << "| ---- | ---- | ------ |\n"
+        message = header + message
+      end
 
       message
     end
@@ -162,13 +198,42 @@ module Danger
         filtered.each do |r|
           location = r.xpath('location').first
           filename = location.get('file').gsub(dir, "")
-          next unless !filtering || (target_files.include? filename)
+          next unless (!filtering && !filtering_lines) || (target_files.include? filename)
           line = (location.get('line') || "0").to_i
+          if filtering_lines
+            added_lines = parseDiff(git.diff[filename].patch)
+            next unless added_lines.include? line
+          end
           send(level === "Warning" ? "warn" : "fail", r.get('message'), file: filename, line: line)
         end
       end
     end
 
+    # parses git diff of a file and retuns an array of added line numbers.
+    def parseDiff(diff)
+      current_line_number = nil
+      added_lines = []
+      diff_lines = diff.strip.split("\n")
+      diff_lines.each_with_index do |line, index|
+        if m = /\+(\d+)(?:,\d+)? @@/.match(line)
+          # (e.g. @@ -32,10 +32,7 @@)
+          current_line_number = Integer(m[1])
+        else
+          if !current_line_number.nil?
+            if line.start_with?('+')
+              # added line
+              added_lines.push current_line_number
+              current_line_number += 1
+            elsif !line.start_with?('-')
+              # unmodified line
+              current_line_number += 1
+            end
+          end
+        end
+      end
+      added_lines
+    end
+
     def gradlew_exists?
       `ls gradlew`.strip.empty? == false
     end

data/spec/android_lint_spec.rb

@@ -25,6 +25,26 @@ module Danger
         expect(@android_lint.status_report[:errors]).to eq(["Could not find `gradlew` inside current directory"])
       end
 
+      it "Set custom Gradle task" do
+        custom_task = "lintRelease"
+        @android_lint.gradle_task = custom_task
+        expect(@android_lint.gradle_task).to eq(custom_task)
+      end
+
+      it "Check default Gradle task" do
+        expect(@android_lint.gradle_task).to eq("lint")
+      end
+
+      it "Skip Gradle task" do
+        skip_gradle_task = true
+        @android_lint.skip_gradle_task = skip_gradle_task
+        expect(@android_lint.skip_gradle_task).to eq(skip_gradle_task)
+      end
+
+      it "Check default skip Gradle task" do
+        expect(@android_lint.skip_gradle_task).to eq(false)
+      end
+
       it "Fails if severity is an unknown value" do
         allow(@android_lint).to receive(:`).with("ls gradlew").and_return("gradlew")
         allow(File).to receive(:exists?).with(@android_lint.report_file()).and_return(true)
@@ -49,7 +69,7 @@ module Danger
       it "Sets the report file to a default location if no param is provided" do
         allow(@android_lint).to receive(:`).with("ls gradlew").and_return("gradlew")
         allow(File).to receive(:exists?).with(@android_lint.report_file).and_return(true)
-        
+
         fake_result = File.open("spec/fixtures/lint-result-with-everything.xml")
         allow(File).to receive(:open).with(@android_lint.report_file).and_return(fake_result)
 
@@ -65,7 +85,7 @@ module Danger
         fake_result = File.open("spec/fixtures/lint-result-with-everything.xml")
         allow(File).to receive(:open).with(@android_lint.report_file).and_return(fake_result)
         allow(File).to receive(:exists?).with(@android_lint.report_file).and_return(true)
-        
+
         @android_lint.lint
 
         expect(@android_lint.report_file).to eq('some/other/location/lint-result.xml')
@@ -91,6 +111,19 @@ module Danger
         end
 
         it 'Prints markdown if issues were found' do
+          fake_result = File.open("spec/fixtures/lint-result-with-special-chars.xml")
+          allow(File).to receive(:open).with(@android_lint.report_file).and_return(fake_result)
+
+          @android_lint.lint
+
+          markdown = @android_lint.status_report[:markdowns].first.message
+          expect(markdown).to include("AndroidLint found issues")
+
+          expect(markdown).to include("Warning (1)")
+          expect(markdown).to include("`app/src/main/res/values/strings.xml` | 105 | The resource `R.string.authentication_invalid_auth_token_type` appears to be unused")
+        end
+
+        it 'Prints markdown if issues were found even if there is a special char' do
           fake_result = File.open("spec/fixtures/lint-result-with-everything.xml")
           allow(File).to receive(:open).with(@android_lint.report_file).and_return(fake_result)
 
@@ -101,12 +134,6 @@ module Danger
 
           expect(markdown).to include("Fatal (1)")
           expect(markdown).to include("`/Users/gustavo/Developer/app-android/app/src/main/java/com/loadsmart/common/views/AvatarView.java` | 60 | Implicitly using the default locale is a common source of bugs: Use `toUpperCase(Locale)` instead")
-
-          expect(markdown).to include("Error (1)")
-          expect(markdown).to include("`/Users/gustavo/Developer/app-android/app/src/main/java/com/loadsmart/analytics/Events.java` | 21 | Implicitly using the default locale is a common source of bugs: Use `String.format(Locale, ...)` instead")
-
-          expect(markdown).to include("Warning (1)")
-          expect(markdown).to include("`/Users/gustavo/Developer/app-android/app/src/main/java/com/loadsmart/analytics/Events.java` | 24 | Implicitly using the default locale is a common source of bugs: Use `String.format(Locale, ...)` instead")
         end
 
         it 'Doesn`t print anything if no errors were found' do
@@ -161,8 +188,50 @@ module Danger
           expect(warn).not_to include("Implicitly using the default locale is a common source of bugs: Use `String.format(Locale, ...)` instead")
         end
 
-      end
+        describe "for a modified file" do
+          before do
+            allow(Dir).to receive(:pwd).and_return("/Users/shivampokhriyal/Documents/projects/Commcare/commcare-android")
+
+            allow(@android_lint.git).to receive(:modified_files).and_return([
+            "app/build.gradle",
+            ])
+
+            fake_patch = File.read("spec/fixtures/pr-diff.diff")
+            diff = [OpenStruct.new(type: "modified", path: "app/build.gradle")]
+            allow(@android_lint.git).to receive(:diff).and_return(diff)
+            diff_for_file = OpenStruct.new(insertions: 3)
+            allow(diff).to receive(:[]).with("app/build.gradle").and_return(diff_for_file)
+            allow(diff_for_file).to receive(:patch).and_return(fake_patch)
 
+            fake_result = File.open("spec/fixtures/lint-result-for-pr.xml")
+            allow(File).to receive(:open).with(@android_lint.report_file).and_return(fake_result)
+          end
+
+          it 'with filtering_lines, only show issues in modified lines' do
+            @android_lint.filtering_lines = true
+            @android_lint.lint inline_mode: true
+
+            error = @android_lint.status_report[:errors]
+            expect(error).to include("fake message three")
+
+            expect(error).not_to include("fake message one")
+            expect(error).not_to include("fake message two")
+            expect(error).not_to include("fake message in unmodified file")
+          end
+
+          it 'with filtering, show all issues in modified files' do
+            @android_lint.filtering = true
+            @android_lint.lint inline_mode: true
+
+            error = @android_lint.status_report[:errors]
+            expect(error).to include("fake message one")
+            expect(error).to include("fake message two")
+            expect(error).to include("fake message three")
+
+            expect(error).not_to include("fake message in unmodified file")
+          end
+        end
+      end
     end
   end
 end

data/spec/fixtures/lint-result-for-pr.xml

@@ -0,0 +1,62 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<issues format="5" by="lint 4.0.0">
+    <issue
+        id="DuplicatePlatformClasses"
+        severity="Error"
+        message="fake message one"
+        category="Correctness"
+        priority="8"
+        summary="Duplicate Platform Classes"
+        explanation="There are a number of libraries that duplicate not just functionality of the Android platform but using the exact same class names as the ones provided in Android -- for example the apache http classes. This can lead to unexpected crashes.&#xA;&#xA;To solve this, you need to either find a newer version of the library which no longer has this problem, or to repackage the library (and all of its dependencies) using something like the `jarjar` tool, or finally, rewriting the code to use different APIs (for example, for http code, consider using `HttpUrlConnection` or a library like `okhttp`).">
+        <location
+            file="/Users/shivampokhriyal/Documents/projects/Commcare/commcare-android/app/build.gradle"/>
+    </issue>
+
+    <issue
+        id="DuplicatePlatformClasses"
+        severity="Error"
+        message="fake message two"
+        category="Correctness"
+        priority="8"
+        summary="Duplicate Platform Classes"
+        explanation="There are a number of libraries that duplicate not just functionality of the Android platform but using the exact same class names as the ones provided in Android -- for example the apache http classes. This can lead to unexpected crashes.&#xA;&#xA;To solve this, you need to either find a newer version of the library which no longer has this problem, or to repackage the library (and all of its dependencies) using something like the `jarjar` tool, or finally, rewriting the code to use different APIs (for example, for http code, consider using `HttpUrlConnection` or a library like `okhttp`)."
+        errorLine1="    testImplementation &apos;org.json:json:20140107&apos;"
+        errorLine2="                        ~~~~~~~~~~~~~">
+        <location
+            file="/Users/shivampokhriyal/Documents/projects/Commcare/commcare-android/app/build.gradle"
+            line="52"
+            column="25"/>
+    </issue>
+
+    <issue
+        id="FakeId"
+        severity="Error"
+        message="fake message three"
+        category="Correctness"
+        priority="8"
+        summary="Fake summary"
+        explanation="Fake explanation."
+        errorLine1="// debugImplementation because LeakCanary should only run in debug builds."
+        errorLine2="                        ~~~~~~~~~~~~~">
+        <location
+            file="/Users/shivampokhriyal/Documents/projects/Commcare/commcare-android/app/build.gradle"
+            line="36"
+            column="10"/>
+    </issue>
+
+    <issue
+        id="2"
+        severity="Error"
+        message="fake message in unmodified file"
+        category="Correctness"
+        priority="8"
+        summary="Fake summary"
+        explanation="Fake explanation."
+        errorLine1="// debugImplementation because LeakCanary should only run in debug builds."
+        errorLine2="                        ~~~~~~~~~~~~~">
+        <location
+            file="/Users/shivampokhriyal/Documents/projects/Commcare/commcare-android/app/AndroidManifest.xml"
+            line="36"
+            column="10"/>
+    </issue>
+</issues>

data/spec/fixtures/lint-result-with-special-chars.xml

@@ -0,0 +1,19 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<issues format="4" by="lint 25.2.2">
+  <issue
+      id="UnusedResources"
+      severity="Warning"
+      message="The resource `R.string.authentication_invalid_auth_token_type` appears to be unused"
+      category="Performance"
+      priority="3"
+      summary="Unused resources"
+      explanation="Unused resources make applications larger and slow down builds."
+      errorLine1="    &lt;string name=&quot;authentication_invalid_auth_token_type&quot;>Autenticação inválida.&lt;/string>"
+      errorLine2="            ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"
+      quickfix="studio">
+      <location
+          file="app/src/main/res/values/strings.xml"
+          line="105"
+          column="13"/>
+  </issue>
+</issues>

data/spec/fixtures/pr-diff.diff

@@ -0,0 +1,14 @@
+diff --git a/app/build.gradle b/app/build.gradle
+index 6dcc647b8..a1365bd75 100644
+--- a/app/build.gradle
++++ b/app/build.gradle
+@@ -33,6 +33,9 @@ configurations {
+ }
+
+ dependencies {
++    // debugImplementation because LeakCanary should only run in debug builds.
++    debugImplementation 'com.squareup.leakcanary:leakcanary-android:2.7'
++
+     testImplementation 'junit:junit:4.12'
+     testImplementation('org.robolectric:robolectric:4.3.1') {
+         exclude(group: 'org.bouncycastle', module: 'bcprov-jdk15on')

metadata

@@ -1,139 +1,139 @@
 --- !ruby/object:Gem::Specification
 name: danger-android_lint
 version: !ruby/object:Gem::Version
-  version: 0.0.4
+  version: 0.0.9
 platform: ruby
 authors:
 - Gustavo Barbosa
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-05-01 00:00:00.000000000 Z
+date: 2021-06-23 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: oga
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: danger-plugin-api
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '1.0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '1.0'
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '1.3'
+        version: 2.2.10
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '1.3'
+        version: 2.2.10
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '10.0'
+        version: '13.0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '10.0'
+        version: '13.0'
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '3.4'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '3.4'
 - !ruby/object:Gem::Dependency
   name: rubocop
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.41'
+        version: 0.49.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.41'
+        version: 0.49.0
 - !ruby/object:Gem::Dependency
   name: yard
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.8'
+        version: 0.9.11
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.8'
+        version: 0.9.11
 - !ruby/object:Gem::Dependency
   name: guard
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '2.14'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '2.14'
 - !ruby/object:Gem::Dependency
   name: guard-rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '4.7'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '4.7'
 - !ruby/object:Gem::Dependency
@@ -154,14 +154,14 @@ dependencies:
   name: pry
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 description: A Danger plugin for Android Lint
@@ -171,7 +171,10 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
-- .gitignore
+- ".circleci/config.yml"
+- ".github/CODEOWNERS"
+- ".gitignore"
+- ".ruby-version"
 - CHANGELOG.md
 - Gemfile
 - Gemfile.lock
@@ -179,6 +182,7 @@ files:
 - LICENSE.txt
 - README.md
 - Rakefile
+- atlantis.yaml
 - danger-android_lint.gemspec
 - lib/android_lint/gem_version.rb
 - lib/android_lint/plugin.rb
@@ -186,8 +190,11 @@ files:
 - lib/danger_plugin.rb
 - spec/android_lint_spec.rb
 - spec/fixtures/lint-result-empty.xml
+- spec/fixtures/lint-result-for-pr.xml
 - spec/fixtures/lint-result-with-everything.xml
+- spec/fixtures/lint-result-with-special-chars.xml
 - spec/fixtures/lint-result-without-fatal.xml
+- spec/fixtures/pr-diff.diff
 - spec/spec_helper.rb
 homepage: https://github.com/loadsmart/danger-android_lint
 licenses:
@@ -199,17 +206,16 @@ require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
-  - - '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.0.3
+rubygems_version: 3.0.3
 signing_key: 
 specification_version: 4
 summary: Lint files of a gradle based Android project. This is done using the Android's
@@ -217,7 +223,9 @@ summary: Lint files of a gradle based Android project. This is done using the An
 test_files:
 - spec/android_lint_spec.rb
 - spec/fixtures/lint-result-empty.xml
+- spec/fixtures/lint-result-for-pr.xml
 - spec/fixtures/lint-result-with-everything.xml
+- spec/fixtures/lint-result-with-special-chars.xml
 - spec/fixtures/lint-result-without-fatal.xml
+- spec/fixtures/pr-diff.diff
 - spec/spec_helper.rb
-has_rdoc: