danger-android_lint 0.0.10 → 0.0.12

checksums.yaml

@@ -1,4 +1,7 @@
 ---
+SHA256:
+  metadata.gz: 1ef6802abdd658676a4f468420f61b6b8cb5f159308b5956d10669eb24a064af
+  data.tar.gz: 3e832d957ecd0a5340c47c5bf1a8aaaad48b487854eb5362d67dd3824d237d72
 SHA512:
-  metadata.gz: ee6bc1e76ca2a7d11670cf1d0d50438a05aa62e93c6d81b289b48e4b2c2709181a234d6f6664439dc1aa531e5b1467722aa71752934662495cf992188227381c
-  data.tar.gz: 0f0e99183aea7bbbda95cddeb56c29d9f939d948f627e8da60b2bf2711dd0d8a794d7349c534cf9c5fa3d6e940abbc7c1ef38e6c599792f4ee8ee5b2689b2643
+  metadata.gz: ea599c3805e6433fff6bea20f13dc8fc2019af37f3f9b9755715c5e17b3794a60ecff1b255858fe5e5d8ca5c33979ee32bbbf22f30559d671eace731556a42a0
+  data.tar.gz: 23c41cf0cbd6f266d6f3ae1b34aace297994858cc8498a6ffcd35a1a09b79e8bb363558f84938c92aca3fcf40cab7d9f3b846b8488000b4a6fb6327408735b63

data/.circleci/config.yml

@@ -1,13 +1,13 @@
 version: 2.1
 orbs:
-  ruby: circleci/ruby@1.0
+  ruby: circleci/ruby@2.0
 
 jobs:
   build:
     docker:
-      - image: circleci/ruby:2.7
+      - image: cimg/ruby:3.2.0
     steps:
       - checkout
-      - run: gem install bundler:2.2.10
+      - run: gem install bundler:2.4.3
       - run: bundle install
       - run: bundle exec rake spec

data/.github/CODEOWNERS

@@ -1 +1 @@
-*	@barbosa
+*	@loadsmart/mobile

data/.ruby-version

@@ -1 +1 @@
-3.0.2
+3.2.0

data/CHANGELOG.md

@@ -1,3 +1,11 @@
+# 0.0.12
+
+- Support ruby 3.2.0, fix undefined method exists? for File:Class (#38) ([@irgaly](https://github.com/irgaly))
+
+# 0.0.11
+
+- Add `excluding_issue_ids` parameter to skip showing issues with the given IDs, e.g. "MissingTranslation" ([@petitJAM](https://github.com/petitJAM))
+
 # 0.0.10
 
 - Fix `filtering_lines` parameter to also apply to when `inline_mode` is `false` ([@petitJAM](https://github.com/petitJAM))

data/Gemfile.lock

@@ -1,18 +1,18 @@
 PATH
   remote: .
   specs:
-    danger-android_lint (0.0.9)
+    danger-android_lint (0.0.12)
       danger-plugin-api (~> 1.0)
       oga
 
 GEM
   remote: https://rubygems.org/
   specs:
-    addressable (2.7.0)
+    addressable (2.8.0)
       public_suffix (>= 2.0.2, < 5.0)
     ansi (1.5.0)
     ast (2.4.2)
-    claide (1.0.3)
+    claide (1.1.0)
     claide-plugins (0.9.2)
       cork
       nap
@@ -21,7 +21,7 @@ GEM
     colored2 (3.1.2)
     cork (0.3.0)
       colored2 (~> 3.1)
-    danger (8.2.3)
+    danger (8.5.0)
       claide (~> 1.0)
       claide-plugins (>= 0.9.2)
       colored2 (~> 3.1)
@@ -37,24 +37,34 @@ GEM
     danger-plugin-api (1.0.0)
       danger (> 2.0)
     diff-lcs (1.4.4)
-    faraday (1.4.2)
+    faraday (1.10.0)
       faraday-em_http (~> 1.0)
       faraday-em_synchrony (~> 1.0)
       faraday-excon (~> 1.1)
+      faraday-httpclient (~> 1.0)
+      faraday-multipart (~> 1.0)
       faraday-net_http (~> 1.0)
-      faraday-net_http_persistent (~> 1.1)
-      multipart-post (>= 1.2, < 3)
+      faraday-net_http_persistent (~> 1.0)
+      faraday-patron (~> 1.0)
+      faraday-rack (~> 1.0)
+      faraday-retry (~> 1.0)
       ruby2_keywords (>= 0.0.4)
     faraday-em_http (1.0.0)
     faraday-em_synchrony (1.0.0)
     faraday-excon (1.1.0)
     faraday-http-cache (2.2.0)
       faraday (>= 0.8)
+    faraday-httpclient (1.0.1)
+    faraday-multipart (1.0.3)
+      multipart-post (>= 1.2, < 3)
     faraday-net_http (1.0.1)
-    faraday-net_http_persistent (1.1.0)
+    faraday-net_http_persistent (1.2.0)
+    faraday-patron (1.0.0)
+    faraday-rack (1.0.0)
+    faraday-retry (1.0.3)
     ffi (1.15.3)
     formatador (0.3.0)
-    git (1.8.1)
+    git (1.10.2)
       rchardet (~> 1.8)
     guard (2.17.0)
       formatador (>= 0.2.4)
@@ -70,7 +80,7 @@ GEM
       guard (~> 2.1)
       guard-compat (~> 1.1)
       rspec (>= 2.99.0, < 4.0)
-    kramdown (2.3.1)
+    kramdown (2.3.2)
       rexml
     kramdown-parser-gfm (1.1.0)
       kramdown (~> 2.0)
@@ -86,7 +96,7 @@ GEM
     notiffany (0.1.3)
       nenv (~> 0.1)
       shellany (~> 0.0)
-    octokit (4.21.0)
+    octokit (4.22.0)
       faraday (>= 0.9)
       sawyer (~> 0.8.0, >= 0.5.3)
     oga (3.3)
@@ -133,19 +143,21 @@ GEM
       ansi
       ast
     ruby-progressbar (1.11.0)
-    ruby2_keywords (0.0.4)
+    ruby2_keywords (0.0.5)
     sawyer (0.8.2)
       addressable (>= 2.3.5)
       faraday (> 0.8, < 2.0)
     shellany (0.0.1)
-    terminal-table (3.0.1)
+    terminal-table (3.0.2)
       unicode-display_width (>= 1.1.1, < 3)
     thor (1.1.0)
     unicode-display_width (1.7.0)
     yard (0.9.26)
 
 PLATFORMS
+  arm64-darwin-21
   universal-darwin-20
+  x86_64-darwin-22
   x86_64-linux
 
 DEPENDENCIES
@@ -161,4 +173,4 @@ DEPENDENCIES
   yard (~> 0.9.11)
 
 BUNDLED WITH
-   2.2.10
+   2.4.3

data/README.md

@@ -92,6 +92,17 @@ android_lint.filtering_lines = true
 android_lint.lint
 ```
 
+#### Filter issues by ID
+
+In some cases you may want to conditionally ignore specific lint warnings without fully disabling
+them in your `lintOptions` configuration. To do that, you can pass a list of IDs to the
+`excluding_issue_ids` parameter.
+
+```rb
+android_lint.excluding_issue_ids = ["MissingTranslation"]
+android_lint.lint
+```
+
 #### Make Danger comment directly on the line instead of printing a Markdown table (GitHub only)
 
 ```rb

data/catalog-info.yaml

@@ -0,0 +1,14 @@
+apiVersion: backstage.io/v1alpha1
+kind: Component
+metadata:
+  name: danger-android_lint
+  description: A Danger plugin for Android Lint
+  annotations:
+    github.com/project-slug: loadsmart/danger-android_lint
+    opslevel.com/tier: tier_3
+  tags:
+    - ruby
+spec:
+  type: other
+  lifecycle: production
+  owner: mobile

data/lib/android_lint/gem_version.rb

@@ -1,3 +1,3 @@
 module AndroidLint
-  VERSION = "0.0.10".freeze
+  VERSION = "0.0.12".freeze
 end

data/lib/android_lint/plugin.rb

@@ -84,9 +84,12 @@ module Danger
     # Only show messages within changed files.
     attr_accessor :filtering
 
-    # Only shows messages for the modified lines.
+    # Only show messages for the modified lines.
     attr_accessor :filtering_lines
 
+    # Only show messages for issues not in this list.
+    attr_accessor :excluding_issue_ids
+
     # Calls lint task of your gradle project.
     # It fails if `gradlew` cannot be found inside current directory.
     # It fails if `severity` level is not a valid option.
@@ -107,7 +110,7 @@ module Danger
         system "./gradlew #{gradle_task}"
       end
 
-      unless File.exists?(report_file)
+      unless File.exist?(report_file)
         fail("Lint report not found at `#{report_file}`. "\
           "Have you forgot to add `xmlReport true` to your `build.gradle` file?")
       end
@@ -167,6 +170,8 @@ module Danger
       message = ""
 
       results.each do |r|
+        issue_id = r.get('id')
+        next if excluding_issue_ids && excluding_issue_ids.include?(issue_id)
         location = r.xpath('location').first
         filename = location.get('file').gsub(dir, "")
         next unless (!filtering && !filtering_lines) || (target_files.include? filename)

data/spec/android_lint_spec.rb

@@ -47,7 +47,7 @@ module Danger
 
       it "Fails if severity is an unknown value" do
         allow(@android_lint).to receive(:`).with("ls gradlew").and_return("gradlew")
-        allow(File).to receive(:exists?).with(@android_lint.report_file()).and_return(true)
+        allow(File).to receive(:exist?).with(@android_lint.report_file()).and_return(true)
 
         @android_lint.severity = "Dummy"
         @android_lint.lint
@@ -57,7 +57,7 @@ module Danger
 
       it "Sets severity to 'Warning' if no severity param is provided" do
         allow(@android_lint).to receive(:`).with("ls gradlew").and_return("gradlew")
-        allow(File).to receive(:exists?).with(@android_lint.report_file).and_return(true)
+        allow(File).to receive(:exist?).with(@android_lint.report_file).and_return(true)
 
         fake_result = File.open("spec/fixtures/lint-result-with-everything.xml")
         allow(File).to receive(:open).with(@android_lint.report_file).and_return(fake_result)
@@ -68,7 +68,7 @@ module Danger
 
       it "Sets the report file to a default location if no param is provided" do
         allow(@android_lint).to receive(:`).with("ls gradlew").and_return("gradlew")
-        allow(File).to receive(:exists?).with(@android_lint.report_file).and_return(true)
+        allow(File).to receive(:exist?).with(@android_lint.report_file).and_return(true)
 
         fake_result = File.open("spec/fixtures/lint-result-with-everything.xml")
         allow(File).to receive(:open).with(@android_lint.report_file).and_return(fake_result)
@@ -84,7 +84,7 @@ module Danger
 
         fake_result = File.open("spec/fixtures/lint-result-with-everything.xml")
         allow(File).to receive(:open).with(@android_lint.report_file).and_return(fake_result)
-        allow(File).to receive(:exists?).with(@android_lint.report_file).and_return(true)
+        allow(File).to receive(:exist?).with(@android_lint.report_file).and_return(true)
 
         @android_lint.lint
 
@@ -93,7 +93,7 @@ module Danger
 
       it "Fails if report file does not exist" do
         allow(@android_lint).to receive(:`).with("ls gradlew").and_return("gradlew")
-        allow(File).to receive(:exists?).with(@android_lint.report_file).and_return(false)
+        allow(File).to receive(:exist?).with(@android_lint.report_file).and_return(false)
 
         fake_result = File.open("spec/fixtures/lint-result-with-everything.xml")
         allow(File).to receive(:open).with(@android_lint.report_file).and_return(fake_result)
@@ -107,7 +107,7 @@ module Danger
       describe 'lint' do
         before do
           allow(@android_lint).to receive(:`).with("ls gradlew").and_return("gradlew")
-          allow(File).to receive(:exists?).with(@android_lint.report_file).and_return(false)
+          allow(File).to receive(:exist?).with(@android_lint.report_file).and_return(false)
         end
 
         it 'Prints markdown if issues were found' do
@@ -146,7 +146,7 @@ module Danger
           expect(markdown).to be_nil
         end
 
-        it 'Doesn`t print anything if no errors were found' do
+        it 'Doesn`t print anything if no errors were found at the set minimum severity level' do
           fake_result = File.open("spec/fixtures/lint-result-without-fatal.xml")
           allow(File).to receive(:open).with(@android_lint.report_file).and_return(fake_result)
 
@@ -188,6 +188,23 @@ module Danger
           expect(warn).not_to include("Implicitly using the default locale is a common source of bugs: Use `String.format(Locale, ...)` instead")
         end
 
+        describe 'excluding_issue_ids' do
+          before do
+            fake_result = File.open("spec/fixtures/lint-result-with-everything.xml")
+            allow(File).to receive(:open).with(@android_lint.report_file).and_return(fake_result)
+          end
+
+          it 'Does not print ignored issues' do
+            @android_lint.excluding_issue_ids = ["MissingTranslation", "RtlEnabled"]
+            @android_lint.lint
+
+            markdown = @android_lint.status_report[:markdowns].first.message
+            expect(markdown).to include("Implicitly using the default locale")
+            expect(markdown).not_to include("is not translated in")
+            expect(markdown).not_to include("The project references RTL attributes, but does not explicitly enable or disable RTL support with `android:supportsRtl` in the manifest")
+          end
+        end
+
         describe "for a modified file" do
           before do
             allow(Dir).to receive(:pwd).and_return("/Users/shivampokhriyal/Documents/projects/Commcare/commcare-android")

data/spec/fixtures/lint-result-with-everything.xml

@@ -61,4 +61,34 @@ If you want the methods to just perform ASCII replacement, for example to conver
             column="16"/>
     </issue>
 
+    <issue
+        id="MissingTranslation"
+        severity="Error"
+        message="&quot;someStringResource&quot; is not translated in &quot;de&quot; (German), &quot;fi&quot; (Finnish), &quot;ru&quot; (Russian), &quot;sv&quot; (Swedish), &q
+        uot;ko&quot; (Korean), &quot;pt&quot; (Portuguese), &quot;el&quot; (Greek), &quot;en&quot; (English), &quot;it&quot; (Italian), &quot;fr&quot; (French), &quot;es&quot; (Spanish), &quot;cs&q
+        uot; (Czech), &quot;nb&quot; (Norwegian Bokmål), &quot;ja&quot; (Japanese), &quot;da&quot; (Danish), &quot;ca&quot; (Catalan), &quot;nl&quot; (Dutch)"
+        category="Correctness:Messages"
+        priority="8"
+        summary="Incomplete translation"
+        explanation="If an application has more than one locale, then all the strings declared in one language should also be translated in all other languages.&#xA;&#xA;If the string should **not** be translated, you can add the attribute `translatable=&quot;false&quot;` on the `&lt;string>` element, or you can define all your non-translatable strings in a resource file called `donottranslate.xml`. Or, you can ignore the issue with a `tools:ignore=&quot;MissingTranslation&quot;` attribute.&#xA;&#xA;You can tell lint (and other tools) which language is the default language in your `res/values/` folder by specifying `tools:locale=&quot;languageCode&quot;` for the root `&lt;resources>` element in your resource file. (The `tools` prefix refers to the namespace declaration `http://schemas.android.com/tools`.)"
+        errorLine1="    &lt;string name=&quot;someStringResource&quot;>Hello this is a string resource.&lt;/string>"
+        errorLine2="            ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
+        <location
+            file="/Users/gustavo/Developer/app-android/app/src/main/res/values/strings.xml"
+            line="10"
+            column="13"/>
+    </issue>
+
+    <issue
+        id="RtlEnabled"
+        severity="Warning"
+        message="The project references RTL attributes, but does not explicitly enable or disable RTL support with `android:supportsRtl` in the manifest"
+        category="Internationalization:Bidirectional Text"
+        priority="3"
+        summary="Using RTL attributes without enabling RTL support"
+        explanation="To enable right-to-left support, when running on API 17 and higher, you must set the `android:supportsRtl` attribute in the manifest `&lt;application>` element.&#xA;&#xA;If you have started adding RTL attributes, but have not yet finished the migration, you can set the attribute to false to satisfy this lint check.">
+        <location
+            file="/Users/gustavo/Developer/app-android/app/src/main/AndroidManifest.xml"/>
+    </issue>
+
 </issues>

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: danger-android_lint
 version: !ruby/object:Gem::Version
-  version: 0.0.10
+  version: 0.0.12
 platform: ruby
 authors:
 - Gustavo Barbosa
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2022-04-22 00:00:00.000000000 Z
+date: 2023-04-21 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: oga
@@ -183,6 +183,7 @@ files:
 - README.md
 - Rakefile
 - atlantis.yaml
+- catalog-info.yaml
 - danger-android_lint.gemspec
 - lib/android_lint/gem_version.rb
 - lib/android_lint/plugin.rb
@@ -215,7 +216,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.0.9
+rubygems_version: 3.4.1
 signing_key:
 specification_version: 4
 summary: Lint files of a gradle based Android project. This is done using the Android's