danger-android_lint 0.0.1 → 0.0.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: f282c21919c8285f09b44d4466a690e9d3208db8
-  data.tar.gz: ea242b17a6681032b7f611894ec0e548044eb24a
+  metadata.gz: 6032c641b6bfe75156ded93357b0108d7f52cd37
+  data.tar.gz: 4e3a4911b701879fa141df99552cbaed3dee7da7
 SHA512:
-  metadata.gz: da1f099f47ecdd976e212c1469b2bcc628e8d9051fcf69fb2f8c7809e0f4f207fad13bb9075f4ce598c459ef4653fbf6c41d70296970d6519d3b0cd5d0a5b7bb
-  data.tar.gz: 854b76159b3d53544d08f0f34f2574ee8351a709979c85dd8e08fd127b70a85bb716655d594e7dbb5360c8922be296527aa9fe4e12f46bded97941ae76f5be7f
+  metadata.gz: 30cdfffe72726c2ae90796f052cd330cf31dc4d336c5d57e59bf38ef57f5e22375faaf81704180c5f3d5399b54a899713d8575a29771aeeb754a65602baac75f
+  data.tar.gz: ae790c26a696b6331ae9e19f5c0000c2a572888d6a3f29931153b98ac6e844b32b2b0c281739c749a9546b16264df4cae680ed759e84e7dbbb4e1bfb03412b5c

data/.gitignore

@@ -1,4 +1,6 @@
+*.orig
 .DS_Store
 pkg
 .idea/
 .yardoc/
+*.gem

data/CHANGELOG.md

@@ -1,2 +1,6 @@
-## 1.0.0
+## 0.0.2
+- Fix check for inexistent report file
+- Fix markdown message being printed without any issues reported
+
+## 0.0.1
 - Initial version

data/lib/android_lint/gem_version.rb

@@ -1,3 +1,3 @@
 module AndroidLint
-  VERSION = "0.0.1".freeze
+  VERSION = "0.0.2".freeze
 end

data/lib/android_lint/plugin.rb

@@ -57,16 +57,18 @@ module Danger
         return
       end
 
+      system "./gradlew #{gradle_task || 'lint'}"
+
       unless File.exists?(REPORT_FILE)
         fail("Lint report not found at `#{REPORT_FILE}`. "\
           "Have you forgot to add `xmlReport true` to your `build.gradle` file?")
       end
 
-      system "./gradlew #{gradle_task || 'lint'}"
-
       issues = read_issues_from_report
-      message = message_for_issues(issues)
-      markdown(message) unless issues.empty?
+      filtered_issues = filter_issues_by_severity(issues)
+
+      message = message_for_issues(filtered_issues)
+      markdown(message) unless filtered_issues.empty?
     end
 
     # A getter for `severity`, returning "Warning" if value is nil.
@@ -77,7 +79,7 @@ module Danger
 
     private
 
-    def read_issues_from_report()
+    def read_issues_from_report
       file = File.open("app/build/reports/lint/lint-result.xml")
 
       require 'oga'
@@ -86,12 +88,20 @@ module Danger
       report.xpath('//issue')
     end
 
+    def filter_issues_by_severity(issues)
+      issues.select do |issue|
+        severity_index(issue.get("severity")) >= severity_index(severity)
+      end
+    end
+
+    def severity_index(severity)
+      SEVERITY_LEVELS.index(severity) || 0
+    end
+
     def message_for_issues(issues)
       message = "### AndroidLint found issues\n\n"
 
-      severity_index = SEVERITY_LEVELS.index(severity) || 0
-      levels = SEVERITY_LEVELS.slice(severity_index, SEVERITY_LEVELS.size)
-      levels.reverse.each do |level|
+      SEVERITY_LEVELS.reverse.each do |level|
         filtered = issues.select{|issue| issue.get("severity") == level}
         message << parse_results(filtered, level) unless filtered.empty?
       end

data/spec/android_lint_spec.rb

@@ -32,7 +32,7 @@ module Danger
         allow(@android_lint).to receive(:`).with("ls gradlew").and_return("gradlew")
         allow(File).to receive(:exists?).with(Danger::DangerAndroidLint::REPORT_FILE).and_return(true)
 
-        fake_result = File.open("spec/fixtures/lint-result.xml")
+        fake_result = File.open("spec/fixtures/lint-result-with-everything.xml")
         allow(File).to receive(:open).with(Danger::DangerAndroidLint::REPORT_FILE).and_return(fake_result)
 
         @android_lint.lint
@@ -43,7 +43,7 @@ module Danger
         allow(@android_lint).to receive(:`).with("ls gradlew").and_return("gradlew")
         allow(File).to receive(:exists?).with(Danger::DangerAndroidLint::REPORT_FILE).and_return(false)
 
-        fake_result = File.open("spec/fixtures/lint-result.xml")
+        fake_result = File.open("spec/fixtures/lint-result-with-everything.xml")
         allow(File).to receive(:open).with(Danger::DangerAndroidLint::REPORT_FILE).and_return(fake_result)
 
         @android_lint.lint
@@ -56,12 +56,12 @@ module Danger
         before do
           allow(@android_lint).to receive(:`).with("ls gradlew").and_return("gradlew")
           allow(File).to receive(:exists?).with(Danger::DangerAndroidLint::REPORT_FILE).and_return(false)
-
-          fake_result = File.open("spec/fixtures/lint-result.xml")
-          allow(File).to receive(:open).with(Danger::DangerAndroidLint::REPORT_FILE).and_return(fake_result)
         end
 
         it 'Prints markdown if issues were found' do
+          fake_result = File.open("spec/fixtures/lint-result-with-everything.xml")
+          allow(File).to receive(:open).with(Danger::DangerAndroidLint::REPORT_FILE).and_return(fake_result)
+
           @android_lint.lint
 
           markdown = @android_lint.status_report[:markdowns].first.message
@@ -77,6 +77,27 @@ module Danger
           expect(markdown).to include("`Events.java` | 24 | Implicitly using the default locale is a common source of bugs: Use `String.format(Locale, ...)` instead")
         end
 
+        it 'Doesn`t print anything if no errors were found' do
+          fake_result = File.open("spec/fixtures/lint-result-empty.xml")
+          allow(File).to receive(:open).with(Danger::DangerAndroidLint::REPORT_FILE).and_return(fake_result)
+
+          @android_lint.lint
+
+          markdown = @android_lint.status_report[:markdowns].first
+          expect(markdown).to be_nil
+        end
+
+        it 'Doesn`t print anything if no errors were found' do
+          fake_result = File.open("spec/fixtures/lint-result-without-fatal.xml")
+          allow(File).to receive(:open).with(Danger::DangerAndroidLint::REPORT_FILE).and_return(fake_result)
+
+          @android_lint.severity = "Fatal"
+          @android_lint.lint
+
+          markdown = @android_lint.status_report[:markdowns].first
+          expect(markdown).to be_nil
+        end
+
       end
 
     end

data/spec/fixtures/lint-result-empty.xml

@@ -0,0 +1,4 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<issues format="4" by="lint 25.2.2">
+
+</issues>

data/spec/fixtures/lint-result-without-fatal.xml

@@ -0,0 +1,64 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<issues format="4" by="lint 25.2.2">
+
+    <issue
+        id="DefaultLocale"
+        severity="Error"
+        message="Implicitly using the default locale is a common source of bugs: Use `toUpperCase(Locale)` instead"
+        category="Correctness"
+        priority="6"
+        summary="Implied default locale in case conversion"
+        explanation="Calling `String#toLowerCase()` or `#toUpperCase()` *without specifying an explicit locale* is a common source of bugs. The reason for that is that those methods will use the current locale on the user&apos;s device, and even though the code appears to work correctly when you are developing the app, it will fail in some locales. For example, in the Turkish locale, the uppercase replacement for `i` is *not* `I`.
+
+If you want the methods to just perform ASCII replacement, for example to convert an enum name, call `String#toUpperCase(Locale.US)` instead. If you really want to use the current locale, call `String#toUpperCase(Locale.getDefault())` instead."
+        url="http://developer.android.com/reference/java/util/Locale.html#default_locale"
+        urls="http://developer.android.com/reference/java/util/Locale.html#default_locale"
+        errorLine1="        return word.substring(0, 1).toUpperCase();"
+        errorLine2="                                    ~~~~~~~~~~~">
+        <location
+            file="/Users/gustavo/Developer/app-android/app/src/main/java/com/loadsmart/common/views/AvatarView.java"
+            line="60"
+            column="37"/>
+    </issue>
+
+    <issue
+        id="DefaultLocale"
+        severity="Error"
+        message="Implicitly using the default locale is a common source of bugs: Use `String.format(Locale, ...)` instead"
+        category="Correctness"
+        priority="6"
+        summary="Implied default locale in case conversion"
+        explanation="Calling `String#toLowerCase()` or `#toUpperCase()` *without specifying an explicit locale* is a common source of bugs. The reason for that is that those methods will use the current locale on the user&apos;s device, and even though the code appears to work correctly when you are developing the app, it will fail in some locales. For example, in the Turkish locale, the uppercase replacement for `i` is *not* `I`.
+
+If you want the methods to just perform ASCII replacement, for example to convert an enum name, call `String#toUpperCase(Locale.US)` instead. If you really want to use the current locale, call `String#toUpperCase(Locale.getDefault())` instead."
+        url="http://developer.android.com/reference/java/util/Locale.html#default_locale"
+        urls="http://developer.android.com/reference/java/util/Locale.html#default_locale"
+        errorLine1="        return String.format(&quot;Tracking / Close to Delivery #%d Location&quot;, stopIndex);"
+        errorLine2="               ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
+        <location
+            file="/Users/gustavo/Developer/app-android/app/src/main/java/com/loadsmart/analytics/Events.java"
+            line="21"
+            column="16"/>
+    </issue>
+
+    <issue
+        id="DefaultLocale"
+        severity="Warning"
+        message="Implicitly using the default locale is a common source of bugs: Use `String.format(Locale, ...)` instead"
+        category="Correctness"
+        priority="6"
+        summary="Implied default locale in case conversion"
+        explanation="Calling `String#toLowerCase()` or `#toUpperCase()` *without specifying an explicit locale* is a common source of bugs. The reason for that is that those methods will use the current locale on the user&apos;s device, and even though the code appears to work correctly when you are developing the app, it will fail in some locales. For example, in the Turkish locale, the uppercase replacement for `i` is *not* `I`.
+
+If you want the methods to just perform ASCII replacement, for example to convert an enum name, call `String#toUpperCase(Locale.US)` instead. If you really want to use the current locale, call `String#toUpperCase(Locale.getDefault())` instead."
+        url="http://developer.android.com/reference/java/util/Locale.html#default_locale"
+        urls="http://developer.android.com/reference/java/util/Locale.html#default_locale"
+        errorLine1="        return String.format(&quot;Tracking / At Delivery #%d Location&quot;, stopIndex);"
+        errorLine2="               ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
+        <location
+            file="/Users/gustavo/Developer/app-android/app/src/main/java/com/loadsmart/analytics/Events.java"
+            line="24"
+            column="16"/>
+    </issue>
+
+</issues>

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: danger-android_lint
 version: !ruby/object:Gem::Version
-  version: 0.0.1
+  version: 0.0.2
 platform: ruby
 authors:
 - Gustavo Barbosa
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-12-12 00:00:00.000000000 Z
+date: 2016-12-15 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: oga
@@ -185,7 +185,9 @@ files:
 - lib/danger_android_lint.rb
 - lib/danger_plugin.rb
 - spec/android_lint_spec.rb
-- spec/fixtures/lint-result.xml
+- spec/fixtures/lint-result-empty.xml
+- spec/fixtures/lint-result-with-everything.xml
+- spec/fixtures/lint-result-without-fatal.xml
 - spec/spec_helper.rb
 homepage: https://github.com/loadsmart/danger-android_lint
 licenses:
@@ -214,6 +216,8 @@ summary: Lint files of a gradle based Android project. This is done using the An
   Lint tool. Results are passed out as tables in markdown.
 test_files:
 - spec/android_lint_spec.rb
-- spec/fixtures/lint-result.xml
+- spec/fixtures/lint-result-empty.xml
+- spec/fixtures/lint-result-with-everything.xml
+- spec/fixtures/lint-result-without-fatal.xml
 - spec/spec_helper.rb
 has_rdoc: