danconia 0.2.8 → 0.4.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: fc840f5913a010c41495c7fd843304d67565217acf7eb7c248be9bf4c17624f8
-  data.tar.gz: d8906df663f918a41d91525b6ac51de9f8ac6decef179c813fc30145be876c50
+  metadata.gz: e919705ecb2ccf20ed2116a2330e056845882fe7aac0c51908cb7431f41b60f7
+  data.tar.gz: f8c791e9e14941cef253855cdb53f58a06aa0519dc733f00fdb76330aa9577cb
 SHA512:
-  metadata.gz: dc66bbeaf202e6b288f79d4a6fb9b93cc66585771f9543c14a14980252f5a112eb4e6a2cad21d15e4132bda2400f74cdb5567eb9a47a4f7ac7b6161105c2ae9c
-  data.tar.gz: 222d602fb10b842955d921ede2c7bae8bba4fd56dcdb1bcbcc74c12f795959c58250141f05943b607f0de80cdb3a07dc7425219e38f534c375236a0029d29ce2
+  metadata.gz: e264eabbbf2ce16314c6744edfee3518b1063cb87bc5681113fc6e7b7217fc5c4c0b21a84a839077580ed3dedcc7ed6c44784900313ad510a77ddd320a9ff490
+  data.tar.gz: 35a0b29aab773ddeefb68ddf9c754560f6590da7a4223a3f5232044cc574bb87daccd3f0e44220f25d05e8ba35a8f0d2d0186ccb8dcfdc899e87c0472fbd702e

data/.envrc

@@ -0,0 +1,2 @@
+layout ruby
+use nix

data/.gitignore

@@ -15,3 +15,4 @@ test/tmp
 test/version_tmp
 tmp
 .DS_Store
+.direnv

data/.rubocop.yml

@@ -0,0 +1,104 @@
+Style/Documentation:
+  Enabled: false
+
+Style/MethodDefParentheses:
+  Enabled: false
+
+Style/ParallelAssignment:
+  Enabled: false
+
+Style/FrozenStringLiteralComment:
+  Enabled: false
+
+Style/FormatStringToken:
+  Enabled: false
+
+Style/EmptyMethod:
+  Enabled: false
+
+Style/GuardClause:
+  Enabled: false
+
+Style/CommentAnnotation:
+  Enabled: false
+
+Style/AsciiComments:
+  Enabled: false
+
+Style/StabbyLambdaParentheses:
+  EnforcedStyle: require_no_parentheses
+
+Style/MultilineIfModifier:
+  Enabled: false
+
+Style/SafeNavigation:
+  Enabled: false
+
+Style/FormatString:
+  Enabled: false
+
+Style/AndOr:
+  Enabled: false
+
+Style/Next:
+  Enabled: false
+
+Style/NumericPredicate:
+  Enabled: false
+
+Style/SymbolArray:
+  Enabled: false
+
+Style/MutableConstant:
+  Enabled: false
+
+Style/RescueModifier:
+  Enabled: false
+
+Layout/LineLength:
+  Max: 120
+
+Layout/SpaceInsideHashLiteralBraces:
+  Enabled: false
+
+Layout/MultilineMethodCallIndentation:
+  Enabled: false
+
+Layout/TrailingEmptyLines:
+  Enabled: false
+
+Layout/FirstArrayElementIndentation:
+  EnforcedStyle: consistent
+
+Layout/ParameterAlignment:
+  EnforcedStyle: with_fixed_indentation
+
+Layout/SpaceInLambdaLiteral:
+  Enabled: false
+
+Layout/EmptyLineAfterGuardClause:
+  Enabled: false
+
+Metrics:
+  Enabled: false
+
+Bundler:
+  Enabled: false
+
+Lint/AssignmentInCondition:
+  Enabled: false
+
+Lint/ShadowingOuterLocalVariable:
+  Enabled: false
+
+Lint/AmbiguousRegexpLiteral:
+  Enabled: false
+
+Lint/AmbiguousOperator:
+  Enabled: false
+
+Lint/AmbiguousBlockAssociation:
+  Enabled: false
+
+Naming/AccessorMethodName:
+  Enabled: false

data/.ruby-version

@@ -1 +1 @@
-2.5.0
+2.7.5

data/.travis.yml

@@ -2,4 +2,4 @@
 sudo: false
 language: ruby
 cache: bundler
-before_install: gem install bundler -v 1.16.1
+before_install: gem install bundler -v 1.17.3

data/Gemfile.lock

@@ -1,39 +1,39 @@
 PATH
   remote: .
   specs:
-    danconia (0.2.8)
-      activerecord (>= 3.0.0)
+    danconia (0.4.0)
+      activesupport (>= 4.0)
 
 GEM
   remote: https://rubygems.org/
   specs:
-    activemodel (6.0.3.1)
-      activesupport (= 6.0.3.1)
-    activerecord (6.0.3.1)
-      activemodel (= 6.0.3.1)
-      activesupport (= 6.0.3.1)
-    activesupport (6.0.3.1)
+    activemodel (7.0.2.2)
+      activesupport (= 7.0.2.2)
+    activerecord (7.0.2.2)
+      activemodel (= 7.0.2.2)
+      activesupport (= 7.0.2.2)
+    activesupport (7.0.2.2)
       concurrent-ruby (~> 1.0, >= 1.0.2)
-      i18n (>= 0.7, < 2)
-      minitest (~> 5.1)
-      tzinfo (~> 1.1)
-      zeitwerk (~> 2.2, >= 2.2.2)
-    addressable (2.5.2)
-      public_suffix (>= 2.0.2, < 4.0)
-    coderay (1.1.2)
-    concurrent-ruby (1.1.6)
+      i18n (>= 1.6, < 2)
+      minitest (>= 5.1)
+      tzinfo (~> 2.0)
+    addressable (2.8.0)
+      public_suffix (>= 2.0.2, < 5.0)
+    ast (2.4.1)
+    coderay (1.1.3)
+    concurrent-ruby (1.1.9)
     crack (0.4.3)
       safe_yaml (~> 1.0.0)
     diff-lcs (1.3)
-    ffi (1.9.25)
-    formatador (0.2.5)
-    guard (2.14.2)
+    ffi (1.15.5)
+    formatador (1.1.0)
+    guard (2.18.0)
       formatador (>= 0.2.4)
       listen (>= 2.7, < 4.0)
       lumberjack (>= 1.0.12, < 2.0)
       nenv (~> 0.1)
       notiffany (~> 0.0)
-      pry (>= 0.9.12)
+      pry (>= 0.13.0)
       shellany (~> 0.0)
       thor (>= 0.18.1)
     guard-compat (1.2.1)
@@ -42,27 +42,37 @@ GEM
       guard-compat (~> 1.1)
       rspec (>= 2.99.0, < 4.0)
     hashdiff (0.3.7)
-    i18n (1.8.3)
+    i18n (1.10.0)
       concurrent-ruby (~> 1.0)
-    listen (3.1.5)
-      rb-fsevent (~> 0.9, >= 0.9.4)
-      rb-inotify (~> 0.9, >= 0.9.7)
-      ruby_dep (~> 1.2)
-    lumberjack (1.0.13)
-    method_source (0.9.0)
-    minitest (5.14.1)
+    jaro_winkler (1.5.4)
+    listen (3.7.1)
+      rb-fsevent (~> 0.10, >= 0.10.3)
+      rb-inotify (~> 0.9, >= 0.9.10)
+    lumberjack (1.2.8)
+    method_source (1.0.0)
+    mini_portile2 (2.7.1)
+    minitest (5.15.0)
     nenv (0.3.0)
-    notiffany (0.1.1)
+    nokogiri (1.13.1)
+      mini_portile2 (~> 2.7.0)
+      racc (~> 1.4)
+    notiffany (0.1.3)
       nenv (~> 0.1)
       shellany (~> 0.0)
-    pry (0.11.3)
-      coderay (~> 1.1.0)
-      method_source (~> 0.9.0)
-    public_suffix (3.0.2)
+    parallel (1.19.2)
+    parser (2.7.1.4)
+      ast (~> 2.4.1)
+    pry (0.14.1)
+      coderay (~> 1.1)
+      method_source (~> 1.0)
+    public_suffix (4.0.6)
+    racc (1.6.0)
+    rainbow (3.0.0)
     rake (13.0.1)
-    rb-fsevent (0.10.3)
-    rb-inotify (0.9.10)
-      ffi (>= 0.5.0, < 2)
+    rb-fsevent (0.11.1)
+    rb-inotify (0.10.1)
+      ffi (~> 1.0)
+    rexml (3.2.5)
     rspec (3.7.0)
       rspec-core (~> 3.7.0)
       rspec-expectations (~> 3.7.0)
@@ -76,29 +86,39 @@ GEM
       diff-lcs (>= 1.2.0, < 2.0)
       rspec-support (~> 3.7.0)
     rspec-support (3.7.1)
-    ruby_dep (1.5.0)
+    rubocop (0.80.1)
+      jaro_winkler (~> 1.5.1)
+      parallel (~> 1.10)
+      parser (>= 2.7.0.1)
+      rainbow (>= 2.2.2, < 4.0)
+      rexml
+      ruby-progressbar (~> 1.7)
+      unicode-display_width (>= 1.4.0, < 1.7)
+    ruby-progressbar (1.10.1)
     safe_yaml (1.0.4)
     shellany (0.0.1)
-    sqlite3 (1.4.1)
-    thor (0.20.0)
-    thread_safe (0.3.6)
-    tzinfo (1.2.7)
-      thread_safe (~> 0.1)
+    sqlite3 (1.4.2)
+    thor (1.2.1)
+    tzinfo (2.0.4)
+      concurrent-ruby (~> 1.0)
+    unicode-display_width (1.6.1)
     webmock (3.4.2)
       addressable (>= 2.3.6)
       crack (>= 0.3.2)
       hashdiff
-    zeitwerk (2.3.0)
 
 PLATFORMS
   ruby
 
 DEPENDENCIES
+  activerecord (>= 4.0)
   danconia!
   guard
   guard-rspec
+  nokogiri
   rake
   rspec
+  rubocop (~> 0.80.0)
   sqlite3
   webmock
 

data/README.md

@@ -1,8 +1,18 @@
 # Danconia
 
-A very simple money library for Ruby, backed by BigDecimal (no conversion to cents, i.e. "infinite precision") with support for external exchange rates services.
+A very simple money library for Ruby, backed by BigDecimal, with multi-currency support.
 
-[![Build Status](https://travis-ci.org/eeng/danconia.svg?branch=master)](https://travis-ci.org/eeng/danconia)
+[![Build Status](https://app.travis-ci.com/eeng/danconia.svg?branch=master)](https://app.travis-ci.com/eeng/danconia)
+
+## Features
+
+* Backed by BigDecimal (no conversion to cents is done, i.e. "infinite precision")
+* Multi-currency support
+* Pluggable exchange rates services:
+  - [CurrencyLayer API](https://currencylayer.com/)
+  - [BNA](https://www.bna.com.ar/)
+  - FixedRates (for testing use)
+* Pluggable stores for persisting the exchange rates
 
 ## Installation
 
@@ -29,10 +39,12 @@ Please refer to `examples/single_currency.rb` for some configuration options.
 
 ## Multi-Currency Support
 
-To handle multiple currencies you need to configure an `Exchange` in order to fetch the rates. For example, with [CurrencyLayer](https://currencylayer.com/):
+To handle multiple currencies you need to configure an `Exchange` in order to fetch the rates. For example, with CurrencyLayer:
 
 ```ruby
 # This can be placed in a Rails initializer
+require 'danconia/exchanges/currency_layer'
+
 Danconia.configure do |config|
   config.default_exchange = Danconia::Exchanges::CurrencyLayer.new(access_key: '...')
 end
@@ -56,6 +68,8 @@ By default, rates are stored in memory, but you can supply a store in the exchan
 Given a `products` table with a decimal column `price` and a string column `price_currency` (optional), then you can use the `money` class method to automatically convert it to Money:
 
 ```ruby
+require 'danconia/integrations/active_record'
+
 class Product < ActiveRecord::Base
   money :price
 end

data/bin/console

@@ -0,0 +1,7 @@
+#!/usr/bin/env ruby
+
+require 'bundler/setup'
+require 'danconia'
+
+require 'pry'
+Pry.start

data/danconia.gemspec

@@ -17,11 +17,15 @@ Gem::Specification.new do |gem|
   gem.executables   = gem.files.grep(%r{^bin/}).map{ |f| File.basename(f) }
   gem.test_files    = gem.files.grep(%r{^(test|spec|features)/})
   gem.require_paths = ["lib"]
-  gem.add_dependency "activerecord", '>= 3.0.0'
+
+  gem.add_dependency 'activesupport', '>= 4.0'
+  gem.add_development_dependency "activerecord", '>= 4.0'
   gem.add_development_dependency "sqlite3"
   gem.add_development_dependency "rake"
   gem.add_development_dependency "guard"
   gem.add_development_dependency "guard-rspec"
   gem.add_development_dependency "rspec"
   gem.add_development_dependency "webmock"
+  gem.add_development_dependency "nokogiri"
+  gem.add_development_dependency 'rubocop', '~> 0.80.0'
 end

data/examples/bna.rb

@@ -0,0 +1,35 @@
+# Example using BNA (Banco Nación de Argentina) and storing rates daily in ActiveRecord.
+
+require 'danconia/integrations/active_record'
+require 'danconia/exchanges/bna'
+
+ActiveRecord::Base.logger = Logger.new(STDOUT)
+ActiveRecord::Base.establish_connection adapter: 'sqlite3', database: ':memory:'
+
+ActiveRecord::Schema.define do
+  # You can use this in a Rails migration
+  create_table :exchange_rates do |t|
+    t.date :date
+    t.string :pair, limit: 6
+    t.string :rate_type
+    t.decimal :rate, precision: 12, scale: 6
+    t.index [:date, :pair, :rate_type], unique: true
+  end
+end
+
+Danconia.configure do |config|
+  config.default_exchange = Danconia::Exchanges::BNA.new(
+    store: Danconia::Stores::ActiveRecord.new(unique_keys: %i[date pair rate_type], date_field: :date)
+  )
+end
+
+# Periodically call this method to keep the rates up to date
+puts 'Updating rates...'
+Danconia.config.default_exchange.update_rates!
+
+# Uses the latest rate
+puts Money(1, 'USD').exchange_to('ARS', rate_type: 'billetes').inspect
+puts Money(1, 'USD').exchange_to('ARS', rate_type: 'divisas').inspect
+
+# Raises Danconia::Errors::ExchangeRateNotFound as there is no rate for that date
+# Money(1, 'USD').exchange_to('ARS', rate_type: 'billetes', date: Date.new(2000))

data/examples/currency_layer.rb

@@ -1,6 +1,10 @@
+# Example using CurrencyLayer API and storing only the latests rates in ActiveRecord.
 # Remember to supply your CurrencyLayer key in the ACCESS_KEY environment variable to run this example
-require 'danconia'
 
+require 'danconia/integrations/active_record'
+require 'danconia/exchanges/currency_layer'
+
+ActiveRecord::Base.logger = Logger.new(STDOUT)
 ActiveRecord::Base.establish_connection adapter: 'sqlite3', database: ':memory:'
 
 ActiveRecord::Schema.define do
@@ -19,8 +23,8 @@ Danconia.configure do |config|
   )
 end
 
-# Periodically call this method to keep rates up to date
-puts 'Updating dates with CurrencyLayer API...'
+# Periodically call this method to keep the rates up to date
+puts 'Updating rates...'
 Danconia.config.default_exchange.update_rates!
 
 puts Money(1, 'USD').exchange_to('EUR').inspect # => 0.854896 EUR

data/examples/fixed_rates.rb

@@ -1,8 +1,6 @@
-require 'danconia'
-
 Danconia.configure do |config|
   config.default_currency = 'ARS'
   config.default_exchange = Danconia::Exchanges::FixedRates.new(rates: {'USDARS' => 27.5, 'USDEUR' => 0.86})
 end
 
-puts Money(10, 'ARS').exchange_to('EUR').inspect # => 0.31273 EUR
+puts Money(10, 'ARS').exchange_to('EUR').inspect # => 0.31273 EUR

data/examples/single_currency.rb

@@ -1,8 +1,7 @@
-require 'danconia'
+# Example showing how to use a single currency.
 
 # USD is the default currency if no configuration is provided
-puts (Money(10.25) / 2).inspect # => 5.125 USD
-puts (Money(10.25) / 2).to_s # => $5.13
+puts Money(10.25).inspect # => 5.125 USD
 
 # Lets switch to other currency
 Danconia.configure do |config|

data/lib/danconia/currency.rb

@@ -1,6 +1,6 @@
 module Danconia
-  class Currency < Struct.new(:code, :symbol, :description, keyword_init: true)
-    def self.find code, exchange
+  Currency = Struct.new(:code, :symbol, :description, keyword_init: true) do
+    def self.find code
       return code if code.is_a? Currency
       new Danconia.config.available_currencies.find { |c| c[:code] == code } || {code: code, symbol: '$'}
     end

data/lib/danconia/exchange.rb

@@ -0,0 +1,47 @@
+require 'danconia/pair'
+
+module Danconia
+  class Exchange
+    def rate from, to, **opts
+      return 1.0 if from == to
+
+      pair = Pair.new(from, to)
+      rates = direct_and_inverted_rates(opts)
+      rates[pair] or indirect_rate(pair, rates) or raise Errors::ExchangeRateNotFound.new(from, to)
+    end
+
+    # Override this method in subclasses. Should return a map of pairs to rates.
+    # See `FixedRates` for an example implementation.
+    def rates **_opts
+      raise NotImplementedError
+    end
+
+    private
+
+    # Returns the original rates plus the inverted ones, to simplify rate finding logic.
+    # Also wraps the pair strings into Pair objects.
+    def direct_and_inverted_rates opts
+      rates(opts).each_with_object({}) do |(pair_str, rate), rs|
+        pair = Pair.parse(pair_str)
+        rs[pair] = rate
+        rs[pair.invert] ||= 1.0 / rate
+      end
+    end
+
+    def indirect_rate ind_pair, rates
+      if (from_pair = rates.keys.detect { |pair| pair.from == ind_pair.from }) &&
+         (to_pair = rates.keys.detect { |pair| pair.to == ind_pair.to })
+        rates[from_pair] * rates[to_pair]
+      end
+    end
+
+    def array_of_rates_to_hash array
+      pairs = array.map { |er| er[:pair] }
+      if pairs.size != pairs.uniq.size
+        raise ArgumentError, "Exchange returned duplicate pairs. Maybe you forgot a filter?\n#{array}"
+      end
+
+      Hash[array.map { |er| er.values_at(:pair, :rate) }]
+    end
+  end
+end

data/lib/danconia/exchanges/bna.rb

@@ -0,0 +1,61 @@
+require 'danconia/errors/api_error'
+require 'net/http'
+require 'nokogiri'
+
+module Danconia
+  module Exchanges
+    # The BNA does not provide an API to pull the rates, so this implementation scrapes the home HTML directly.
+    # Returns rates of both types, "Billetes" and "Divisas", and only the "tipo de cambio vendedor" ones.
+    # See `examples/bna.rb` for a complete usage example.
+    class BNA < Exchange
+      attr_reader :store
+
+      def initialize store: Stores::InMemory.new
+        @store = store
+      end
+
+      def fetch_rates
+        response = Net::HTTP.get URI 'https://www.bna.com.ar/Personas'
+        scrape_rates(response, 'billetes') + scrape_rates(response, 'divisas')
+      end
+
+      def update_rates!
+        @store.save_rates fetch_rates
+      end
+
+      def rates rate_type:, date: nil
+        array_of_rates_to_hash @store.rates(rate_type: rate_type, date: date)
+      end
+
+      private
+
+      def scrape_rates response, type
+        doc = Nokogiri::XML(response).css("##{type}")
+
+        if doc.css('thead th:last-child').text != 'Venta'
+          raise Errors::APIError, "Could not scrape '#{type}' rates. Maybe the format changed?"
+        end
+
+        doc.css('tbody tr').map do |row|
+          pair = parse_pair(row.css('td:first-child').text) or next
+          rate = parse_rate(row.css('td:last-child').text, pair)
+          date = Date.parse(doc.css('.fechaCot').text)
+          {pair: pair, rate: rate, date: date, rate_type: type}
+        end.compact.presence or raise Errors::APIError, "Could not scrape '#{type}' rates. Maybe the format changed?"
+      end
+
+      def parse_pair cur_name
+        case cur_name
+        when 'Dolar U.S.A' then 'USDARS'
+        when 'Euro' then 'EURARS'
+        when 'Real *' then 'BRLARS'
+        end
+      end
+
+      def parse_rate str, pair
+        val = Float(str.tr(',', '.'))
+        pair == 'BRLARS' ? val / 100.0 : val
+      end
+    end
+  end
+end

data/lib/danconia/exchanges/currency_layer.rb

@@ -4,10 +4,14 @@ require 'json'
 
 module Danconia
   module Exchanges
+    # Fetches the rates from https://currencylayer.com/. The `access_key` must be provided.
+    # See `examples/currency_layer.rb` for a complete usage example.
     class CurrencyLayer < Exchange
-      def initialize access_key:, **args
-        super args
+      attr_reader :store
+
+      def initialize access_key:, store: Stores::InMemory.new
         @access_key = access_key
+        @store = store
       end
 
       def fetch_rates
@@ -18,6 +22,14 @@ module Danconia
           raise Errors::APIError, response
         end
       end
+
+      def update_rates!
+        @store.save_rates fetch_rates.map { |pair, rate| {pair: pair, rate: rate} }
+      end
+
+      def rates **_opts
+        array_of_rates_to_hash @store.rates
+      end
     end
   end
 end

data/lib/danconia/exchanges/fixed_rates.rb

@@ -1,13 +1,11 @@
 module Danconia
   module Exchanges
     class FixedRates < Exchange
-      def initialize rates: {}, **args
-        super args
+      def initialize rates: {}
         @rates = rates
-        update_rates!
       end
 
-      def fetch_rates
+      def rates **_opts
         @rates
       end
     end

data/lib/danconia/integrations/active_record.rb

@@ -1,4 +1,5 @@
 require 'active_record'
+require 'danconia/stores/active_record'
 
 module Danconia
   module Integrations
@@ -8,24 +9,22 @@ module Danconia
       end
 
       module ClassMethods
-        def money(*attr_names)
+        def money(*attr_names, **exchange_opts)
           attr_names.each do |attr_name|
             amount_column = attr_name
-            currency_column = "#{attr_name}_currency"
+            currency_column = :"#{attr_name}_currency"
 
-            class_eval <<-EOR, __FILE__, __LINE__ + 1
-              def #{attr_name}= value
-                write_attribute :#{amount_column}, value.is_a?(Money) ? value.amount : value
-                write_attribute :#{currency_column}, value.currency.code if respond_to?(:#{currency_column}) && value.is_a?(Money)
-              end
+            define_method "#{attr_name}=" do |value|
+              write_attribute amount_column, value.is_a?(Money) ? value.amount : value
+              write_attribute currency_column, value.currency.code if respond_to?(currency_column) && value.is_a?(Money)
+            end
 
-              def #{attr_name}
-                amount = read_attribute :#{amount_column}
-                currency = read_attribute :#{currency_column}
-                decimals = self.class.columns.detect { |c| c.name == '#{amount_column}' }.scale
-                Money.new amount, currency, decimals: decimals if amount
-              end
-            EOR
+            define_method attr_name do
+              amount = read_attribute amount_column
+              currency = read_attribute currency_column
+              decimals = self.class.columns.detect { |c| c.name == amount_column.to_s }.scale
+              Money.new amount, currency, decimals: decimals, exchange_opts: exchange_opts if amount
+            end
           end
         end
       end