dalli 5.0.12 → 5.0.13

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 237c6d61c07c784fab08e871f5ec95e05a56f280a738bd2a060176ea49885198
-  data.tar.gz: 846bb56b3ce9e7a7c1b9c2bfd91faa907c5b8974e686a0767d4437343dadd2b3
+  metadata.gz: f386fb06afa43acffc1a4c63b7c611930d6302c90d10df138b8a0c24182fadcb
+  data.tar.gz: 5fd63314770f91b3f3668613e37f19fbe582c7e31ba1a5043155c5cd999b3560
 SHA512:
-  metadata.gz: 8ef4bca995d5ed6d1d0d47b460a21f9ac99db727d3a60fe60f168760b11e7b1c2e139903b5d2b3b8d8ce0869ff252b5b77acdf422db8d07456301e83e87e9e94
-  data.tar.gz: 5b272117c00c7ce7e077ad5137a708a9ce06a842408b75f8efd1248c72a29b3fc739cfe7347dd475229158c3cd0869989c89b57f51d91bc8794c277a4324a0a9
+  metadata.gz: 0d5368195322b97078321fe4385be067cd004e3d66dcf1e65329474d9161fcfeee3a227ec1988dbc693b27cd5bd91dfc6ab9332ee8a5509e321fa8baafe16b55
+  data.tar.gz: c18b9a743113cf553698a0238d9d773d498cd93a21f1593b798ff5432438a6be00b86ae049157026cc06541491117b19cead5c432777a4e372c902df5b17fa68

data/CHANGELOG.md

@@ -4,6 +4,13 @@ Dalli Changelog
 Unreleased
 ==========
 
+5.0.13
+==========
+
+Bug fixes:
+
+- `set_multi` across more than one server stored `nil` for a Symbol key or a key over 250 bytes, in place of the value given
+
 5.0.12
 ==========
 

data/lib/dalli/pipelined_setter.rb

@@ -41,9 +41,12 @@ module Dalli
 
     private
 
+    # Values are looked up by each key as sent. The caller's key can't be
+    # rebuilt from it: a long key is digested, and a Symbol becomes a String.
     def setup_requests(hash, ttl, req_options)
-      groups = groups_for_keys(hash.keys)
-      make_set_requests(groups, hash, ttl, req_options)
+      pairs = hash.transform_keys { |k| @key_manager.validate_key(k.to_s) }
+      groups = groups_for_keys(pairs.keys)
+      make_set_requests(groups, pairs, ttl, req_options)
       groups.keys
     end
 
@@ -51,12 +54,10 @@ module Dalli
     # Loop through the server-grouped sets of keys, writing
     # the corresponding quiet set requests to the appropriate servers
     ##
-    def make_set_requests(groups, hash, ttl, req_options)
+    def make_set_requests(groups, pairs, ttl, req_options)
       groups.each do |server, keys_for_server|
         keys_for_server.each do |key|
-          original_key = @key_manager.key_without_namespace(key)
-          value = hash[original_key]
-          server.request(:pipelined_set, key, value, ttl, req_options)
+          server.request(:pipelined_set, key, pairs[key], ttl, req_options)
         rescue Dalli::MarshalError, Dalli::ValueOverMaxSize => e
           # Nothing was written for this key, so the server's other keys are
           # unaffected; raised by #process once the batch is complete
@@ -81,8 +82,7 @@ module Dalli
     end
 
     def groups_for_keys(keys)
-      validated_keys = keys.map { |k| @key_manager.validate_key(k.to_s) }
-      groups = @ring.keys_grouped_by_server(validated_keys)
+      groups = @ring.keys_grouped_by_server(keys)
 
       if (unfound_keys = groups.delete(nil))
         Dalli.logger.debug do

data/lib/dalli/version.rb

@@ -1,7 +1,7 @@
 # frozen_string_literal: true
 
 module Dalli
-  VERSION = '5.0.12'
+  VERSION = '5.0.13'
 
   MIN_SUPPORTED_MEMCACHED_VERSION = '1.6'
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: dalli
 version: !ruby/object:Gem::Version
-  version: 5.0.12
+  version: 5.0.13
 platform: ruby
 authors:
 - Peter M. Goldstein