dalli 4.3.9 → 4.3.10

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 2e7ed5e67a328d8850a50358f988c46803599cd7df6327d3318c6e3951aef6a8
-  data.tar.gz: ce71002a269001f7c8e620aad263425aadd2a170cdcf557df843653afebeabfd
+  metadata.gz: 41490f01a85678506bed8f5e234cbbea7dadee8d5369f8c9800206a63a82260c
+  data.tar.gz: 5176f61b9332988912f0216f516caedcfe0fb8a86f0eeea4d129e52ec7a6f183
 SHA512:
-  metadata.gz: f8f59848e325e4f66519c5dc291fd35c617e5e958548dd2b7415014f6d0d7933aaad510f467c2c1fc799395b2388fe394a24689a5eb7032ec93333d0348d4ad7
-  data.tar.gz: 3a4bcb6aadc3247ffbfb10006e946bfd40e55fe3481ee705313146151b3e7a1b9dac35bb17e6ac06d4da161e624c072deca4406ae15baa242ba69e6ff06058df
+  metadata.gz: abccb3715898dcb8c1f6f3581f807253c91cf0190a2ff7ec44c70aea73d4312e5f39faebce3f510b47686cce02c8545806397cb8fb574801b36a6077a06582a2
+  data.tar.gz: 468fa248795f1e7c4905bf47c365e0807428ca2b05e5499d4686ea94b506584d818c5bd03b09d822182def1b3cb76ac97feab8977b8a906d5362d891f7120185

data/CHANGELOG.md

@@ -4,6 +4,13 @@ Dalli Changelog
 Unreleased
 ==========
 
+4.3.10
+==========
+
+Bug fixes:
+
+- `set_multi` across more than one server stored `nil` for a Symbol key or a key over 250 bytes, in place of the value given
+
 4.3.9
 ==========
 

data/lib/dalli/pipelined_setter.rb

@@ -41,9 +41,12 @@ module Dalli
 
     private
 
+    # Values are looked up by each key as sent. The caller's key can't be
+    # rebuilt from it: a long key is digested, and a Symbol becomes a String.
     def setup_requests(hash, ttl, req_options)
-      groups = groups_for_keys(hash.keys)
-      make_set_requests(groups, hash, ttl, req_options)
+      pairs = hash.transform_keys { |k| @key_manager.validate_key(k.to_s) }
+      groups = groups_for_keys(pairs.keys)
+      make_set_requests(groups, pairs, ttl, req_options)
       groups.keys
     end
 
@@ -51,12 +54,10 @@ module Dalli
     # Loop through the server-grouped sets of keys, writing
     # the corresponding quiet set requests to the appropriate servers
     ##
-    def make_set_requests(groups, hash, ttl, req_options)
+    def make_set_requests(groups, pairs, ttl, req_options)
       groups.each do |server, keys_for_server|
         keys_for_server.each do |key|
-          original_key = @key_manager.key_without_namespace(key)
-          value = hash[original_key]
-          server.request(:pipelined_set, key, value, ttl, req_options)
+          server.request(:pipelined_set, key, pairs[key], ttl, req_options)
         rescue Dalli::MarshalError, Dalli::ValueOverMaxSize => e
           # Nothing was written for this key, so the server's other keys are
           # unaffected; raised by #process once the batch is complete
@@ -81,8 +82,7 @@ module Dalli
     end
 
     def groups_for_keys(keys)
-      validated_keys = keys.map { |k| @key_manager.validate_key(k.to_s) }
-      groups = @ring.keys_grouped_by_server(validated_keys)
+      groups = @ring.keys_grouped_by_server(keys)
 
       if (unfound_keys = groups.delete(nil))
         Dalli.logger.debug do

data/lib/dalli/version.rb

@@ -1,7 +1,7 @@
 # frozen_string_literal: true
 
 module Dalli
-  VERSION = '4.3.9'
+  VERSION = '4.3.10'
 
   MIN_SUPPORTED_MEMCACHED_VERSION = '1.4'
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: dalli
 version: !ruby/object:Gem::Version
-  version: 4.3.9
+  version: 4.3.10
 platform: ruby
 authors:
 - Peter M. Goldstein