dalli 3.0.4 → 3.1.1

data/lib/dalli/protocol/connection_manager.rb

@@ -0,0 +1,242 @@
+# frozen_string_literal: true
+
+require 'English'
+require 'socket'
+require 'timeout'
+
+module Dalli
+  module Protocol
+    ##
+    # Manages the socket connection to the server, including ensuring liveness
+    # and retries.
+    ##
+    class ConnectionManager
+      DEFAULTS = {
+        # seconds between trying to contact a remote server
+        down_retry_delay: 30,
+        # connect/read/write timeout for socket operations
+        socket_timeout: 1,
+        # times a socket operation may fail before considering the server dead
+        socket_max_failures: 2,
+        # amount of time to sleep between retries when a failure occurs
+        socket_failure_delay: 0.1,
+        # Set keepalive
+        keepalive: true
+      }.freeze
+
+      attr_accessor :hostname, :port, :socket_type, :options
+      attr_reader :sock
+
+      def initialize(hostname, port, socket_type, client_options)
+        @hostname = hostname
+        @port = port
+        @socket_type = socket_type
+        @options = DEFAULTS.merge(client_options)
+        @request_in_progress = false
+        @sock = nil
+        @pid = nil
+
+        reset_down_info
+      end
+
+      def name
+        if socket_type == :unix
+          hostname
+        else
+          "#{hostname}:#{port}"
+        end
+      end
+
+      def establish_connection
+        Dalli.logger.debug { "Dalli::Server#connect #{name}" }
+
+        @sock = memcached_socket
+        @pid = Process.pid
+      rescue SystemCallError, Timeout::Error, EOFError, SocketError => e
+        # SocketError = DNS resolution failure
+        error_on_request!(e)
+      end
+
+      def reconnect_down_server?
+        return true unless @last_down_at
+
+        time_to_next_reconnect = @last_down_at + options[:down_retry_delay] - Time.now
+        return true unless time_to_next_reconnect.positive?
+
+        Dalli.logger.debug do
+          format('down_retry_delay not reached for %<name>s (%<time>.3f seconds left)', name: name,
+                                                                                        time: time_to_next_reconnect)
+        end
+        false
+      end
+
+      def up!
+        log_up_detected
+        reset_down_info
+      end
+
+      # Marks the server instance as down.  Updates the down_at state
+      # and raises an Dalli::NetworkError that includes the underlying
+      # error in the message.  Calls close to clean up socket state
+      def down!
+        close
+        log_down_detected
+
+        @error = $ERROR_INFO&.class&.name
+        @msg ||= $ERROR_INFO&.message
+        raise_down_error
+      end
+
+      def raise_down_error
+        raise Dalli::NetworkError, "#{name} is down: #{@error} #{@msg}"
+      end
+
+      def socket_timeout
+        @socket_timeout ||= @options[:socket_timeout]
+      end
+
+      def confirm_ready!
+        error_on_request!(RuntimeError.new('Already writing to socket')) if request_in_progress?
+        close_on_fork if fork_detected?
+      end
+
+      def close
+        return unless @sock
+
+        begin
+          @sock.close
+        rescue StandardError
+          nil
+        end
+        @sock = nil
+        @pid = nil
+        abort_request!
+      end
+
+      def connected?
+        !@sock.nil?
+      end
+
+      def request_in_progress?
+        @request_in_progress
+      end
+
+      def start_request!
+        @request_in_progress = true
+      end
+
+      def finish_request!
+        @request_in_progress = false
+      end
+
+      def abort_request!
+        @request_in_progress = false
+      end
+
+      def read(count)
+        start_request!
+        data = @sock.readfull(count)
+        finish_request!
+        data
+      rescue SystemCallError, Timeout::Error, EOFError => e
+        error_on_request!(e)
+      end
+
+      def write(bytes)
+        start_request!
+        result = @sock.write(bytes)
+        finish_request!
+        result
+      rescue SystemCallError, Timeout::Error => e
+        error_on_request!(e)
+      end
+
+      # Non-blocking read.  Should only be used in the context
+      # of a caller who has called start_request!, but not yet
+      # called finish_request!.  Here to support the operation
+      # of the get_multi operation
+      def read_nonblock
+        @sock.read_available
+      end
+
+      def max_allowed_failures
+        @max_allowed_failures ||= @options[:socket_max_failures] || 2
+      end
+
+      def error_on_request!(err_or_string)
+        log_warn_message(err_or_string)
+
+        @fail_count += 1
+        if @fail_count >= max_allowed_failures
+          down!
+        else
+          # Closes the existing socket, setting up for a reconnect
+          # on next request
+          reconnect!('Socket operation failed, retrying...')
+        end
+      end
+
+      def reconnect!(message)
+        close
+        sleep(options[:socket_failure_delay]) if options[:socket_failure_delay]
+        raise Dalli::NetworkError, message
+      end
+
+      def reset_down_info
+        @fail_count = 0
+        @down_at = nil
+        @last_down_at = nil
+        @msg = nil
+        @error = nil
+      end
+
+      def memcached_socket
+        if socket_type == :unix
+          Dalli::Socket::UNIX.open(hostname, options)
+        else
+          Dalli::Socket::TCP.open(hostname, port, options)
+        end
+      end
+
+      def log_warn_message(err_or_string)
+        detail = err_or_string.is_a?(String) ? err_or_string : "#{err_or_string.class}: #{err_or_string.message}"
+        Dalli.logger.warn do
+          detail = err_or_string.is_a?(String) ? err_or_string : "#{err_or_string.class}: #{err_or_string.message}"
+          "#{name} failed (count: #{@fail_count}) #{detail}"
+        end
+      end
+
+      def close_on_fork
+        message = 'Fork detected, re-connecting child process...'
+        Dalli.logger.info { message }
+        # Close socket on a fork, setting us up for reconnect
+        # on next request.
+        close
+        raise Dalli::NetworkError, message
+      end
+
+      def fork_detected?
+        @pid && @pid != Process.pid
+      end
+
+      def log_down_detected
+        @last_down_at = Time.now
+
+        if @down_at
+          time = Time.now - @down_at
+          Dalli.logger.debug { format('%<name>s is still down (for %<time>.3f seconds now)', name: name, time: time) }
+        else
+          @down_at = @last_down_at
+          Dalli.logger.warn("#{name} is down")
+        end
+      end
+
+      def log_up_detected
+        return unless @down_at
+
+        time = Time.now - @down_at
+        Dalli.logger.warn { format('%<name>s is back (downtime was %<time>.3f seconds)', name: name, time: time) }
+      end
+    end
+  end
+end

data/lib/dalli/protocol/response_buffer.rb

@@ -0,0 +1,53 @@
+# frozen_string_literal: true
+
+require 'socket'
+require 'timeout'
+
+module Dalli
+  module Protocol
+    ##
+    # Manages the buffer for responses from memcached.
+    ##
+    class ResponseBuffer
+      def initialize(io_source, response_processor)
+        @io_source = io_source
+        @response_processor = response_processor
+      end
+
+      def read
+        @buffer << @io_source.read_nonblock
+      end
+
+      # Attempts to process a single response from the buffer.  Starts
+      # by advancing the buffer to the specified start position
+      def process_single_getk_response
+        bytes, resp_header, key, value = @response_processor.getk_response_from_buffer(@buffer)
+        advance(bytes)
+        [resp_header, key, value]
+      end
+
+      # Advances the internal response buffer by bytes_to_advance
+      # bytes.  The
+      def advance(bytes_to_advance)
+        return unless bytes_to_advance.positive?
+
+        @buffer = @buffer[bytes_to_advance..-1]
+      end
+
+      # Resets the internal buffer to an empty state,
+      # so that we're ready to read pipelined responses
+      def reset
+        @buffer = +''
+      end
+
+      # Clear the internal response buffer
+      def clear
+        @buffer = nil
+      end
+
+      def in_progress?
+        !@buffer.nil?
+      end
+    end
+  end
+end

data/lib/dalli/protocol/server_config_parser.rb

@@ -8,19 +8,36 @@ module Dalli
     # socket_type.
     ##
     class ServerConfigParser
+      MEMCACHED_URI_PROTOCOL = 'memcached://'
+
       # TODO: Revisit this, especially the IP/domain part.  Likely
       # can limit character set to LDH + '.'.  Hex digit section
-      # appears to have been added to support IPv6, but as far as
-      # I can tell it doesn't work
+      # is there to support IPv6 addresses, which need to be specified with
+      # a bounding []
       SERVER_CONFIG_REGEXP = /\A(\[([\h:]+)\]|[^:]+)(?::(\d+))?(?::(\d+))?\z/.freeze
 
       DEFAULT_PORT = 11_211
       DEFAULT_WEIGHT = 1
 
       def self.parse(str)
+        return parse_non_uri(str) unless str.start_with?(MEMCACHED_URI_PROTOCOL)
+
+        parse_uri(str)
+      end
+
+      def self.parse_uri(str)
+        uri = URI.parse(str)
+        auth_details = {
+          username: uri.user,
+          password: uri.password
+        }
+        [uri.host, normalize_port(uri.port), :tcp, DEFAULT_WEIGHT, auth_details]
+      end
+
+      def self.parse_non_uri(str)
         res = deconstruct_string(str)
 
-        hostname = normalize_hostname(str, res)
+        hostname = normalize_host_from_match(str, res)
         if hostname.start_with?('/')
           socket_type = :unix
           port, weight = attributes_for_unix_socket(res)
@@ -28,7 +45,7 @@ module Dalli
           socket_type = :tcp
           port, weight = attributes_for_tcp_socket(res)
         end
-        [hostname, port, weight, socket_type]
+        [hostname, port, socket_type, weight, {}]
       end
 
       def self.deconstruct_string(str)
@@ -49,7 +66,7 @@ module Dalli
         [normalize_port(res[3]), normalize_weight(res[4])]
       end
 
-      def self.normalize_hostname(str, res)
+      def self.normalize_host_from_match(str, res)
         raise Dalli::DalliError, "Could not parse hostname #{str}" if res.nil? || res[1] == '[]'
 
         res[2] || res[1]

data/lib/dalli/protocol/value_marshaller.rb

@@ -0,0 +1,59 @@
+# frozen_string_literal: true
+
+require 'forwardable'
+
+module Dalli
+  module Protocol
+    ##
+    # Dalli::Protocol::ValueMarshaller compartmentalizes the logic for marshalling
+    # and unmarshalling unstructured data (values) to Memcached.  It also enforces
+    # limits on the maximum size of marshalled data.
+    ##
+    class ValueMarshaller
+      extend Forwardable
+
+      DEFAULTS = {
+        # max size of value in bytes (default is 1 MB, can be overriden with "memcached -I <size>")
+        value_max_bytes: 1024 * 1024
+      }.freeze
+
+      OPTIONS = DEFAULTS.keys.freeze
+
+      def_delegators :@value_serializer, :serializer
+      def_delegators :@value_compressor, :compressor, :compression_min_size, :compress_by_default?
+
+      def initialize(client_options)
+        @value_serializer = ValueSerializer.new(client_options)
+        @value_compressor = ValueCompressor.new(client_options)
+
+        @marshal_options =
+          DEFAULTS.merge(client_options.select { |k, _| OPTIONS.include?(k) })
+      end
+
+      def store(key, value, options = nil)
+        bitflags = 0
+        value, bitflags = @value_serializer.store(value, options, bitflags)
+        value, bitflags = @value_compressor.store(value, options, bitflags)
+
+        error_if_over_max_value_bytes(key, value)
+        [value, bitflags]
+      end
+
+      def retrieve(value, flags)
+        value = @value_compressor.retrieve(value, flags)
+        @value_serializer.retrieve(value, flags)
+      end
+
+      def value_max_bytes
+        @marshal_options[:value_max_bytes]
+      end
+
+      def error_if_over_max_value_bytes(key, value)
+        return if value.bytesize <= value_max_bytes
+
+        message = "Value for #{key} over max size: #{value_max_bytes} <= #{value.bytesize}"
+        raise Dalli::ValueOverMaxSize, message
+      end
+    end
+  end
+end

data/lib/dalli/protocol/value_serializer.rb

@@ -0,0 +1,91 @@
+# frozen_string_literal: true
+
+module Dalli
+  module Protocol
+    ##
+    # Dalli::Protocol::ValueSerializer compartmentalizes the logic for managing
+    # serialization and deserialization of stored values.  It manages interpreting
+    # relevant options from both client and request, determining whether to
+    # serialize/deserialize on store/retrieve, and processes bitflags as necessary.
+    ##
+    class ValueSerializer
+      DEFAULTS = {
+        serializer: Marshal
+      }.freeze
+
+      OPTIONS = DEFAULTS.keys.freeze
+
+      # https://www.hjp.at/zettel/m/memcached_flags.rxml
+      # Looks like most clients use bit 0 to indicate native language serialization
+      FLAG_SERIALIZED = 0x1
+
+      attr_accessor :serialization_options
+
+      def initialize(protocol_options)
+        @serialization_options =
+          DEFAULTS.merge(protocol_options.select { |k, _| OPTIONS.include?(k) })
+      end
+
+      def store(value, req_options, bitflags)
+        do_serialize = !(req_options && req_options[:raw])
+        store_value = do_serialize ? serialize_value(value) : value.to_s
+        bitflags |= FLAG_SERIALIZED if do_serialize
+        [store_value, bitflags]
+      end
+
+      # TODO: Some of these error messages need to be validated.  It's not obvious
+      # that all of them are actually generated by the invoked code
+      # in current systems
+      # rubocop:disable Layout/LineLength
+      TYPE_ERR_REGEXP = %r{needs to have method `_load'|exception class/object expected|instance of IO needed|incompatible marshal file format}.freeze
+      ARGUMENT_ERR_REGEXP = /undefined class|marshal data too short/.freeze
+      NAME_ERR_STR = 'uninitialized constant'
+      # rubocop:enable Layout/LineLength
+
+      def retrieve(value, bitflags)
+        serialized = (bitflags & FLAG_SERIALIZED) != 0
+        serialized ? serializer.load(value) : value
+      rescue TypeError => e
+        filter_type_error(e)
+      rescue ArgumentError => e
+        filter_argument_error(e)
+      rescue NameError => e
+        filter_name_error(e)
+      end
+
+      def filter_type_error(err)
+        raise err unless TYPE_ERR_REGEXP.match?(err.message)
+
+        raise UnmarshalError, "Unable to unmarshal value: #{err.message}"
+      end
+
+      def filter_argument_error(err)
+        raise err unless ARGUMENT_ERR_REGEXP.match?(err.message)
+
+        raise UnmarshalError, "Unable to unmarshal value: #{err.message}"
+      end
+
+      def filter_name_error(err)
+        raise err unless err.message.include?(NAME_ERR_STR)
+
+        raise UnmarshalError, "Unable to unmarshal value: #{err.message}"
+      end
+
+      def serializer
+        @serialization_options[:serializer]
+      end
+
+      def serialize_value(value)
+        serializer.dump(value)
+      rescue Timeout::Error => e
+        raise e
+      rescue StandardError => e
+        # Serializing can throw several different types of generic Ruby exceptions.
+        # Convert to a specific exception so we can special case it higher up the stack.
+        exc = Dalli::MarshalError.new(e.message)
+        exc.set_backtrace e.backtrace
+        raise exc
+      end
+    end
+  end
+end

data/lib/dalli/protocol.rb

@@ -2,8 +2,7 @@
 
 module Dalli
   module Protocol
-    # Implements the NullObject pattern to store an application-defined value for 'Key not found' responses.
-    class NilObject; end
-    NOT_FOUND = NilObject.new
+    # Preserved for backwards compatibility.  Should be removed in 4.0
+    NOT_FOUND = ::Dalli::NOT_FOUND
   end
 end

data/lib/dalli/ring.rb

@@ -1,10 +1,24 @@
 # frozen_string_literal: true
 
-require "digest/sha1"
-require "zlib"
+require 'digest/sha1'
+require 'zlib'
 
 module Dalli
+  ##
+  # An implementation of a consistent hash ring, designed to minimize
+  # the cache miss impact of adding or removing servers from the ring.
+  # That is, adding or removing a server from the ring should impact
+  # the key -> server mapping of ~ 1/N of the stored keys where N is the
+  # number of servers in the ring.  This is done by creating a large
+  # number of "points" per server, distributed over the space
+  # 0x00000000 - 0xFFFFFFFF. For a given key, we calculate the CRC32
+  # hash, and find the nearest "point" that is less than or equal to the
+  # the key's hash.  In this implemetation, each "point" is represented
+  # by a Dalli::Ring::Entry.
+  ##
   class Ring
+    # The number of entries on the continuum created per server
+    # in an equally weighted scenario.
     POINTS_PER_SERVER = 160 # this is the default in libmemcached
 
     attr_accessor :servers, :continuum
@@ -12,45 +26,48 @@ module Dalli
     def initialize(servers, options)
       @servers = servers
       @continuum = nil
-      if servers.size > 1
-        total_weight = servers.inject(0) { |memo, srv| memo + srv.weight }
-        continuum = []
-        servers.each do |server|
-          entry_count_for(server, servers.size, total_weight).times do |idx|
-            hash = Digest::SHA1.hexdigest("#{server.name}:#{idx}")
-            value = Integer("0x#{hash[0..7]}")
-            continuum << Dalli::Ring::Entry.new(value, server)
-          end
-        end
-        @continuum = continuum.sort_by(&:value)
-      end
+      @continuum = build_continuum(servers) if servers.size > 1
 
       threadsafe! unless options[:threadsafe] == false
       @failover = options[:failover] != false
     end
 
     def server_for_key(key)
-      if @continuum
-        hkey = hash_for(key)
-        20.times do |try|
-          # Find the closest index in the Ring with value <= the given value
-          entryidx = @continuum.bsearch_index { |entry| entry.value > hkey }
-          if entryidx.nil?
-            entryidx = @continuum.size - 1
-          else
-            entryidx -= 1
-          end
-          server = @continuum[entryidx].server
-          return server if server.alive?
-          break unless @failover
-          hkey = hash_for("#{try}#{key}")
-        end
-      else
-        server = @servers.first
-        return server if server&.alive?
+      server = if @continuum
+                 server_from_continuum(key)
+               else
+                 @servers.first
+               end
+
+      # Note that the call to alive? has the side effect of initializing
+      # the socket
+      return server if server&.alive?
+
+      raise Dalli::RingError, 'No server available'
+    end
+
+    def server_from_continuum(key)
+      hkey = hash_for(key)
+      20.times do |try|
+        server = server_for_hash_key(hkey)
+
+        # Note that the call to alive? has the side effect of initializing
+        # the socket
+        return server if server.alive?
+        break unless @failover
+
+        hkey = hash_for("#{try}#{key}")
       end
+      nil
+    end
 
-      raise Dalli::RingError, "No server available"
+    def keys_grouped_by_server(key_arr)
+      key_arr.group_by do |key|
+        server_for_key(key)
+      rescue Dalli::RingError
+        Dalli.logger.debug { "unable to get key #{key}" }
+        nil
+      end
     end
 
     def lock
@@ -62,6 +79,23 @@ module Dalli
       end
     end
 
+    def pipeline_consume_and_ignore_responses
+      @servers.each do |s|
+        s.request(:noop)
+      rescue Dalli::NetworkError
+        # Ignore this error, as it indicates the socket is unavailable
+        # and there's no need to flush
+      end
+    end
+
+    def socket_timeout
+      @servers.first.socket_timeout
+    end
+
+    def close
+      @servers.each(&:close)
+    end
+
     private
 
     def threadsafe!
@@ -78,9 +112,35 @@ module Dalli
       ((total_servers * POINTS_PER_SERVER * server.weight) / Float(total_weight)).floor
     end
 
+    def server_for_hash_key(hash_key)
+      # Find the closest index in the Ring with value <= the given value
+      entryidx = @continuum.bsearch_index { |entry| entry.value > hash_key }
+      if entryidx.nil?
+        entryidx = @continuum.size - 1
+      else
+        entryidx -= 1
+      end
+      @continuum[entryidx].server
+    end
+
+    def build_continuum(servers)
+      continuum = []
+      total_weight = servers.inject(0) { |memo, srv| memo + srv.weight }
+      servers.each do |server|
+        entry_count_for(server, servers.size, total_weight).times do |idx|
+          hash = Digest::SHA1.hexdigest("#{server.name}:#{idx}")
+          value = Integer("0x#{hash[0..7]}")
+          continuum << Dalli::Ring::Entry.new(value, server)
+        end
+      end
+      continuum.sort_by(&:value)
+    end
+
+    ##
+    # Represents a point in the consistent hash ring implementation.
+    ##
     class Entry
-      attr_reader :value
-      attr_reader :server
+      attr_reader :value, :server
 
       def initialize(val, srv)
         @value = val

data/lib/dalli/server.rb

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-module Dalli
-  warn "Dalli::Server is deprecated, use Dalli::Protocol::Binary instead"
+module Dalli # rubocop:disable Style/Documentation
+  warn 'Dalli::Server is deprecated, use Dalli::Protocol::Binary instead'
   Server = Protocol::Binary
 end