daily_affirmation 0.3.4 → 0.3.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: f4ecd8c16b9ba58d859435a2411832db38da7bba
-  data.tar.gz: ae497ebd542784fadc5f2ebc55545cfd2efd1599
+  metadata.gz: 6a022e692ab6c6153908145526ce9b632fd7d5e0
+  data.tar.gz: a0c8602cf2068f7ce3ae72785311ba18ee39622a
 SHA512:
-  metadata.gz: e2122846d1b00cc97b10f25a67f219306dd966813cd91610aed6af041f80b0c2faf8d2c6bf39564471bebf56caf4dc0821a5bdfd42140261d566e0b81564bce2
-  data.tar.gz: 7875f55e1ca8cdefee943e2619d847ebe510c4b9e5fb2fffcf1120a462a3d65bb1949a0461494a1a252456eebda743f4caa40f1d9cb832549d3061a5f7496260
+  metadata.gz: d754e83e8cd50bebae51e08a48d0725f7d0e4cd9cf5176f2ee11830a0f17805800e083138ba6b9947170acecbbd10f0409f8596d6fe91a0df16319ef131b8906
+  data.tar.gz: 2065b6b3846a6511f4cbdbaf203b31f4189660ab11970385c15fc4d91ebf92486d936ad7fff57eb9baec6a94b9a6e54c905a49599e35ec10073ab661fc4494cc

data/lib/daily_affirmation/validators/numericality_validator.rb

@@ -4,7 +4,7 @@ module DailyAffirmation
   module Validators
     class NumericalityValidator < Validator
       def valid?
-        @valid ||= numeric? && greater_than? && less_than?
+        @valid ||= value ? numeric? && greater_than? && less_than? : true
       end
 
       def error_message
@@ -16,23 +16,23 @@ module DailyAffirmation
       private
 
       def numeric?
-        value.is_a?(Numeric)
+        @numeric ||= value.is_a?(Numeric)
       end
 
       def greater_than?
-        if gt = opts[:greater_than]
-          value > gt
-        else
-          true
-        end
+        @greater_than ||= if numeric? && gt = opts[:greater_than]
+                            value > gt
+                          else
+                            true
+                          end
       end
 
       def less_than?
-        if lt = opts[:less_than]
-          value < lt
-        else
-          true
-        end
+        @less_than ||= if numeric? && lt = opts[:less_than]
+                         value < lt
+                       else
+                         true
+                       end
       end
 
       def default_error_message

data/lib/daily_affirmation/version.rb

@@ -1,3 +1,3 @@
 module DailyAffirmation
-  VERSION = "0.3.4"
+  VERSION = "0.3.5"
 end

data/spec/validators/numericality_validator_spec.rb

@@ -4,6 +4,13 @@ require_relative "../../lib/daily_affirmation/validators/numericality_validator"
 describe "NumericalityValidator" do
   subject { DailyAffirmation::Validators::NumericalityValidator }
 
+  it "passes validation if the arribute is nil" do
+    obj = double(:age => nil)
+
+    validator = subject.new(obj, :age)
+    expect(validator).to be_valid
+  end
+
   it "passes validation if the attribute is a Numeric" do
     obj = double(:age => 1.0)
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: daily_affirmation
 version: !ruby/object:Gem::Version
-  version: 0.3.4
+  version: 0.3.5
 platform: ruby
 authors:
 - Shane Emmons