daigaku 0.3.0 → 0.4.0

data/spec/daigaku/unit_spec.rb

@@ -1,85 +1,82 @@
 require 'spec_helper'
 
 describe Daigaku::Unit do
-
   it { is_expected.to respond_to :title }
   it { is_expected.to respond_to :task }
   it { is_expected.to respond_to :solution }
   it { is_expected.to respond_to :reference_solution }
   it { is_expected.to respond_to :mastered? }
 
-  let(:course_name) { course_dir_names.first }
+  let(:course_name)  { course_dir_names.first }
   let(:chapter_name) { chapter_dir_names.first }
-  let(:unit_name) { unit_dir_names.first }
+  let(:unit_name)    { unit_dir_names.first }
 
   subject { Daigaku::Unit.new(unit_dirs(course_name).first[0]) }
 
-  it "has the prescribed title" do
+  it 'has the prescribed title' do
     expect(subject.title).to eq unit_titles.first
   end
 
-  describe "#task" do
-    it "returns an object of type Daigaku::Task" do
+  describe '#task' do
+    it 'returns an object of type Daigaku::Task' do
       expect(subject.task).to be_a Daigaku::Task
     end
 
-    it "returns the unit's appropriate task" do
+    it 'returns the unit’s appropriate task' do
       task = available_task(course_name, chapter_name, unit_name).first
       expect(subject.task.markdown).to eq task.markdown
     end
 
-    it "lazy-loads the task" do
+    it 'lazy-loads the task' do
       expect(subject.instance_variable_get(:@task)).to be_nil
       subject.task
       expect(subject.instance_variable_get(:@task)).not_to be_nil
     end
   end
 
-  describe "#reference_solution" do
-    it "returns an object of type Daigaku::ReferenceSolution" do
+  describe '#reference_solution' do
+    it 'returns an object of type Daigaku::ReferenceSolution' do
       expect(subject.reference_solution).to be_a Daigaku::ReferenceSolution
     end
 
-    it "returns the units appropriate predefined reference solution" do
-      reference_solution = available_reference_solution(course_name,
-                                                        chapter_name,
-                                                        unit_name).first
+    it 'returns the units appropriate predefined reference solution' do
+      names = [course_name, chapter_name, unit_name]
+      reference_solution = available_reference_solution(*names).first
       expect(subject.reference_solution.code).to eq reference_solution.code
     end
 
-    it "lazy-loads the reference solution" do
+    it 'lazy-loads the reference solution' do
       expect(subject.instance_variable_get(:@reference_solution)).to be_nil
       subject.reference_solution
       expect(subject.instance_variable_get(:@reference_solution)).not_to be_nil
     end
   end
 
-  describe "#solution" do
-    it "returns an object of type Daigaku::Solution" do
+  describe '#solution' do
+    it 'returns an object of type Daigaku::Solution' do
       expect(subject.solution).to be_a Daigaku::Solution
     end
 
-    it "returns the units appropriate solution provided by the user" do
-      expect(subject.solution.code).to eq available_solution(course_name,
-                                                             chapter_name,
-                                                             unit_name).code
+    it 'returns the units appropriate solution provided by the user' do
+      code = available_solution(course_name, chapter_name, unit_name).code
+      expect(subject.solution.code).to eq code
     end
 
-    it "lazy-loads the reference solution" do
+    it 'lazy-loads the reference solution' do
       expect(subject.instance_variable_get(:@solution)).to be_nil
       subject.solution
       expect(subject.instance_variable_get(:@solution)).not_to be_nil
     end
   end
 
-  describe "#mastered?" do
-    it "returns false by default" do
-      expect(subject.mastered?).to be_falsey
+  describe '#mastered?' do
+    it 'returns false by default' do
+      expect(subject.mastered?).to be false
     end
 
-    it "returns true if the solution has been verified" do
+    it 'returns true if the solution has been verified' do
       allow_any_instance_of(Daigaku::Solution).to receive(:verified?) { true }
-      expect(subject.mastered?).to be_truthy
+      expect(subject.mastered?).to be true
     end
   end
 end

data/spec/daigaku/views/chapters_menu_spec.rb

@@ -1,6 +1,5 @@
 require 'spec_helper'
 
 describe Daigaku::Views::ChaptersMenu, type: :view do
-
   it { is_expected.to be_a Daigaku::Views::Menu }
 end

data/spec/daigaku/views/courses_menu_spec.rb

@@ -1,6 +1,5 @@
 require 'spec_helper'
 
 describe Daigaku::Views::CoursesMenu, type: :view do
-
   it { is_expected.to be_a Daigaku::Views::Menu }
 end

data/spec/daigaku/views/menu_spec.rb

@@ -1,7 +1,6 @@
 require 'spec_helper'
 
 describe Daigaku::Views::Menu do
-
   it { is_expected.to respond_to :enter }
   it { is_expected.to respond_to :reenter }
 
@@ -16,4 +15,4 @@ describe Daigaku::Views::Menu do
       expect(subject.protected_methods).to include(method)
     end
   end
-end
+end

data/spec/daigaku/views/task_view_spec.rb

@@ -1,7 +1,5 @@
 require 'spec_helper'
 
 describe Daigaku::Views::TaskView, type: :view do
-
   it { is_expected.to respond_to :enter }
-
 end

data/spec/daigaku/views/units_menu_spec.rb

@@ -1,6 +1,5 @@
 require 'spec_helper'
 
 describe Daigaku::Views::UnitsMenu, type: :view do
-
   it { is_expected.to be_a Daigaku::Views::Menu }
 end

data/spec/daigaku/views_spec.rb

@@ -1,7 +1,6 @@
 require 'spec_helper'
 
 describe Daigaku::Views do
-
   subject do
     class Test
       include Daigaku::Views

data/spec/daigaku_spec.rb

@@ -1,28 +1,25 @@
 require 'spec_helper'
 
-describe "Daigaku module" do
-
-  describe "::config" do
-
+describe 'Daigaku module' do
+  describe '.config' do
     subject { Daigaku.config }
 
     [:config, :configure, :start].each do |method|
-      it "responds to ::#{method}" do
+      it "responds to .#{method}" do
         expect(Daigaku.singleton_methods).to include method
       end
     end
 
-    it "returns Configuration of class Daigaku::Configuration" do
+    it 'returns Configuration of class Daigaku::Configuration' do
       expect(subject).to be_an_instance_of Daigaku::Configuration
     end
 
-    it "returns a singleton setting" do
+    it 'returns a singleton setting' do
       expect(subject).to be Daigaku.config
     end
   end
 
-  describe "::configure" do
-
+  describe '.configure' do
     let(:configure) do
       proc do
         Daigaku.configure do |config|
@@ -31,16 +28,16 @@ describe "Daigaku module" do
       end
     end
 
-    it "allows to configure the app" do
+    it 'allows to configure the app' do
       expect { configure.call }.not_to raise_error
     end
 
-    it "sets configutation properties" do
+    it 'sets configuration properties' do
       configure.call
       expect(Daigaku.config.solutions_path).to eq test_basepath
     end
 
-    it "allows to change the config during runtime" do
+    it 'allows to change the config during runtime' do
       Daigaku.configure do |config|
         config.solutions_path = courses_basepath
       end

data/spec/path_helpers_spec.rb

@@ -1,28 +1,27 @@
 require 'spec_helper'
 
-describe "PathHelpers" do
-
-  it "provides a temp base path" do
+describe 'PathHelpers' do
+  it 'provides a temp base path' do
     puts "\n* temp base path:"
     puts temp_basepath
   end
 
-  it "provides a test base path" do
+  it 'provides a test base path' do
     puts "\n* test base path:"
     puts test_basepath
   end
 
-  it "provides a courses base path" do
+  it 'provides a courses base path' do
     puts "\n* courses base path:"
     puts courses_basepath
   end
 
-  it "provides the course directories" do
+  it 'provides the course directories' do
     puts "\n* course dirs:"
     puts course_dirs
   end
 
-  it "provides each course's chapter directories" do
+  it 'provides each course’s chapter directories' do
     puts "\n* chapter dirs: "
 
     course_dir_names.each do |course_name|
@@ -30,7 +29,7 @@ describe "PathHelpers" do
     end
   end
 
-  it "provides each chapter's unit directories" do
+  it 'provides each chapter’s unit directories' do
     puts "\n* unit dirs:"
 
     course_dir_names.each do |course_name|
@@ -38,22 +37,22 @@ describe "PathHelpers" do
     end
   end
 
-  it "provides all unit directories as flattened array" do
+  it 'provides all unit directories as flattened array' do
     puts "\n* all unit dirs:"
     puts all_unit_dirs
   end
 
-  it "provides all solution file paths" do
+  it 'provides all solution file paths' do
     puts "\n* all solution file paths:"
     puts all_solution_file_paths
   end
 
-  it "provides all test file paths" do
+  it 'provides all test file paths' do
     puts "\n* all test file paths:"
     puts all_test_file_paths
   end
 
-  it "provides the local_storage_file path" do
+  it 'provides the local_storage_file path' do
     puts "\n* local storage file path:"
     puts local_storage_file
   end

data/spec/resource_helpers_spec.rb

@@ -1,33 +1,32 @@
 require 'spec_helper'
 
-describe "ResourceHelpers" do
-
+describe 'ResourceHelpers' do
   let(:course) { course_dir_names.first }
   let(:chapter) { chapter_dir_names.first }
   let(:unit) { unit_dir_names.first }
 
-  it "provides the available courses" do
+  it 'provides the available courses' do
     puts "\n* available courses:"
-    puts available_courses.map &:inspect
+    puts available_courses.map(&:inspect)
   end
 
-  it "provides a course's available chapters" do
+  it 'provides a course’s available chapters' do
     puts "\n* available chapters:"
-    puts available_chapters(course).map &:inspect
+    puts available_chapters(course).map(&:inspect)
   end
 
-  it "provides a chapter's avaliable units" do
+  it 'provides a chapter’s avaliable units' do
     puts "\n* available units:"
-    puts available_units(course, chapter).map &:inspect
+    puts available_units(course, chapter).map(&:inspect)
   end
 
-  it "provides a unit's task file" do
+  it 'provides a unit’s task file' do
     puts "\n* task:"
-    puts available_task(course, chapter, unit).map &:inspect
+    puts available_task(course, chapter, unit).map(&:inspect)
   end
 
-  it "provides a unit's reference solution file" do
+  it 'provides a unit’s reference solution file' do
     puts "\n* reference solution:"
-    puts available_reference_solution(course, chapter, unit).map &:inspect
+    puts available_reference_solution(course, chapter, unit).map(&:inspect)
   end
 end

data/spec/spec_helper.rb

@@ -3,9 +3,8 @@ require 'webmock/rspec'
 
 def require_files_from(paths = [])
   paths.each do |path|
-    Dir[File.join(File.expand_path("#{path}*.rb", __FILE__))].sort.each do |file|
-      require file
-    end
+    files = Dir[File.join(File.expand_path("#{path}*.rb", __FILE__))].sort
+    files.each { |file| require file }
   end
 end
 
@@ -13,7 +12,7 @@ RSpec.configure do |config|
   config.color = true
 
   require File.expand_path('../../lib/daigaku', __FILE__)
-  require_files_from ["../support/**/"]
+  require_files_from ['../support/**/']
 
   config.include TestHelpers
 

data/spec/support/macros/content_helpers.rb

@@ -1,13 +1,13 @@
 module ContentHelpers
-
   TASK_FILE_CONTENT = [
-    "Heading\n======", "##Task",
-    "Solve this task!",
-    "##Hints",
-    "Just do it right..."
-  ].join("\n\n")
+    "Heading\n======",
+    '##Task',
+    'Solve this task!',
+    '##Hints',
+    'Just do it right...'
+  ].join("\n\n").freeze
 
-  SOLUTION_CONTENT = 'print "hello world".upcase'
+  SOLUTION_CONTENT = 'print "hello world".upcase'.freeze
 
   TEST_CONTENT = [
     "require 'rspec'\n",
@@ -20,12 +20,12 @@ module ContentHelpers
     "    allow(self).to receive(:print).and_return ''",
     "    expect_any_instance_of(String).to receive(:upcase).and_return('HELLO WORLD')\n",
     "    [['solution::code']]",
-    "  end",
-    "end"
-    ].join("\n")
+    '  end',
+    'end'
+  ].join("\n").freeze
 
   TEST_FAILED_JSON =
-    %Q#
+    '
       { "examples":
         [
           { "description": "description 1",
@@ -56,10 +56,10 @@ module ContentHelpers
       },
       "summary_line": "2 example, 1 failure"
     }
-  #
+  '.freeze
 
   TEST_PASSED_JSON =
-    %Q#
+    '
       { "examples":
         [
           { "description":"description 1",
@@ -85,10 +85,10 @@ module ContentHelpers
         },
         "summary_line":"2 example, 0 failures"
       }
-    #
+    '.freeze
 
-  TEST_PASSED_MESSAGE = "Your code passed all tests."
-  EXAMPLE_PASSED_MESSAGE = "Your code passed this requirement."
+  TEST_PASSED_MESSAGE    = 'Your code passed all tests.'.freeze
+  EXAMPLE_PASSED_MESSAGE = 'Your code passed this requirement.'.freeze
 
   def task_file_content
     TASK_FILE_CONTENT
@@ -125,5 +125,4 @@ module ContentHelpers
   def example_passed_message
     EXAMPLE_PASSED_MESSAGE
   end
-
 end

data/spec/support/macros/mock_helpers.rb

@@ -1,5 +1,4 @@
 module MockHelpers
-
   def mock_default_window
     allow_any_instance_of(described_class).to receive(:default_window) { true }
   end
@@ -16,10 +15,11 @@ module MockHelpers
   end
 
   def suppress_print_out
-    allow(described_class).to receive(:say_warning) {}
-    allow(described_class).to receive(:say_info) {}
-    allow(described_class).to receive(:say) {}
-    allow($stdout).to receive(:puts) {}
-    allow($stdout).to receive(:print) {}
+    allow(described_class).to receive(:say_warning)
+    allow(described_class).to receive(:say_info)
+    allow(described_class).to receive(:say)
+
+    allow($stdout).to receive(:puts)
+    allow($stdout).to receive(:print)
   end
 end