dag_me 0.3.0 → 0.4.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: f9afbe234f1c36638c4a965eae2c76bfd93ffbc259b6f57fcf9c7ff57688176d
-  data.tar.gz: e50691a084e46d40e800f51635d7e1ab07e98fb865324a784a6ad88d51ccb93d
+  metadata.gz: 535847d509f0a7d65eb13927c894086c021addbc89017257bec5a41af5c0a547
+  data.tar.gz: 3c50f1a759fdbfb225897ee76cf1753073a2b24d1e3b6fa32f9c312b7cd3a7ae
 SHA512:
-  metadata.gz: b6a321babe86ba1529efb4e30bfa742f2149e40d42cf9971c78b15810783eb425f7ba9d45b31d4def9a4a39e4f024f566f12d49dd52a8f30c2a3968c96134e16
-  data.tar.gz: 0b43392262483e5691e449c6eba57b7517e4649db776a5b6e29b50a1ca9868be83849f8297e69e47c564dd4988af127feead3c70978ffe7c3c92e3ea8949e25d
+  metadata.gz: fdfb3514a36b5b892296b87113f04151881823f8102337f061425640252673b23e2ab3169cbaa2153dba09aedda4ce2fdf1b585b2f085e85492c100cc458db45
+  data.tar.gz: 489c29e4aaa52a208ca00f1df5766ef784e2e5e40597b155c3e8adc9ea60cef83a520318fc7957a12c534db4f036d1e903918295c0185f13eb3d99232fb5e987

data/README.md

@@ -150,6 +150,15 @@ end
 Generated tables (`orbital.station_dag_edges`, `orbital.station_dag_paths`) and
 functions land in the node table's schema; trigger names stay plain identifiers.
 
+Long table names would push generated identifiers past PostgreSQL's 63-byte
+limit; pass a custom prefix instead of letting it truncate:
+
+```ruby
+class MaterialTracking::ProductBillOfMaterial < ApplicationRecord
+  dag_me prefix: 'bom_dag'   # bom_dag_edges, bom_dag_paths, bom_dag_lock, ...
+end
+```
+
 ## Multi-tenancy
 
 ```ruby

data/lib/dag_me/configuration.rb

@@ -6,7 +6,8 @@ module DagMe
 
     attr_reader :model, :name, :maintain, :prefix, :schema, :edge_table, :paths_table, :scope_columns
 
-    def initialize(model:, name: nil, maintain: :postgresql_closure, scope: nil, edge_table: nil, paths_table: nil)
+    def initialize(model:, name: nil, maintain: :postgresql_closure, scope: nil, prefix: nil,
+                   edge_table: nil, paths_table: nil)
       unless MAINTAIN_MODES.include?(maintain)
         raise ArgumentError, "maintain must be one of #{MAINTAIN_MODES.inspect}, got #{maintain.inspect}"
       end
@@ -19,9 +20,12 @@ module DagMe
       # identifier - trigger and temp-table names cannot carry a schema - and
       # place generated tables and functions in the node table's schema.
       @schema, base_table = split_schema(model.table_name)
-      @prefix = [base_table.singularize, @name, 'dag'].compact.join('_')
-      @edge_table = edge_table || qualify("#{prefix}_edges")
-      @paths_table = paths_table || qualify("#{prefix}_paths")
+      # A custom prefix keeps generated identifiers under PostgreSQL's 63-byte
+      # limit when the derived one (long table names) would silently truncate.
+      @prefix = prefix&.to_s || [base_table.singularize, @name, 'dag'].compact.join('_')
+      validate_prefix!
+      @edge_table = edge_table || qualify("#{@prefix}_edges")
+      @paths_table = paths_table || qualify("#{@prefix}_paths")
       # Ivar peek keeps class load DB-free; composite keys must be declared
       # before the macro. Array === because AR seeds a BasicObject sentinel.
       @composite_pk = model.instance_variable_defined?(:@primary_key) &&
@@ -137,6 +141,21 @@ module DagMe
 
     private
 
+    # The longest generated suffix is "_edge_insert_check" (18 bytes); reject
+    # prefixes whose identifiers PostgreSQL would silently truncate at 63.
+    def validate_prefix!
+      unless /\A[a-z_][a-z0-9_]*\z/.match?(@prefix)
+        raise ArgumentError, "prefix must be a lowercase SQL identifier, got #{@prefix.inspect}"
+      end
+
+      max = 63 - '_edge_insert_check'.length
+      return if @prefix.length <= max
+
+      raise ArgumentError,
+            "prefix #{@prefix.inspect} is #{@prefix.length} bytes; identifiers would exceed " \
+            "PostgreSQL's 63-byte limit (max prefix: #{max}). Pass dag_me prefix: '...' with a shorter name."
+    end
+
     def split_schema(table_name)
       return table_name.split('.', 2) if table_name.include?('.')
 

data/lib/dag_me/ddl.rb

@@ -76,6 +76,16 @@ module DagMe
       statements
     end
 
+    # Graph#backfill_self_rows! reuses this to repair nodes inserted with
+    # triggers disabled (e.g. Rails fixture loading).
+    def backfill_self_rows_sql
+      <<~SQL
+        INSERT INTO #{config.paths_table} (#{list(anc_cols)}, #{list(desc_cols)}, min_depth, path_count#{scope_column_list})
+        SELECT #{list(pk_cols)}, #{list(pk_cols)}, 0, 1#{scope_column_list} FROM #{config.node_table}
+        ON CONFLICT DO NOTHING;
+      SQL
+    end
+
     def uninstall_sql
       [
         "DROP TRIGGER IF EXISTS #{config.trigger_name('node_insert')} ON #{config.node_table};",
@@ -489,14 +499,6 @@ module DagMe
       SQL
     end
 
-    def backfill_self_rows_sql
-      <<~SQL
-        INSERT INTO #{config.paths_table} (#{list(anc_cols)}, #{list(desc_cols)}, min_depth, path_count#{scope_column_list})
-        SELECT #{list(pk_cols)}, #{list(pk_cols)}, 0, 1#{scope_column_list} FROM #{config.node_table}
-        ON CONFLICT DO NOTHING;
-      SQL
-    end
-
     def truth_walk_sql
       <<~SQL.chomp
         WITH RECURSIVE walk(#{list(anc_cols)}, #{list(desc_cols)}, depth) AS (

data/lib/dag_me/graph.rb

@@ -56,6 +56,18 @@ module DagMe
       self
     end
 
+    # Restores missing self-rows for nodes inserted with triggers disabled -
+    # Rails fixture loading wraps inserts in disable_referential_integrity,
+    # which skips the node_insert trigger. Idempotent; meant for test setups.
+    def backfill_self_rows!
+      return self unless config.closure?
+
+      model.connection_pool.with_connection do |conn|
+        conn.execute(DDL.new(config).backfill_self_rows_sql)
+      end
+      self
+    end
+
     # Rows where the stored closure disagrees with the recursive-CTE truth.
     # Empty means healthy.
     def validate

data/lib/dag_me/macro.rb

@@ -14,7 +14,7 @@ module DagMe
     #   relay.add_child(other, dag: :power)
     #   relay.comms_children
     #   Relay.dag(:power).rebuild!
-    def dag_me(name = nil, maintain: :postgresql_closure, scope: nil, edge_table: nil, paths_table: nil)
+    def dag_me(name = nil, maintain: :postgresql_closure, scope: nil, prefix: nil, edge_table: nil, paths_table: nil)
       key = name&.to_sym || :default
       unless include?(DagMe::Model)
         class_attribute :dag_configs, instance_writer: false, instance_predicate: false, default: {}.freeze
@@ -22,7 +22,7 @@ module DagMe
       end
       raise ArgumentError, "#{self.name}: dag #{key.inspect} is already defined" if dag_configs.key?(key)
 
-      config = Configuration.new(model: self, name: name&.to_sym, maintain:, scope:, edge_table:, paths_table:)
+      config = Configuration.new(model: self, name: name&.to_sym, maintain:, scope:, prefix:, edge_table:, paths_table:)
       self.dag_configs = dag_configs.merge(key => config).freeze
       DagMe::Model.attach(self, config)
       self

data/lib/dag_me/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module DagMe
-  VERSION = '0.3.0'
+  VERSION = '0.4.1'
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: dag_me
 version: !ruby/object:Gem::Version
-  version: 0.3.0
+  version: 0.4.1
 platform: ruby
 authors:
 - Abdelkader Boudih