dag_me 0.2.0 → 0.4.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 700c8b25bcaadebf2b1d273e1d640585b0941a1b755e4e68b8b4cde46b4dcfc7
-  data.tar.gz: 17f8e047810f1fdcefedbf0717d34fab12482bdbc356a1391a999b31bf5988b9
+  metadata.gz: 74bbe571eab1c3286bee396dbe9516dff6de559e55ffe5a68bd9baa1c394db50
+  data.tar.gz: 9e7fce79faa9157888ef20fb3aef236e2a2f0da836d5b8aaa1fde56bb95a4097
 SHA512:
-  metadata.gz: 40c39bced539dbdab504c0f271d86dfb40efecdc28dde66f63077effd077fee53b303eb0e0e765ec32db000e9bfdaf59a415cd9db60f50ae98edf68545c50266
-  data.tar.gz: 047dd04b53fb61c367fca26038652e1bc4ca42984849565aec2ec45cf4917f94a8917cf829eec3bc36f4459c1941cd80f1d4209196afb793269343b962f8f6de
+  metadata.gz: 680138923ec2d8ff9e9dec8cc048211dc82576c412b2b38f68e4bf0eb28ff12c90beb64b70ca173b5c3d16e09acb241cf9631393f78c391b26c3fd0d646e86ae
+  data.tar.gz: 25a79cf7c541f8a03b680f22c110ebdc9b274c178c5fb5c9e95ffb1f7b5e0084a8c5a41ed7a6ef4494d358c02bf5edbefdca6530c98014130e99f1429d511041

data/README.md

@@ -150,6 +150,15 @@ end
 Generated tables (`orbital.station_dag_edges`, `orbital.station_dag_paths`) and
 functions land in the node table's schema; trigger names stay plain identifiers.
 
+Long table names would push generated identifiers past PostgreSQL's 63-byte
+limit; pass a custom prefix instead of letting it truncate:
+
+```ruby
+class MaterialTracking::ProductBillOfMaterial < ApplicationRecord
+  dag_me prefix: 'bom_dag'   # bom_dag_edges, bom_dag_paths, bom_dag_lock, ...
+end
+```
+
 ## Multi-tenancy
 
 ```ruby

data/lib/dag_me/configuration.rb

@@ -6,7 +6,8 @@ module DagMe
 
     attr_reader :model, :name, :maintain, :prefix, :schema, :edge_table, :paths_table, :scope_columns
 
-    def initialize(model:, name: nil, maintain: :postgresql_closure, scope: nil, edge_table: nil, paths_table: nil)
+    def initialize(model:, name: nil, maintain: :postgresql_closure, scope: nil, prefix: nil,
+                   edge_table: nil, paths_table: nil)
       unless MAINTAIN_MODES.include?(maintain)
         raise ArgumentError, "maintain must be one of #{MAINTAIN_MODES.inspect}, got #{maintain.inspect}"
       end
@@ -19,9 +20,12 @@ module DagMe
       # identifier - trigger and temp-table names cannot carry a schema - and
       # place generated tables and functions in the node table's schema.
       @schema, base_table = split_schema(model.table_name)
-      @prefix = [base_table.singularize, @name, 'dag'].compact.join('_')
-      @edge_table = edge_table || qualify("#{prefix}_edges")
-      @paths_table = paths_table || qualify("#{prefix}_paths")
+      # A custom prefix keeps generated identifiers under PostgreSQL's 63-byte
+      # limit when the derived one (long table names) would silently truncate.
+      @prefix = prefix&.to_s || [base_table.singularize, @name, 'dag'].compact.join('_')
+      validate_prefix!
+      @edge_table = edge_table || qualify("#{@prefix}_edges")
+      @paths_table = paths_table || qualify("#{@prefix}_paths")
       # Ivar peek keeps class load DB-free; composite keys must be declared
       # before the macro. Array === because AR seeds a BasicObject sentinel.
       @composite_pk = model.instance_variable_defined?(:@primary_key) &&
@@ -137,6 +141,21 @@ module DagMe
 
     private
 
+    # The longest generated suffix is "_edge_insert_check" (18 bytes); reject
+    # prefixes whose identifiers PostgreSQL would silently truncate at 63.
+    def validate_prefix!
+      unless /\A[a-z_][a-z0-9_]*\z/.match?(@prefix)
+        raise ArgumentError, "prefix must be a lowercase SQL identifier, got #{@prefix.inspect}"
+      end
+
+      max = 63 - '_edge_insert_check'.length
+      return if @prefix.length <= max
+
+      raise ArgumentError,
+            "prefix #{@prefix.inspect} is #{@prefix.length} bytes; identifiers would exceed " \
+            "PostgreSQL's 63-byte limit (max prefix: #{max}). Pass dag_me prefix: '...' with a shorter name."
+    end
+
     def split_schema(table_name)
       return table_name.split('.', 2) if table_name.include?('.')
 

data/lib/dag_me/ddl.rb

@@ -175,10 +175,20 @@ module DagMe
       config.scope_columns.map { |c| "#{left}.#{c} IS DISTINCT FROM #{right}.#{c}" }.join(' OR ')
     end
 
+    # Honors PostgreSQLAdapter.create_unlogged_tables (Rails test-env speed
+    # setting): a logged table cannot FK-reference an unlogged node table.
+    def create_table_clause
+      if ActiveRecord::ConnectionAdapters::PostgreSQLAdapter.create_unlogged_tables
+        'CREATE UNLOGGED TABLE'
+      else
+        'CREATE TABLE'
+      end
+    end
+
     def edges_table_sql
       defs = (col_defs(parent_cols) + col_defs(child_cols)).map { |d| "  #{d}," }.join("\n")
       <<~SQL
-        CREATE TABLE #{config.edge_table} (
+        #{create_table_clause} #{config.edge_table} (
           id bigint GENERATED BY DEFAULT AS IDENTITY PRIMARY KEY,
         #{defs}
           created_at timestamptz NOT NULL DEFAULT now()#{scope_column_defs},
@@ -194,7 +204,7 @@ module DagMe
     def paths_table_sql
       defs = (col_defs(anc_cols) + col_defs(desc_cols)).map { |d| "  #{d}," }.join("\n")
       <<~SQL
-        CREATE TABLE #{config.paths_table} (
+        #{create_table_clause} #{config.paths_table} (
         #{defs}
           min_depth integer NOT NULL,
           path_count numeric NOT NULL#{scope_column_defs},

data/lib/dag_me/macro.rb

@@ -14,7 +14,7 @@ module DagMe
     #   relay.add_child(other, dag: :power)
     #   relay.comms_children
     #   Relay.dag(:power).rebuild!
-    def dag_me(name = nil, maintain: :postgresql_closure, scope: nil, edge_table: nil, paths_table: nil)
+    def dag_me(name = nil, maintain: :postgresql_closure, scope: nil, prefix: nil, edge_table: nil, paths_table: nil)
       key = name&.to_sym || :default
       unless include?(DagMe::Model)
         class_attribute :dag_configs, instance_writer: false, instance_predicate: false, default: {}.freeze
@@ -22,7 +22,7 @@ module DagMe
       end
       raise ArgumentError, "#{self.name}: dag #{key.inspect} is already defined" if dag_configs.key?(key)
 
-      config = Configuration.new(model: self, name: name&.to_sym, maintain:, scope:, edge_table:, paths_table:)
+      config = Configuration.new(model: self, name: name&.to_sym, maintain:, scope:, prefix:, edge_table:, paths_table:)
       self.dag_configs = dag_configs.merge(key => config).freeze
       DagMe::Model.attach(self, config)
       self

data/lib/dag_me/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module DagMe
-  VERSION = '0.2.0'
+  VERSION = '0.4.0'
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: dag_me
 version: !ruby/object:Gem::Version
-  version: 0.2.0
+  version: 0.4.0
 platform: ruby
 authors:
 - Abdelkader Boudih