czech_post_b2b_client 1.2.6 → 1.3.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 74fa378ca71040acf1adb94fb61fa1d371ae2491273b3585bed2ef14ce6911e8
-  data.tar.gz: efda7da207ddf3146be8181c4765f8cca645020131f3cda81e211fb5ff9ea828
+  metadata.gz: d3625c919136ebf4fa10070dee900b1491f19880a7cdc96c77cc5029e95ce09f
+  data.tar.gz: 4e66d3911f876a85215306b6ac21f6d2fc8629acae3aba75ca6b0a966af61468
 SHA512:
-  metadata.gz: 9752291d61873388331118b6167d212e40aab3ce344d0306f664ba245ac5e6515296dba98a97788b0604a39355a4514ac3d409b548d14e63efe3786f920cb627
-  data.tar.gz: 257ceece993bb225b3ec020667af0fab9c26edd0b2eb16c35d41c470f70c7b8377443da68dc7c057e9d1d237e4bc74743cf70a585a5ad7c6fe10152c86990a63
+  metadata.gz: f3b353230a9e87d89d81a093d970292001d357efb26dea1705d904c79061350eea2a7e3e38f843b6670604c0f6393877d07624059a1917d10fd3d3ecec93cb5c
+  data.tar.gz: ae7566f678cd5235daed64d53dac229f4a6352e44c303f88b9f39d29519416110e0f3faf042b46c7145dc9301da6e1208cd7fe9e373737f8530646eda859ff94

data/.rubocop.yml

@@ -2,6 +2,7 @@ require:
 # rubocop-minitest
 
 AllCops:
+  NewCops: enable
   Include:
     - "**/Gemfile"
     - "**/Rakefile"
@@ -12,7 +13,10 @@ AllCops:
     - "**/*.jb"
   Exclude:
     - "bin/*"
-Documentation:
+    - "documents/**/*"
+    - "test/fixtures/**/*"
+
+Style/Documentation:
   Enabled: false
 Layout/LineLength:
   Max: 140

data/CHANGELOG.md

@@ -2,6 +2,15 @@
 
 All changes to the gem are documented here.
 
+## [1.3.0] - 2022-04-07
+ - checked currently available  Print Templates codes
+ - enhanced address sheet printing with ability to print ZPL sheets (templates 200, 201 and 202).
+   Result of `AddressSheetGenerator` now have `pdf_content` and `zpl_content`.
+ - found new(?) API from Czech Post , see `documents/B2B-ZSKService-1.4.0.yaml` and https://www.ceskaposta.cz/napi/b2b.
+
+## [1.2.8] - 2022-03-22
+  - added new response codes
+
 ## [1.2.6] - 2020-10-27
 
  - fixed passing all errors from `parcelsServiceSync` response.

data/README.md

@@ -1,5 +1,11 @@
 
 # FRESH NEWS
+7.4.2022
+Finally there is some online documentation about nAPI of Czech post (https://www.ceskaposta.cz/napi/b2b)
+Not yet checked  if this is the same api we use or new one. Seems that authorization is different.
+
+
+26.8.2020
 After full usage in production (vyvolej.to, squared.one), we found that Czech POst have trouble with `parcelServiceSync` (maybe `sendParcels` too). When You try to register package with `:customs_documents`, you get `INVALID_BATCH` response with no error, but with `parcelCode`:
 ```
 <?xml version="1.0" encoding="UTF-8"?>

data/lib/czech_post_b2b_client/b2b_errors.rb

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-# rubocop:disable Style/AsciiComments, Layout/LineLength
+# rubocop:disable Layout/LineLength
 
 # response <B2BFaultMessage>
 # Chybový kód | Detail chyby            | Popis
@@ -36,10 +36,12 @@ module CzechPostB2bClient
       end
 
       def initialize(details = '')
+        super
         self.details = details
       end
 
       attr_accessor :details
+
       def code
         self.class.code
       end
@@ -108,4 +110,4 @@ module CzechPostB2bClient
   end
 end
 
-# rubocop:enable Style/AsciiComments, Layout/LineLength
+# rubocop:enable Layout/LineLength

data/lib/czech_post_b2b_client/configuration.rb

@@ -32,7 +32,7 @@ module CzechPostB2bClient
       }
 
       @language = :cs
-      @logger = defined?(Rails) ? ::Rails.logger : ::Logger.new(STDOUT)
+      @logger = defined?(Rails) ? ::Rails.logger : ::Logger.new($stdout)
       @b2b_api_base_uri = 'https://b2b.postaonline.cz/services/POLService/v1'
       @sending_post_office_location_number = 1
 

data/lib/czech_post_b2b_client/post_services.rb

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-# rubocop:disable Layout/LineLength, Style/AsciiComments
+# rubocop:disable Layout/LineLength
 
 # Hopefully complete list of services which can be assigned to parcels
 # It is hard to get list of current services and even harder to find out what does they mean (so You pick right name in English).
@@ -84,6 +84,7 @@ module CzechPostB2bClient
       @description = 'Cenný obsah'
       # ; Balík Do ruky (DR, DV, DE) ; Balík Na poštu (NP, NV) |
     end
+
     class EconomyDelivery < Base
       @code = '1K'
       @abbreviation = 'EK'
@@ -774,4 +775,4 @@ module CzechPostB2bClient
   end
 end
 
-# rubocop:enable Layout/LineLength, Style/AsciiComments
+# rubocop:enable Layout/LineLength

data/lib/czech_post_b2b_client/printing_templates.rb

@@ -1,7 +1,5 @@
 # frozen_string_literal: true
 
-# rubocop:disable Style/AsciiComments
-
 # Available printing templates, which can be used in AdressSheetsGenerator `options[:template_id]`
 #
 # Do not miss `CzechPostB2bClient::PrintingTemplates.all_classes` method,
@@ -11,6 +9,10 @@ module CzechPostB2bClient
     class Base
       class << self
         attr_reader :id, :description, :page_dimensions
+
+        def content_type
+          :pdf
+        end
       end
     end
 
@@ -134,12 +136,6 @@ module CzechPostB2bClient
       @page_dimensions = 'unverified'
     end
 
-    class CODVoucherForCSOB < Base
-      @id = 13
-      @description = 'Dobírková složenka ČSOB'
-      @page_dimensions = 'unverified'
-    end
-
     class RRLabels3x8 < Base
       @id = 26
       @description = 'štítky pro RR : 3x8'
@@ -177,29 +173,23 @@ module CzechPostB2bClient
         @page_dimensions = 'A5 landscape (210 × 148 mm)'
       end
 
-      class CN22FourOnPage < Base
-        @id = 74
-        @description = 'Celní prohlášení CN22 : 4x (A4)'
-        @page_dimensions = 'unverified A4'
-      end
-
-      class CN22WithCK < Base
-        @id = 75
-        @description = 'Celní prohlášení CN22 s ČK (A4)'
-        @page_dimensions = 'unverified A4'
-      end
-
-      class CN22WithCKFourOnPage < Base
-        @id = 76
-        @description = 'Celní prohlášení CN22 s ČK : 4x (A4)'
-        @page_dimensions = 'unverified A4'
-      end
-    end
-
-    class CN22FourOnPage < Base
-      @id = 74
-      @description = 'Celní prohlášení CN22 : 4x'
-      @page_dimensions = 'A4 portrait (210 × 297 mm)'
+      # class CN22FourOnPage < Base
+      #   @id = 74
+      #   @description = 'Celní prohlášení CN22 : 4x (A4)'
+      #   @page_dimensions = 'unverified A4'
+      # end
+
+      # class CN22WithCK < Base
+      #   @id = 75
+      #   @description = 'Celní prohlášení CN22 s ČK (A4)'
+      #   @page_dimensions = 'unverified A4'
+      # end
+
+      # class CN22WithCKFourOnPage < Base
+      #   @id = 76
+      #   @description = 'Celní prohlášení CN22 s ČK : 4x (A4)'
+      #   @page_dimensions = 'unverified A4'
+      # end
     end
 
     module HarmonizedLabel
@@ -234,20 +224,28 @@ module CzechPostB2bClient
         @description = 'Harmonizovaný štítek bianco - na výšku'
         @page_dimensions = 'A6 landscape (148 × 105 mm)'
       end
+    end
+
+    module ZebraLabel
+      class Base < CzechPostB2bClient::PrintingTemplates::Base
+        def self.content_type
+          :zpl
+        end
+      end
 
-      class ZebraBianco105x148 < Base
+      class Bianco105x148 < ZebraLabel::Base
         @id = 200
         @description = 'Harmonizovaný štítek bianco - (Zebra - 105x148); nejde o PDF'
         @page_dimensions = 'unverified 105 × 148 mm'
       end
 
-      class ZebraBianco100x150 < Base
+      class Bianco100x150 < ZebraLabel::Base
         @id = 201
         @description = 'Harmonizovaný štítek bianco - (Zebra - 100x150); nejde o PDF'
         @page_dimensions = 'unverified 100 × 150 mm'
       end
 
-      class ZebraBianco100x125 < Base
+      class Bianco100x125 < ZebraLabel::Base
         @id = 202
         @description = 'Harmonizovaný štítek bianco - (Zebra - 100x125); nejde o PDF'
         @page_dimensions = 'unverified 100 × 125 mm'
@@ -259,7 +257,12 @@ module CzechPostB2bClient
       base_class = CzechPostB2bClient::PrintingTemplates::Base
       ObjectSpace.each_object(base_class.singleton_class).reject { |c| c == base_class }
     end
+
+    def self.find(id)
+      klass = all_classes.detect { |k| k.id == id }
+      raise "PrintingTemplate with id: #{id}  is unknown!" unless klass
+
+      klass
+    end
   end
 end
-
-# rubocop:enable Style/AsciiComments

data/lib/czech_post_b2b_client/request_builders/base_builder.rb

@@ -10,6 +10,7 @@ module CzechPostB2bClient
       TIME_FORMAT = '%FT%T.%L%:z' # '2014-03-12T13:33:34.573+01:00'
 
       def initialize(request_id: 1)
+        super()
         @request_id = request_id
       end
 

data/lib/czech_post_b2b_client/request_builders/get_parcel_state_builder.rb

@@ -6,6 +6,7 @@ module CzechPostB2bClient
       attr_reader :parcel_codes
 
       def initialize(parcel_codes:, request_id: 1)
+        super()
         @parcel_codes = parcel_codes
         @request_id = request_id
       end

data/lib/czech_post_b2b_client/request_builders/get_parcels_printing_builder.rb

@@ -6,6 +6,7 @@ module CzechPostB2bClient
       attr_reader :parcel_codes, :options
 
       def initialize(parcel_codes:, options:, request_id: 1)
+        super()
         @parcel_codes = parcel_codes
         @options = options
         @request_id = request_id

data/lib/czech_post_b2b_client/request_builders/get_result_parcels_builder.rb

@@ -6,6 +6,7 @@ module CzechPostB2bClient
       attr_reader :transaction_id
 
       def initialize(transaction_id:, request_id: 1)
+        super()
         @transaction_id = transaction_id
         @request_id = request_id
       end

data/lib/czech_post_b2b_client/request_builders/get_stats_builder.rb

@@ -6,6 +6,7 @@ module CzechPostB2bClient
       attr_reader :from_date, :to_date
 
       def initialize(from_date:, to_date:, request_id: 1)
+        super()
         @from_date = from_date.to_time
         @to_date = to_date.to_time
         @request_id = request_id

data/lib/czech_post_b2b_client/request_builders/parcel_service_sync_builder.rb

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-# rubocop:disable Layout/LineLength, Style/AsciiComments
+# rubocop:disable Layout/LineLength
 
 module CzechPostB2bClient
   module RequestBuilders
@@ -8,6 +8,7 @@ module CzechPostB2bClient
       attr_reader :common_data, :parcel
 
       def initialize(common_data:, parcel:, request_id: 1)
+        super()
         @common_data = common_data
         @parcel = parcel
         @request_id = request_id
@@ -207,7 +208,7 @@ module CzechPostB2bClient
           add_element_to(do_parcel_address, 'ns2:custCardNum', value: addressee_data[:custom_card_number]) # Nepovinne: cislo zakaznicke karty
 
           (addressee_data[:advice_informations] || []).each_with_index do |adv_info, index|
-            add_element_to(do_parcel_address, 'ns2:adviceInformation' + (index + 1).to_s, value: adv_info) # Nepovinne: Informace 1- 6 k dodejce
+            add_element_to(do_parcel_address, "ns2:adviceInformation#{index + 1}", value: adv_info) # Nepovinne: Informace 1- 6 k dodejce
           end
           add_element_to(do_parcel_address, 'ns2:adviceNote', value: addressee_data[:advice_note]) # Nepovinne: Poznamka k dodejce
         end
@@ -258,7 +259,7 @@ module CzechPostB2bClient
       def add_bank_elements(parent_element, bank_account)
         return if bank_account.to_s == ''
 
-        if (m = bank_account.match(%r{(?:(\d+)-)?(\d+)\/(\d+)}))
+        if (m = bank_account.match(%r{(?:(\d+)-)?(\d+)/(\d+)}))
           prefix = m[1]
           account = m[2]
           bank = m[3]
@@ -284,4 +285,4 @@ module CzechPostB2bClient
   end
 end
 
-# rubocop:enable Layout/LineLength, Style/AsciiComments
+# rubocop:enable Layout/LineLength

data/lib/czech_post_b2b_client/request_builders/send_parcels_builder.rb

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-# rubocop:disable Layout/LineLength, Style/AsciiComments
+# rubocop:disable Layout/LineLength
 
 module CzechPostB2bClient
   module RequestBuilders
@@ -8,6 +8,7 @@ module CzechPostB2bClient
       attr_reader :common_data, :parcels
 
       def initialize(common_data:, parcels:, request_id: 1)
+        super()
         @common_data = common_data
         @parcels = parcels
         @request_id = request_id
@@ -225,7 +226,7 @@ module CzechPostB2bClient
           add_element_to(do_parcel_address, 'ns2:custCardNum', value: addressee_data[:custom_card_number]) # Nepovinne: cislo zakaznicke karty
 
           (addressee_data[:advice_informations] || []).each_with_index do |adv_info, index|
-            add_element_to(do_parcel_address, 'ns2:adviceInformation' + (index + 1).to_s, value: adv_info) # Nepovinne: Informace 1- 6 k dodejce
+            add_element_to(do_parcel_address, "ns2:adviceInformation#{index + 1}", value: adv_info) # Nepovinne: Informace 1- 6 k dodejce
           end
           add_element_to(do_parcel_address, 'ns2:adviceNote', value: addressee_data[:advice_note]) # Nepovinne: Poznamka k dodejce
         end
@@ -263,9 +264,7 @@ module CzechPostB2bClient
         return if address_data.nil?
 
         address_tags_and_values(address_data).each_pair do |xml_tag, value|
-          unless without.include?(xml_tag)
-            add_element_to(parent_element, xml_tag, value: value) unless value.nil?
-          end
+          add_element_to(parent_element, xml_tag, value: value) if !without.include?(xml_tag) && !value.nil?
         end
       end
 
@@ -289,7 +288,7 @@ module CzechPostB2bClient
       def add_bank_elements(parent_element, bank_account)
         return if bank_account.to_s == ''
 
-        if (m = bank_account.match(%r{(?:(\d+)-)?(\d+)\/(\d+)}))
+        if (m = bank_account.match(%r{(?:(\d+)-)?(\d+)/(\d+)}))
           prefix = m[1]
           account = m[2]
           bank = m[3]
@@ -315,4 +314,4 @@ module CzechPostB2bClient
   end
 end
 
-# rubocop:enable Layout/LineLength, Style/AsciiComments
+# rubocop:enable Layout/LineLength

data/lib/czech_post_b2b_client/response_codes.rb

@@ -24,6 +24,7 @@ module CzechPostB2bClient
       end
 
       attr_reader :details
+
       def initialize(details = '')
         @details = details
       end
@@ -2001,6 +2002,48 @@ module CzechPostB2bClient
       @type = :info
     end
 
+    class InfoService40CanceledDueMissingContactToAddressee < CzechPostB2bClient::ResponseCodes::BaseCode
+      @code = 424
+      @text = 'INFO_CANCEL_SERVICE_40'
+      @description = 'Zrušena služba 40 - neuveden kontaktní údaj adresáta'
+      @type = :info
+    end
+
+    class InfoService29CanceledDueMissingContactToAddressee < CzechPostB2bClient::ResponseCodes::BaseCode
+      @code = 425
+      @text = 'INFO_CANCEL_SERVICE_29'
+      @description = 'Zrušena dopl. sl. 29 – neuveden kontaktní údaj'
+      @type = :info
+    end
+
+    class InfoService40CanceledNotAllowedTogetherWithService29 < CzechPostB2bClient::ResponseCodes::BaseCode
+      @code = 426
+      @text = 'INFO_CANCEL_SERVICE_40'
+      @description = 'Zrušena služba 40 – nepovolena se sl. 29'
+      @type = :info
+    end
+
+    class InfoService40CanceledPackageIsPosteRestante < CzechPostB2bClient::ResponseCodes::BaseCode
+      @code = 427
+      @text = 'INFO_CANCEL_SERVICE_40'
+      @description = 'Zrušena služba 40 – zásilka Poste restante'
+      @type = :info
+    end
+
+    class InfoService7KCancelledNotArrangedForClient < CzechPostB2bClient::ResponseCodes::BaseCode
+      @code = 428
+      @text = 'INFO_CANCEL_SERVICE_7K'
+      @description = 'Zrušena služba 7K - nesjednaná služba pro zákaznické řešení'
+      @type = :info
+    end
+
+    class InfoAvizoServiceAppended < CzechPostB2bClient::ResponseCodes::BaseCode
+      @code = 429
+      @text = 'INFO_NOTIFICIATON_WAS_MODIFIED'
+      @description = 'Služba avizování přiřazena dle kontaktních údajů'
+      @type = :info
+    end
+
     # must be at end to collect all classes defined before
     def self.all_classes
       base_class = CzechPostB2bClient::ResponseCodes::BaseCode

data/lib/czech_post_b2b_client/response_parsers/base_parser.rb

@@ -6,6 +6,7 @@ module CzechPostB2bClient
   module ResponseParsers
     class BaseParser < SteppedService::Base
       def initialize(xml:)
+        super()
         @response_xml = xml
       end
 
@@ -34,41 +35,41 @@ module CzechPostB2bClient
 
       def build_result
         @result = {
-          request: { created_at: request_data.time_stamp,
-                     contract_id: request_data.id_contract,
-                     request_id: request_data.id_ext_transaction },
+          request: { created_at: request_data[:time_stamp],
+                     contract_id: request_data[:id_contract],
+                     request_id: request_data[:id_ext_transaction] },
           response: { created_at: response_time }
         }
       end
 
       def response_service_data
-        b2b_response_hash.dig('serviceData')
+        b2b_response_hash['serviceData']
       end
 
       def response_header
-        b2b_response_hash.dig('header')
+        b2b_response_hash['header']
       end
 
       def response_root_node
-        return response_service_data.dig(response_root_node_name) if response_service_data.keys.include?(response_root_node_name)
+        return response_service_data[response_root_node_name] if response_service_data.keys.include?(response_root_node_name)
 
         errors.add(:xml, "Cannot find `#{response_root_node_name}` in `serviceData` node.")
         fail_on_structure_parsing
       end
 
       def b2b_response_hash
-        response_hash.dig('b2bSyncResponse') || response_hash.dig('b2bASyncResponse')
+        response_hash['b2bSyncResponse'] || response_hash['b2bASyncResponse']
       end
 
       def request_data
-        b2b_request_hash = response_header.dig('b2bRequestHeader')
-        OpenStruct.new(id_ext_transaction: b2b_request_hash.dig('idExtTransaction').to_s,
-                       time_stamp: Time.parse(b2b_request_hash.dig('timeStamp')),
-                       id_contract: b2b_request_hash.dig('idContract').to_s)
+        b2b_request_hash = response_header['b2bRequestHeader']
+        { id_ext_transaction: b2b_request_hash['idExtTransaction'].to_s,
+          time_stamp: Time.parse(b2b_request_hash['timeStamp']),
+          id_contract: b2b_request_hash['idContract'].to_s }
       end
 
       def response_time
-        Time.parse(response_header.dig('timeStamp'))
+        Time.parse(response_header['timeStamp'])
       rescue TypeError
         Time.now.utc
       end
@@ -87,7 +88,7 @@ module CzechPostB2bClient
       end
 
       def handle_result_building_error(error)
-        @result = { result_builder_error: error.message + ' at line: ' + error.backtrace.first,
+        @result = { result_builder_error: "#{error.message} at line: #{error.backtrace.first}",
                     response_hash: response_hash }
         fail_on_structure_parsing
       end

data/lib/czech_post_b2b_client/response_parsers/get_parcel_state_parser.rb

@@ -21,7 +21,7 @@ module CzechPostB2bClient
       def response_parcel_hashes
         return [] if response_root_node.nil?
 
-        [response_root_node.dig('parcel')].flatten.compact # to always get array of hash(es)
+        [response_root_node['parcel']].flatten.compact # to always get array of hash(es)
       end
 
       def parcel_data_from(rp_hash) # rubocop:disable Metrics/AbcSize

data/lib/czech_post_b2b_client/response_parsers/get_parcels_printing_parser.rb

@@ -7,28 +7,40 @@ module CzechPostB2bClient
     class GetParcelsPrintingParser < BaseParser
       def build_result
         super
-        @result[:response][:state] = state_hash_from(printing_response_header_result.dig('doPrintingStateResponse'))
-        @result[:printings] = { options: options_hash,
-                                pdf_content: pdf_content }
+        @result[:response][:state] = state_hash_from(printing_response_header_result['doPrintingStateResponse'])
+        opt_hash = options_hash
+        @result[:printings] = { options: opt_hash }.merge(content_hash(opt_hash[:template_id]))
       end
 
       def options_hash
-        options_response = printing_response_header_result.dig('doPrintingHeader')
+        options_response = printing_response_header_result['doPrintingHeader']
         {
-          customer_id: options_response.dig('customerID'),
-          contract_number: options_response.dig('contractNumber'),
-          template_id: options_response.dig('idForm').to_i,
-          margin_in_mm: { top: options_response.dig('shiftVertical').to_i,
-                          left: options_response.dig('shiftHorizontal').to_i },
-          position_order: options_response.dig('position').to_i
+          customer_id: options_response['customerID'],
+          contract_number: options_response['contractNumber'],
+          template_id: options_response['idForm'].to_i,
+          margin_in_mm: { top: options_response['shiftVertical'].to_i,
+                          left: options_response['shiftHorizontal'].to_i },
+          position_order: options_response['position'].to_i
         }
       end
 
-      def pdf_content
-        pdf_content_encoded = response_root_node.dig('doPrintingDataResult', 'file')
-        return nil if pdf_content_encoded.nil?
+      def content_hash(template_id)
+        if zpl_template?(template_id)
+          { zpl_content: response_content.force_encoding('utf-8') }
+        else
+          { pdf_content: response_content }
+        end
+      end
+
+      def zpl_template?(template_id)
+        CzechPostB2bClient::PrintingTemplates.find(template_id).content_type == :zpl
+      end
+
+      def response_content
+        content_encoded = response_root_node.dig('doPrintingDataResult', 'file')
+        return nil if content_encoded.nil?
 
-        ::Base64.decode64(pdf_content_encoded)
+        ::Base64.decode64(content_encoded)
       end
 
       def response_root_node_name
@@ -36,7 +48,7 @@ module CzechPostB2bClient
       end
 
       def printing_response_header_result
-        response_root_node.dig('doPrintingHeaderResult')
+        response_root_node['doPrintingHeaderResult']
       end
     end
   end

data/lib/czech_post_b2b_client/response_parsers/get_result_parcels_parser.rb

@@ -25,7 +25,7 @@ module CzechPostB2bClient
       end
 
       def response_parcel_hashes
-        [response_root_node.dig('doParcelParamResult')].flatten.compact # to always get array of hash(es)
+        [response_root_node['doParcelParamResult']].flatten.compact # to always get array of hash(es)
       end
 
       def parcel_parcel_id_from(rp_hash)
@@ -34,7 +34,7 @@ module CzechPostB2bClient
 
       def parcel_data_from(rp_hash)
         { parcel_code: rp_hash['parcelCode'],
-          states: [state_hash_from(rp_hash.dig('doParcelStateResponse'))] }
+          states: [state_hash_from(rp_hash['doParcelStateResponse'])] }
       end
 
       def updated_result_value_for(value, parcel_params_result_hash)

data/lib/czech_post_b2b_client/response_parsers/get_stats_parser.rb

@@ -5,18 +5,15 @@ module CzechPostB2bClient
     class GetStatsParser < BaseParser
       def build_result
         super
-        @result[:imports] = { requested: imports.all,
-                              with_errors: imports.err,
-                              successful: imports.ok,
-                              imported_parcels: imports.parcels }
+        @result[:imports] = imports
       end
 
       def imports
         imports_hash = response_root_node
-        OpenStruct.new(all: imports_hash.dig('importAll').to_i,
-                       err: imports_hash.dig('importErr').to_i,
-                       ok: imports_hash.dig('importOk').to_i,
-                       parcels: imports_hash.dig('parcels').to_i)
+        { requested: imports_hash['importAll'].to_i,
+          with_errors: imports_hash['importErr'].to_i,
+          successful: imports_hash['importOk'].to_i,
+          imported_parcels: imports_hash['parcels'].to_i }
       end
 
       def response_root_node_name

data/lib/czech_post_b2b_client/response_parsers/parcel_service_sync_parser.rb

@@ -35,7 +35,7 @@ module CzechPostB2bClient
       end
 
       def response_print_hash
-        response_root_node.dig('responsePrintParams')
+        response_root_node['responsePrintParams']
       end
 
       def parcel_parcel_id_from(rp_hash)
@@ -44,7 +44,7 @@ module CzechPostB2bClient
 
       def parcel_data_from(rp_hash)
         { parcel_code: rp_hash['parcelCode'],
-          states: parcel_states_form(rp_hash.dig('parcelDataResponse')) }
+          states: parcel_states_form(rp_hash['parcelDataResponse']) }
       end
 
       def parcel_states_form(data_responses)
@@ -54,8 +54,8 @@ module CzechPostB2bClient
       def print_data_from(print_hash)
         return nil if print_hash.nil? || print_hash.empty?
 
-        { pdf_content: pdf_content_from(print_hash.dig('file')),
-          state: state_hash_from(print_hash.dig('printParamsResponse')) }
+        { pdf_content: pdf_content_from(print_hash['file']),
+          state: state_hash_from(print_hash['printParamsResponse']) }
       end
 
       def pdf_content_from(pdf_content_encoded)