czech_post_b2b_client 1.2.4 → 1.2.5

data/lib/czech_post_b2b_client/response_parsers/base_parser.rb

@@ -50,9 +50,7 @@ module CzechPostB2bClient
       end
 
       def response_root_node
-        if response_service_data.keys.include?(response_root_node_name)
-          return response_service_data.dig(response_root_node_name)
-        end
+        return response_service_data.dig(response_root_node_name) if response_service_data.keys.include?(response_root_node_name)
 
         errors.add(:xml, "Cannot find `#{response_root_node_name}` in `serviceData` node.")
         fail_on_structure_parsing

data/lib/czech_post_b2b_client/response_parsers/get_result_parcels_parser.rb

@@ -48,9 +48,7 @@ module CzechPostB2bClient
         # more parcel_codes for one parcel_id => probably errors
         old_p_code = value[:parcel_code]
         new_p_code = pd_hash[:parcel_code]
-        if old_p_code != new_p_code
-          raise "Two different parcel_codes [#{old_p_code}, #{new_p_code}] for parcel_id:'#{parcel_id}'"
-        end
+        raise "Two different parcel_codes [#{old_p_code}, #{new_p_code}] for parcel_id:'#{parcel_id}'" if old_p_code != new_p_code
 
         value
       end

data/lib/czech_post_b2b_client/response_parsers/parcel_service_sync_parser.rb

@@ -71,9 +71,7 @@ module CzechPostB2bClient
         # more parcel_codes for one parcel_id => probably errors
         old_p_code = value[:parcel_code]
         new_p_code = pd_hash[:parcel_code]
-        if old_p_code != new_p_code
-          raise "Two different parcel_codes [#{old_p_code}, #{new_p_code}] for parcel_id:'#{parcel_id}'"
-        end
+        raise "Two different parcel_codes [#{old_p_code}, #{new_p_code}] for parcel_id:'#{parcel_id}'" if old_p_code != new_p_code
 
         value
       end

data/lib/czech_post_b2b_client/services/api_caller.rb

@@ -55,7 +55,8 @@ module CzechPostB2bClient
         request = Net::HTTP::Post.new service_uri.request_uri, headers
         request.body = request_xml
 
-        debug_msg = "CzechPost B2B REQUEST: #{request} to #{service_uri.request_uri} with body:\n#{request.body}"
+        debug_msg = "CzechPost B2B REQUEST: #{request} to #{service_uri.request_uri}" \
+                    " with headers: #{headers}\n and body:\n#{request.body}"
         CzechPostB2bClient.logger.debug(debug_msg)
 
         request
@@ -106,7 +107,8 @@ module CzechPostB2bClient
         return 'error code not found in XML' unless error_match
 
         error_code = error_match[1].to_i
-        error = CzechPostB2bClient::B2BErrors.new_by_code(error_code)
+        error_details = result.xml.match(%r{<(?:\w+\:)?errorDescription>(.*)</(?:\w+\:)?errorDescription>})
+        error = CzechPostB2bClient::B2BErrors.new_by_code(error_code, error_details[1])
         return "error code [#{error_code}] is unknown" unless error
 
         error.message

data/lib/czech_post_b2b_client/services/parcels_send_process_updater.rb

@@ -63,7 +63,7 @@ module CzechPostB2bClient
           response_code = response_state[:code]
           next if response_code == CzechPostB2bClient::ResponseCodes::Ok.code
 
-          errors.add(:parcels, "Parcel[#{parcel_id}] => #{CzechPostB2bClient::ResponseCodes.new_by_code(response_code)}") # rubocop:disable Layout/LineLength
+          errors.add(:parcels, "Parcel[#{parcel_id}] => #{CzechPostB2bClient::ResponseCodes.new_by_code(response_code)}")
         end
       end
     end

data/lib/czech_post_b2b_client/services/parcels_sync_sender.rb

@@ -80,7 +80,7 @@ module CzechPostB2bClient
           response_code = response_state[:code]
           next if response_code == CzechPostB2bClient::ResponseCodes::Ok.code
 
-          errors.add(:parcels, "Parcel[#{parcel_id}] => #{CzechPostB2bClient::ResponseCodes.new_by_code(response_code)}") # rubocop:disable Layout/LineLength
+          errors.add(:parcels, "Parcel[#{parcel_id}] => #{CzechPostB2bClient::ResponseCodes.new_by_code(response_code)}")
         end
       end
     end

data/lib/czech_post_b2b_client/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module CzechPostB2bClient
-  VERSION = '1.2.4'
+  VERSION = '1.2.5'
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: czech_post_b2b_client
 version: !ruby/object:Gem::Version
-  version: 1.2.4
+  version: 1.2.5
 platform: ruby
 authors:
 - Petr Mlčoch