cypress-on-rails 1.2.0 → 1.2.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: f21cac226aa4015c07018d58964e0644fa129190addcf71f9b968ce727bcbbdc
-  data.tar.gz: cc6ca291b3054e3da1914927515106d27e2064d262f05040025e3c649d7d7ff0
+  metadata.gz: 651ff2a2ceeb3e680b7aebb2caa45f08eed82d0c1e19f764acc3b70dab8ff56e
+  data.tar.gz: dd5036d3fe346f0d3d962c832313534b737cf9a3bfed1c8c52a2c919c8ebe878
 SHA512:
-  metadata.gz: 880f43bc0764b118be64782dc46d873348b9f579c43f48709002abb2ab970da97228cd046d915a564d9a9183dd6a2bd2501e6326154ceafa79f71598e5e657e7
-  data.tar.gz: 2e89c6aca7735d4972aaf270e448d31865c083be59fee3f3611549805d1ea26e7be91e403fece32b82750acfb60f19d1341d85c9e02bd367ac0bf18f6f07f60e
+  metadata.gz: b0cd309f049d622d06ba0cde5faae638659cbbade3741995f67812b8f449e41be8d90fb6863be1386e53b63c5cb90113d1ac821b93fb6c8a935074d48e7a3843
+  data.tar.gz: 8b69c6c9623f6670398f8ee0f9363264e66554baff4cc867f3414e24ab74caa5e90b0a26b2f95885f39967e20bcb7032d27e3fb1facb6f86d6c24f04626403f1

data/CHANGELOG.md

@@ -1,3 +1,7 @@
+## 1.2.1
+### Fixed
+* simple factory fails silently, changed to use create!
+
 ## 1.2.0
 ### Tasks
 * adding additional log failure logging

data/lib/cypress_dev/simple_rails_factory.rb

@@ -1,17 +1,15 @@
+require 'active_support/core_ext/string'
+
 module CypressDev
   module SimpleRailsFactory
     def self.create(type, params = {})
-      type.camelize.constantize.create(params)
-    rescue NameError => e
-      Rails.logger.warn e.message
+      type.camelize.constantize.create!(params)
     end
 
     def self.create_list(type, amount, params = {})
       amount.to_i.times do
         create(type,params)
       end
-    rescue NameError => e
-      Rails.logger.warn e.message
     end
   end
 end

data/lib/cypress_dev/version.rb

@@ -1,3 +1,3 @@
 module CypressDev
-  VERSION = '1.2.0'
+  VERSION = '1.2.1'
 end

data/spec/cypress_dev/command_executor/simple_rails_factory_spec.rb

@@ -0,0 +1,23 @@
+require 'cypress_dev/simple_rails_factory'
+
+RSpec.describe CypressDev::SimpleRailsFactory do
+  subject { CypressDev::SimpleRailsFactory }
+
+  class AppRecord
+    def self.create!(*)
+    end
+  end
+
+  before { allow(AppRecord).to receive(:create!) }
+
+  it do
+    subject.create('AppRecord', { my_args: 'Hello World' })
+
+    expect(AppRecord).to have_received(:create!).with( { my_args: 'Hello World' } )
+  end
+
+  it do
+    expect{ subject.create('UnknownRecord', { my_args: 'Hello World' }) }.
+      to raise_error(NameError)
+  end
+end

data/spec/integrations/rails_3_2/app/models/post.rb

@@ -1,4 +1,8 @@
 class Post < OpenStruct
+  def self.create!(attributes)
+    create(attributes)
+  end
+
   def self.create(attributes)
     @all ||= []
     post = new(attributes)

data/spec/integrations/rails_4_2/app/models/post.rb

@@ -1,4 +1,8 @@
 class Post < OpenStruct
+  def self.create!(attributes)
+    create(attributes)
+  end
+
   def self.create(attributes)
     @all ||= []
     post = new(attributes)

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: cypress-on-rails
 version: !ruby/object:Gem::Version
-  version: 1.2.0
+  version: 1.2.1
 platform: ruby
 authors:
 - miceportal team
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-11-07 00:00:00.000000000 Z
+date: 2018-12-28 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rack
@@ -131,6 +131,7 @@ files:
 - lib/generators/cypress_dev/templates/spec/cypress/support/index.js
 - lib/generators/cypress_dev/templates/spec/cypress/support/on-rails.js
 - spec/cypress_dev/command_executor/cypress_helper.rb
+- spec/cypress_dev/command_executor/simple_rails_factory_spec.rb
 - spec/cypress_dev/command_executor/test_command.rb
 - spec/cypress_dev/command_executor/test_command_with_options.rb
 - spec/cypress_dev/command_executor_spec.rb
@@ -295,7 +296,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: cypress-on-rails
-rubygems_version: 2.7.4
+rubygems_version: 2.7.6
 signing_key: 
 specification_version: 4
 summary: Integrates cypress with rails or rack applications