cxml-ruby 0.7.0 → 0.8.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 1f43fac9295a9de5ac9f0c327a73b26260569c239c70bad553e8cb0721c5fb7b
-  data.tar.gz: 41e42f9b4a188923bf7c42105571c0f81da954fc82d4825d0c1c0dbd49ec7f93
+  metadata.gz: 125ea774cb74155d9512b222d1d47a06945558d87d441dd1491d53caf8e9ca9a
+  data.tar.gz: 986ef57d03cf1706eedf08618dc5b52931171f42b147e1d81dfabaf6a6c32df8
 SHA512:
-  metadata.gz: 90361cf48f65bc79bde60722efe16be0f61f60e455998aa7c73bdbbcba7984b2c9b7b322b70579572d2d44988ed554db0f4ecd046038de6d0fc43086fe64fd77
-  data.tar.gz: 23892b7370c13805e5ad69c0c1bed7b2181c872abc8cb9abed99c074e7423f28d764d8cfa3889593cd0a528ec3674b5384b4f5d5a97bcf59c576adebbf06cd61
+  metadata.gz: ebfe04583c735c1635a14d89cc49d4f1494b1d49b79efa7d072d261b1d91d0831a5f5d644fcfde75c54c572528fcca499288b4393dfdf86b33958d065b167d3b
+  data.tar.gz: 3a97f6bcc16715eae27f2ef9a8f4ade47281f092116458fc784224bd46d97cdae1f29e65234d07946ef7027accdce0e91dd9635003f8064c8b4af7730d0c1857

data/CHANGELOG.md

@@ -14,6 +14,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ---
 
+## [0.8.0] - 2021-04-25
+### Changed
+- Support continued parsing of child nodes if unknown attribute is encountered with `raise_unknown_elements` set to `false`.
+
 ## [0.7.0] - 2021-01-12
 ### Added
 - Support parsing Phone tags.

data/lib/cxml/document_node.rb

@@ -121,9 +121,7 @@ module CXML
       klass = "CXML::#{camelize(key)}"
       send("#{key}=", Object.const_get(klass).new(val))
     rescue NoMethodError => e
-      raise(UnknownAttributeError, e) if CXML.raise_unknown_elements
-
-      CXML.logger.warn(e)
+      handle_unknown_elements_error(e)
     rescue NameError => e
       raise(e) unless e.to_s.match?(klass)
 
@@ -136,6 +134,8 @@ module CXML
       else
         send("#{key}=", val)
       end
+    rescue NoMethodError => e
+      handle_unknown_elements_error(e)
     end
 
     def camelize(string, uppercase_first_letter: true)
@@ -150,5 +150,11 @@ module CXML
         "#{Regexp.last_match(1)}#{Regexp.last_match(2).capitalize}"
       end.gsub('/', '::')
     end
+
+    def handle_unknown_elements_error(error)
+      raise(UnknownAttributeError, error) if CXML.raise_unknown_elements
+
+      CXML.logger.warn(error)
+    end
   end
 end

data/lib/cxml/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module CXML
-  VERSION = '0.7.0'
+  VERSION = '0.8.0'
 end

data/spec/document_spec.rb

@@ -82,6 +82,26 @@ describe CXML::Document do
       end
     end
 
+    context 'when unknown attribute is present' do
+      let(:data) { CXML::Parser.new(data: fixture('document_node_with_unknown_attribute.xml')).parse }
+      let(:doc) { CXML::Document.new(data) }
+
+      it 'does not raise and parses child nodes if CXML.raise_unknown_elements is false' do
+        CXML.raise_unknown_elements = false
+        -> { doc }.should_not raise_error
+
+        doc.response.status.code.should eq(200)
+        doc.response.status.content.should eq('123456')
+
+        # Reset `raise_unknown_elements` for future tests
+        CXML.raise_unknown_elements = true
+      end
+
+      it 'raises UnknownAttributeError' do
+        -> { doc }.should raise_error(CXML::UnknownAttributeError)
+      end
+    end
+
     context 'when a response document is passed' do
       let(:data) { CXML::Parser.new(data: fixture('response_status_200.xml')).parse }
       include_examples :document_has_mandatory_values

data/spec/fixtures/document_node_with_unknown_attribute.xml

@@ -0,0 +1,7 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<!DOCTYPE cXML SYSTEM "http://xml.cXML.org/schemas/cXML/1.2.020/cXML.dtd">
+<cXML xml:lang="en-US" payloadID="test-id" timestamp="2020-09-10T20:32:26+00:00">
+  <Response invalid="invalid">
+    <Status code="200" text="Ok">123456</Status>
+  </Response>
+</cXML>

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: cxml-ruby
 version: !ruby/object:Gem::Version
-  version: 0.7.0
+  version: 0.8.0
 platform: ruby
 authors:
 - Josh Beckman
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2021-01-12 00:00:00.000000000 Z
+date: 2021-04-25 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: ox
@@ -213,6 +213,7 @@ files:
 - spec/fixtures/1.2.020-InvoiceDetail.dtd
 - spec/fixtures/1.2.020-cXML.dtd
 - spec/fixtures/1.2.037-InvoiceDetail.dtd
+- spec/fixtures/document_node_with_unknown_attribute.xml
 - spec/fixtures/envelope.xml
 - spec/fixtures/envelope2.xml
 - spec/fixtures/invoice_backed_and_unbacked_by_pos.xml
@@ -281,6 +282,7 @@ test_files:
 - spec/fixtures/1.2.020-InvoiceDetail.dtd
 - spec/fixtures/1.2.020-cXML.dtd
 - spec/fixtures/1.2.037-InvoiceDetail.dtd
+- spec/fixtures/document_node_with_unknown_attribute.xml
 - spec/fixtures/envelope.xml
 - spec/fixtures/envelope2.xml
 - spec/fixtures/invoice_backed_and_unbacked_by_pos.xml