cxml-ruby 0.6.1 → 0.8.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 87772dd26f3194f54c29efa9a993202f79e8102f9bda767bbab87fb43579b9be
-  data.tar.gz: 227e6acd1a26406c8eaeabdec57326e5ac85ff5a965ff11c0d24650d786c3f51
+  metadata.gz: 25b2ba1b0156e96916f3f5aa7788d4b4c0d175452fa91e09b1cb8ad0c96f3c06
+  data.tar.gz: 73806c22df23149ca45e46250ecb5fc907ede4826dd7919d3ec922bdd93872cd
 SHA512:
-  metadata.gz: 812724e750bb2f67a33fa0cd2acef0d03996d394574ea265f40b90c842f1b5244de9ab7ca74a7acedc38a6dbd0d96030933be52a6ef0cf7d2713328117d660bb
-  data.tar.gz: 93d10408aaaafaa739ffa6841a83b0ecabe253247cff418684887ac8bfb3fed328e29a649e09d9e1ed043f8aa3d7adfcfbff4104156fb5e80993463d9ed147b6
+  metadata.gz: dbaed7a1c8af7c579c0f516422f085e802c3a7e582739dd99a476fc8eb45bea542cefc3b34920cadca1d72e74752d2a38cfc9981601d948167c8dbc050c7bbbb
+  data.tar.gz: f14c6e2f0c74c493cf2430daa9a90b948fc967c3268f72f0fd180f0eec0de7499baddaabc95ee417ef72552e33d3c4d75d3956437d7b2c797ad5e394310715d6

data/.github/workflows/ruby.yml

@@ -6,13 +6,16 @@ jobs:
   build:
 
     runs-on: ubuntu-latest
+    strategy:
+      matrix:
+        ruby: [ '2.6.x', '2.7.x', '3.0.x' ]
 
     steps:
     - uses: actions/checkout@v2
-    - name: Set up Ruby 2.6
+    - name: Set up Ruby ${{ matrix.ruby }}
       uses: actions/setup-ruby@v1
       with:
-        ruby-version: 2.6.x
+        ruby-version: ${{ matrix.ruby }}
     - name: Test with Rake
       run: |
         sudo apt-get install libxml2-utils

data/CHANGELOG.md

@@ -14,6 +14,22 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ---
 
+## [0.8.2] - 2021-12-21
+### Fixed
+- Add support for Ruby 3.x.x.
+
+## [0.8.1] - 2021-05-24
+### Fixed
+- Reorder the attributes output for `PunchoutSetupRequest`.
+
+## [0.8.0] - 2021-04-25
+### Changed
+- Support continued parsing of child nodes if unknown attribute is encountered with `raise_unknown_elements` set to `false`.
+
+## [0.7.0] - 2021-01-12
+### Added
+- Support parsing Phone tags.
+
 ## [0.6.1] - 2020-09-04
 ### Fixed
 - Handle parsing CDATA tags in cXML content (Thanks @CRiva!).

data/lib/cxml/country_code.rb

@@ -0,0 +1,9 @@
+# frozen_string_literal: true
+
+module CXML
+  class CountryCode < DocumentNode
+    accessible_attributes %i[
+      iso_country_code
+    ]
+  end
+end

data/lib/cxml/document_node.rb

@@ -35,7 +35,7 @@ module CXML
       data = data.serializable_hash if data.is_a?(self.class)
       return unless data.is_a?(Hash)
 
-      data.each(&method(:initialize_attribute))
+      data.each { |arr| initialize_attribute(*arr) }
     end
 
     def serializable_hash
@@ -121,9 +121,7 @@ module CXML
       klass = "CXML::#{camelize(key)}"
       send("#{key}=", Object.const_get(klass).new(val))
     rescue NoMethodError => e
-      raise(UnknownAttributeError, e) if CXML.raise_unknown_elements
-
-      CXML.logger.warn(e)
+      handle_unknown_elements_error(e)
     rescue NameError => e
       raise(e) unless e.to_s.match?(klass)
 
@@ -136,6 +134,8 @@ module CXML
       else
         send("#{key}=", val)
       end
+    rescue NoMethodError => e
+      handle_unknown_elements_error(e)
     end
 
     def camelize(string, uppercase_first_letter: true)
@@ -150,5 +150,11 @@ module CXML
         "#{Regexp.last_match(1)}#{Regexp.last_match(2).capitalize}"
       end.gsub('/', '::')
     end
+
+    def handle_unknown_elements_error(error)
+      raise(UnknownAttributeError, error) if CXML.raise_unknown_elements
+
+      CXML.logger.warn(error)
+    end
   end
 end

data/lib/cxml/phone.rb

@@ -0,0 +1,13 @@
+# frozen_string_literal: true
+
+module CXML
+  class Phone < DocumentNode
+    accessible_attributes %i[
+      name
+    ]
+
+    accessible_nodes %i[
+      telephone_number
+    ]
+  end
+end

data/lib/cxml/punch_out_setup_request.rb

@@ -5,12 +5,13 @@ module CXML
     accessible_attributes %i[
       operation
     ]
+
     accessible_nodes %i[
+      buyer_cookie
+      extrinsics
       browser_form_post
       supplier_setup
-      buyer_cookie
       ship_to
-      extrinsics
       contact
     ]
 

data/lib/cxml/telephone_number.rb

@@ -0,0 +1,11 @@
+# frozen_string_literal: true
+
+module CXML
+  class TelephoneNumber < DocumentNode
+    accessible_nodes %i[
+      country_code
+      area_or_city_code
+      number
+    ]
+  end
+end

data/lib/cxml/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module CXML
-  VERSION = '0.6.1'
+  VERSION = '0.8.2'
 end

data/spec/document_spec.rb

@@ -82,6 +82,26 @@ describe CXML::Document do
       end
     end
 
+    context 'when unknown attribute is present' do
+      let(:data) { CXML::Parser.new(data: fixture('document_node_with_unknown_attribute.xml')).parse }
+      let(:doc) { CXML::Document.new(data) }
+
+      it 'does not raise and parses child nodes if CXML.raise_unknown_elements is false' do
+        CXML.raise_unknown_elements = false
+        -> { doc }.should_not raise_error
+
+        doc.response.status.code.should eq(200)
+        doc.response.status.content.should eq('123456')
+
+        # Reset `raise_unknown_elements` for future tests
+        CXML.raise_unknown_elements = true
+      end
+
+      it 'raises UnknownAttributeError' do
+        -> { doc }.should raise_error(CXML::UnknownAttributeError)
+      end
+    end
+
     context 'when a response document is passed' do
       let(:data) { CXML::Parser.new(data: fixture('response_status_200.xml')).parse }
       include_examples :document_has_mandatory_values

data/spec/fixtures/document_node_with_unknown_attribute.xml

@@ -0,0 +1,7 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<!DOCTYPE cXML SYSTEM "http://xml.cXML.org/schemas/cXML/1.2.020/cXML.dtd">
+<cXML xml:lang="en-US" payloadID="test-id" timestamp="2020-09-10T20:32:26+00:00">
+  <Response invalid="invalid">
+    <Status code="200" text="Ok">123456</Status>
+  </Response>
+</cXML>

data/spec/fixtures/punch_out_setup_request_doc_with_ship_to.xml

@@ -39,6 +39,13 @@
 <Country isoCountryCode="US">United States</Country>
 </PostalAddress>
 <Email name="default">jmadden@coupa1.com</Email>
+<Phone name="work">
+  <TelephoneNumber>
+    <CountryCode isoCountryCode="US">1</CountryCode>
+    <AreaOrCityCode>855</AreaOrCityCode>
+    <Number>8671234</Number>
+  </TelephoneNumber>
+</Phone>
 </Address>
 </ShipTo>
 </PunchOutSetupRequest>

data/spec/punch_out_setup_request_spec.rb

@@ -38,6 +38,8 @@ describe CXML::PunchOutSetupRequest do
       doc = CXML::Document.new(data)
       doc.request.punch_out_setup_request.ship_to.should_not be_nil
       doc.request.punch_out_setup_request.ship_to.address.name.should_not be_nil
+      doc.request.punch_out_setup_request.ship_to.address.phone.should_not be_nil
+      doc.request.punch_out_setup_request.ship_to.address.phone.telephone_number.should_not be_nil
     end
   end
 

metadata

@@ -1,15 +1,15 @@
 --- !ruby/object:Gem::Specification
 name: cxml-ruby
 version: !ruby/object:Gem::Version
-  version: 0.6.1
+  version: 0.8.2
 platform: ruby
 authors:
 - Josh Beckman
 - Eleni Chappen
-autorequire:
+autorequire: 
 bindir: bin
 cert_chain: []
-date: 2020-09-04 00:00:00.000000000 Z
+date: 2021-12-28 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: ox
@@ -115,6 +115,7 @@ files:
 - lib/cxml/confirmation_status.rb
 - lib/cxml/contact.rb
 - lib/cxml/country.rb
+- lib/cxml/country_code.rb
 - lib/cxml/credential.rb
 - lib/cxml/credential_mac.rb
 - lib/cxml/deducted_price.rb
@@ -170,6 +171,7 @@ files:
 - lib/cxml/parser.rb
 - lib/cxml/payment_term.rb
 - lib/cxml/period.rb
+- lib/cxml/phone.rb
 - lib/cxml/postal_address.rb
 - lib/cxml/protocol.rb
 - lib/cxml/punch_out_order_message.rb
@@ -195,6 +197,7 @@ files:
 - lib/cxml/tax_detail.rb
 - lib/cxml/tax_location.rb
 - lib/cxml/taxable_amount.rb
+- lib/cxml/telephone_number.rb
 - lib/cxml/to.rb
 - lib/cxml/total.rb
 - lib/cxml/total_allowances.rb
@@ -210,6 +213,7 @@ files:
 - spec/fixtures/1.2.020-InvoiceDetail.dtd
 - spec/fixtures/1.2.020-cXML.dtd
 - spec/fixtures/1.2.037-InvoiceDetail.dtd
+- spec/fixtures/document_node_with_unknown_attribute.xml
 - spec/fixtures/envelope.xml
 - spec/fixtures/envelope2.xml
 - spec/fixtures/invoice_backed_and_unbacked_by_pos.xml
@@ -250,7 +254,7 @@ homepage: https://github.com/officeluv/cxml-ruby
 licenses:
 - MIT
 metadata: {}
-post_install_message:
+post_install_message: 
 rdoc_options: []
 require_paths:
 - lib
@@ -265,52 +269,8 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.1.2
-signing_key:
+rubygems_version: 3.2.3
+signing_key: 
 specification_version: 4
 summary: Parse/generate documents with the cXML protocol
-test_files:
-- spec/credential_spec.rb
-- spec/cxml_spec.rb
-- spec/document_spec.rb
-- spec/fixtures/.gitkeep
-- spec/fixtures/1.2.014-cXML.dtd
-- spec/fixtures/1.2.020-InvoiceDetail.dtd
-- spec/fixtures/1.2.020-cXML.dtd
-- spec/fixtures/1.2.037-InvoiceDetail.dtd
-- spec/fixtures/envelope.xml
-- spec/fixtures/envelope2.xml
-- spec/fixtures/invoice_backed_and_unbacked_by_pos.xml
-- spec/fixtures/invoice_backed_by_multiple_pos.xml
-- spec/fixtures/invoice_taxes_at_line.xml
-- spec/fixtures/invoice_taxes_at_line_multiple_taxes.xml
-- spec/fixtures/invoice_taxes_at_total.xml
-- spec/fixtures/item_in.xml
-- spec/fixtures/order_request.xml
-- spec/fixtures/punch_out_order_message_doc.xml
-- spec/fixtures/punch_out_setup_request_doc.xml
-- spec/fixtures/punch_out_setup_request_doc_coupa.xml
-- spec/fixtures/punch_out_setup_request_doc_with_ship_to.xml
-- spec/fixtures/purchase_order_request_200.xml
-- spec/fixtures/request_doc.xml
-- spec/fixtures/response_status_200.xml
-- spec/fixtures/response_status_400.xml
-- spec/header_spec.rb
-- spec/invoice_detail_request_spec.rb
-- spec/item_detail_spec.rb
-- spec/item_id_spec.rb
-- spec/item_in_spec.rb
-- spec/money_spec.rb
-- spec/output/.gitkeep
-- spec/parser_spec.rb
-- spec/protocol_spec.rb
-- spec/punch_out_order_message_header_spec.rb
-- spec/punch_out_order_message_spec.rb
-- spec/punch_out_setup_request_spec.rb
-- spec/purchase_order_request_spec.rb
-- spec/request_spec.rb
-- spec/response_spec.rb
-- spec/sender_spec.rb
-- spec/spec_helper.rb
-- spec/status_spec.rb
-- spec/support/helpers.rb
+test_files: []