custom_counter_cache 0.1.1 → 0.1.2

checksums.yaml

@@ -0,0 +1,7 @@
+---
+SHA1:
+  metadata.gz: 6e5fc4d939f22ea47d554fccc9fc4a1d38bbfbd8
+  data.tar.gz: 320ea9e7b270ae977f1baf59cb35a7a6a1e4f470
+SHA512:
+  metadata.gz: b7b67a4159f8266cd5a9dc6b46baebd5ac4cc06821fa93100dfc968d6cd52ff3020c93df3797a730ed08fe16866f21d4cc301d0eaaf9dc49b9f1594a173ea642
+  data.tar.gz: 7906c1b7ed13b8c43870a1066279c3434e86c2104a761838ad74b0f97c592b347ef3eb236611e7c0adac2715a6f4ef3769dd3d3f203b44c8f1a9316a7792a181

data/lib/custom_counter_cache/model.rb

@@ -8,6 +8,7 @@ module CustomCounterCache::Model
 
     def define_counter_cache(cache_column, &block)
       return unless table_exists?
+
       # counter accessors
       unless column_names.include?(cache_column.to_s)
         has_many :counters, :as => :countable, :dependent => :destroy
@@ -27,19 +28,26 @@ module CustomCounterCache::Model
           end
         end
       end
+
       # counter update method
       define_method "update_#{cache_column}" do
-        update_attribute cache_column, block.call(self)
+        if self.class.column_names.include?(cache_column.to_s)
+          update_attribute cache_column, block.call(self)
+        else
+          send "#{cache_column}=", block.call(self)
+        end
       end
     end
 
     def update_counter_cache(association, cache_column, options = {})
       return unless table_exists?
+
       association  = association.to_sym
       cache_column = cache_column.to_sym
       method_name  = "callback_#{cache_column}".to_sym
       reflection   = reflect_on_association(association)
       foreign_key  = reflection.options[:foreign_key] || reflection.association_foreign_key
+
       # define callback
       define_method method_name do
         # update old association
@@ -59,6 +67,7 @@ module CustomCounterCache::Model
           record.send("update_#{cache_column}")
         end
       end
+
       # set callbacks
       after_create  method_name, options
       after_update  method_name, options

data/lib/custom_counter_cache/version.rb

@@ -1,5 +1,5 @@
 module CustomCounterCache
 
-  VERSION = '0.1.1'
+  VERSION = '0.1.2'
 
 end

data/test/counter_test.rb

@@ -4,10 +4,12 @@ class CounterTest < Test::Unit::TestCase
 
   def setup
     @user = User.create
+    @box = Box.create
   end
 
   def test_default_counter_value
     assert_equal 0, @user.published_count
+    assert_equal 0, @box.green_balls_count
   end
 
   def test_create_and_destroy_counter
@@ -28,6 +30,17 @@ class CounterTest < Test::Unit::TestCase
     assert_equal 0, @user.published_count
   end
 
+  def test_increment_and_decrement_counter_with_conditions_on_model_with_counter_column
+    @ball = @box.balls.create(:color => 'red')
+    assert_equal 0, @box.reload.green_balls_count
+    @ball.update_attribute :color, 'green'
+    assert_equal 1, @box.reload.green_balls_count
+    3.times { |i| @box.balls.create(:color => 'green') }
+    assert_equal 4, @box.reload.green_balls_count
+    @box.balls.each {|b| b.update_attributes(:color => 'red') }
+    assert_equal 0, @box.reload.green_balls_count
+  end
+
   # Test that an eager loaded
   def test_eager_loading_with_no_counter
     @article = @user.articles.create(:state => 'unpublished')

data/test/test_helper.rb

@@ -20,6 +20,14 @@ ActiveRecord::Schema.define(:version => 1) do
     t.integer :value, :null => false, :default => 0
   end
   add_index :counters, [ :countable_id, :countable_type, :key ], :unique => true
+
+  create_table :boxes do |t|
+    t.integer :green_balls_count, :default => 0
+  end
+  create_table :balls do |t|
+    t.belongs_to :box
+    t.string :color, :default => 'red'
+  end
 end
 
 class User < ActiveRecord::Base
@@ -37,3 +45,16 @@ end
 class Counter < ActiveRecord::Base
   belongs_to :countable, :polymorphic => true
 end
+
+class Box < ActiveRecord::Base
+  has_many :balls
+  define_counter_cache :green_balls_count do |box|
+    box.balls.green.count
+  end
+end
+
+class Ball < ActiveRecord::Base
+  belongs_to :box
+  scope :green, lambda { where(:color => 'green') }
+  update_counter_cache :box, :green_balls_count, :if => Proc.new { |ball| ball.color_changed? }
+end

metadata

@@ -1,46 +1,41 @@
 --- !ruby/object:Gem::Specification
 name: custom_counter_cache
 version: !ruby/object:Gem::Version
-  version: 0.1.1
-  prerelease: 
+  version: 0.1.2
 platform: ruby
 authors:
 - Cedric Howe
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-08-20 00:00:00.000000000 Z
+date: 2014-04-05 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ~>
+    - - '>='
       - !ruby/object:Gem::Version
         version: '3.1'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ~>
+    - - '>='
       - !ruby/object:Gem::Version
         version: '3.1'
 - !ruby/object:Gem::Dependency
   name: sqlite3
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
 description: ''
@@ -55,31 +50,28 @@ files:
 - test/counter_test.rb
 - test/test_helper.rb
 homepage: http://github.com/cedric/custom_counter_cache/
-licenses: []
+licenses:
+- MIT
+metadata: {}
 post_install_message: 
 rdoc_options: []
 require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
-  none: false
   requirements:
-  - - ! '>='
+  - - '>='
     - !ruby/object:Gem::Version
       version: '0'
-      segments:
-      - 0
-      hash: 603101207245387797
 required_rubygems_version: !ruby/object:Gem::Requirement
-  none: false
   requirements:
-  - - ! '>='
+  - - '>='
     - !ruby/object:Gem::Version
       version: 1.3.6
 requirements: []
 rubyforge_project: custom_counter_cache
-rubygems_version: 1.8.23
+rubygems_version: 2.0.3
 signing_key: 
-specification_version: 3
+specification_version: 4
 summary: Custom counter_cache functionality that supports conditions and multiple
   models.
 test_files: