cushion_defaults 0.5.0 → 0.5.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 725ea185c013e34737b4bf5f46e0fa08fff68428
-  data.tar.gz: 8414ae7cce652e15c91e654194c435ebe8aa0ed4
+  metadata.gz: eb9a0010fb2ee9d019f6fc9552354d422289810f
+  data.tar.gz: e34bed7551afc9746f0195766b50d2d17c02f8f5
 SHA512:
-  metadata.gz: eaf552d0557b4c07c083fa3db1074f4ddc058b20d8039e35d1f1c772e5f49ce3ba1e1e5a78b92973d7f4565a3ed45ebbbad2f36eee2f2e1a8c2fe3af9bce3f82
-  data.tar.gz: 68c8e99dd1543ae61ba627678eddaf63e962f276b5ffceb2e38eb812ec67dca281afd9f4157cbf7acae57a10d3e114bc49bb98204d7315fdf850ef9869dc7887
+  metadata.gz: a7cfe9bf2ef8919910408925c54ab14ae43b4efe50ebe3212a0e90fd850af8d6d94523d8b512d9093ea5905654d708ccb59ed44e57a3d69cf9c0fab67b84bee7
+  data.tar.gz: f6701c502a954b8c3a266366135377119c515053e8342d36ebc124fe503169a40795982b2a07069a0b002d85538713d52ad1848c0ffd784702c9b4c1aabbbbeb

data/CHANGELOG.md

@@ -36,7 +36,7 @@
     - IMPROVEMENT: Testing
         - `test/` renamed to `spec/`
         - Add `.rspec` and `spec/spec_helper.rb`
-    - Improve documentation further.
+    - DOCUMENTATION: Numerous expansions
 
 ## 0.3.x
 
@@ -46,7 +46,7 @@
         - ClassMethods#freeze_default
         - ClassMethods#deep_freeze_default
         - ClassMethods#thaw_default
-- 0.3.1: Bugfix to #freeze_defaults, #deep_freeze_defaults, and #thaw_defaults
+- 0.3.1: BUGFIX: Corrected fatal error in #freeze_defaults, #deep_freeze_defaults, and #thaw_defaults
 
 ## 0.4.x
 
@@ -64,5 +64,11 @@
     - NEW OPTION: bang_things_up
         - If true, bang readers will automatically be set up every time a cushion_reader is created.
         - Default: true
-    - Bugfix interaction between procs and #crystallize_defaults
-    - Expand README.md
+    - BUGFIX: fix interaction between procs and #crystallize_defaults
+    - DOCUMENTATION: Expand README.md
+
+-0.5.1
+    - DEPENDENCY: Support now added for Ruby >= 1.9.3
+    - CONFIGURATION: Default log level now WARN (was INFO)
+    - BUGFIX: Remove unnecessary warning on adding +bang_readers+
+    - PERFORMANCE: Moderate performance gains (approx. 20%) on +cushion_reader+

data/README.md

@@ -307,7 +307,7 @@ passerby.when_i_noticed_you == Time.now # false—1 sec later
 
 ```
 
-Alternatively, you can write a normal proc and call the variable's +bang_reader+ if you're worried the variable may not be set.
+Alternatively, you can write a normal proc and call the variable's `bang_reader` if you're worried the variable may not be set.
 
 ```ruby
 class Person
@@ -422,12 +422,12 @@ weather_judgment: 'is it hot in here or is it just me?'
 
 ```yaml
 # config/cushion_defaults/fal/user.yaml
-weather_judgment: "if only it weren\'t for the leaves"
+weather_judgment: "if only it weren't for the leaves"
 ```
 
 ```yaml
 # config/cushion_defaults/win/user.yaml
-weather_judgment: "baby it\'s cold outside"
+weather_judgment: "baby it's cold outside"
 ```
 
 Combine this with the following Ruby, and we can get different defaults depending on the current meteorological season.

data/lib/cushion_defaults/class_methods.rb

@@ -95,21 +95,24 @@ module CushionDefaults
     def cushion_reader(*syms)
       syms.each do |sym|
         sym = sym.to_sym
-        sym_str = sym.to_s
         if self_or_parent_instance_method?(sym)
           CushionDefaults.log("#{self} or a parent class already has what looks like a getter method for #{sym_str}", :warn)
         end
-        instance_variable_string = "@#{sym_str}"
+        instance_variable_string = "@#{sym}"
+
+        # significant performance gains from using this rather than #defaults in method below
+        defaults_cache = @defaults
+
         define_method(sym) do
-          if instance_variable_defined?(instance_variable_string) && (CushionDefaults.conf.no_pushies? || defaults.not_pushy?(sym))
+          if instance_variable_defined?(instance_variable_string) && (CushionDefaults.conf.no_pushies? || defaults_cache.not_pushy?(sym))
             instance_variable_get(instance_variable_string)
-          elsif defaults[sym].respond_to? :call
-            defaults[sym].call(self, sym)
           else
-            defaults[sym]
+            # much faster to save as var
+            da_default = defaults_cache[sym]
+            da_default.respond_to?(:call) ? da_default.call(self, sym) : da_default
           end
         end
-        CushionDefaults.log("cushion_reader #{sym_str} established for #{self}")
+        CushionDefaults.log("cushion_reader #{sym} established for #{self}")
       end
       bang_reader *syms if CushionDefaults.conf.bang_things_up
     end
@@ -163,14 +166,14 @@ module CushionDefaults
     def bang_reader(*syms)
       syms.each do |sym|
         sym = sym.to_sym
-        sym_str = "#{sym}!"
-        if self_or_parent_instance_method?(sym)
-          CushionDefaults.log("#{self} or a parent class already has a bang method #{sym_str}", :warn)
+        bang_sym = "#{sym}!".to_sym
+        if self_or_parent_instance_method?(bang_sym)
+          CushionDefaults.log("#{self} or a parent class already has a bang method #{bang_sym}", :warn)
         end
-        define_method(sym_str.to_sym) do
+        define_method(bang_sym) do
           crystallize_default(sym)
         end
-        CushionDefaults.log("bang_reader #{sym_str} established for #{self}")
+        CushionDefaults.log("bang_reader #{bang_sym} established for #{self}")
       end
     end
 
@@ -203,6 +206,8 @@ module CushionDefaults
 
         instance_variable_string = "@#{sym}"
 
+        defaults_cache = @defaults
+
         define_method(method_name) do |y|
           if CushionDefaults.nilish? y
             if CushionDefaults.conf.whiny_ignores
@@ -210,7 +215,7 @@ module CushionDefaults
             end
             remove_instance_variable(instance_variable_string) if instance_variable_defined?(instance_variable_string)
           else
-            if CushionDefaults.conf.we_have_a_pushy? && defaults.pushy?(sym)
+            if CushionDefaults.conf.we_have_a_pushy? && defaults_cache.pushy?(sym)
               CushionDefaults.log("You are setting a value for #{sym}, but this is a pushy default and this value will not be returned by any cushion_readers.", :warn)
             end
             instance_variable_set(instance_variable_string, y)

data/lib/cushion_defaults/configuration.rb

@@ -134,7 +134,7 @@ module CushionDefaults
       self.bang_things_up = true
       self.record_in_log = true
       self.logger = Logger.new $stdout
-      self.log_lvl = Logger::INFO
+      self.log_lvl = Logger::WARN
       self.whiny_yaml = false
       self.whiny_ignores = false
       self.ignore_attempts_to_set_nil = true
@@ -210,8 +210,8 @@ module CushionDefaults
     # Specifies the formatter for logger. Will not be called if a logger is assigned with +should_assign_formatter+ set to
     # false.
     def assign_formatter_to_logger
-      logger.formatter = proc do |severity, time, progname, msg|
-        "\nCUSHIONDEFAULTS: #{severity}\n\t\##{progname ? "#{progname} at" : "At"} #{time.strftime('%d %b %Y, %H:%M:%S%p')}\n\t#{msg}\n"
+      logger.formatter = proc do |severity, _time, progname, msg|
+        "\nCUSHIONDEFAULTS: #{severity}\n\t\##{progname if progname}\n\t#{msg}\n"
       end
     end
   end

data/lib/cushion_defaults.rb

@@ -28,7 +28,7 @@ require 'cushion_defaults/errors'
 module CushionDefaults
 
   # Version constant
-  VERSION = '0.5.0'
+  VERSION = '0.5.1'
 
   # The path of the first file that +includes+ CushionDefaults.
   CALLING_PATH = File.expand_path(File.dirname($0)) + '/'
@@ -62,7 +62,7 @@ module CushionDefaults
     return unless conf.record_in_log
 
     # If caller_method_name is nil, magically get the name of the calling method
-    caller_method_name ||= caller_locations(1,1)[0].label.to_s
+    caller_method_name ||= caller[0].to_s
     conf.logger.progname = caller_method_name unless caller_method_name == ''
 
     case level

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: cushion_defaults
 version: !ruby/object:Gem::Version
-  version: 0.5.0
+  version: 0.5.1
 platform: ruby
 authors:
 - Ryan Mitchell
@@ -24,20 +24,6 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '2.11'
-- !ruby/object:Gem::Dependency
-  name: yard
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '0.8'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '0.8'
 description: Cushion your instance variables. Get a default if a variable isn’t defined.
   DRY off your code.
 email: posgarou@gmail.com
@@ -70,7 +56,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: 2.0.0
+      version: 1.9.3
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="