currentuser-services 0.2.2 → 0.2.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: ae898926da5133f9853c0ebaa2175501e5811373
-  data.tar.gz: 868f2530dd74510911dd066b2bdaf4c35714c4fb
+  metadata.gz: 4bed2624d3407bf18098ccda4f4091a6c1b16403
+  data.tar.gz: 43aaead3751bb9df1d2f6da1b76506eac57811d1
 SHA512:
-  metadata.gz: ce33859a9a81ce55ad6f1d1a681bd90f6a23a259e16861cf946ed8e4cef485a817bf0453737e62b367b91fc03dea561eb3549afcca42425da09cd48a2694f1aa
-  data.tar.gz: 3fb58eccbd97420401bd3130e16ffff5e3d574f0b39b3e831957f1e98176130e528c00029ad7269dd2756baf067dbf0d63d01c7b4e3a36bc5ccdc0e4a0632c41
+  metadata.gz: 76cd438c0731a783f151c4502b7cc979f806d9fe987c9521e2ce41f5a07ad3891176e6c2d23a99067c5d94b9c9fb8aaa6e76a79a1fb83c60840e63663ce61378
+  data.tar.gz: fb8b4e25f8e857a3aa7c2d2072e01a86ddc7c7eb1616c1f70cdc1d3f3d865c08032cbfd65780d75e3f5ea33461c911825d17ef5728041f040ed933d6b190047e

data/CHANGELOG.md

@@ -1,8 +1,14 @@
 # Changelog
 
+## 0.2.3 ##
+
+**Bugfix**
+
+* Don't use symbol in session values, as they may be stringified with Rails 4.2.0
+
 ## 0.2.2 ##
 
-** Bugfix**
+**Bugfix**
 
 * Fix controller requirement for ruby 2.1+
 

data/VERSION

@@ -1 +1 @@
-0.2.2
+0.2.3

data/app/controllers/currentuser/services/sessions_controller.rb

@@ -5,10 +5,16 @@ module Currentuser
       def sign_in
         Services.check_authentication_params!(params)
 
+        # Note: in this method, we create an hash with string keys because, with Rails 4.2.0, keys are stringified
+        # between two requests if session is stored in a json cookie (which is the default behavior for Rails 4.2.0).
+        hash = {}
+
         # Log in
-        session[:currentuser] = {id: params[:currentuser_id]}
+        hash['id'] = params[:currentuser_id]
         # Note that params[:sign_up] should equal 'true' (String) or should be absent.
-        session[:currentuser][:sign_up] = true  if params[:sign_up]
+        hash['sign_up'] = true  if params[:sign_up]
+
+        session[:currentuser] = hash
 
         redirect_to '/'
       end

data/currentuser-services.gemspec

@@ -2,16 +2,16 @@
 # DO NOT EDIT THIS FILE DIRECTLY
 # Instead, edit Jeweler::Tasks in Rakefile, and run 'rake gemspec'
 # -*- encoding: utf-8 -*-
-# stub: currentuser-services 0.2.2 ruby lib
+# stub: currentuser-services 0.2.3 ruby lib
 
 Gem::Specification.new do |s|
   s.name = "currentuser-services"
-  s.version = "0.2.2"
+  s.version = "0.2.3"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
   s.require_paths = ["lib"]
   s.authors = ["eric-currentuser"]
-  s.date = "2015-02-15"
+  s.date = "2015-03-04"
   s.description = "Offsite sign up and sign in forms for Currentuser.io"
   s.email = "TBD"
   s.extra_rdoc_files = [

data/lib/currentuser/services/controllers/authenticates.rb

@@ -11,7 +11,7 @@ module Currentuser
       end
 
       def currentuser_id
-        return @currentuser_id ||= currentuser_session && currentuser_session[:id]
+        return @currentuser_id ||= currentuser_session && currentuser_session['id']
       end
 
       def currentuser_sign_in_url

data/test/currentuser/services/authenticates_test.rb

@@ -30,7 +30,7 @@ module Currentuser
       # require_currentuser
 
       test 'execute action if currentuser_id is available' do
-        session[:currentuser] = {id: 'user_id_1'}
+        session[:currentuser] = {'id' => 'user_id_1'}
 
         get_with_route :test_action_requiring_user
         assert_response :ok
@@ -47,15 +47,15 @@ module Currentuser
       # currentuser_session
 
       test 'currentuser_session returns currentuser session' do
-        session[:currentuser] = {foo: 'blah'}
+        session[:currentuser] = {'foo' => 'blah'}
 
-        assert_equal({foo: 'blah'}, @controller.currentuser_session)
+        assert_equal({'foo' => 'blah'}, @controller.currentuser_session)
       end
 
       # currentuser_id
 
       test 'currentuser_id returns currentuser ID' do
-        session[:currentuser] = {id: 'user_id_1'}
+        session[:currentuser] = {'id' => 'user_id_1'}
 
         assert_equal 'user_id_1', @controller.currentuser_id
       end

data/test/currentuser/services/sessions_controller_test.rb

@@ -38,8 +38,8 @@ module Currentuser
         end
 
         assert_redirected_to '/'
-        assert_equal({id: user_id}, session[:currentuser])
-        refute session[:currentuser].has_key?(:sign_up)
+        assert_equal({'id' => user_id}, session[:currentuser])
+        refute session[:currentuser].has_key?('sign_up')
       end
 
       test 'sign_in sets sign_up if sign_up is true' do
@@ -54,7 +54,7 @@ module Currentuser
         end
 
         assert_redirected_to '/'
-        assert_equal true, session[:currentuser][:sign_up]
+        assert_equal true, session[:currentuser]['sign_up']
       end
 
       # This test proves that we use Services#check_authentication_params!
@@ -70,13 +70,13 @@ module Currentuser
       # sign_out
 
       test 'sign_out deletes session and redirects to root' do
-        session_hash = {currentuser: {foo: :blah}, other_key: :other_value}
+        session_hash = {currentuser: {'foo' => 'blah'}, other_key: 'other_value'}
 
         delete_with_route :sign_out, {}, session_hash
         assert_redirected_to '/'
 
         assert_nil session[:currentuser]
-        assert_equal :other_value, session[:other_key]
+        assert_equal 'other_value', session[:other_key]
       end
 
       # available

data/test/test_application/application.rb

@@ -20,7 +20,7 @@ module TestRailsApp
       render inline: "
         Private page
         <%= button_to 'Sign out', 'currentuser/sign_out', method: :delete %>
-        <% if currentuser_session[:sign_up] %>Sign Up<% end %>
+        <% if currentuser_session['sign_up'] %>Sign Up<% end %>
       "
     end
   end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: currentuser-services
 version: !ruby/object:Gem::Version
-  version: 0.2.2
+  version: 0.2.3
 platform: ruby
 authors:
 - eric-currentuser
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-02-15 00:00:00.000000000 Z
+date: 2015-03-04 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: gem_config