current_session 0.1.5 → 0.1.7

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 13ac22af37f6aa5545fb02c46c729473b043b67c4073c9b481015c422c7d5927
-  data.tar.gz: c2bd6c1da99e69a41ecadf263f2c0219633d45da7cb723476d4fb8904c8344ee
+  metadata.gz: 505b1421a5df8b13c947388a55f0af6224ebae0d7e61c552292896e53a7ffae8
+  data.tar.gz: 1d047d2c47aff4e1665a743d7d38cb5b964493525d0c3f611fcac36f22bc2ec9
 SHA512:
-  metadata.gz: 1e193a8e670f0f684dc509193b0d1ada1f092551b312cc3032527520e8c1957c413a2bd77c2637556498b5f898b49974839d4752e1d09792dda68a73e357cc5f
-  data.tar.gz: 4cd6ca157c873142fc4c43c9a14c2a16e7f8487364d94c116204e7aca36d9b005c5f05d44e80aa3264885363d08e74271d4d442c786d7359fd44c01ee47225d3
+  metadata.gz: fde9c27a98d38fd4bcc0a55c82921cfd19c9525538a9a618d91a575c287fe8611bac043f455c25d62e6b2703d03c962fa2b9e4aaa50f9a3a2b91eb087e41fbc6
+  data.tar.gz: c6fb18a168a5cdaf575d63ddcac4ef35bf9ba3943a15a76615e77301e63c2953117b7231e501f1e89381cc7850e19251ae6f32c1b691b3d5c6df0a6d93f97e8f

data/.rubocop.yml

@@ -17,7 +17,7 @@ Style/StringLiteralsInInterpolation:
   EnforcedStyle: double_quotes
 
 Layout/LineLength:
-  Max: 120
+  Max: 125
   Exclude:
     - current_session.gemspec
 

data/Gemfile

@@ -5,8 +5,10 @@ source "https://rubygems.org"
 # Specify your gem's dependencies in current_user_omniauth.gemspec
 gemspec
 
-gem "rake", "~> 13.0"
+gem "rake"
 
-gem "rspec", "~> 3.0"
+gem "rspec"
 
-gem "rubocop", "~> 1.7"
+gem "rubocop"
+gem "rubocop-performance"
+gem "rubocop-rspec"

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    current_session (0.1.4)
+    current_session (0.1.7)
       activesupport (>= 6.0.0)
 
 GEM
@@ -26,7 +26,7 @@ GEM
     hashie (5.0.0)
     i18n (1.12.0)
       concurrent-ruby (~> 1.0)
-    json (2.6.2)
+    json (2.6.3)
     method_source (1.0.0)
     minitest (5.16.3)
     omniauth (2.1.0)
@@ -34,43 +34,48 @@ GEM
       rack (>= 2.2.3)
       rack-protection
     parallel (1.22.1)
-    parser (3.1.2.1)
+    parser (3.1.3.0)
       ast (~> 2.4.1)
     pry (0.14.1)
       coderay (~> 1.1)
       method_source (~> 1.0)
-    rack (3.0.0)
-    rack-protection (3.0.1)
+    rack (3.0.2)
+    rack-protection (3.0.5)
       rack
     rainbow (3.1.1)
     rake (13.0.6)
-    regexp_parser (2.6.0)
+    regexp_parser (2.6.1)
     rexml (3.2.5)
-    rspec (3.11.0)
-      rspec-core (~> 3.11.0)
-      rspec-expectations (~> 3.11.0)
-      rspec-mocks (~> 3.11.0)
-    rspec-core (3.11.0)
-      rspec-support (~> 3.11.0)
-    rspec-expectations (3.11.1)
+    rspec (3.12.0)
+      rspec-core (~> 3.12.0)
+      rspec-expectations (~> 3.12.0)
+      rspec-mocks (~> 3.12.0)
+    rspec-core (3.12.0)
+      rspec-support (~> 3.12.0)
+    rspec-expectations (3.12.1)
       diff-lcs (>= 1.2.0, < 2.0)
-      rspec-support (~> 3.11.0)
-    rspec-mocks (3.11.1)
+      rspec-support (~> 3.12.0)
+    rspec-mocks (3.12.1)
       diff-lcs (>= 1.2.0, < 2.0)
-      rspec-support (~> 3.11.0)
-    rspec-support (3.11.1)
-    rubocop (1.36.0)
+      rspec-support (~> 3.12.0)
+    rspec-support (3.12.0)
+    rubocop (1.41.1)
       json (~> 2.3)
       parallel (~> 1.10)
       parser (>= 3.1.2.1)
       rainbow (>= 2.2.2, < 4.0)
       regexp_parser (>= 1.8, < 3.0)
       rexml (>= 3.2.5, < 4.0)
-      rubocop-ast (>= 1.20.1, < 2.0)
+      rubocop-ast (>= 1.23.0, < 2.0)
       ruby-progressbar (~> 1.7)
       unicode-display_width (>= 1.4.0, < 3.0)
-    rubocop-ast (1.21.0)
+    rubocop-ast (1.24.0)
       parser (>= 3.1.1.0)
+    rubocop-performance (1.15.1)
+      rubocop (>= 1.7.0, < 2.0)
+      rubocop-ast (>= 0.4.0)
+    rubocop-rspec (2.16.0)
+      rubocop (~> 1.33)
     ruby-progressbar (1.11.0)
     simplecov (0.21.2)
       docile (~> 1.1)
@@ -78,13 +83,16 @@ GEM
       simplecov_json_formatter (~> 0.1)
     simplecov-html (0.12.3)
     simplecov_json_formatter (0.1.4)
-    sqlite3 (1.5.1-arm64-darwin)
+    sqlite3 (1.5.4-arm64-darwin)
+    sqlite3 (1.5.4-x86_64-linux)
     tzinfo (2.0.5)
       concurrent-ruby (~> 1.0)
     unicode-display_width (2.3.0)
 
 PLATFORMS
   arm64-darwin-20
+  arm64-darwin-21
+  x86_64-linux
 
 DEPENDENCIES
   activerecord
@@ -92,9 +100,11 @@ DEPENDENCIES
   ffaker
   omniauth
   pry
-  rake (~> 13.0)
-  rspec (~> 3.0)
-  rubocop (~> 1.7)
+  rake
+  rspec
+  rubocop
+  rubocop-performance
+  rubocop-rspec
   simplecov
   sqlite3
 

data/lib/current_session/auth_method.rb

@@ -2,34 +2,11 @@
 
 module CurrentSession
   #
-  # Base class for providing auth methods
+  # auth method
   #
   class AuthMethod
-    class_attribute :user_class
-
-    class FindBy < self
-      def call(&block)
-        find_by_auth.try(&block)
-      end
-    end
-
-    class FindOrCreateBy < self
-      def call(&block)
-        find_or_create_by_auth.try(&block)
-      end
-    end
-
-    def self.new_auth_class(auth_methods_module)
-      new_auth_class =
-        if auth_methods_module.method_defined?(:find_by_auth)
-          Class.new(CurrentSession::AuthMethod::FindBy) { include auth_methods_module }
-        elsif auth_methods_module.method_defined?(:find_or_create_by_auth)
-          Class.new(CurrentSession::AuthMethod::FindOrCreateBy) { include auth_methods_module }
-        else
-          fail NotImplementedError, "You must implement find_by_auth or find_or_create_by_auth"
-        end
-      new_auth_class.user_class = user_class
-      new_auth_class
+    def self.new_class(methods)
+      Class.new(self) { include methods }
     end
 
     def initialize(request)
@@ -40,5 +17,12 @@ module CurrentSession
     def auth
       request.env["omniauth.auth"]
     end
+
+    #
+    # @return User
+    #
+    def connect
+      fail NotImplementedError, "You must implement #{self.class}##{__method__}"
+    end
   end
 end

data/lib/current_session/base.rb

@@ -6,48 +6,7 @@ module CurrentSession
   #
   class Base < ActiveSupport::CurrentAttributes
     include CurrentSession::Interface
+    include CurrentSession::Dsl
     attribute :current_user
-
-    class << self
-      attr_accessor :session_token_class
-      attr_reader :user_class
-
-      def user_class=(user_class)
-        @user_class = user_class
-        @auth_class.user_class = user_class if @auth_class
-      end
-
-      def current_time(_)
-        Time.current
-      end
-
-      def session_methods=(session_methods)
-        @session_methods = session_methods
-        @session_class = CurrentSession::SessionMethod.new_session_class(session_methods)
-      end
-
-      def session_methods(&block)
-        if block
-          @session_methods = Module.new(&block)
-          @session_class = CurrentSession::SessionMethod.new_session_class(session_methods)
-        else
-          @session_methods
-        end
-      end
-
-      def auth_methods=(auth_methods_module)
-        @auth_class = CurrentSession::AuthMethod.new_auth_class(auth_methods_module)
-      end
-
-      def auth_methods(&block)
-        if block
-          @auth_methods = Module.new(&block)
-          @auth_class = CurrentSession::AuthMethod.new_auth_class(auth_methods)
-          @auth_class.user_class = user_class
-        else
-          @auth_methods
-        end
-      end
-    end
   end
 end

data/lib/current_session/dsl.rb

@@ -0,0 +1,35 @@
+# frozen_string_literal: true
+
+module CurrentSession
+  #
+  # configuration dsl
+  #
+  module Dsl
+    extend ActiveSupport::Concern
+    class_methods do
+      def session_methods=(session_method)
+        @session_methods = CurrentSession::SessionMethod.new_class(session_method)
+      end
+
+      def session_methods(&block)
+        if block
+          @session_methods = CurrentSession::SessionMethod.new_class(Module.new(&block))
+        else
+          @session_methods
+        end
+      end
+
+      def auth_methods=(auth_method)
+        @auth_methods = CurrentSession::AuthMethod.new_class(auth_method)
+      end
+
+      def auth_methods(&block)
+        if block
+          @auth_methods = CurrentSession::AuthMethod.new_class(Module.new(&block))
+        else
+          @auth_methods
+        end
+      end
+    end
+  end
+end

data/lib/current_session/interface.rb

@@ -12,37 +12,18 @@ module CurrentSession
       end
 
       def update(request)
-        session_repository(request).try do |repository|
-          repository.find { |user| self.current_user = user }
-        end
+        self.current_user = @session_methods.new(request).find
         self
       end
 
       def create(request)
-        auth = @auth_class.new(request)
-        auth.call do |user|
-          auth.update(user)
-          session_repository(request).update_session_token(user)
-        end
+        self.current_user = @auth_methods.new(request).connect
+        @session_methods.new(request).create(current_user)
+        self
       end
 
       def destroy(request)
-        self.current_user = nil
-        session_repository(request).try do |repository|
-          repository.destroy
-          repository.delete_session_token
-        end
-      end
-
-      private
-
-      def session_repository(request)
-        @session_class.new(
-          request: request,
-          user_class: user_class,
-          session_token_class: session_token_class,
-          current_time: current_time(request)
-        )
+        @session_methods.new(request).destroy
       end
     end
   end

data/lib/current_session/session_method.rb

@@ -2,45 +2,45 @@
 
 module CurrentSession
   #
-  # Base class for processing to get session_token from request.session
+  # session Method
   #
   class SessionMethod
-    def self.new_session_class(session_methods)
-      Class.new(CurrentSession::SessionMethod) { include session_methods }
-    end
-
-    def initialize(current_time:, request:, user_class:, session_token_class:)
-      @current_time = current_time
-      @request = request
-      @user_class = user_class
-      @session_token_class = session_token_class
+    def self.new_class(methods)
+      Class.new(self) do
+        include methods
+      end
     end
-    attr_reader :current_time, :request, :user_class, :session_token_class
 
-    def key
-      @key ||= CurrentSession.key(user_class)
+    def self.define(&block)
+      Module.new do
+        define_method(:find, &block)
+        define_method(:create) {}
+        define_method(:destroy) {}
+      end
     end
 
-    def session_token
-      @session_token ||= request.session[key]
+    def initialize(request)
+      @request = request
     end
+    attr_reader :request
 
-    def new_session_token
-      SecureRandom.urlsafe_base64(64)
+    #
+    # @return User
+    #
+    def find
+      fail NotImplementedError, "You must implement #{self.class}##{__method__}"
     end
 
-    def delete_session_token
-      request.session.delete(key)
+    def create(user)
+      fail NotImplementedError, "You must implement #{self.class}##{__method__}"
     end
 
-    def update_session_token(user)
-      request.session[key] = create(user)
+    def destroy
+      fail NotImplementedError, "You must implement #{self.class}##{__method__}"
     end
 
-    def try
-      session_token.presence.try do |_|
-        yield self
-      end
+    def new_session_token
+      SecureRandom.urlsafe_base64(128)
     end
   end
 end

data/lib/current_session/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module CurrentSession
-  VERSION = "0.1.5"
+  VERSION = "0.1.7"
 end

data/lib/current_session.rb

@@ -9,12 +9,12 @@ require "active_support"
 module CurrentSession
   extend ActiveSupport::Autoload
   autoload :Base
+  autoload :Dsl
   autoload :Interface
   autoload :AuthMethod
   autoload :SessionMethod
-  autoload :SessionMethods
 
-  def self.key(user_class)
-    "session_#{user_class.name.underscore.parameterize(separator: "_")}_key"
+  def self.key(namespace)
+    "session_#{namespace.name.underscore.parameterize(separator: "_")}_key"
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: current_session
 version: !ruby/object:Gem::Version
-  version: 0.1.5
+  version: 0.1.7
 platform: ruby
 authors:
 - Masa (Aileron inc)
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2022-10-21 00:00:00.000000000 Z
+date: 2022-12-23 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -148,12 +148,9 @@ files:
 - lib/current_session.rb
 - lib/current_session/auth_method.rb
 - lib/current_session/base.rb
+- lib/current_session/dsl.rb
 - lib/current_session/interface.rb
 - lib/current_session/session_method.rb
-- lib/current_session/session_methods.rb
-- lib/current_session/session_methods/active_record_session.rb
-- lib/current_session/session_methods/env_session.rb
-- lib/current_session/session_methods/uid_session.rb
 - lib/current_session/version.rb
 homepage: https://github.com/aileron-inc/current_session
 licenses:
@@ -175,7 +172,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.2.22
+rubygems_version: 3.3.26
 signing_key:
 specification_version: 4
 summary: Library for current_user using ActiveSupport::CurrentAttributes

data/lib/current_session/session_methods/active_record_session.rb

@@ -1,35 +0,0 @@
-# frozen_string_literal: true
-
-module CurrentSession
-  module SessionMethods
-    #
-    # Implementation of session tokens for DB management
-    #
-    module ActiveRecordSession
-      def find
-        session_token_class.find_by(value: session_token).try do |record|
-          update(record)
-          yield record.user
-        end
-      end
-
-      def create(user)
-        session_token_class.create(user_id: user.id, value: new_session_token) do |record|
-          update(record)
-        end.value
-      end
-
-      def update(token)
-        token.update(
-          last_request_at: current_time,
-          last_request_ip: request.remote_ip,
-          last_request_user_agent: request.user_agent
-        )
-      end
-
-      def destroy
-        session_token_class.find_by(value: session_token)&.destroy
-      end
-    end
-  end
-end

data/lib/current_session/session_methods/env_session.rb

@@ -1,32 +0,0 @@
-# frozen_string_literal: true
-
-module CurrentSession
-  module SessionMethods
-    #
-    # repository to return the user specified by the environment variable
-    #
-    module EnvSession
-      # rubocop:disable Metrics/MethodLength
-      def self.build(current_user_id)
-        Module.new do
-          define_method(:current_user) { user_class.find(current_user_id) }
-
-          def try
-            yield self
-          end
-
-          def find
-            yield current_user
-          end
-
-          def create(_)
-          end
-
-          def destroy
-          end
-        end
-      end
-      # rubocop:enable Metrics/MethodLength
-    end
-  end
-end

data/lib/current_session/session_methods/uid_session.rb

@@ -1,21 +0,0 @@
-# frozen_string_literal: true
-
-module CurrentSession
-  module SessionMethods
-    #
-    # Implementation of using UIDs as session tokens
-    #
-    module UidSession
-      def find(&block)
-        user_class.find_by(uid: session_token).try(&block)
-      end
-
-      def create(user)
-        user.uid
-      end
-
-      def destroy
-      end
-    end
-  end
-end

data/lib/current_session/session_methods.rb

@@ -1,13 +0,0 @@
-# frozen_string_literal: true
-
-#
-# Reference implementation of session_methods
-#
-module CurrentSession
-  module SessionMethods
-    extend ActiveSupport::Autoload
-    autoload :UidSession
-    autoload :EnvSession
-    autoload :ActiveRecordSession
-  end
-end