currency_quote 0.1.3 → 0.1.8

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 9c53cd739f292d46b462b70e99d93f3797f41df61758104293c77f4bf8573ffc
-  data.tar.gz: 382045e0d812adeb655fe084bb13463c9f7bb688081ec406a91d98815f55b494
+  metadata.gz: a40c658e70dd631e2ebfe07cb250b1aee1917b65d152b76704f508877eee6413
+  data.tar.gz: eccea7c2458ad7f76686fb6b8e5c471c1cceb6fd57dbcbe537ee82f3c7da1408
 SHA512:
-  metadata.gz: c4fc3365c86ac13ead56a1bf3dae0dc0a57072c7806ba23d2196ff5fa9165a8afcb70dd676789a0abb0d9b8d97ae86bf24b406fbca36efaf74453754c5a3d4a3
-  data.tar.gz: '096fe84138e2fde1b9b082658d7c6748bd8ffa4602f3de6b7e56270e78a75ced9b513da9ff35ecbc9becaf5e6eddcb6952c8365338a216e3a40feedcaf71e5c0'
+  metadata.gz: f799969d09d60bd074429f6d5a91f7a8fda187d9f5c645e3e14f5950897651934ca0dc7ba50596c47a6c8b4f26a755d9b3088e71f471593e910f6345eb525502
+  data.tar.gz: c00160541e39ec418cea55f75024bc186591cced6f91fe77132ee825885a44b355319f25cf94d08e6a07645463c63b7438277cc0ec44aaef8a2a99b954d8f6ea

data/Gemfile

@@ -7,3 +7,5 @@ gem "rake", "~> 12.0"
 gem "rspec", "~> 3.0"
 
 gem "nokogiri", "~> 1.10"
+
+gem "addressable", "~> 2.7"

data/Gemfile.lock

@@ -1,15 +1,18 @@
 PATH
   remote: .
   specs:
-    currency_quote (0.1.2)
+    currency_quote (0.1.7)
 
 GEM
   remote: https://rubygems.org/
   specs:
+    addressable (2.7.0)
+      public_suffix (>= 2.0.2, < 5.0)
     diff-lcs (1.4.4)
     mini_portile2 (2.4.0)
     nokogiri (1.10.10)
       mini_portile2 (~> 2.4.0)
+    public_suffix (4.0.6)
     rake (12.3.3)
     rspec (3.10.0)
       rspec-core (~> 3.10.0)
@@ -29,6 +32,7 @@ PLATFORMS
   ruby
 
 DEPENDENCIES
+  addressable (~> 2.7)
   currency_quote!
   nokogiri (~> 1.10)
   rake (~> 12.0)

data/lib/currency_quote.rb

@@ -1,9 +1,6 @@
 require_relative "currency_quote/version"
 require_relative "currency_quote/dolar"
 require_relative "currency_quote/currency"
-require_relative "support/hash.rb"
-require_relative "support/string.rb"
-require_relative "support/symbol.rb"
 
 module CurrencyQuote
 	class Error < StandardError; end

data/lib/currency_quote/currency.rb

@@ -14,10 +14,14 @@ class CurrencyQuote::Currency
 	end
 
 	def get_quotation
-		get_dolar_quotation
-		make_get_to_bcra
-		get_currency_quotation
-		return struct
+		if currency == "Dolar Estadounidense" 
+			return get_dolar_quotation
+		else
+			get_dolar_quotation
+			make_get_to_bcra
+			get_currency_quotation
+			return struct
+		end
 	end
 
 	private
@@ -36,7 +40,7 @@ class CurrencyQuote::Currency
 			index = data.index(currency)
 			if index
 				quote = data[index + 1].gsub(",", ".").to_f
-				quote = 1 if quote == 0
+				quote = 1.0 if quote == 0
 				@sell = (dolar.sell * quote).to_f
 				@buy  = (dolar.buy * quote).to_f
 			else

data/lib/currency_quote/dolar.rb

@@ -2,6 +2,7 @@ class CurrencyQuote::Dolar
 	require 'open-uri'
 	require 'nokogiri'
 	require 'date'
+	require "addressable/uri"
 
 	attr_accessor :date, :doc, :sell, :buy
 
@@ -20,14 +21,14 @@ class CurrencyQuote::Dolar
 	private
 
 		def make_get_to_bna
-			
-			opts = {
+			params = Addressable::URI.new
+			params.query_values = {
 				id: 'billetes',
 				fecha: date,
 				filtroEuro: 0,
 				filtroDolar: 1
 			}
-			url = "#{BASE_URL}?#{opts.to_param}"
+			url = "#{BASE_URL}?#{params.query}"
 
 			@doc = Nokogiri::HTML( URI.open(url) )
 		end
@@ -35,8 +36,8 @@ class CurrencyQuote::Dolar
 		def extract_data
 			data = @doc.css("td").map(&:text)
 			@date = data[data.size - 1]
-			@sell = data[data.size - 2].to_f
-			@buy  = data[data.size - 3].to_f
+			@sell = data[data.size - 2].gsub(",", ".").to_f
+			@buy  = data[data.size - 3].gsub(",", ".").to_f
 		end
 
 		def struct

data/lib/currency_quote/version.rb

@@ -1,3 +1,3 @@
 module CurrencyQuote
-  VERSION = "0.1.3"
+  VERSION = "0.1.8"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: currency_quote
 version: !ruby/object:Gem::Version
-  version: 0.1.3
+  version: 0.1.8
 platform: ruby
 authors:
 - Facundo A. Díaz Martínez
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2020-11-16 00:00:00.000000000 Z
+date: 2020-11-17 00:00:00.000000000 Z
 dependencies: []
 description: 
 email:
@@ -34,9 +34,6 @@ files:
 - lib/currency_quote/currency.rb
 - lib/currency_quote/dolar.rb
 - lib/currency_quote/version.rb
-- lib/support/hash.rb
-- lib/support/string.rb
-- lib/support/symbol.rb
 homepage: https://www.sesocio.com
 licenses:
 - MIT

data/lib/support/hash.rb

@@ -1,12 +0,0 @@
-class Hash
-
-	def to_query(namespace = nil)
-		query = collect do |key, value|
-			value.to_s.to_query(namespace ? "#{namespace}[#{key}]" : key)
-		end.compact
-
-		query.sort! unless namespace.to_s.include?("[]")
-		query.join("&")
-	end
-	alias_method :to_param, :to_query
-end

data/lib/support/string.rb

@@ -1,8 +0,0 @@
-class String
-	require "cgi"
-
-	def to_query(key)
-		"#{CGI.escape(key.to_s)}=#{CGI.escape(self)}"
-	end
-	alias_method :to_param, :to_query
-end

data/lib/support/symbol.rb

@@ -1,8 +0,0 @@
-class Symbol
-	require "cgi"
-
-	def to_query
-		CGI.escape(self.to_s)
-	end
-	alias_method :to_param, :to_query
-end