currency_exchange 0.0.2 → 0.0.3

data/currency_exchange.gemspec

@@ -20,8 +20,7 @@ Gem::Specification.new do |s|
 
   # specify any dependencies here; for example:
   s.add_development_dependency "rspec"
-  s.add_runtime_dependency "rest-client"
-  s.add_runtime_dependency "json"
-  s.add_runtime_dependency "activesupport", ">= 3.2.0"
-  s.add_runtime_dependency "rails", ">= 3.2.0"
+  s.add_development_dependency "rest-client"
+  s.add_development_dependency "json"
+  s.add_development_dependency "rails", ">= 3.2.0"
 end

data/lib/currency_exchange.rb

@@ -7,8 +7,8 @@ module CurrencyExchange
   end
 
   module Transporters
-    autoload :ExchangeTransporter, 'currency_exchange/transporters/exchange_transporter'
     autoload :JsonTransporter, 'currency_exchange/transporters/json_transporter'
+    autoload :ExchangeTransporter, 'currency_exchange/transporters/exchange_transporter'
   end
 
   module Data
@@ -16,8 +16,8 @@ module CurrencyExchange
   end
 
   module Storage
+    autoload :RailsCache, 'currency_exchange/storage/rails_cache'
     autoload :Cache, 'currency_exchange/storage/cache'
-    autoload :MemCache, 'currency_exchange/storage/mem_cache'
   end
 
   class << self

data/lib/currency_exchange/storage/cache.rb

@@ -1,7 +1,7 @@
 module CurrencyExchange
   class Storage::Cache
 
-    CACHE_STRATEGY = { :memcache => CurrencyExchange::Storage::MemCache }
+    CACHE_STRATEGY = { :rails_cache => CurrencyExchange::Storage::RailsCache }
 
     class << self
       attr_accessor :cache_strategy

data/lib/currency_exchange/storage/{mem_cache.rb → rails_cache.rb}

@@ -1,19 +1,19 @@
 begin 
   require 'rails'
 rescue LoadError
-  raise "You don't have rails installed"
+  raise "You don't have required libraries installed"
 end
 
 module CurrencyExchange
   module Storage
-    class MemCache < Cache
+    class RailsCache < Cache
 
       def fetch(key)
         Rails.cache.read(key)
       end
       
       def store(key, value)
-        Rails.cache.write(key, value, :expires_in => 1.day)
+        Rails.cache.write(key, value, :expires_in => 86400)
         value
       end
     end

data/lib/currency_exchange/transporters/exchange_transporter.rb

@@ -1,10 +1,3 @@
-begin
-  require 'rest-client'
-  require 'json'
-rescue LoadError
-  raise "You don't have the required gems installed"
-end
-
 module CurrencyExchange
   module Transporters
     class ExchangeTransporter

data/lib/currency_exchange/version.rb

@@ -1,3 +1,3 @@
 module CurrencyExchange
-  VERSION = "0.0.2"
+  VERSION = "0.0.3"
 end

data/spec/storage/cache_spec.rb

@@ -0,0 +1,49 @@
+require 'spec_helper'
+
+describe CurrencyExchange::Storage::Cache do
+
+  describe "#cache_strategy" do
+    let(:cache_strategy) { :ok }
+    
+    before do
+      CurrencyExchange::Storage::Cache.cache_strategy = cache_strategy 
+    end
+
+    it "should set a cache strategy" do
+      CurrencyExchange::Storage::Cache.cache_strategy.should == cache_strategy
+     end
+  end
+
+  describe "#load_instance" do
+    let(:cache_strategy) { nil }
+    subject { CurrencyExchange::Storage::Cache.send(:load_instance) }
+
+    before do
+      CurrencyExchange::Storage::Cache.cache_strategy = cache_strategy 
+    end
+
+    it "should return self" do
+      subject.class.should == CurrencyExchange::Storage::Cache
+    end
+
+    context "when strategy is to rails cache" do
+      let(:cache_strategy) { :rails_cache }
+
+      it "should return rails cache storage" do
+         subject.class.should == CurrencyExchange::Storage::RailsCache
+      end
+    end
+  end
+
+  describe "#store" do
+    let(:key) { "abc" }
+    let(:value) { 10 }
+    subject { CurrencyExchange::Storage::Cache.new.store(key, value) }
+
+    it "should not store and return value" do
+      subject.should == value 
+    end
+  end
+  
+end
+

data/spec/storage/rails_cache_spec.rb

@@ -0,0 +1,33 @@
+require 'spec_helper'
+
+describe CurrencyExchange::Storage::RailsCache do
+
+  describe "#fetch" do
+    let(:cache_data) { "my data" }
+    let(:key) { 123 }
+
+    subject { CurrencyExchange::Storage::RailsCache.new.fetch(key) }
+
+    before do
+      Rails.stub_chain(:cache, :read).and_return(cache_data)
+    end
+
+    it "should retrieve from cache" do
+      subject.should == cache_data
+    end
+  end
+
+  describe "#store" do
+    let(:key) { 123 }
+    let(:value) { "ok" }
+    subject {  CurrencyExchange::Storage::RailsCache.new.store(key, value) }
+
+    before do
+      Rails.stub_chain(:cache, :write).with(key, value, anything()).and_return(true)
+    end
+
+    it "should return back value" do
+      subject.should == value
+    end
+  end
+end

data/spec/transporters/exchange_transporter_spec.rb

@@ -0,0 +1,59 @@
+require 'spec_helper'
+
+describe CurrencyExchange::Transporters::ExchangeTransporter do
+
+  describe "#load_instance" do
+    let(:strategy) { nil }
+    subject { CurrencyExchange::Transporters::ExchangeTransporter.load_instance(strategy) }
+
+    context "when strategy is to use json" do
+      let(:strategy) { :json }
+
+      it "should return json transporter" do
+        subject.class.should == CurrencyExchange::Transporters::ExchangeTransporter::TRANSPORTER_STRATEGY[:json]
+      end
+    end
+
+    it "should return an instance of itself" do
+      subject.class.should == CurrencyExchange::Transporters::ExchangeTransporter
+    end
+  end
+
+  describe "#fetch_data" do
+    let(:url) { "http://www.blah.com" }
+
+    subject { CurrencyExchange::Transporters::ExchangeTransporter.new.fetch_data(url) }
+    it "should throw a not implemented error" do
+      expect { subject }.to raise_error(NotImplementedError)
+    end
+  end
+
+  describe "#retrieve_rates" do
+    let(:url) { "http://www.blah.com" }
+    let(:fetch_data) { "fetched data" }
+    let(:store_data) { "store data" }
+    let(:storage) { mock('storage', :fetch => fetch_data, :store => store_data) }
+    let(:transporter) { CurrencyExchange::Transporters::ExchangeTransporter.new }
+
+    subject { transporter.retrieve_rates(url) }
+
+    before do
+      CurrencyExchange::Storage::Cache.stub(:instance).and_return(storage)
+      transporter.stub(:fetch_data)
+    end
+
+    it "should return data in storage" do
+      subject.should == fetch_data
+    end
+
+    context "when fetch data is nil" do
+      let(:fetch_data) { nil }
+
+      it "should store and return data" do
+        subject.should == store_data
+      end
+    end
+  end
+  
+end
+

data/spec/transporters/json_transporter_spec.rb

@@ -0,0 +1,29 @@
+require 'spec_helper'
+
+describe CurrencyExchange::Transporters::JsonTransporter do
+
+  describe "#fetch_data" do
+    let(:url) { "http://www.blah.com" }
+    let(:body) { '{"one":true}' }
+    let(:json) { { 'one' => true } }
+    let(:response) { mock("response", :body => body) }
+
+    subject { CurrencyExchange::Transporters::JsonTransporter.new.fetch_data url }
+
+    before do
+      RestClient.stub(:get).and_return(response)
+    end
+
+    it "should call rest client" do
+      RestClient.should_receive(:get).with(url, anything())
+      subject
+    end
+
+    it "should retrieve body of response" do
+      subject.should == json
+    end
+  end
+  
+end
+
+

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification 
 name: currency_exchange
 version: !ruby/object:Gem::Version 
-  hash: 27
+  hash: 25
   prerelease: 
   segments: 
   - 0
   - 0
-  - 2
-  version: 0.0.2
+  - 3
+  version: 0.0.3
 platform: ruby
 authors: 
 - Thil Bandara
@@ -15,7 +15,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2012-02-14 00:00:00 Z
+date: 2012-02-15 00:00:00 Z
 dependencies: 
 - !ruby/object:Gem::Dependency 
   name: rspec
@@ -43,7 +43,7 @@ dependencies:
         segments: 
         - 0
         version: "0"
-  type: :runtime
+  type: :development
   version_requirements: *id002
 - !ruby/object:Gem::Dependency 
   name: json
@@ -57,10 +57,10 @@ dependencies:
         segments: 
         - 0
         version: "0"
-  type: :runtime
+  type: :development
   version_requirements: *id003
 - !ruby/object:Gem::Dependency 
-  name: activesupport
+  name: rails
   prerelease: false
   requirement: &id004 !ruby/object:Gem::Requirement 
     none: false
@@ -73,24 +73,8 @@ dependencies:
         - 2
         - 0
         version: 3.2.0
-  type: :runtime
+  type: :development
   version_requirements: *id004
-- !ruby/object:Gem::Dependency 
-  name: rails
-  prerelease: false
-  requirement: &id005 !ruby/object:Gem::Requirement 
-    none: false
-    requirements: 
-    - - ">="
-      - !ruby/object:Gem::Version 
-        hash: 15
-        segments: 
-        - 3
-        - 2
-        - 0
-        version: 3.2.0
-  type: :runtime
-  version_requirements: *id005
 description: A basic library to retrieve and convert currency
 email: 
 - tbandara@gmail.com
@@ -110,7 +94,7 @@ files:
 - lib/currency_exchange/exchangers/open_exchange.rb
 - lib/currency_exchange/ext/fixnum.rb
 - lib/currency_exchange/storage/cache.rb
-- lib/currency_exchange/storage/mem_cache.rb
+- lib/currency_exchange/storage/rails_cache.rb
 - lib/currency_exchange/transporters/exchange_transporter.rb
 - lib/currency_exchange/transporters/json_transporter.rb
 - lib/currency_exchange/version.rb
@@ -118,6 +102,10 @@ files:
 - spec/exchangers/open_exchange_spec.rb
 - spec/ext/fixnum_spec.rb
 - spec/spec_helper.rb
+- spec/storage/cache_spec.rb
+- spec/storage/rails_cache_spec.rb
+- spec/transporters/exchange_transporter_spec.rb
+- spec/transporters/json_transporter_spec.rb
 homepage: https://github.com/thil/currency_exchange
 licenses: []
 
@@ -156,3 +144,7 @@ test_files:
 - spec/exchangers/open_exchange_spec.rb
 - spec/ext/fixnum_spec.rb
 - spec/spec_helper.rb
+- spec/storage/cache_spec.rb
+- spec/storage/rails_cache_spec.rb
+- spec/transporters/exchange_transporter_spec.rb
+- spec/transporters/json_transporter_spec.rb