currency_converter 1.0.2 → 1.1.0

checksums.yaml

@@ -1,15 +1,15 @@
 ---
 !binary "U0hBMQ==":
   metadata.gz: !binary |-
-    NTUxNzgxMzNiMDcwNDZlZGRhNThmNTkxZDkxODRjZWEyNzVjNzkxNA==
+    NmY1MDE3MzYzYTYzMGMyYWY0ZjlkNjkyNmIxODUyZWNmNDIyMjgwZA==
   data.tar.gz: !binary |-
-    YTcyZDdmMjFjNmU5ODlmZWNhNTczYTczYmFiMWFhZDJiYTk4NmUyYw==
+    ZDcwMWFjYmEwYjc2YWZiMDI3NTQ3NjM3MTRiZWY3NGVmMTBiYTM1Yg==
 SHA512:
   metadata.gz: !binary |-
-    MTg0MTg1YWI5YjUxNDM3YmZiMzlmMTQ0NTk0YTU1NmVhYWM1NzBkMzAxY2Fj
-    YTljNjg5YzVhMTQzNWUzOGJhMWFmNjQzMmVlOGY0MmQ1YzExM2NhODJhYTA2
-    ZjA0NzNlNTMzZmM3ZjFlNzliZTdiMDc2MzBmMTdhZWIzODIxMTE=
+    NzYwMDQ3MDVlODU1MmYxZjVkMjRkZWI2YjYxYmI1NjEzN2NmYThkYjlkNDVk
+    MWE3OWY1MGJmYmQ3MzgzNjE1ZjBlYTgxNjY1YWNlZjllMTMwNTk1MjBkNWMw
+    YmE0Y2MxMmVkNjA4YWQ0NDY5ZTJhYjlhZjFjNjdlMWU5YWIxYmY=
   data.tar.gz: !binary |-
-    Mzk0YWExMWRlYzc2ZTA5YjQxMTIwMDU0ZTdkNTUwNTkxNjFmNDUyM2RlZjdk
-    N2Q3Yzg3OTM3YWYzYmZmZGE2MzFlMzlmZDI0MWU3NjdkMDgwMGUzZjM3YjI5
-    YWZjM2JhNTZiNTdhYmQ2NjliYTE0M2RmMDg3ZmY2NzdjNDI2NmM=
+    MmQwZDk3NzRhODExOTE0ZDIxNTM2MGJlMzA1NzVjYThlYTM4NGI0YjJjOTE0
+    YjI5OGZkYjc1NWUxNzI0MWNlNWQwOTQyMjY5MGQ3ZWE4YTYzYzFiZTAzYjRm
+    NzI3YzU2MGRiNjU1MjAxMzVjYWE3NDk2NDg2ODM4NWNkNzgwZWU=

data/.travis.yml

@@ -0,0 +1,16 @@
+language: ruby
+rvm:
+  - 1.9.3
+  - 2.0.0
+  - 2.1.0
+  - 2.1.1
+  - 2.2
+
+before_install:
+  - gem install bundler
+
+install:
+  - travis_retry bundle install
+
+script:
+  - bundle exec rake spec

data/README.md

@@ -1,6 +1,6 @@
 # CurrencyConverter
 
-Simple Ruby API to get exchange rates from currencies using themoneyconverter.com website. You can convert currencies directly through this library.
+Simple Ruby API to get exchange rates from currencies using Google finance currency converter and Yahoo finance currency converter. You can convert currencies directly through this library.
 
 ## Installation
 
@@ -18,20 +18,22 @@ Or install it yourself as:
 
 ## Usage
 
-To convert between two currencies:
+To convert between two currencies using Google finance currency converter:
 
-    CurrencyConverter.exchange("EUR", "USD", 100)
+    currency_converter = CurrencyConverter::Google.new
+    currency_converter.exchange("EUR", "USD", 100)
     => 132.89
 
-    CurrencyConverter.exchange("USD", "EUR", 100)
+    currency_converter.exchange("USD", "EUR", 100)
     => 75.15
 
-To get the most recent exchange rate between two currencies:
+To convert between two currencies using Yahoo finance currency converter:
 
-    CurrencyConverter.exchange("EUR", "USD", 1)
+    currency_converter = CurrencyConverter::Yahoo.new
+    currency_converter.exchange("EUR", "USD", 1)
     => 1.33
 
-    CurrencyConverter.exchange("USD", "EUR", 1)
+    currency_converter.exchange("USD", "EUR", 1)
     => 0.75
 
 ## Contributing

data/lib/currency_converter.rb

@@ -1,67 +1,3 @@
-require 'currency_converter/exceptions'
-require 'currency_converter/currencies'
 require 'currency_converter/version'
-require 'net/http'
-require 'nokogiri'
-
-module CurrencyConverter
-  class << self
-    # Returns the Symbol of 'from' currency
-    attr_reader :from_currency
-
-    # Returns the Symbol of 'to' currency
-    attr_reader :to_currency
-
-    # Receive the amount of you desire currency.
-    #
-    # @param [String, String, Numeric] other currency to exchange to.
-    #
-    # @return [amount]
-    #
-    # @example
-    # CurrencyConverter.exchange("USD", "EUR", 100)
-    # CurrencyConverter.exchange("USD", "INR", 100)
-    def exchange(from, to, fixnum)
-      @from_currency = from.upcase.to_sym
-      @to_currency = to.upcase.to_sym
-
-      validate_currency
-
-      ex_rate = exchange_rate
-
-      validate_rate(ex_rate)
-
-      ex_rate.to_f * fixnum
-    end
-
-    private
-
-    # Returns the Float value of rate or nil
-    def exchange_rate
-      http = Net::HTTP.new('themoneyconverter.com', 80)
-      url = "/CurrencyConverter.aspx?from=#{from_currency.to_s.upcase}&to=#{to_currency.to_s.upcase}"
-      response = http.get(url)
-
-      doc = Nokogiri::HTML(response.body)
-      result = doc.css('div.cc-rate textarea').first.text
-
-      regexp = Regexp.new('(\\d+(?:\\.\\d+)?)')
-      regexp.match result
-
-      return $1
-    rescue Timeout::Error
-      raise StandardError, "Please check your internet connection"
-    end
-
-    # Raise errors for invalid currencies.
-    def validate_currency
-      raise UnknownCurrency.new(from_currency) unless CurrencyConverter::CURRENCIES.has_key?(from_currency)
-      raise UnknownCurrency.new(to_currency) unless CurrencyConverter::CURRENCIES.has_key?(to_currency)
-    end
-
-    # Raise errors for missing data.
-    def validate_rate(rate)
-      raise MissingExchangeRate.new(from_currency, to_currency) if rate.to_f.zero?
-    end
-  end
-end
+require 'currency_converter/google'
+require 'currency_converter/yahoo'

data/lib/currency_converter/google.rb

@@ -0,0 +1,67 @@
+require 'currency_converter/exceptions'
+require 'currency_converter/currencies'
+require 'net/http'
+require 'nokogiri'
+
+module CurrencyConverter
+  class Google
+    # Returns the Symbol of 'from' currency
+    attr_reader :from_currency
+
+    # Returns the Symbol of 'to' currency
+    attr_reader :to_currency
+
+    # Receive the amount of you desire currency.
+    #
+    # @param [String, String, Numeric] other currency to exchange to.
+    #
+    # @return [amount]
+    #
+    # @example
+    # currency_converter = CurrencyConverter::Google.new
+    # currency_converter.exchange("USD", "EUR", 100)
+    # currency_converter.exchange("USD", "INR", 100)
+    def exchange(from, to, fixnum)
+      @from_currency = from.upcase.to_sym
+      @to_currency = to.upcase.to_sym
+
+      validate_currency
+
+      ex_rate = exchange_rate
+
+      validate_rate(ex_rate)
+
+      ex_rate.to_f * fixnum
+    end
+
+    private
+
+    # Returns the Float value of rate or nil
+    def exchange_rate
+      http = Net::HTTP.new('themoneyconverter.com', 80)
+      url = "/CurrencyConverter.aspx?from=#{from_currency.to_s.upcase}&to=#{to_currency.to_s.upcase}"
+      response = http.get(url)
+
+      doc = Nokogiri::HTML(response.body)
+      result = doc.css('div.cc-rate textarea').first.text
+
+      regexp = Regexp.new('(\\d+(?:\\.\\d+)?)')
+      regexp.match result
+
+      return $1
+    rescue Timeout::Error
+      raise StandardError, "Please check your internet connection"
+    end
+
+    # Raise errors for invalid currencies.
+    def validate_currency
+      raise CurrencyConverter::UnknownCurrency.new(from_currency) unless CurrencyConverter::CURRENCIES.has_key?(from_currency)
+      raise CurrencyConverter::UnknownCurrency.new(to_currency) unless CurrencyConverter::CURRENCIES.has_key?(to_currency)
+    end
+
+    # Raise errors for missing data.
+    def validate_rate(rate)
+      raise CurrencyConverter::MissingExchangeRate.new(from_currency, to_currency) if rate.to_f.zero?
+    end
+  end
+end

data/lib/currency_converter/version.rb

@@ -1,3 +1,3 @@
 module CurrencyConverter
-  VERSION = "1.0.2"
-end
+  VERSION = "1.1.0"
+end

data/lib/currency_converter/yahoo.rb

@@ -0,0 +1,82 @@
+require 'currency_converter/exceptions'
+require 'currency_converter/currencies'
+require 'net/http'
+require 'nokogiri'
+
+module CurrencyConverter
+  class Yahoo
+    # Returns the Symbol of 'base' currency
+    attr_reader :from_currency
+
+    # Returns the Symbol of 'quot' currency
+    attr_reader :to_currency
+
+    # Returns the array of currencies rates
+    attr_reader :rates
+
+    def initialize
+      response = fetch_data
+
+      parse_rates(response.body)
+    end
+
+    # Receive the amount of you desire currency.
+    #
+    # @param [String, String, Numeric] other currency to exchange to.
+    #
+    # @return [amount]
+    #
+    # @example
+    # currency_converter = CurrencyConverter::Yahoo.new
+    # currency_converter.exchange("USD", "EUR", 100)
+    # currency_converter.exchange("USD", "INR", 100)
+    def exchange(base, quot, amount)
+      @from_currency = base.upcase.to_sym
+      @to_currency = quot.upcase.to_sym
+
+      validate_currency
+
+      base_rate = rates[@from_currency].to_f
+      quot_rate = rates[@to_currency].to_f
+
+      rate = base_rate.zero? ? 0 : (quot_rate / base_rate)
+      validate_rate(rate)
+
+      amount * rate
+    end
+
+    private
+
+    def fetch_data
+      api = "http://finance.yahoo.com/webservice/v1/symbols/allcurrencies/quote;currency=true?view=basic"
+
+      uri  = URI.parse(api)
+      http = Net::HTTP.new(uri.host, uri.port)
+      http.read_timeout = http.open_timeout = 20
+      http.start { http.request(Net::HTTP::Get.new(uri.to_s)) }
+    end
+
+    def parse_rates(html)
+      @rates = { :USD => 1.0 }
+
+      result = Nokogiri::HTML(html)
+      result.css('resource').each do |resource|
+        symbol = resource.xpath(".//field[@name='symbol']").text[0,3]
+        price  = resource.xpath(".//field[@name='price']").text
+
+        @rates[symbol.upcase.to_sym] = price.to_f unless symbol.nil? && price.nil?
+      end
+    end
+
+    # Raise errors for invalid currencies.
+    def validate_currency
+      raise UnknownCurrency.new(from_currency) unless CURRENCIES.has_key?(from_currency)
+      raise UnknownCurrency.new(to_currency) unless CURRENCIES.has_key?(to_currency)
+    end
+
+    # Raise errors for missing data.
+    def validate_rate(rate)
+      raise MissingExchangeRate.new(from_currency, to_currency) if rate.zero?
+    end
+  end
+end

data/spec/currency_converter/google_spec.rb

@@ -0,0 +1,24 @@
+require "spec_helper"
+
+describe CurrencyConverter::Google do
+  let(:currency_converter) { CurrencyConverter::Google.new }
+
+  describe "#exchange" do
+    it "returns the correct rate" do
+      expect(currency_converter.exchange("USD", "USD", 1)).to eq 1
+    end
+  end
+
+  describe "#validate_currency" do
+    describe CurrencyConverter::UnknownCurrency do
+      it 'raise an error on an unsupported currency code' do
+        expect { currency_converter.exchange("EUR", "UNKNOWN", 100) }.to raise_error(CurrencyConverter::UnknownCurrency)
+        expect { currency_converter.exchange("UNKNOWN", "EUR", 100) }.to raise_error(CurrencyConverter::UnknownCurrency)
+      end
+
+      it 'doesn\'t raise an error for supported currency codes' do
+        expect { currency_converter.exchange("EUR", "USD", 100) }.not_to raise_error
+      end
+    end
+  end
+end

data/spec/currency_converter/yahoo_spec.rb

@@ -0,0 +1,24 @@
+require "spec_helper"
+
+describe CurrencyConverter::Yahoo do
+  let(:currency_converter) { CurrencyConverter::Yahoo.new }
+
+  describe "#exchange" do
+    it "returns the correct rate" do
+      expect(currency_converter.exchange("USD", "USD", 1)).to eq 1
+    end
+  end
+
+  describe "#validate_currency" do
+    describe CurrencyConverter::UnknownCurrency do
+      it 'raise an error on an unsupported currency code' do
+        expect { currency_converter.exchange("EUR", "UNKNOWN", 100) }.to raise_error(CurrencyConverter::UnknownCurrency)
+        expect { currency_converter.exchange("UNKNOWN", "EUR", 100) }.to raise_error(CurrencyConverter::UnknownCurrency)
+      end
+
+      it 'doesn\'t raise an error for supported currency codes' do
+        expect { currency_converter.exchange("EUR", "USD", 100) }.not_to raise_error
+      end
+    end
+  end
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: currency_converter
 version: !ruby/object:Gem::Version
-  version: 1.0.2
+  version: 1.1.0
 platform: ruby
 authors:
 - Diganta Mandal
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-08-18 00:00:00.000000000 Z
+date: 2016-08-19 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: nokogiri
@@ -105,6 +105,7 @@ extra_rdoc_files: []
 files:
 - .gitignore
 - .rspec
+- .travis.yml
 - Gemfile
 - LICENSE.txt
 - README.md
@@ -113,8 +114,11 @@ files:
 - lib/currency_converter.rb
 - lib/currency_converter/currencies.rb
 - lib/currency_converter/exceptions.rb
+- lib/currency_converter/google.rb
 - lib/currency_converter/version.rb
-- spec/currency_converter_spec.rb
+- lib/currency_converter/yahoo.rb
+- spec/currency_converter/google_spec.rb
+- spec/currency_converter/yahoo_spec.rb
 - spec/spec_helper.rb
 homepage: https://github.com/dark-prince/currency_converter
 licenses:
@@ -143,6 +147,7 @@ summary: Google provides a web site to converts currencies using exchange rates
   they have not provided any API for ruby. This is a small library that converts currencies
   exchange rate. You can convert currencies directly through this library.
 test_files:
-- spec/currency_converter_spec.rb
+- spec/currency_converter/google_spec.rb
+- spec/currency_converter/yahoo_spec.rb
 - spec/spec_helper.rb
 has_rdoc: 

data/spec/currency_converter_spec.rb

@@ -1,23 +0,0 @@
-require "spec_helper"
-
-describe CurrencyConverter do
-  describe ".exchange" do
-    it "returns the correct rate" do
-      expect(CurrencyConverter.exchange("USD", "USD", 1)).to eq 1
-    end
-  end
-
-  describe "#validate_currency" do
-    describe CurrencyConverter::UnknownCurrency do
-      it 'raise an error on an unsupported currency code' do
-        expect { CurrencyConverter.exchange("EUR", "UNKNOWN", 100) }.to raise_error(CurrencyConverter::UnknownCurrency)
-        expect { CurrencyConverter.exchange("UNKNOWN", "EUR", 100) }.to raise_error(CurrencyConverter::UnknownCurrency)
-      end
-
-      it 'doesn\'t raise an error for supported currency codes' do
-        expect { CurrencyConverter.exchange("EUR", "USD", 100) }.not_to raise_error
-        #expect { CurrencyConverter.exchange("EUR", "USD", 100) }.not_to raise_error(CurrencyConverter::UnknownCurrency)
-      end
-    end
-  end
-end