currency_cloud 0.9.0 → 0.10.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 21e40aa27737b56bbcb3fe6294f765bbb90c46ac
-  data.tar.gz: 9cecc3d51f3109cca139f8f6d2402696810506b8
+  metadata.gz: ebec99730dd5705d4cf2c166f6df611617818e42
+  data.tar.gz: 397acffa929fd40cf630618f28540497bafd53e9
 SHA512:
-  metadata.gz: 9062a94961ec83cf03efb75d3d344d2920d0422f8747c506266b53c8cc6b844793bc851e99a8a1c120be3623d9576651903be830afb9fc990a4f774521f2fc71
-  data.tar.gz: 2382cd3f97358095d0ce9eae6e058772594a14f3159d812a600dc300982300d780cad847774e7bc6442ee3c46a7c7780af039805c822e1de6b51a4110a0852c5
+  metadata.gz: ff21d17e42f741459e92125e8551a6b93f5e9ee37d59af9dddd24182cbfbc185b9491fc6b39b9564ab94afcd1491ebc502e35ca2fa8019bcd88249a78b448394
+  data.tar.gz: 1e69916dc9465acbeadfead6d459c097b1281066ca984a2916d11678473e6a1a7390a2bb60c1e28ba5cceb8e19dd0726d82c70b79d69ddb952305ae0b824baf4

data/.gitignore

@@ -1,3 +1,34 @@
 .DS_Store
+
 *.gem
+*.rbc
+/.config
+/coverage/
+/InstalledFiles
+/pkg/
+/spec/reports/
+/spec/examples.txt
+/test/tmp/
+/test/version_tmp/
+/tmp/
+
+.env
+.byebug_history
+
+## Documentation cache and generated files:
+/.yardoc/
+/_yardoc/
+/doc/
+/rdoc/
+
+## Environment normalization:
+/.bundle/
+/vendor/bundle
+/lib/bundler/man/
+
 Gemfile.lock
+.ruby-version
+.ruby-gemset
+
+# unless supporting rvm < 1.11.0 or doing something fancy, ignore this:
+.rvmrc

data/.rubocop.yml

@@ -6,3 +6,9 @@ Style/Documentation:
 
 Style/SymbolArray:
   EnforcedStyle: brackets
+
+Style/NumericLiterals:
+  Enabled: false
+
+Metrics/BlockLength:
+  Enabled: false

data/.travis.yml

@@ -5,11 +5,9 @@ cache: bundler
 
 rvm:
   - 1.9.3
-  - 2.0.0
-  - 2.1
   - 2.2
   - 2.3.4
   - 2.4.1
   - jruby-19mode
-  - jruby-9.1.5.0 
-  - rbx-3.74
+  - jruby-9.1.17.0
+  - jruby-9.2.0.0

data/Gemfile

@@ -1,6 +1,3 @@
 source 'https://rubygems.org'
 
-gem 'guard-rspec', require: false
-gem 'guard', '2.12.6'
-
 gemspec

data/LICENSE.md

@@ -1,22 +1,21 @@
 The MIT License (MIT)
 
-Copyright (c) 2015 Currency Cloud
+Copyright (c) 2015-2018 Currencycloud
 
-Permission is hereby granted, free of charge, to any person obtaining
-a copy of this software and associated documentation files (the
-"Software"), to deal in the Software without restriction, including
-without limitation the rights to use, copy, modify, merge, publish,
-distribute, sublicense, and/or sell copies of the Software, and to
-permit persons to whom the Software is furnished to do so, subject to
-the following conditions:
+Permission is hereby granted, free of charge, to any person obtaining a copy
+of this software and associated documentation files (the "Software"), to deal
+in the Software without restriction, including without limitation the rights
+to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
+copies of the Software, and to permit persons to whom the Software is
+furnished to do so, subject to the following conditions:
 
-The above copyright notice and this permission notice shall be
-included in all copies or substantial portions of the Software.
+The above copyright notice and this permission notice shall be included in
+all copies or substantial portions of the Software.
 
-THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
-EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
-MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
-NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE
-LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION
-OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION
-WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
+THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
+AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
+OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
+THE SOFTWARE. OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.

data/README.md

@@ -2,8 +2,9 @@
 
 # Currencycloud
 
-This is the official Ruby SDK for v2 of Currencycloud's API. Additional documentation
-for each API endpoint can be found at [developer.currencycloud.com][developer]. If you have any queries or you require support, please contact our sales team at sales@currencycloud.com.
+This is the official Ruby SDK for the Currencycloud API. Additional documentation for each API endpoint can be found at [developer.currencycloud.com][docs].
+
+If you have any queries or you require support, please contact our development team at development@currencycloud.com Please quote your login id in any correspondence as this makes it easier for us to locate your account and give you the support you need.
 
 ## Installation
 
@@ -91,7 +92,7 @@ platform: Ruby 1.9.3
 request:
   parameters:
     login_id: non-existent-login-id
-    api_key: ef0fd50fca1fb14c1fab3a8436b9ecb57528f0
+    api_key: deadbeefdeadbeefdeadbeefdeadbeefdeadbeefdeadbeefdeadbeefdeadbeef
   verb: post
   url: https://devapi.currencycloud.com/v2/authenticate/api
 response:
@@ -130,6 +131,7 @@ Test cases can be run with: `bundle exec rspec`. There is also a `Guardfile` tha
 is useful for continuously rerunning tests while you develop.
 
 ## Dependencies
+
 * [HTTParty][httparty]
 * [json][json]
 

data/Rakefile

@@ -1,19 +1,19 @@
-desc "Run an IRB session"
+desc 'Run an IRB session'
 task :console do
-  exec "irb -I lib -r irb/completion -r currency_cloud"
+  exec 'irb -I lib -r irb/completion -r currency_cloud'
 end
 
 def play
   sleep 1
-  puts "..."
+  puts '...'
   IRB.conf[:MAIN_CONTEXT].irb
-  IRB.conf[:MAIN_CONTEXT].io.prompt = "HELLO"
+  IRB.conf[:MAIN_CONTEXT].io.prompt = 'HELLO'
 end
 
-desc "Run an IRB session in kiosk mode"
+desc 'Run an IRB session in kiosk mode'
 task :kiosk do
-  Thread.abort_on_exception=true
-  #exec "irb -I lib -r irb/completion -r currency_cloud -r currency_cloud/kiosk"
+  Thread.abort_on_exception = true
+  # exec "irb -I lib -r irb/completion -r currency_cloud -r currency_cloud/kiosk"
   require 'irb'
   IRB.setup nil
   IRB.conf[:MAIN_CONTEXT] = IRB::Irb.new.context
@@ -22,9 +22,9 @@ task :kiosk do
   @irb = IRB.irb nil, self
 end
 
-desc "Test and build gem"
+desc 'Test and build gem'
 task :build do
-  sh("rm -f currency_cloud*.gem")
-  sh("rspec")
-  sh("gem build currency_cloud.gemspec")
-end
+  sh('rm -f currency_cloud*.gem')
+  sh('rspec')
+  sh('gem build currency_cloud.gemspec')
+end

data/currency_cloud.gemspec

@@ -1,29 +1,29 @@
-$:.unshift(File.join(File.dirname(__FILE__), 'lib'))
+$LOAD_PATH.unshift(File.join(File.dirname(__FILE__), 'lib'))
 
 require 'currency_cloud/version'
 
-spec = Gem::Specification.new do |s|
+Gem::Specification.new do |s|
   s.name = 'currency_cloud'
   s.version = CurrencyCloud::VERSION
   s.summary = 'Ruby SDK for the Currency Cloud API'
-  s.description = 'Ruby SDK for the Currency Cloud API - https://connect.currencycloud.com/'
+  s.description = 'Ruby SDK for the Currency Cloud API - https://www.currencycloud.com/developers/overview/'
   s.authors = ['Liam McAndrew', 'Richard Nienaber']
   s.email = ['liam.mcandrew@currencycloud.com', 'richard.nienaber@currencycloud.com']
-  s.homepage = 'https://connect.currencycloud.com/documentation/getting-started/introduction'
+  s.homepage = 'https://github.com/Currencycloud/currencycloud-ruby/'
   s.licenses = ['MIT']
   s.required_ruby_version = '>= 1.9'
 
   s.add_dependency('httparty', '0.14.0')
   s.add_dependency('json', '~> 1.8')
 
-  s.add_development_dependency('rspec', '~> 3.1')
-  s.add_development_dependency('rake', '~> 10.3')
-  s.add_development_dependency('webmock', '~> 1.21')
-  s.add_development_dependency('vcr', '~> 2.9')
   s.add_development_dependency('addressable', '<= 2.4.0')
+  s.add_development_dependency('rake', '~> 10.3')
+  s.add_development_dependency('rspec', '~> 3.1')
+  s.add_development_dependency('vcr', '~> 3.0.3')
+  s.add_development_dependency('webmock', '~> 2.3.2')
 
   s.files = `git ls-files`.split("\n")
   s.test_files    = `git ls-files -- spec/*`.split("\n")
-  s.executables   = `git ls-files -- bin/*`.split("\n").map{ |f| File.basename(f) }
+  s.executables   = `git ls-files -- bin/*`.split("\n").map { |f| File.basename(f) }
   s.require_paths = ['lib']
 end

data/examples/server.rb

@@ -3,13 +3,13 @@ require_relative 'currency_cloud'
 require 'sinatra'
 
 get '/conversion' do
-  conversion = CurrencyCloud::Conversion.create({
-    buy_currency: params[:buy_currency], 
+  conversion = CurrencyCloud::Conversion.create(
+    buy_currency: params[:buy_currency],
     sell_currency: params[:sell_currency],
-    amount: params[:amount], 
-    fixed_side: 'buy', 
-    reason: 'test', 
+    amount: params[:amount],
+    fixed_side: 'buy',
+    reason: 'test',
     term_agreement: true
-  })
+  )
   "Conversion created: #{conversion.short_reference}"
-end
+end

data/lib/currency_cloud/client.rb

@@ -13,7 +13,11 @@ module CurrencyCloud
     end
 
     def build_url(url)
-      "#{resource}/#{url}"
+      if url && url != '' && url != '/'
+        "#{resource}/#{url}"
+      else
+        "#{resource}"
+      end
     end
 
     def request

data/lib/currency_cloud/conversion.rb

@@ -4,5 +4,20 @@ module CurrencyCloud
 
     resource :conversions
     actions :create, :retrieve, :find
+
+    def cancel(params = {})
+      attrs = client.post("#{id}/cancel", params)
+      ConversionCancelResult.new(attrs)
+    end
+
+    def date_change(params)
+      attrs = client.post("#{id}/date_change", params)
+      ConversionDateChangeResult.new(attrs)
+    end
+
+    def split(params)
+      attrs = client.post("#{id}/split", params)
+      ConversionSplitResult.new(attrs)
+    end
   end
 end

data/lib/currency_cloud/conversion_cancel_result.rb

@@ -0,0 +1,5 @@
+module CurrencyCloud
+  class ConversionCancelResult
+    include CurrencyCloud::Resource
+  end
+end

data/lib/currency_cloud/conversion_date_change_result.rb

@@ -0,0 +1,5 @@
+module CurrencyCloud
+  class ConversionDateChangeResult
+    include CurrencyCloud::Resource
+  end
+end

data/lib/currency_cloud/conversion_split_result.rb

@@ -0,0 +1,5 @@
+module CurrencyCloud
+  class ConversionSplitResult
+    include CurrencyCloud::Resource
+  end
+end

data/lib/currency_cloud/errors/api_error.rb

@@ -33,7 +33,7 @@ module CurrencyCloud
       errors = raw_response.parsed_response
       @code = errors['error_code']
       @messages = []
-      
+
       return unless errors['error_messages']
 
       errors['error_messages'].each do |field, messages|
@@ -62,7 +62,7 @@ module CurrencyCloud
         },
         'errors' => messages.map(&:to_h)
       }
-      "#{class_name}#{$/}#{YAML.dump(error_details)}"
+      "#{class_name}#{$INPUT_RECORD_SEPARATOR}#{YAML.dump(error_details)}"
     end
   end
 

data/lib/currency_cloud/errors/error_utils.rb

@@ -4,15 +4,15 @@ module CurrencyCloud
       base = "ruby-#{RUBY_VERSION}"
       implementation = case RUBY_ENGINE
                        when 'ruby' then ''
-                       when 'jruby' then ' (jruby-#{JRUBY_VERSION})"'
-                       when 'rbx' then ' (rbx-#{Rubinius::VERSION})'
-                       else ' (other)'
+                       when 'jruby' then " (jruby-#{JRUBY_VERSION})"
+                       when 'rbx' then " (rbx-#{Rubinius::VERSION})"
+                       else " (#{RUBY_ENGINE})"
                        end
       "#{base}#{implementation}"
     end
 
     REDACTED_PARAMS = [:api_key, :login_id, :token].freeze
-    REDACTED_STRING = "REDACTED".freeze
+    REDACTED_STRING = 'REDACTED'.freeze
 
     def redacted_params(params)
       redacted = params.dup

data/lib/currency_cloud/errors/unexpected_error.rb

@@ -4,11 +4,11 @@ module CurrencyCloud
 
     attr_reader :inner_error
 
-    def initialize(verb, route, params, e)
+    def initialize(verb, route, params, inner)
       @verb = verb
       @route = route
       @params = redacted_params(params)
-      @inner_error = e
+      @inner_error = inner
     end
 
     def to_s
@@ -25,7 +25,7 @@ module CurrencyCloud
         },
         'inner_error' => inner_error.to_s
       }
-      "#{class_name}#{$/}#{YAML.dump(error_details)}"
+      "#{class_name}#{$INPUT_RECORD_SEPARATOR}#{YAML.dump(error_details)}"
     end
   end
 end

data/lib/currency_cloud/iban.rb

@@ -0,0 +1,22 @@
+module CurrencyCloud
+  class IBAN
+    include CurrencyCloud::Resource
+
+    resource :ibans
+
+    def self.find(params = {})
+      result = client.get('/', params)
+      IBANs.new(:ibans, self, result)
+    end
+
+    def self.for_subaccount(subaccount_id, params = {})
+      result = client.get("subaccounts/#{subaccount_id}", params)
+      IBANs.new(:ibans, self, result)
+    end
+
+    def self.for_subaccounts(params = {})
+      result = client.get('subaccounts/find', params)
+      IBANs.new(:ibans, self, result)
+    end
+  end
+end

data/lib/currency_cloud/ibans.rb

@@ -0,0 +1,6 @@
+require 'currency_cloud/resourceful_collection'
+
+module CurrencyCloud
+  class IBANs < CurrencyCloud::ResourcefulCollection
+  end
+end

data/lib/currency_cloud/payer_required_details.rb

@@ -0,0 +1,5 @@
+module CurrencyCloud
+  class PayerRequiredDetails
+    include CurrencyCloud::Resource
+  end
+end

data/lib/currency_cloud/payment.rb

@@ -4,5 +4,15 @@ module CurrencyCloud
 
     resource :payments
     actions :create, :retrieve, :find, :delete, :update
+
+    def submission(params = {})
+      result = client.get("#{id}/submission", params)
+      PaymentSubmission.new(result)
+    end
+
+    def self.authorise(*ids)
+      result = client.post("authorise", payment_ids: ids)['authorisations']
+      result.map { |pa| PaymentAuthorisationResult.new(pa) }
+    end
   end
 end

data/lib/currency_cloud/payment_authorisation_result.rb

@@ -0,0 +1,5 @@
+module CurrencyCloud
+  class PaymentAuthorisationResult
+    include CurrencyCloud::Resource
+  end
+end

data/lib/currency_cloud/payment_dates.rb

@@ -0,0 +1,5 @@
+module CurrencyCloud
+  class PaymentDates
+    include CurrencyCloud::Resource
+  end
+end

data/lib/currency_cloud/payment_submission.rb

@@ -0,0 +1,5 @@
+module CurrencyCloud
+  class PaymentSubmission
+    include CurrencyCloud::Resource
+  end
+end