currency_cloud 0.8.0 → 0.8.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: d03914430ce3008c972006bfdce468cc9d5247c4
-  data.tar.gz: 45a61b8743f130d88c690db610532deefec3e65c
+  metadata.gz: 4feb1a53b41a150cd7175eebb4ca92504235de38
+  data.tar.gz: baa29a21ca77d8edee42a2690889195b5ad00ca4
 SHA512:
-  metadata.gz: 9fdf242df295a23bc62137212cc3ee8fed27806be15d0c20a50c1ba6b77c09f86bbeb368e1cd4793ac42df96ec6f50232a568ca13e0968943d26c8f8759c86b0
-  data.tar.gz: becd764f0a82a9582411705245d3699b5ca501a372f813618aeff8c7b2d98837a7b2ba43241db74bdccf093c17255b4ef73c0c127ce36537473ec4389e7c32a0
+  metadata.gz: 06b86ac4c431de61ff3d559269632e6648a0bd6b95cb3f546c84a46705a0a8ce63f0b2f9fd73eae1b3ab10f7f5244e6d52e63f20649967f6100faf23998ba70a
+  data.tar.gz: 6824ca0ab4ea2edfe96198be1adc15317a93f2024196a4f606ad108a1bd56d6377c4823dc5f97e712e236c1f2e046f913a3397b5277846aa50e24546d6a92938

data/.rubocop.yml

@@ -3,3 +3,6 @@ Metrics/LineLength:
 
 Style/Documentation:
   Enabled: false
+
+Style/SymbolArray:
+  EnforcedStyle: brackets

data/Gemfile

@@ -1,6 +1,5 @@
 source 'https://rubygems.org'
 
-gem 'sinatra'
 gem 'guard-rspec', require: false
 gem 'guard', '2.12.6'
 

data/currency_cloud.gemspec

@@ -13,7 +13,7 @@ spec = Gem::Specification.new do |s|
   s.licenses = ['MIT']
   s.required_ruby_version = '>= 1.9'
 
-  s.add_dependency('httparty', '~> 0.13')
+  s.add_dependency('httparty', '0.14.0')
   s.add_dependency('json', '~> 1.8')
 
   s.add_development_dependency('rspec', '~> 3.1')

data/lib/currency_cloud/errors/api_error.rb

@@ -27,12 +27,14 @@ module CurrencyCloud
     def initialize(verb, route, params, raw_response)
       @verb = verb
       @route = route
-      @params = params
+      @params = redacted_params(params)
       @raw_response = raw_response
       @status_code = raw_response.code
       errors = raw_response.parsed_response
       @code = errors['error_code']
       @messages = []
+      
+      return unless errors['error_messages']
 
       errors['error_messages'].each do |field, messages|
         messages.each do |message|

data/lib/currency_cloud/errors/error_utils.rb

@@ -10,5 +10,19 @@ module CurrencyCloud
                        end
       "#{base}#{implementation}"
     end
+
+    REDACTED_PARAMS = [:api_key, :login_id, :token].freeze
+    REDACTED_STRING = "REDACTED".freeze
+
+    def redacted_params(params)
+      redacted = params.dup
+
+      REDACTED_PARAMS.each do |param|
+        redacted[param.to_sym] = REDACTED_STRING if redacted.key? param.to_sym
+        redacted[param.to_s] = REDACTED_STRING if redacted.key? param.to_s
+      end
+
+      redacted
+    end
   end
 end

data/lib/currency_cloud/errors/unexpected_error.rb

@@ -7,7 +7,7 @@ module CurrencyCloud
     def initialize(verb, route, params, e)
       @verb = verb
       @route = route
-      @params = params
+      @params = redacted_params(params)
       @inner_error = e
     end
 

data/lib/currency_cloud/version.rb

@@ -2,5 +2,5 @@
 
 module CurrencyCloud
   API_VERSION = 'v2'.freeze # API Version
-  VERSION = '0.8.0'.freeze # Gem Version
+  VERSION = '0.8.2'.freeze # Gem Version
 end

data/spec/integration/error_utils_spec.rb

@@ -0,0 +1,30 @@
+require "spec_helper"
+
+describe "ErrorUtils" do
+  module CurrencyCloud
+    class ErrorUtilTester
+      extend ErrorUtils
+    end
+  end
+
+  it "can #redact_params" do
+    params = {
+      unaffected: "value",
+      api_key: "value",
+      login_id: "value",
+      token: "value"
+    }
+
+    redacted = CurrencyCloud::ErrorUtilTester.redacted_params(params)
+
+    expect(redacted[:unaffected]).to eq "value"
+    expect(redacted[:api_key]).to eq CurrencyCloud::ErrorUtils::REDACTED_STRING
+    expect(redacted[:login_id]).to eq CurrencyCloud::ErrorUtils::REDACTED_STRING
+    expect(redacted[:token]).to eq CurrencyCloud::ErrorUtils::REDACTED_STRING
+
+    expect(params[:unaffected]).to eq "value"
+    expect(params[:api_key]).to eq "value"
+    expect(params[:login_id]).to eq "value"
+    expect(params[:token]).to eq "value"
+  end
+end

data/spec/integration/errors_spec.rb

@@ -26,8 +26,8 @@ describe 'Error', vcr: true do
 platform: #{error.platform}
 request:
   parameters:
-    login_id: non-existent-login-id
-    api_key: ef0fd50fca1fb14c1fab3a8436b9ecb57528f0
+    login_id: REDACTED
+    api_key: REDACTED
   verb: post
   url: https://devapi.currencycloud.com/v2/authenticate/api
 response:
@@ -105,8 +105,8 @@ errors:
 platform: #{error.platform}
 request:
   parameters:
-    login_id: rjnienaber@gmail.com
-    api_key: ef0fd50fca1fb14c1fab3a8436b9ecb65f02f129fd87eafa45ded8ae257528f0
+    login_id: REDACTED
+    api_key: REDACTED
   verb: post
   url: https://devapi.currencycloud.com/v2/authenticate/api
 inner_error: Timeout::Error

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: currency_cloud
 version: !ruby/object:Gem::Version
-  version: 0.8.0
+  version: 0.8.2
 platform: ruby
 authors:
 - Liam McAndrew
@@ -9,26 +9,26 @@ authors:
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2017-04-24 00:00:00.000000000 Z
+date: 2017-07-06 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - '='
       - !ruby/object:Gem::Version
-        version: '0.13'
+        version: 0.14.0
   name: httparty
   prerelease: false
   type: :runtime
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - '='
       - !ruby/object:Gem::Version
-        version: '0.13'
+        version: 0.14.0
 - !ruby/object:Gem::Dependency
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ~>
       - !ruby/object:Gem::Version
         version: '1.8'
   name: json
@@ -36,13 +36,13 @@ dependencies:
   type: :runtime
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ~>
       - !ruby/object:Gem::Version
         version: '1.8'
 - !ruby/object:Gem::Dependency
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ~>
       - !ruby/object:Gem::Version
         version: '3.1'
   name: rspec
@@ -50,13 +50,13 @@ dependencies:
   type: :development
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ~>
       - !ruby/object:Gem::Version
         version: '3.1'
 - !ruby/object:Gem::Dependency
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ~>
       - !ruby/object:Gem::Version
         version: '10.3'
   name: rake
@@ -64,13 +64,13 @@ dependencies:
   type: :development
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ~>
       - !ruby/object:Gem::Version
         version: '10.3'
 - !ruby/object:Gem::Dependency
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ~>
       - !ruby/object:Gem::Version
         version: '1.21'
   name: webmock
@@ -78,13 +78,13 @@ dependencies:
   type: :development
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ~>
       - !ruby/object:Gem::Version
         version: '1.21'
 - !ruby/object:Gem::Dependency
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ~>
       - !ruby/object:Gem::Version
         version: '2.9'
   name: vcr
@@ -92,13 +92,13 @@ dependencies:
   type: :development
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ~>
       - !ruby/object:Gem::Version
         version: '2.9'
 - !ruby/object:Gem::Dependency
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "<="
+    - - <=
       - !ruby/object:Gem::Version
         version: 2.4.0
   name: addressable
@@ -106,7 +106,7 @@ dependencies:
   type: :development
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "<="
+    - - <=
       - !ruby/object:Gem::Version
         version: 2.4.0
 description: Ruby SDK for the Currency Cloud API - https://connect.currencycloud.com/
@@ -117,9 +117,9 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
-- ".gitignore"
-- ".rubocop.yml"
-- ".travis.yml"
+- .gitignore
+- .rubocop.yml
+- .travis.yml
 - Gemfile
 - Guardfile
 - LICENSE.md
@@ -169,6 +169,7 @@ files:
 - spec/currency_cloud_spec.rb
 - spec/integration/actions_spec.rb
 - spec/integration/authentication_spec.rb
+- spec/integration/error_utils_spec.rb
 - spec/integration/errors_spec.rb
 - spec/integration/rates_spec.rb
 - spec/integration/reference_spec.rb
@@ -214,17 +215,17 @@ require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ">="
+  - - '>='
     - !ruby/object:Gem::Version
       version: '1.9'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ">="
+  - - '>='
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
 rubyforge_project:
-rubygems_version: 2.4.8
+rubygems_version: 2.1.9
 signing_key:
 specification_version: 4
 summary: Ruby SDK for the Currency Cloud API
@@ -234,6 +235,7 @@ test_files:
 - spec/currency_cloud_spec.rb
 - spec/integration/actions_spec.rb
 - spec/integration/authentication_spec.rb
+- spec/integration/error_utils_spec.rb
 - spec/integration/errors_spec.rb
 - spec/integration/rates_spec.rb
 - spec/integration/reference_spec.rb