currency-rate 0.2.0 → 0.2.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 3840cff6b0d67d1daba2cf2a74231d2c8655311e
-  data.tar.gz: 9057b69eeef323940d40e0f127abe91cc902e949
+  metadata.gz: e0b5e77d6b38d2c35b7571ad074be82db677be4c
+  data.tar.gz: 8a30a9a49e696c626435ccc290c80eca6995350a
 SHA512:
-  metadata.gz: 64b511ad2f1a37c491a0e3d805c0053130dfeceb9e19874a8a3a981b175840098abbb529d9a89881b466ed15bd4364eeecfc9be04b3aefa6b8d05b7851f798d4
-  data.tar.gz: 9b4708166f703fb4ebc34563073dd846e593fe87b2a17716ee5b76f1a0d60800caf1efcd1a75f94f869d381b448ba4123a0fae54de26f351720cbcef933b30bf
+  metadata.gz: b0fdd7232a2fbb6721adbe444a9a90beb1b197d348ee4d08e435b9f32e1984f4a6c86d46fdb2e09dbcdcc54f384c7c375c0ff98d074f4c7f8dbb6d86b6992a0e
+  data.tar.gz: e0fca9cf058bfc219ac771bc89759ace677e9f4da365103ec4f239ea06b5e5cffb20fa337ff1125cd9f491c6b6cdb7a7096743a9973af8ec1f59b8dbd6942fc7

data/README.md

@@ -39,7 +39,7 @@ In the second case, we are trying to get the exchange rate for USD/BTC pair, whi
 "how much in BTC would 1 USD be?". If the source (Bitstamp, in this case) doesn't provide the
 inverted rate, the Adapter inverts the rate itself using the exchange rate for BTC/USD.
 
-You can also using `anchor_currency` with `#get`:
+You can also use `anchor_currency` argument with `#get`:
 
     CurrencyRate.get('Bitstamp', 'USD', 'EUR', anchor_currency: 'BTC')
 
@@ -63,3 +63,15 @@ for how and when to store/fetch data, not other classes.
 Credits
 -------
 This gem was extracted from [straight gem](https://github.com/MyceliumGear/straight), thanks to all the people who added various exchange rate adapters and contributed code.
+
+TODO
+----
+
+1. Remove code duplication in Adapters, specifically for
+   `#rate_for`, `#invert_rate` and `#currency_pair_rate` methods.
+
+2. Allow both lower case and upper case currency codes.
+
+3. Clean up tests, I have a feeling there some completely useless ones.
+
+4. Adapters should have a default "to" currency. For example, everyone knows Bitfinex trades BTC for USD mostly.

data/VERSION

@@ -1 +1 @@
-0.2.0
+0.2.1

data/lib/btc_adapters/btcchina_adapter.rb

@@ -5,7 +5,8 @@ module CurrencyRate
 
     def rate_for(from,to)
       super
-      rate = rate_to_f(@rates['ticker']['last'])
+      raise raise CurrencyNotSupported unless [from,to].include?('CNY')
+      rate = rate_to_f(@rates['ticker'] && @rates['ticker']['last'])
       invert_rate(from,to,rate)
     end
 

data/lib/currency_rate.rb

@@ -40,11 +40,15 @@ module CurrencyRate
     to == 'BTC' ? result : result.round(2)
   end
 
-    private
+  private
 
     def self.adapter_class(s)
       return s unless s.kind_of?(String) # if we pass class, no need to convert
-      adapter = "#{s}_adapter".classify(CurrencyRate).instance
+      adapter = classify_string("#{s}_adapter", CurrencyRate).instance
+    end
+
+    def self.classify_string(s, prefix="")
+      Kernel.const_get(prefix.to_s + "::" + s.split('_').collect(&:capitalize).join)
     end
 
 end

data/spec/fixtures/vcr/exchange_rate_adapters/btc_adapters/btcchina_adapter.yml

@@ -2,7 +2,7 @@
 http_interactions:
 - request:
     method: get
-    uri: http://api.huobi.com/staticmarket/ticker_btc_json.js
+    uri: https://data.btcchina.com/data/ticker
     body:
       encoding: US-ASCII
       string: ''
@@ -18,66 +18,37 @@ http_interactions:
       code: 200
       message: OK
     headers:
-      Date:
-      - Mon, 20 Jun 2016 07:13:19 GMT
-      Content-Type:
-      - application/javascript;charset=UTF-8
-      Content-Length:
-      - '152'
-      Connection:
-      - keep-alive
-      Set-Cookie:
-      - __jsluid=4232513531b381fc752eef8d4dd55251; path=/
+      Access-Control-Allow-Methods:
+      - GET
       Access-Control-Allow-Origin:
       - "*"
-      X-Frame-Options:
-      - SAMEORIGIN
-      X-Cache:
-      - bypass
-    body:
-      encoding: UTF-8
-      string: '{"time":"1466406799","ticker":{"open":5108.77,"vol":512967.119,"symbol":"btccny","last":5084.51,"buy":5084.51,"sell":5084.93,"high":5138,"low":5010.5}
-        }'
-    http_version: 
-  recorded_at: Mon, 20 Jun 2016 07:13:19 GMT
-- request:
-    method: get
-    uri: http://api.huobi.com/staticmarket/ticker_ltc_json.js
-    body:
-      encoding: US-ASCII
-      string: ''
-    headers:
-      Accept-Encoding:
-      - gzip;q=1.0,deflate;q=0.6,identity;q=0.3
-      Accept:
-      - "*/*"
-      User-Agent:
-      - Ruby
-  response:
-    status:
-      code: 200
-      message: OK
-    headers:
-      Date:
-      - Mon, 20 Jun 2016 07:13:20 GMT
+      Cache-Control:
+      - no-store, no-cache, must-revalidate, post-check=0, pre-check=0
       Content-Type:
-      - application/javascript;charset=UTF-8
-      Content-Length:
-      - '147'
+      - application/json
+      Date:
+      - Tue, 21 Jun 2016 08:28:10 GMT
+      Expires:
+      - Thu, 19 Nov 1981 08:52:00 GMT
+      Front-End-Https:
+      - 'on'
+      Pragma:
+      - no-cache
+      Server:
+      - nginx/1.8.1
+      Set-Cookie:
+      - btcchina_lang=en; expires=Wed, 21-Jun-2017 08:28:10 GMT; path=/; domain=.btcc.com
+      X-Cache-Cfc:
+      - "- 1466497690.039"
+      X-Powered-By:
+      - PHP/5.4.45
+      Transfer-Encoding:
+      - chunked
       Connection:
       - keep-alive
-      Set-Cookie:
-      - __jsluid=7312808630c655d05ce1143b909ff703; path=/
-      Access-Control-Allow-Origin:
-      - "*"
-      X-Frame-Options:
-      - SAMEORIGIN
-      X-Cache:
-      - bypass
     body:
       encoding: UTF-8
-      string: '{"time":"1466406800","ticker":{"open":37.46,"vol":46953638.9983,"symbol":"ltccny","last":36.92,"buy":36.91,"sell":36.92,"high":37.59,"low":36.59}
-        }'
+      string: '{"ticker":{"high":"5090.00","low":"4615.02","buy":"4785.55","sell":"4786.12","last":"4785.55","vol":"58752.19850000","date":1466497687,"vwap":"4738.11","prev_close":"4931.64","open":"4931.65"}}'
     http_version: 
-  recorded_at: Mon, 20 Jun 2016 07:13:20 GMT
+  recorded_at: Tue, 21 Jun 2016 08:28:10 GMT
 recorded_with: VCR 3.0.3

data/spec/fixtures/vcr/exchange_rate_adapters/btc_adapters/huobi_adapter.yml

@@ -19,15 +19,15 @@ http_interactions:
       message: OK
     headers:
       Date:
-      - Mon, 20 Jun 2016 07:03:48 GMT
+      - Tue, 21 Jun 2016 08:25:20 GMT
       Content-Type:
       - application/javascript;charset=UTF-8
       Content-Length:
-      - '147'
+      - '149'
       Connection:
       - keep-alive
       Set-Cookie:
-      - __jsluid=d0d079a4dbfaaec600a13a4d86867881; path=/
+      - __jsluid=683b360451a7f7c973ef086944f6a50e; path=/
       Access-Control-Allow-Origin:
       - "*"
       X-Frame-Options:
@@ -36,10 +36,10 @@ http_interactions:
       - bypass
     body:
       encoding: UTF-8
-      string: '{"time":"1466406228","ticker":{"open":5108.77,"vol":510742.6937,"symbol":"btccny","last":5081,"buy":5081,"sell":5081.09,"high":5138,"low":5010.5}
+      string: '{"time":"1466497520","ticker":{"open":4961.18,"vol":602328.2638,"symbol":"btccny","last":4791.5,"buy":4792.1,"sell":4792.99,"high":4993,"low":4650}
         }'
     http_version: 
-  recorded_at: Mon, 20 Jun 2016 07:03:48 GMT
+  recorded_at: Tue, 21 Jun 2016 08:25:20 GMT
 - request:
     method: get
     uri: http://api.huobi.com/staticmarket/ticker_ltc_json.js
@@ -59,15 +59,15 @@ http_interactions:
       message: OK
     headers:
       Date:
-      - Mon, 20 Jun 2016 07:03:49 GMT
+      - Tue, 21 Jun 2016 08:25:21 GMT
       Content-Type:
       - application/javascript;charset=UTF-8
       Content-Length:
-      - '145'
+      - '147'
       Connection:
       - keep-alive
       Set-Cookie:
-      - __jsluid=77e576c3013fc72045c6db3c1486abac; path=/
+      - __jsluid=37a542d8ce58ca1b0f4ff9619ec029c2; path=/
       Access-Control-Allow-Origin:
       - "*"
       X-Frame-Options:
@@ -76,8 +76,8 @@ http_interactions:
       - bypass
     body:
       encoding: UTF-8
-      string: '{"time":"1466406229","ticker":{"open":37.46,"vol":46826640.2353,"symbol":"ltccny","last":36.9,"buy":36.9,"sell":36.91,"high":37.59,"low":36.59}
+      string: '{"time":"1466497521","ticker":{"open":36.11,"vol":65225442.1187,"symbol":"ltccny","last":34.25,"buy":34.24,"sell":34.25,"high":36.26,"low":32.53}
         }'
     http_version: 
-  recorded_at: Mon, 20 Jun 2016 07:03:49 GMT
+  recorded_at: Tue, 21 Jun 2016 08:25:21 GMT
 recorded_with: VCR 3.0.3

data/spec/lib/btc_adapters/btcchina_adapter_spec.rb

@@ -11,12 +11,12 @@ RSpec.describe CurrencyRate::BTCChinaAdapter do
   end
 
   before(:each) do
-    @exchange_adapter = CurrencyRate::HuobiAdapter.instance
+    @exchange_adapter = CurrencyRate::BTCChinaAdapter.instance
   end
 
   it "finds the rate for currency code" do
-    expect(@exchange_adapter.rate_for('BTC', 'CNY')).to eq(5084.51)
-    expect(@exchange_adapter.rate_for('CNY', 'BTC')).to eq(0.00019667578586727137)
+    expect(@exchange_adapter.rate_for('BTC', 'CNY')).to eq(4785.55)
+    expect(@exchange_adapter.rate_for('CNY', 'BTC')).to eq(0.00020896239721662085)
     expect( -> { @exchange_adapter.rate_for('FEDcoin', 'USD') }).to raise_error(CurrencyRate::Adapter::CurrencyNotSupported)
   end
 

data/spec/lib/btc_adapters/huobi_adapter_spec.rb

@@ -15,10 +15,10 @@ RSpec.describe CurrencyRate::HuobiAdapter do
   end
 
   it "finds the rate for currency code" do
-    expect(@exchange_adapter.rate_for('BTC', 'CNY')).to eq(5081.0)
-    expect(@exchange_adapter.rate_for('CNY', 'BTC')).to eq(0.000196811651249754)
-    expect(@exchange_adapter.rate_for('LTC', 'CNY')).to eq(36.9)
-    expect(@exchange_adapter.rate_for('CNY', 'LTC')).to eq(0.02710027100271003)
+    expect(@exchange_adapter.rate_for('BTC', 'CNY')).to eq(4791.5)
+    expect(@exchange_adapter.rate_for('CNY', 'BTC')).to eq(0.0002087029114056141)
+    expect(@exchange_adapter.rate_for('LTC', 'CNY')).to eq(34.25)
+    expect(@exchange_adapter.rate_for('CNY', 'LTC')).to eq(0.029197080291970802)
     expect( -> { @exchange_adapter.rate_for('FEDcoin', 'USD') }).to raise_error(CurrencyRate::Adapter::CurrencyNotSupported)
   end
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: currency-rate
 version: !ruby/object:Gem::Version
-  version: 0.2.0
+  version: 0.2.1
 platform: ruby
 authors:
 - Roman Snitko
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-06-20 00:00:00.000000000 Z
+date: 2016-06-21 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: satoshi-unit
@@ -124,7 +124,6 @@ files:
 - lib/btc_adapters/kraken_adapter.rb
 - lib/btc_adapters/localbitcoins_adapter.rb
 - lib/btc_adapters/okcoin_adapter.rb
-- lib/core_ext/classify.rb
 - lib/core_ext/deep_get.rb
 - lib/currency_rate.rb
 - lib/fiat_adapter.rb

data/lib/core_ext/classify.rb

@@ -1,7 +0,0 @@
-class String
-
-  def classify(prefix="")
-    Kernel.const_get(prefix.to_s + "::" + self.split('_').collect(&:capitalize).join)
-  end
-
-end