currency-rate 0.1.1 → 0.2.0

data/spec/fixtures/vcr/exchange_rate_adapters/fiat_adapters/yahoo_adapter.yml

@@ -0,0 +1,50 @@
+---
+http_interactions:
+- request:
+    method: get
+    uri: http://query.yahooapis.com/v1/public/yql?env=store://datatables.org/alltableswithkeys&format=json&q=SELECT%20*%20FROM%20yahoo.finance.xchange%20WHERE%20pair%20IN(%22USDAUD%22,%22USDBGN%22,%22USDBRL%22,%22USDCAD%22,%22USDCHF%22,%22USDCNY%22,%22USDCZK%22,%22USDDKK%22,%22USDGBP%22,%22USDHKD%22,%22USDHRK%22,%22USDHUF%22,%22USDIDR%22,%22USDILS%22,%22USDINR%22,%22USDJPY%22,%22USDKRW%22,%22USDMXN%22,%22USDMYR%22,%22USDNOK%22,%22USDNZD%22,%22USDPHP%22,%22USDPLN%22,%22USDRON%22,%22USDRUB%22,%22USDSEK%22,%22USDSGD%22,%22USDTHB%22,%22USDTRY%22,%22USDUSD%22,%22USDZAR%22,%22USDEUR%22)
+    body:
+      encoding: US-ASCII
+      string: ''
+    headers:
+      Accept-Encoding:
+      - gzip;q=1.0,deflate;q=0.6,identity;q=0.3
+      Accept:
+      - "*/*"
+      User-Agent:
+      - Ruby
+  response:
+    status:
+      code: 200
+      message: OK
+    headers:
+      X-Yql-Host:
+      - main-2327bac4-1df8-11e6-a4df-d4ae52974c31
+      X-Content-Type-Options:
+      - nosniff
+      Access-Control-Allow-Origin:
+      - "*"
+      Content-Type:
+      - application/json; charset=UTF-8
+      Cache-Control:
+      - no-cache
+      Date:
+      - Sun, 19 Jun 2016 07:10:46 GMT
+      Age:
+      - '0'
+      Server:
+      - ATS
+      Via:
+      - http/1.1 a14.ue.bf1.yahoo.net (ApacheTrafficServer [cMsSf ])
+      Y-Trace:
+      - BAEAQAAAAAC2YQNA_AaEuAAAAAAAAAAAZOzi9VN5UAwAAAAAAAAAAAAFNZxJY.NpAAU1nElkwG5.Cp0MAAAAAA--
+      Transfer-Encoding:
+      - chunked
+      Connection:
+      - keep-alive
+    body:
+      encoding: UTF-8
+      string: '{"query":{"count":32,"created":"2016-06-19T07:10:46Z","lang":"en-US","results":{"rate":[{"id":"USDAUD","Name":"USD/AUD","Rate":"1.3524","Date":"6/18/2016","Time":"12:29pm","Ask":"1.3530","Bid":"1.3524"},{"id":"USDBGN","Name":"USD/BGN","Rate":"1.7333","Date":"6/18/2016","Time":"12:29pm","Ask":"1.7436","Bid":"1.7333"},{"id":"USDBRL","Name":"USD/BRL","Rate":"3.4162","Date":"6/18/2016","Time":"12:29pm","Ask":"3.4208","Bid":"3.4162"},{"id":"USDCAD","Name":"USD/CAD","Rate":"1.2895","Date":"6/18/2016","Time":"12:29pm","Ask":"1.2900","Bid":"1.2895"},{"id":"USDCHF","Name":"USD/CHF","Rate":"0.9598","Date":"6/18/2016","Time":"12:29pm","Ask":"0.9600","Bid":"0.9598"},{"id":"USDCNY","Name":"USD/CNY","Rate":"6.5705","Date":"6/18/2016","Time":"12:29pm","Ask":"6.5718","Bid":"6.5705"},{"id":"USDCZK","Name":"USD/CZK","Rate":"24.0020","Date":"6/18/2016","Time":"12:29pm","Ask":"24.0200","Bid":"24.0020"},{"id":"USDDKK","Name":"USD/DKK","Rate":"6.5953","Date":"6/18/2016","Time":"12:29pm","Ask":"6.5972","Bid":"6.5953"},{"id":"USDGBP","Name":"USD/GBP","Rate":"0.6964","Date":"6/18/2016","Time":"12:29pm","Ask":"0.6968","Bid":"0.6964"},{"id":"USDHKD","Name":"USD/HKD","Rate":"7.7614","Date":"6/18/2016","Time":"12:29pm","Ask":"7.7616","Bid":"7.7614"},{"id":"USDHRK","Name":"USD/HRK","Rate":"6.6707","Date":"6/18/2016","Time":"12:29pm","Ask":"6.6732","Bid":"6.6707"},{"id":"USDHUF","Name":"USD/HUF","Rate":"278.5100","Date":"6/18/2016","Time":"12:29pm","Ask":"278.9000","Bid":"278.5100"},{"id":"USDIDR","Name":"USD/IDR","Rate":"13337.5000","Date":"6/18/2016","Time":"12:29pm","Ask":"13340.0000","Bid":"13337.5000"},{"id":"USDILS","Name":"USD/ILS","Rate":"3.8674","Date":"6/18/2016","Time":"12:29pm","Ask":"3.8766","Bid":"3.8674"},{"id":"USDINR","Name":"USD/INR","Rate":"67.0724","Date":"6/18/2016","Time":"12:29pm","Ask":"67.0910","Bid":"67.0724"},{"id":"USDJPY","Name":"USD/JPY","Rate":"104.1700","Date":"6/18/2016","Time":"12:29pm","Ask":"104.2000","Bid":"104.1700"},{"id":"USDKRW","Name":"USD/KRW","Rate":"1170.5450","Date":"6/18/2016","Time":"12:29pm","Ask":"1171.9000","Bid":"1170.5450"},{"id":"USDMXN","Name":"USD/MXN","Rate":"18.8280","Date":"6/18/2016","Time":"12:29pm","Ask":"18.8330","Bid":"18.8280"},{"id":"USDMYR","Name":"USD/MYR","Rate":"4.0885","Date":"6/18/2016","Time":"12:29pm","Ask":"4.0895","Bid":"4.0885"},{"id":"USDNOK","Name":"USD/NOK","Rate":"8.3600","Date":"6/18/2016","Time":"12:29pm","Ask":"8.3656","Bid":"8.3600"},{"id":"USDNZD","Name":"USD/NZD","Rate":"1.4176","Date":"6/18/2016","Time":"12:29pm","Ask":"1.4180","Bid":"1.4176"},{"id":"USDPHP","Name":"USD/PHP","Rate":"46.4395","Date":"6/18/2016","Time":"12:29pm","Ask":"46.4700","Bid":"46.4395"},{"id":"USDPLN","Name":"USD/PLN","Rate":"3.9162","Date":"6/18/2016","Time":"12:29pm","Ask":"3.9166","Bid":"3.9162"},{"id":"USDRON","Name":"USD/RON","Rate":"4.0220","Date":"6/18/2016","Time":"12:29pm","Ask":"4.0246","Bid":"4.0220"},{"id":"USDRUB","Name":"USD/RUB","Rate":"64.7795","Date":"6/18/2016","Time":"12:29pm","Ask":"64.8100","Bid":"64.7795"},{"id":"USDSEK","Name":"USD/SEK","Rate":"8.3321","Date":"6/18/2016","Time":"12:29pm","Ask":"8.3336","Bid":"8.3321"},{"id":"USDSGD","Name":"USD/SGD","Rate":"1.3499","Date":"6/18/2016","Time":"12:29pm","Ask":"1.3504","Bid":"1.3499"},{"id":"USDTHB","Name":"USD/THB","Rate":"35.2355","Date":"6/18/2016","Time":"12:29pm","Ask":"35.2640","Bid":"35.2355"},{"id":"USDTRY","Name":"USD/TRY","Rate":"2.9269","Date":"6/18/2016","Time":"12:29pm","Ask":"2.9290","Bid":"2.9269"},{"id":"USDUSD","Name":"USD/USD","Rate":"1.0000","Date":"N/A","Time":"N/A","Ask":"1.0000","Bid":"1.0000"},{"id":"USDZAR","Name":"USD/ZAR","Rate":"15.1519","Date":"6/18/2016","Time":"12:29pm","Ask":"15.1828","Bid":"15.1519"},{"id":"USDEUR","Name":"USD/EUR","Rate":"0.8868","Date":"6/18/2016","Time":"12:29pm","Ask":"0.8870","Bid":"0.8868"}]}}}'
+    http_version: 
+  recorded_at: Sun, 19 Jun 2016 07:10:46 GMT
+recorded_with: VCR 3.0.3

data/spec/lib/btc_adapter_spec.rb

@@ -6,45 +6,33 @@ RSpec.describe CurrencyRate::BtcAdapter do
     FETCH_URL = ''
   end
 
+  class SomeExchangeAdapter < CurrencyRate::BtcAdapter
+    def rate_for(from,to)
+      super
+      rate = rate_to_f(750)
+      invert_rate(from,to,rate)
+    end
+  end
+
   before(:each) do
     @exchange_adapter = CurrencyRate::BtcAdapter.instance
   end
 
-  describe "converting currencies" do
-
-    before(:each) do
-      allow(@exchange_adapter).to receive(:fetch_rates!)
-      allow(@exchange_adapter).to receive(:rate_for).with('USD').and_return(450.5412)
-    end
-
-    it "converts amount from currency into BTC" do
-      expect(@exchange_adapter.convert_from_currency(2252.706, currency: 'USD')).to eq(500000000)
-    end
-
-    it "converts from btc into currency" do
-      expect(@exchange_adapter.convert_to_currency(500000000, currency: 'USD')).to eq(2252.706)
-    end
-
-    it "shows btc amounts in various denominations" do
-      expect(@exchange_adapter.convert_from_currency(2252.706, currency: 'USD', btc_denomination: :btc)).to eq(5)
-      expect(@exchange_adapter.convert_to_currency(5, currency: 'USD', btc_denomination: :btc)).to eq(2252.706)
-    end
-
-    it "accepts string as amount and converts it properly" do
-      expect(@exchange_adapter.convert_from_currency('2252.706', currency: 'USD', btc_denomination: :btc)).to eq(5)
-      expect(@exchange_adapter.convert_to_currency('5', currency: 'USD', btc_denomination: :btc)).to eq(2252.706)
-    end
-
+  it "inverts currency rate when needed" do
+    allow(SomeExchangeAdapter.instance).to receive(:fetch_rates!)
+    @exchange_adapter = SomeExchangeAdapter.instance
+    expect(@exchange_adapter.rate_for('USD', 'BTC')).to eq(0.0013333333333333333)
   end
 
+
   it "when checking for rates, only calls fetch_rates! if they were checked long time ago or never" do
     uri_mock = double('uri mock')
     expect(URI).to      receive(:parse).and_return(uri_mock).once
     expect(uri_mock).to receive(:read).and_return('{ "USD": 534.4343 }').once
-    @exchange_adapter.rate_for('USD')
-    @exchange_adapter.rate_for('USD') # not calling fetch_rates! because we've just checked
+    @exchange_adapter.rate_for('USD', 'BTC')
+    @exchange_adapter.rate_for('USD', 'BTC') # not calling fetch_rates! because we've just checked
     @exchange_adapter.instance_variable_set(:@rates_updated_at, Time.now-1900)
-    @exchange_adapter.rate_for('USD')
+    @exchange_adapter.rate_for('USD', 'BTC')
   end
 
   it "raises exception if rate is nil" do

data/spec/lib/btc_adapters/average_rate_adapter_spec.rb

@@ -2,11 +2,11 @@ require 'spec_helper'
 
 RSpec.describe CurrencyRate::AverageRateAdapter do
 
-  before :all do
+  before :each do
     VCR.insert_cassette 'exchange_rate_adapters/btc_adapters/average_rate_adapter'
   end
 
-  after :all do
+  after :each do
     VCR.eject_cassette
   end
 
@@ -23,7 +23,7 @@ RSpec.describe CurrencyRate::AverageRateAdapter do
     uri_mock = double('uri mock')
     allow(uri_mock).to receive(:read).with(read_timeout: 4).and_return(json_response_bistamp, json_response_bitpay)
     allow(URI).to      receive(:parse).and_return(uri_mock)
-    expect(@average_rates_adapter.rate_for('USD')).to eq 150
+    expect(@average_rates_adapter.rate_for('BTC', 'USD')).to eq 150
   end
 
   it "fetches rates for all adapters" do
@@ -40,7 +40,7 @@ RSpec.describe CurrencyRate::AverageRateAdapter do
   end
 
   it "raises exception if all adapters fail to get rates" do
-    expect( -> { @average_rates_adapter.rate_for('FEDcoin') }).to raise_error(CurrencyRate::Adapter::CurrencyNotSupported)
+    expect( -> { @average_rates_adapter.rate_for('BTC', 'FEDcoin') }).to raise_error(CurrencyRate::Adapter::CurrencyNotSupported)
   end
 
   it "raises exception if unallowed method is called" do # fetch_rates! is not to be used in AverageRateAdapter itself

data/spec/lib/btc_adapters/bitfinex_adapter_spec.rb

@@ -0,0 +1,38 @@
+require 'spec_helper'
+
+RSpec.describe CurrencyRate::BitfinexAdapter do
+
+  before :all do
+    VCR.insert_cassette 'exchange_rate_adapters/btc_adapters/bitfinex_adapter'
+  end
+
+  after :all do
+    VCR.eject_cassette
+  end
+
+  before(:each) do
+    @exchange_adapter = CurrencyRate::BitfinexAdapter.instance
+  end
+
+  it "finds the rate for currency code" do
+    expect(@exchange_adapter.rate_for('BTC', 'USD')).to eq(763.0)
+    expect(@exchange_adapter.rate_for('USD', 'BTC')).to eq(0.001310615989515072)
+    expect(@exchange_adapter.rate_for('LTC', 'USD')).to eq(5.5105)
+    expect(@exchange_adapter.rate_for('USD', 'LTC')).to eq(0.1814717357771527)
+    expect( -> { @exchange_adapter.rate_for('FEDcoin', 'USD') }).to raise_error(CurrencyRate::Adapter::CurrencyNotSupported)
+  end
+
+  it "raises exception if rate is nil" do
+    json_response_1 = '{}'
+    json_response_2 = '{"mid":"762.495","bid":"762.49","ask":"762.5","last_price":"762.5","low":"743.1","high":"775.0","volume":"25680.26724445","timestamp":"1466405569.857112499"}'
+    json_response_3 = '{"mid":"762.495","bid":"762.49","ask":"762.5","last_price":"762.5","low":"743.1","high":"775.0","volume":"25680.26724445","timestamp":"1466405569.857112499"}'
+    uri_mock = double('uri mock')
+    allow(uri_mock).to receive(:read).with(read_timeout: 4).and_return(json_response_1, json_response_2, json_response_3)
+    allow(URI).to      receive(:parse).and_return(uri_mock)
+    3.times do
+      @exchange_adapter.fetch_rates!
+      expect( -> { @exchange_adapter.rate_for('FEDcoin', 'BTC') }).to raise_error(CurrencyRate::Adapter::CurrencyNotSupported)
+    end
+  end
+
+end

data/spec/lib/btc_adapters/bitpay_adapter_spec.rb

@@ -15,8 +15,13 @@ RSpec.describe CurrencyRate::BitpayAdapter do
   end
 
   it "finds the rate for currency code" do
-    expect(@exchange_adapter.rate_for('USD')).to be_kind_of(Float)
-    expect( -> { @exchange_adapter.rate_for('FEDcoin') }).to raise_error(CurrencyRate::Adapter::CurrencyNotSupported)
+    expect(@exchange_adapter.rate_for('BTC', 'USD')).to eq(748.02)
+    expect(@exchange_adapter.rate_for('BTC', 'BTC')).to eq(1)
+    expect(@exchange_adapter.rate_for('BTC', 'EUR')).to eq(663.359096)
+    expect(@exchange_adapter.rate_for('EUR', 'BTC')).to eq(1)
+    expect( -> { @exchange_adapter.rate_for('USD', 'EUR') }).to raise_exception(CurrencyRate::Adapter::CurrencyNotSupported)
+    expect( -> { @exchange_adapter.rate_for('EUR', 'USD') }).to raise_exception(CurrencyRate::Adapter::CurrencyNotSupported)
+    expect( -> { @exchange_adapter.rate_for('FEDcoin', 'USD') }).to raise_error(CurrencyRate::Adapter::CurrencyNotSupported)
   end
 
   it "raises exception if rate is nil" do
@@ -28,7 +33,7 @@ RSpec.describe CurrencyRate::BitpayAdapter do
     allow(URI).to      receive(:parse).and_return(uri_mock)
     3.times do
       @exchange_adapter.fetch_rates!
-      expect( -> { @exchange_adapter.rate_for('USD') }).to raise_error(CurrencyRate::Adapter::CurrencyNotSupported)
+      expect( -> { @exchange_adapter.rate_for('FEDcoin', 'USD') }).to raise_error(CurrencyRate::Adapter::CurrencyNotSupported)
     end
   end
 

data/spec/lib/btc_adapters/bitstamp_adapter_spec.rb

@@ -15,8 +15,13 @@ RSpec.describe CurrencyRate::BitstampAdapter do
   end
 
   it "finds the rate for currency code" do
-    expect(@exchange_adapter.rate_for('USD')).to be_kind_of(Float)
-    expect( -> { @exchange_adapter.rate_for('FEDcoin') }).to raise_error(CurrencyRate::Adapter::CurrencyNotSupported)
+    expect(@exchange_adapter.rate_for('BTC', 'USD')).to eq(751.97)
+    expect(@exchange_adapter.rate_for('USD', 'BTC')).to eq(0.0013298402861816295)
+    expect(@exchange_adapter.rate_for('BTC', 'EUR')).to eq(674.5)
+    expect(@exchange_adapter.rate_for('EUR', 'BTC')).to eq(0.0014825796886582653)
+    expect(@exchange_adapter.rate_for('USD', 'EUR')).to eq(0.9008846687447073)
+    expect(@exchange_adapter.rate_for('EUR', 'USD')).to eq(1.11002)
+    expect( -> { @exchange_adapter.rate_for('FEDcoin', 'USD') }).to raise_error(CurrencyRate::Adapter::CurrencyNotSupported)
   end
 
   it "raises exception if rate is nil" do
@@ -28,7 +33,7 @@ RSpec.describe CurrencyRate::BitstampAdapter do
     allow(URI).to      receive(:parse).and_return(uri_mock)
     3.times do
       @exchange_adapter.fetch_rates!
-      expect( -> { @exchange_adapter.rate_for('USD') }).to raise_error(CurrencyRate::Adapter::CurrencyNotSupported)
+      expect( -> { @exchange_adapter.rate_for('FEDcoin', 'BTC') }).to raise_error(CurrencyRate::Adapter::CurrencyNotSupported)
     end
   end
 

data/spec/lib/btc_adapters/btcchina_adapter_spec.rb

@@ -0,0 +1,36 @@
+require 'spec_helper'
+
+RSpec.describe CurrencyRate::BTCChinaAdapter do
+
+  before :all do
+    VCR.insert_cassette 'exchange_rate_adapters/btc_adapters/btcchina_adapter'
+  end
+
+  after :all do
+    VCR.eject_cassette
+  end
+
+  before(:each) do
+    @exchange_adapter = CurrencyRate::HuobiAdapter.instance
+  end
+
+  it "finds the rate for currency code" do
+    expect(@exchange_adapter.rate_for('BTC', 'CNY')).to eq(5084.51)
+    expect(@exchange_adapter.rate_for('CNY', 'BTC')).to eq(0.00019667578586727137)
+    expect( -> { @exchange_adapter.rate_for('FEDcoin', 'USD') }).to raise_error(CurrencyRate::Adapter::CurrencyNotSupported)
+  end
+
+  it "raises exception if rate is nil" do
+    json_response_1 = '{}'
+    json_response_2 = '{"ticker":{"high":"5119.92","low":"4980.00","buy":"5081.50","sell":"5081.97","last":"5081.98","vol":"44572.00110000","date":1466406593,"vwap":"5056.91","prev_close":"5096.97","open":"5096.28"}}'
+    json_response_3 = '{"ticker":{"high":"5119.92","low":"4980.00","buy":"5081.50","sell":"5081.97","last":"5081.98","vol":"44572.00110000","date":1466406593,"vwap":"5056.91","prev_close":"5096.97","open":"5096.28"}}'
+    uri_mock = double('uri mock')
+    allow(uri_mock).to receive(:read).with(read_timeout: 4).and_return(json_response_1, json_response_2, json_response_3)
+    allow(URI).to      receive(:parse).and_return(uri_mock)
+    3.times do
+      @exchange_adapter.fetch_rates!
+      expect( -> { @exchange_adapter.rate_for('FEDcoin', 'BTC') }).to raise_error(CurrencyRate::Adapter::CurrencyNotSupported)
+    end
+  end
+
+end

data/spec/lib/btc_adapters/btce_adapter_spec.rb

@@ -15,8 +15,15 @@ RSpec.describe CurrencyRate::BtceAdapter do
   end
 
   it "finds the rate for currency code" do
-    expect(@exchange_adapter.rate_for('USD')).to be_kind_of(Float)
-    expect( -> { @exchange_adapter.rate_for('FEDcoin') }).to raise_error(CurrencyRate::Adapter::CurrencyNotSupported)
+    expect(@exchange_adapter.rate_for('BTC', 'USD')).to eq(723.872)
+    expect(@exchange_adapter.rate_for('USD', 'BTC')).to eq(0.0013814597055833075)
+    expect(@exchange_adapter.rate_for('BTC', 'EUR')).to eq(665.022)
+    expect(@exchange_adapter.rate_for('EUR', 'BTC')).to eq(0.0015037096517107704)
+    expect(@exchange_adapter.rate_for('USD', 'RUB')).to eq(60.5)
+    expect(@exchange_adapter.rate_for('RUB', 'USD')).to eq(0.01652892561983471)
+    expect(@exchange_adapter.rate_for('EUR', 'RUB')).to eq(65.63)
+    expect(@exchange_adapter.rate_for('RUB', 'EUR')).to eq(0.015236934328813043)
+    expect( -> { @exchange_adapter.rate_for('FEDcoin', 'USD') }).to raise_error(CurrencyRate::Adapter::CurrencyNotSupported)
   end
 
   it "rases exception if rate is nil" do
@@ -28,7 +35,7 @@ RSpec.describe CurrencyRate::BtceAdapter do
     allow(URI).to      receive(:parse).and_return(uri_mock)
     3.times do
       @exchange_adapter.fetch_rates!
-      expect( -> { @exchange_adapter.rate_for('USD') }).to raise_error(CurrencyRate::Adapter::CurrencyNotSupported)
+      expect( -> { @exchange_adapter.rate_for('USD', 'EUR') }).to raise_error(CurrencyRate::Adapter::CurrencyNotSupported)
     end
   end
 

data/spec/lib/btc_adapters/coinbase_adapter_spec.rb

@@ -15,8 +15,9 @@ RSpec.describe CurrencyRate::CoinbaseAdapter do
   end
 
   it "finds the rate for currency code" do
-    expect(@exchange_adapter.rate_for('USD')).to be_kind_of(Float)
-    expect( -> { @exchange_adapter.rate_for('FEDcoin') }).to raise_error(CurrencyRate::Adapter::CurrencyNotSupported)
+    expect(@exchange_adapter.rate_for('BTC', 'USD')).to eq(760.85)
+    expect(@exchange_adapter.rate_for('USD', 'BTC')).to eq(0.001314)
+    expect( -> { @exchange_adapter.rate_for('FEDcoin', 'USD') }).to raise_error(CurrencyRate::Adapter::CurrencyNotSupported)
   end
 
   it "raises exception if rate is nil" do
@@ -28,8 +29,9 @@ RSpec.describe CurrencyRate::CoinbaseAdapter do
     allow(URI).to      receive(:parse).and_return(uri_mock)
     3.times do
       @exchange_adapter.fetch_rates!
-      expect( -> { @exchange_adapter.rate_for('USD') }).to raise_error(CurrencyRate::Adapter::CurrencyNotSupported)
+      expect( -> { @exchange_adapter.rate_for('FEDCoin', 'BTC') }).to raise_error(CurrencyRate::Adapter::CurrencyNotSupported)
     end
+
   end
 
 end

data/spec/lib/btc_adapters/huobi_adapter_spec.rb

@@ -0,0 +1,38 @@
+require 'spec_helper'
+
+RSpec.describe CurrencyRate::HuobiAdapter do
+
+  before :all do
+    VCR.insert_cassette 'exchange_rate_adapters/btc_adapters/huobi_adapter'
+  end
+
+  after :all do
+    VCR.eject_cassette
+  end
+
+  before(:each) do
+    @exchange_adapter = CurrencyRate::HuobiAdapter.instance
+  end
+
+  it "finds the rate for currency code" do
+    expect(@exchange_adapter.rate_for('BTC', 'CNY')).to eq(5081.0)
+    expect(@exchange_adapter.rate_for('CNY', 'BTC')).to eq(0.000196811651249754)
+    expect(@exchange_adapter.rate_for('LTC', 'CNY')).to eq(36.9)
+    expect(@exchange_adapter.rate_for('CNY', 'LTC')).to eq(0.02710027100271003)
+    expect( -> { @exchange_adapter.rate_for('FEDcoin', 'USD') }).to raise_error(CurrencyRate::Adapter::CurrencyNotSupported)
+  end
+
+  it "raises exception if rate is nil" do
+    json_response_1 = '{}'
+    json_response_2 = '{"time":"1466406045","ticker":{"open":5108.77,"vol":533438.162,"symbol":"btccny","last":5081.29,"buy":5081.13,"sell":5081.29,"high":5138,"low":5010.5} }'
+    json_response_3 = '{"time":"1466406045","ticker":{"open":5108.77,"vol":533438.162,"symbol":"btccny","last":5081.29,"buy":5081.13,"sell":5081.29,"high":5138,"low":5010.5} }'
+    uri_mock = double('uri mock')
+    allow(uri_mock).to receive(:read).with(read_timeout: 4).and_return(json_response_1, json_response_2, json_response_3)
+    allow(URI).to      receive(:parse).and_return(uri_mock)
+    3.times do
+      @exchange_adapter.fetch_rates!
+      expect( -> { @exchange_adapter.rate_for('FEDcoin', 'BTC') }).to raise_error(CurrencyRate::Adapter::CurrencyNotSupported)
+    end
+  end
+
+end

data/spec/lib/btc_adapters/kraken_adapter_spec.rb

@@ -15,8 +15,11 @@ RSpec.describe CurrencyRate::KrakenAdapter do
   end
 
   it "finds the rate for currency code" do
-    expect(@exchange_adapter.rate_for('USD')).to be_kind_of(Float)
-    expect( -> { @exchange_adapter.rate_for('FEDcoin') }).to raise_error(CurrencyRate::Adapter::CurrencyNotSupported)
+    expect(@exchange_adapter.rate_for('BTC', 'USD')).to eq(755.15)
+    expect(@exchange_adapter.rate_for('USD', 'BTC')).to eq(0.0013242402171753957)
+    expect(@exchange_adapter.rate_for('BTC', 'EUR')).to eq(671.215)
+    expect(@exchange_adapter.rate_for('EUR', 'BTC')).to eq(0.0014898355966419105)
+    expect( -> { @exchange_adapter.rate_for('FEDcoin', 'USD') }).to raise_error(CurrencyRate::Adapter::CurrencyNotSupported)
   end
 
   it "raises exception if rate is nil" do
@@ -28,7 +31,7 @@ RSpec.describe CurrencyRate::KrakenAdapter do
     allow(URI).to      receive(:parse).and_return(uri_mock)
     3.times do
       @exchange_adapter.fetch_rates!
-      expect( -> { @exchange_adapter.rate_for('USD') }).to raise_error(CurrencyRate::Adapter::CurrencyNotSupported)
+      expect( -> { @exchange_adapter.rate_for('FEDCoin', 'USD') }).to raise_error(CurrencyRate::Adapter::CurrencyNotSupported)
     end
   end
 

data/spec/lib/btc_adapters/localbitcoins_adapter_spec.rb

@@ -15,8 +15,9 @@ RSpec.describe CurrencyRate::LocalbitcoinsAdapter do
   end
 
   it "finds the rate for currency code" do
-    expect(@exchange_adapter.rate_for('USD')).to be_kind_of(Float)
-    expect( -> { @exchange_adapter.rate_for('FEDcoin') }).to raise_error(CurrencyRate::Adapter::CurrencyNotSupported)
+    expect(@exchange_adapter.rate_for('BTC', 'USD')).to eq(591.95)
+    expect(@exchange_adapter.rate_for('USD', 'BTC')).to eq(0.0016893318692457132)
+    expect( -> { @exchange_adapter.rate_for('FEDcoin', 'USD') }).to raise_error(CurrencyRate::Adapter::CurrencyNotSupported)
   end
 
   it "rases exception if rate is nil" do
@@ -28,7 +29,7 @@ RSpec.describe CurrencyRate::LocalbitcoinsAdapter do
     allow(URI).to      receive(:parse).and_return(uri_mock)
     3.times do
       @exchange_adapter.fetch_rates!
-      expect( -> { @exchange_adapter.rate_for('USD') }).to raise_error(CurrencyRate::Adapter::CurrencyNotSupported)
+      expect( -> { @exchange_adapter.rate_for('FEDcoin', 'USD') }).to raise_error(CurrencyRate::Adapter::CurrencyNotSupported)
     end
   end
 

data/spec/lib/btc_adapters/okcoin_adapter_spec.rb

@@ -15,8 +15,16 @@ RSpec.describe CurrencyRate::OkcoinAdapter do
   end
 
   it "finds the rate for currency code" do
-    expect(@exchange_adapter.rate_for('USD')).to be_kind_of(Float)
-    expect( -> { @exchange_adapter.rate_for('FEDcoin') }).to raise_error(CurrencyRate::Adapter::CurrencyNotSupported)
+    expect(@exchange_adapter.rate_for('BTC', 'USD')).to eq(769.05)
+    expect(@exchange_adapter.rate_for('USD', 'BTC')).to eq(0.0013003055718093753)
+    expect(@exchange_adapter.rate_for('BTC', 'CNY')).to eq(5113.0)
+    expect(@exchange_adapter.rate_for('CNY', 'BTC')).to eq(0.00019557989438685703)
+
+    expect(@exchange_adapter.rate_for('LTC', 'USD')).to eq(5.661)
+    expect(@exchange_adapter.rate_for('USD', 'LTC')).to eq(0.17664723547076489)
+    expect(@exchange_adapter.rate_for('LTC', 'CNY')).to eq(37.68)
+    expect(@exchange_adapter.rate_for('CNY', 'LTC')).to eq(0.02653927813163482)
+    expect( -> { @exchange_adapter.rate_for('FEDcoin', 'USD') }).to raise_error(CurrencyRate::Adapter::CurrencyNotSupported)
   end
 
   it "raises exception if rate is nil" do
@@ -28,7 +36,7 @@ RSpec.describe CurrencyRate::OkcoinAdapter do
     3.times do |i|
       @exchange_adapter.instance_variable_set :@rates_updated_at, Time.now
       @exchange_adapter.instance_variable_set :@rates, JSON.parse(response[i])
-      expect( -> { @exchange_adapter.rate_for('USD') }).to raise_error(CurrencyRate::Adapter::CurrencyNotSupported)
+      expect( -> { @exchange_adapter.rate_for('FEDcoin', 'BTC') }).to raise_error(CurrencyRate::Adapter::CurrencyNotSupported)
     end
   end
 

data/spec/lib/fiat_adapters/fixer_adapter_spec.rb

@@ -15,8 +15,11 @@ RSpec.describe CurrencyRate::FixerAdapter do
   end
 
   it "finds the rate for currency code" do
-    expect(@exchange_adapter.rate_for('RUB')).to be_kind_of(Numeric)
-    expect( -> { @exchange_adapter.rate_for('KZT') }).to raise_error(CurrencyRate::Adapter::CurrencyNotSupported)
+    expect(@exchange_adapter.rate_for('EUR', 'USD')).to eq(1.12)
+    expect(@exchange_adapter.rate_for('USD', 'EUR')).to eq(0.88)
+    expect(@exchange_adapter.rate_for('USD', 'RUB')).to eq(65.12)
+    expect(@exchange_adapter.rate_for('RUB', 'USD')).to eq(0.02)
+    expect( -> { @exchange_adapter.rate_for('FEDcoin', 'USD') }).to raise_error(CurrencyRate::Adapter::CurrencyNotSupported)
   end
 
 end