curb 0.8.4 → 1.3.5

data/tests/tc_gc_compact.rb

@@ -0,0 +1,223 @@
+# frozen_string_literal: true
+
+require File.expand_path('helper', __dir__)
+
+class TestGcCompact < Test::Unit::TestCase
+  ITERATIONS = (ENV['CURB_GC_COMPACT_ITERATIONS'] || 50).to_i
+  EASY_PER_MULTI = 3
+  GC_CRASH_REGRESSION_ITERATIONS = (ENV['CURB_GC_CRASH_REGRESSION_ITERATIONS'] || [ITERATIONS, 10].min).to_i
+
+  def setup
+    omit('GC.compact unavailable on this Ruby') unless defined?(GC.compact)
+  end
+
+  def test_multi_perform_with_gc_compact
+    ITERATIONS.times do
+      run_multi_perform_compact_iteration
+      collect_after_iteration
+    end
+  end
+
+  def test_gc_compact_during_multi_cleanup
+    omit('GC cleanup isolation requires fork') if NO_FORK || WINDOWS
+
+    pid = fork do
+      begin
+        ITERATIONS.times do
+          run_multi_cleanup_compact_iteration
+          collect_after_iteration
+        end
+        exit! 0
+      rescue StandardError => e
+        warn("#{e.class}: #{e.message}")
+        warn(e.backtrace.join("\n")) if e.backtrace
+        exit! 1
+      end
+    end
+
+    _child_pid, status = Process.wait2(pid)
+    assert_predicate status, :success?
+  end
+
+  def test_gc_compact_after_detach
+    run_multi_detach_compact_iteration
+    collect_after_iteration
+  end
+
+  def test_gc_compact_after_failed_implicit_multi_cleanup
+    GC_CRASH_REGRESSION_ITERATIONS.times do
+      run_failed_implicit_multi_cleanup_iteration(compact: true, cleanup_with_objectspace: false)
+      collect_after_iteration
+    end
+  end
+
+  def test_gc_cleanup_after_failed_implicit_multi_callback
+    omit('GC cleanup isolation requires fork') if NO_FORK || WINDOWS
+
+    assert_child_process_success do
+      GC_CRASH_REGRESSION_ITERATIONS.times do
+        run_failed_implicit_multi_cleanup_iteration(compact: true, cleanup_with_objectspace: true)
+      end
+    end
+  end
+
+  def test_gc_cleanup_after_invalid_multi_assignment_rejection
+    omit('GC cleanup isolation requires fork') if NO_FORK || WINDOWS
+
+    assert_child_process_success do
+      GC_CRASH_REGRESSION_ITERATIONS.times do
+        easy = Curl::Easy.new($TEST_URL)
+
+        begin
+          easy.multi = Object.new
+          raise 'expected TypeError from Curl::Easy#multi='
+        rescue TypeError => error
+          raise "unexpected error message: #{error.message}" unless /Curl::Multi/.match?(error.message)
+        end
+
+        easy = nil
+        full_gc(compact: true)
+      end
+    end
+  end
+
+  def test_gc_compact_easy
+    iteration = 0
+    responses = []
+    while iteration < ITERATIONS
+      res = Curl.get($TEST_URL) do |easy|
+        easy.timeout = 5
+        easy.on_complete { |_e| }
+        easy.on_failure { |_e, _code| }
+      end
+      iteration += 1
+      responses << res.body
+      compact
+    end
+  end
+
+  private
+
+  def run_multi_perform_compact_iteration
+    multi = Curl::Multi.new
+    handles = add_easy_handles(multi)
+
+    compact
+    multi.perform { compact }
+    compact
+  ensure
+    handles&.each do |easy|
+      begin
+        easy.close
+      rescue StandardError
+        nil
+      end
+    end
+    multi&.close
+  end
+
+  def run_multi_cleanup_compact_iteration
+    multi = Curl::Multi.new
+    add_easy_handles(multi)
+
+    compact
+    multi = nil
+    compact
+  end
+
+  def run_multi_detach_compact_iteration
+    multi = Curl::Multi.new
+    handles = add_easy_handles(multi)
+
+    compact
+    multi.perform { compact }
+
+    handles.each { |easy| multi.remove(easy); compact }
+    compact
+  ensure
+    multi&.close
+  end
+
+  def run_failed_implicit_multi_cleanup_iteration(compact:, cleanup_with_objectspace:)
+    easy = Curl::Easy.new($TEST_URL)
+    easy.on_complete { raise 'complete blew up' }
+
+    begin
+      easy.perform
+      raise 'expected callback abort'
+    rescue Curl::Err::AbortedByCallbackError => error
+      raise "unexpected callback message: #{error.message}" unless error.message == 'complete blew up'
+    end
+
+    raise 'expected implicit cleanup to clear easy.multi' unless easy.multi.nil?
+  ensure
+    easy = nil
+    if cleanup_with_objectspace
+      run_teardown_multi_cleanup
+      flush_deferred_multi_closes_all
+    else
+      flush_deferred_multi_closes_all
+    end
+    full_gc(compact: compact)
+  end
+
+  def add_easy_handles(multi)
+    Array.new(EASY_PER_MULTI) do
+      Curl::Easy.new($TEST_URL) do |easy|
+        easy.timeout = 5
+        easy.on_complete { |_e| }
+        easy.on_failure { |_e, _code| }
+      end.tap { |easy| multi.add(easy) }
+    end
+  end
+
+  def compact
+    GC.compact
+  end
+
+  def full_gc(compact: false)
+    GC.start(full_mark: true, immediate_sweep: true)
+    GC.compact if compact && GC.respond_to?(:compact)
+    GC.start(full_mark: true, immediate_sweep: true)
+  end
+
+  def flush_deferred_multi_closes_all
+    return unless Curl::Easy.respond_to?(:flush_deferred_multi_closes)
+
+    Curl::Easy.flush_deferred_multi_closes(all_threads: true)
+  end
+
+  def run_teardown_multi_cleanup
+    ObjectSpace.each_object(Curl::Multi) do |multi|
+      begin
+        next if multi.instance_variable_defined?(:@deferred_close) && multi.instance_variable_get(:@deferred_close)
+
+        multi.instance_variable_set(:@requests, {})
+        multi._close
+      rescue StandardError
+        nil
+      end
+    end
+  end
+
+  def assert_child_process_success
+    pid = fork do
+      begin
+        yield
+        exit! 0
+      rescue Exception => e
+        warn("#{e.class}: #{e.message}")
+        warn(e.backtrace.join("\n")) if e.backtrace
+        exit! 1
+      end
+    end
+
+    _child_pid, status = Process.wait2(pid)
+    assert_predicate status, :success?
+  end
+
+  def collect_after_iteration
+    ObjectSpace.garbage_collect
+    ObjectSpace.garbage_collect
+  end
+end

data/tests/tc_test_server_methods.rb

@@ -0,0 +1,110 @@
+require File.expand_path(File.join(File.dirname(__FILE__), 'helper'))
+require 'tmpdir'
+
+class TestServerMethodsWaitForServerReady < Test::Unit::TestCase
+  include TestServerMethods
+
+  def server_startup_timeout
+    0.05
+  end
+
+  def unused_port
+    server = TCPServer.new('127.0.0.1', 0)
+    port = server.addr[1]
+    server.close
+    port
+  end
+
+  def test_wait_for_server_ready_returns_false_when_thread_dies
+    thread = Thread.new {}
+    thread.join
+
+    started = Process.clock_gettime(Process::CLOCK_MONOTONIC)
+    assert_equal false, wait_for_server_ready(unused_port, thread: thread)
+    elapsed = Process.clock_gettime(Process::CLOCK_MONOTONIC) - started
+
+    assert_operator elapsed, :<, 0.5
+  end
+
+  def test_wait_for_server_ready_times_out_when_server_never_starts
+    error = assert_raise(RuntimeError) do
+      wait_for_server_ready(unused_port)
+    end
+
+    assert_match(/Failed to startup test server/, error.message)
+  end
+end
+
+class TestServerMethodsLockHandling < Test::Unit::TestCase
+  include TestServerMethods
+
+  def setup
+    @lock_dir = Dir.mktmpdir('curb-server-lock')
+    @__port = unused_port
+  end
+
+  def teardown
+    super
+    FileUtils.remove_entry(@lock_dir) if @lock_dir && File.exist?(@lock_dir)
+  end
+
+  def server_startup_timeout
+    0.05
+  end
+
+  def locked_file
+    File.join(@lock_dir, "server_lock-#{@__port}")
+  end
+
+  def unused_port
+    server = TCPServer.new('127.0.0.1', 0)
+    port = server.addr[1]
+    server.close
+    port
+  end
+
+  def test_clear_stale_server_lock_removes_legacy_lock_when_server_is_down
+    File.write(locked_file, 'locked')
+
+    clear_stale_server_lock(@__port)
+
+    assert_equal false, File.exist?(locked_file)
+  end
+
+  def test_clear_stale_server_lock_removes_dead_pid_lock_when_server_is_down
+    File.write(locked_file, "999999\n")
+
+    clear_stale_server_lock(@__port)
+
+    assert_equal false, File.exist?(locked_file)
+  end
+
+  def test_clear_stale_server_lock_keeps_live_pid_lock_during_startup_window
+    write_server_lock(Process.pid)
+
+    clear_stale_server_lock(@__port)
+
+    assert_equal true, File.exist?(locked_file)
+  end
+
+  def test_clear_stale_server_lock_removes_non_responding_live_pid_lock_after_timeout
+    write_server_lock(Process.pid)
+    stale_time = Time.now - 1
+    File.utime(stale_time, stale_time, locked_file)
+
+    clear_stale_server_lock(@__port)
+
+    assert_equal false, File.exist?(locked_file)
+  end
+
+  def test_stop_test_server_removes_owned_lock_and_shuts_listener_down
+    server_setup(@__port)
+    assert_equal true, File.exist?(locked_file)
+    assert_equal true, server_responding?(@__port)
+
+    stop_test_server
+
+    assert_equal false, File.exist?(locked_file)
+    assert_equal false, server_responding?(@__port)
+  end
+end

data/tests/timeout.rb

@@ -13,15 +13,27 @@ class TestCurbTimeouts < Test::Unit::TestCase
     elapsed = Time.now - start
     assert elapsed > 2
   end
-  
+
   def test_overall_timeout_on_dead_transfer
     curl = Curl::Easy.new(wait_url(2))
     curl.timeout = 1
+    exception = assert_raise(Curl::Err::TimeoutError) do
+      curl.http_get
+    end
+    assert_match(
+      /^Timeout was reached: Operation timed out after/,
+      exception.message
+    )
+  end
+
+  def test_overall_timeout_ms_on_dead_transfer
+    curl = Curl::Easy.new(wait_url(2))
+    curl.timeout_ms = 1000
     assert_raise(Curl::Err::TimeoutError) do
       curl.http_get
     end
   end
-  
+
   def test_clearing_timeout
     curl = Curl::Easy.new(wait_url(2))
     curl.timeout = 1
@@ -36,16 +48,20 @@ class TestCurbTimeouts < Test::Unit::TestCase
     curl = Curl::Easy.new(serve_url(100, 2, 3))
     curl.timeout = 1
     # transfer is aborted despite data being exchanged
-    assert_raise(Curl::Err::TimeoutError) do
+    exception = assert_raise(Curl::Err::TimeoutError) do
       curl.http_get
     end
+    assert_match(
+      /^Timeout was reached: Operation timed out after/,
+      exception.message
+    )
   end
   
   def test_low_speed_time_on_slow_transfer
     curl = Curl::Easy.new(serve_url(100, 1, 3))
     curl.low_speed_time = 2
     # use default low_speed_limit of 1
-    assert true, curl.http_get
+    assert_equal true, curl.http_get
   end
   
   def test_low_speed_time_on_very_slow_transfer
@@ -55,18 +71,26 @@ class TestCurbTimeouts < Test::Unit::TestCase
     # XXX for some reason this test fails if low speed limit is not specified
     curl.low_speed_limit = 1
     # use default low_speed_limit of 1
-    assert_raise(Curl::Err::TimeoutError) do
+    exception = assert_raise(Curl::Err::TimeoutError) do
       curl.http_get
     end
+    assert_match(
+      /^Timeout was reached: Operation too slow/,
+      exception.message
+    )
   end
   
   def test_low_speed_limit_on_slow_transfer
     curl = Curl::Easy.new(serve_url(10, 1, 3))
     curl.low_speed_time = 2
     curl.low_speed_limit = 1000
-    assert_raise(Curl::Err::TimeoutError) do
+    exception = assert_raise(Curl::Err::TimeoutError) do
       curl.http_get
     end
+    assert_match(
+      /^Timeout was reached: Operation too slow/,
+      exception.message
+    )
   end
   
   def test_clearing_low_speed_time

metadata

@@ -1,16 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: curb
 version: !ruby/object:Gem::Version
-  version: 0.8.4
-  prerelease: 
+  version: 1.3.5
 platform: ruby
 authors:
 - Ross Bamford
 - Todd A. Fisher
-autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-05-20 00:00:00.000000000 Z
+date: 2026-05-14 00:00:00.000000000 Z
 dependencies: []
 description: Curb (probably CUrl-RuBy or something) provides Ruby-language bindings
   for the libcurl(3), a fully-featured client-side URL transfer library. cURL and
@@ -21,87 +19,96 @@ extensions:
 - ext/extconf.rb
 extra_rdoc_files:
 - LICENSE
-- README
+- README.md
 files:
 - LICENSE
-- README
+- README.md
 - Rakefile
 - doc.rb
-- ext/extconf.rb
-- lib/curb.rb
-- lib/curl/easy.rb
-- lib/curl/multi.rb
-- lib/curl.rb
+- ext/banned.h
 - ext/curb.c
-- ext/curb_easy.c
-- ext/curb_errors.c
-- ext/curb_multi.c
-- ext/curb_postfield.c
-- ext/curb_upload.c
 - ext/curb.h
+- ext/curb_easy.c
 - ext/curb_easy.h
+- ext/curb_errors.c
 - ext/curb_errors.h
 - ext/curb_macros.h
+- ext/curb_multi.c
 - ext/curb_multi.h
+- ext/curb_postfield.c
 - ext/curb_postfield.h
+- ext/curb_upload.c
 - ext/curb_upload.h
+- ext/extconf.rb
+- lib/curb.rb
+- lib/curl.rb
+- lib/curl/easy.rb
+- lib/curl/multi.rb
 - tests/alltests.rb
 - tests/bug_crash_on_debug.rb
 - tests/bug_crash_on_progress.rb
 - tests/bug_curb_easy_blocks_ruby_threads.rb
 - tests/bug_curb_easy_post_with_string_no_content_length_header.rb
+- tests/bug_follow_redirect_288.rb
 - tests/bug_instance_post_differs_from_class_post.rb
 - tests/bug_issue102.rb
+- tests/bug_issue_noproxy.rb
+- tests/bug_issue_post_redirect.rb
+- tests/bug_issue_spnego.rb
 - tests/bug_multi_segfault.rb
 - tests/bug_postfields_crash.rb
 - tests/bug_postfields_crash2.rb
+- tests/bug_raise_on_callback.rb
 - tests/bug_require_last_or_segfault.rb
 - tests/bugtests.rb
 - tests/helper.rb
+- tests/leak_trace.rb
 - tests/mem_check.rb
 - tests/require_last_or_segfault_script.rb
 - tests/signals.rb
 - tests/tc_curl.rb
 - tests/tc_curl_download.rb
 - tests/tc_curl_easy.rb
+- tests/tc_curl_easy_cookielist.rb
+- tests/tc_curl_easy_request_target.rb
+- tests/tc_curl_easy_resolve.rb
 - tests/tc_curl_easy_setopt.rb
+- tests/tc_curl_maxfilesize.rb
 - tests/tc_curl_multi.rb
+- tests/tc_curl_native_coverage.rb
 - tests/tc_curl_postfield.rb
+- tests/tc_curl_protocols.rb
+- tests/tc_fiber_scheduler.rb
+- tests/tc_ftp_options.rb
+- tests/tc_gc_compact.rb
+- tests/tc_test_server_methods.rb
 - tests/timeout.rb
 - tests/timeout_server.rb
 - tests/unittests.rb
-homepage: http://curb.rubyforge.org/
-licenses: []
-post_install_message: 
+homepage: https://github.com/taf2/curb
+licenses:
+- Ruby
+metadata:
+  changelog_uri: https://github.com/taf2/curb/blob/master/ChangeLog.md
 rdoc_options:
-- --main
-- README
+- "--main"
+- README.md
 require_paths:
 - lib
 - ext
 required_ruby_version: !ruby/object:Gem::Requirement
-  none: false
   requirements:
-  - - ! '>='
+  - - ">="
     - !ruby/object:Gem::Version
-      version: '0'
-      segments:
-      - 0
-      hash: -243569426931689339
+      version: '2.2'
 required_rubygems_version: !ruby/object:Gem::Requirement
-  none: false
   requirements:
-  - - ! '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
-      segments:
-      - 0
-      hash: -243569426931689339
 requirements: []
-rubyforge_project: curb
-rubygems_version: 1.8.24
-signing_key: 
-specification_version: 3
+rubygems_version: 4.0.10
+specification_version: 4
 summary: Ruby libcurl bindings
 test_files:
 - tests/alltests.rb
@@ -109,23 +116,39 @@ test_files:
 - tests/bug_crash_on_progress.rb
 - tests/bug_curb_easy_blocks_ruby_threads.rb
 - tests/bug_curb_easy_post_with_string_no_content_length_header.rb
+- tests/bug_follow_redirect_288.rb
 - tests/bug_instance_post_differs_from_class_post.rb
 - tests/bug_issue102.rb
+- tests/bug_issue_noproxy.rb
+- tests/bug_issue_post_redirect.rb
+- tests/bug_issue_spnego.rb
 - tests/bug_multi_segfault.rb
 - tests/bug_postfields_crash.rb
 - tests/bug_postfields_crash2.rb
+- tests/bug_raise_on_callback.rb
 - tests/bug_require_last_or_segfault.rb
 - tests/bugtests.rb
 - tests/helper.rb
+- tests/leak_trace.rb
 - tests/mem_check.rb
 - tests/require_last_or_segfault_script.rb
 - tests/signals.rb
 - tests/tc_curl.rb
 - tests/tc_curl_download.rb
 - tests/tc_curl_easy.rb
+- tests/tc_curl_easy_cookielist.rb
+- tests/tc_curl_easy_request_target.rb
+- tests/tc_curl_easy_resolve.rb
 - tests/tc_curl_easy_setopt.rb
+- tests/tc_curl_maxfilesize.rb
 - tests/tc_curl_multi.rb
+- tests/tc_curl_native_coverage.rb
 - tests/tc_curl_postfield.rb
+- tests/tc_curl_protocols.rb
+- tests/tc_fiber_scheduler.rb
+- tests/tc_ftp_options.rb
+- tests/tc_gc_compact.rb
+- tests/tc_test_server_methods.rb
 - tests/timeout.rb
 - tests/timeout_server.rb
 - tests/unittests.rb