curation_concerns 1.7.8 → 2.0.0.rc1

data/app/presenters/curation_concerns/member_presenter_factory.rb

@@ -1,70 +0,0 @@
-module CurationConcerns
-  # Creates the presenters of the members (member works and file sets) of a specific object
-  class MemberPresenterFactory
-    class_attribute :file_presenter_class, :work_presenter_class
-    # modify this attribute to use an alternate presenter class for the files
-    self.file_presenter_class = FileSetPresenter
-
-    # modify this attribute to use an alternate presenter class for the child works
-    self.work_presenter_class = WorkShowPresenter
-
-    def initialize(work, ability, request = nil)
-      @work = work
-      @current_ability = ability
-      @request = request
-    end
-
-    delegate :id, to: :@work
-    attr_reader :current_ability, :request
-
-    # @param [Array<String>] ids a list of ids to build presenters for
-    # @param [Class] presenter_class the type of presenter to build
-    # @return [Array<presenter_class>] presenters for the ordered_members (not filtered by class)
-    def member_presenters(ids = ordered_ids, presenter_class = composite_presenter_class)
-      PresenterFactory.build_presenters(ids, presenter_class, *presenter_factory_arguments)
-    end
-
-    # @return [Array<FileSetPresenter>] presenters for the orderd_members that are FileSets
-    def file_set_presenters
-      @file_set_presenters ||= member_presenters(ordered_ids & file_set_ids)
-    end
-
-    # @return [Array<WorkShowPresenter>] presenters for the ordered_members that are not FileSets
-    def work_presenters
-      @work_presenters ||= member_presenters(ordered_ids - file_set_ids, work_presenter_class)
-    end
-
-    private
-
-      # TODO: Extract this to ActiveFedora::Aggregations::ListSource
-      def ordered_ids
-        @ordered_ids ||= begin
-                           ActiveFedora::SolrService.query("proxy_in_ssi:#{id}",
-                                                           rows: 10_000,
-                                                           fl: "ordered_targets_ssim")
-                                                    .flat_map { |x| x.fetch("ordered_targets_ssim", []) }
-                         end
-      end
-
-      # These are the file sets that belong to this work, but not necessarily
-      # in order.
-      # Arbitrarily maxed at 10 thousand; had to specify rows due to solr's default of 10
-      def file_set_ids
-        @file_set_ids ||= begin
-                            ActiveFedora::SolrService.query("{!field f=has_model_ssim}FileSet",
-                                                            rows: 10_000,
-                                                            fl: ActiveFedora.id_field,
-                                                            fq: "{!join from=ordered_targets_ssim to=id}id:\"#{id}/list_source\"")
-                                                     .flat_map { |x| x.fetch(ActiveFedora.id_field, []) }
-                          end
-      end
-
-      def presenter_factory_arguments
-        [current_ability, request]
-      end
-
-      def composite_presenter_class
-        CompositePresenterFactory.new(file_presenter_class, work_presenter_class, ordered_ids & file_set_ids)
-      end
-  end
-end

data/app/search_builders/curation_concerns/member_search_builder.rb

@@ -1,21 +0,0 @@
-module CurationConcerns
-  class MemberSearchBuilder < ::SearchBuilder
-    class_attribute :from_field
-    self.from_field = 'member_ids_ssim'
-
-    # Defines which search_params_logic should be used when searching for Collection members
-    self.default_processor_chain += [:include_collection_ids]
-
-    # include filters into the query to only include the collection memebers
-    def include_collection_ids(solr_parameters)
-      solr_parameters[:fq] ||= []
-      solr_parameters[:fq] << "{!join from=#{from_field} to=id}id:#{collection_id}"
-    end
-
-    protected
-
-      def collection_id
-        blacklight_params.fetch('id')
-      end
-  end
-end

data/app/views/catalog/_action_menu_partials/_collection.html.erb

@@ -1,27 +0,0 @@
-<div class="btn-group">
-  <button class="btn btn-default btn-small dropdown-toggle" data-toggle="dropdown" href="#">Select an action <span class="caret"></span></button>
-  <ul class="dropdown-menu">
-    <% if can? :edit, document %>
-      <li>
-        <%= link_to [:edit, document], class: 'itemicon itemedit' do %><i class="glyphicon glyphicon-pencil"></i> Edit <%= document.human_readable_type %>
-        <% end %>
-      </li>
-      <li>
-        <% if @collection # We're on the view page for @collection. -%>
-          <%= button_for_remove_from_collection(document) %>
-        <% else %>
-          <%= link_to document, class: 'itemicon itemtrash', title: 'Delete Collection', method: :delete, data: {
-                          confirm: "Deleting a collection from #{application_name} is permanent. Click OK to delete this collection from #{application_name}, or Cancel to cancel this operation" } do %>
-                          <i class="glyphicon glyphicon-trash"></i> Delete <%= document.human_readable_type %>
-          <% end %>
-        <% end %>
-      </li>
-    <% end %>
-    <% if can? :collect, document %>
-      <li>
-        <%= link_to_select_collection document %>
-      </li>
-    <% end %>
-  </ul>
-  <%= render 'collections/add_to_collection_modal', collectible: document if can? :collect, document %>
-</div>

data/app/views/curation_concerns/base/_form_in_works_error.html.erb

@@ -1,3 +0,0 @@
-<% unless f.object.model.errors[:in_works_ids].empty? %>
-  <%= f.full_error(:in_works_ids) %>
-<% end %>

data/app/views/curation_concerns/base/_form_ordered_members_error.html.erb

@@ -1,3 +0,0 @@
-<% unless f.object.model.errors[:ordered_member_ids].empty? %>
-  <%= f.full_error(:ordered_member_ids) %>
-<% end %>

data/db/migrate/20170308175556_add_allows_access_grant_to_workflow.rb

@@ -1,5 +0,0 @@
-class AddAllowsAccessGrantToWorkflow < ActiveRecord::Migration
-  def change
-    add_column :sipity_workflows, :allows_access_grant, :boolean
-  end
-end

data/spec/actors/curation_concerns/add_to_collections_actor_spec.rb

@@ -1,66 +0,0 @@
-require 'spec_helper'
-describe CurationConcerns::Actors::AddToCollectionActor do
-  let(:user) { create(:user) }
-  let(:curation_concern) { GenericWork.new }
-  let(:attributes) { {} }
-  let(:collection) { create(:collection).tap do |col|
-    col.apply_depositor_metadata user
-  end }
-  subject do
-    CurationConcerns::Actors::ActorStack.new(curation_concern,
-                                             user,
-                                             [described_class,
-                                              CurationConcerns::Actors::GenericWorkActor])
-  end
-  describe 'the next actor' do
-    let(:root_actor) { double }
-    before do
-      allow(CurationConcerns::Actors::RootActor).to receive(:new).and_return(root_actor)
-    end
-
-    let(:attributes) do
-      { collection_ids: ['123'], title: ['test'] }
-    end
-
-    it 'does not receive the collection_ids' do
-      expect(root_actor).to receive(:create).with(title: ['test'])
-      subject.create(attributes)
-    end
-  end
-
-  describe 'create' do
-    let(:attributes) do
-      { collection_ids: [collection.id], title: ['test'] }
-    end
-
-    it 'adds it to the collection' do
-      expect(subject.create(attributes)).to be true
-      expect(collection.reload.members).to eq [curation_concern]
-    end
-
-    describe "when work is in user's own collection" do
-      it "removes the work from that collection" do
-        # had to move collection and subject down into the spec to ensure they use the same user
-        collection = create(:collection).tap do |col|
-          col.apply_depositor_metadata user
-        end
-        subject.create(attributes)
-        expect(subject.create(collection_ids: [])).to be true
-        expect(collection.reload.members).to eq []
-      end
-    end
-
-    describe "when work is in another user's collection" do
-      let(:other_user) { create(:user) }
-      before do
-        collection.apply_depositor_metadata other_user
-        subject.create(attributes)
-      end
-
-      it "doesn't remove the work from that collection" do
-        expect(subject.create(collection_ids: [])).to be true
-        expect(collection.reload.members).to eq [curation_concern]
-      end
-    end
-  end
-end

data/spec/actors/curation_concerns/optimistic_lock_validator_spec.rb

@@ -1,50 +0,0 @@
-require 'spec_helper'
-
-RSpec.describe CurationConcerns::OptimisticLockValidator do
-  let(:update_actor) do
-    double('update actor', update: true,
-                           curation_concern: work,
-                           user: depositor)
-  end
-
-  let(:actor) do
-    CurationConcerns::Actors::ActorStack.new(work, depositor, [described_class])
-  end
-
-  let(:depositor) { create(:user) }
-  let(:work) { create(:generic_work) }
-
-  describe "update" do
-    before do
-      allow(CurationConcerns::Actors::RootActor).to receive(:new).and_return(update_actor)
-      allow(update_actor).to receive(:update).and_return(true)
-    end
-
-    subject { actor.update(attributes) }
-
-    context "when version is blank" do
-      let(:attributes) { { version: '' } }
-      it { is_expected.to be true }
-    end
-
-    context "when version is provided" do
-      context "and the version is current" do
-        let(:attributes) { { version: work.etag } }
-
-        it "returns true and calls the next actor without the version attribute" do
-          expect(update_actor).to receive(:update).with({}).and_return(true)
-          expect(subject).to be true
-        end
-      end
-
-      context "and the version is not current" do
-        let(:attributes) { { version: "W/\"ab2e8552cb5f7f00f91d2b223eca45849c722301\"" } }
-
-        it "returns false and sets an error" do
-          expect(subject).to be false
-          expect(work.errors[:base]).to include "Another user has made a change to that Generic work since you accessed the edit form."
-        end
-      end
-    end
-  end
-end

data/spec/forms/curation_concerns/forms/file_manager_form_spec.rb

@@ -1,19 +0,0 @@
-require 'spec_helper'
-
-RSpec.describe CurationConcerns::Forms::FileManagerForm do
-  let(:work) { create(:work) }
-  let(:ability) { instance_double Ability }
-  let(:form) { described_class.new(work, ability) }
-
-  describe "#member_presenters" do
-    subject { form.member_presenters }
-    let(:factory) { instance_double(CurationConcerns::MemberPresenterFactory, member_presenters: result) }
-    let(:result) { double }
-    before do
-      allow(CurationConcerns::MemberPresenterFactory).to receive(:new).with(work, ability).and_return(factory)
-    end
-    it "is delegated to the MemberPresenterFactory" do
-      expect(subject).to eq result
-    end
-  end
-end

data/spec/presenters/curation_concerns/member_presenter_factory_spec.rb

@@ -1,25 +0,0 @@
-require 'spec_helper'
-
-RSpec.describe CurationConcerns::MemberPresenterFactory do
-  describe "#file_set_presenters" do
-    describe "getting presenters from factory" do
-      let(:solr_document) { SolrDocument.new(attributes) }
-      let(:attributes) { {} }
-      let(:ability) { double }
-      let(:request) { double }
-      let(:factory) { described_class.new(solr_document, ability, request) }
-      let(:presenter_class) { double }
-      before do
-        allow(factory).to receive(:composite_presenter_class).and_return(presenter_class)
-        allow(factory).to receive(:ordered_ids).and_return(['12', '33'])
-        allow(factory).to receive(:file_set_ids).and_return(['33', '12'])
-      end
-
-      it "uses the set class" do
-        expect(CurationConcerns::PresenterFactory).to receive(:build_presenters)
-          .with(['12', '33'], presenter_class, ability, request)
-        factory.file_set_presenters
-      end
-    end
-  end
-end

data/spec/views/curation_concerns/admin/workflow_roles/index.html.erb_spec.rb

@@ -1,33 +0,0 @@
-require 'spec_helper'
-
-describe 'curation_concerns/admin/workflow_roles/index.html.erb', type: :view do
-  let!(:user1) { create(:user) }
-  let!(:user2) { create(:user) }
-  let(:presenter) do
-    CurationConcerns::Admin::WorkflowRolePresenter.new
-  end
-
-  before do
-    assign(:presenter, presenter)
-    allow(view).to receive(:admin_workflow_roles_path).and_return('/admin/workflow_roles')
-  end
-
-  context 'with no users having workflow roles' do
-    it 'displays "No Roles" for each user' do
-      render
-      expect(rendered).to have_content('No roles', count: 2)
-    end
-  end
-
-  context 'with some users having workflow roles' do
-    before do
-      # Force user instances to have corresponding sipity agents
-      user1.to_sipity_agent
-      user2.to_sipity_agent
-    end
-    it 'displays roles for each user' do
-      render
-      expect(rendered.match(/<ul>\s+<\/ul>/m)).to be nil
-    end
-  end
-end

data/spec/views/curation_concerns/base/_form.html.erb_spec.rb

@@ -1,35 +0,0 @@
-require 'spec_helper'
-
-describe 'curation_concerns/base/_form.html.erb', type: :view do
-  let(:ability) { double }
-  let(:user) { stub_model(User) }
-  let(:form) do
-    CurationConcerns::GenericWorkForm.new(work, ability)
-  end
-
-  before do
-    # view.lookup_context.view_paths.push 'app/views/curation_concerns'
-    # allow(controller).to receive(:current_user).and_return(user)
-    allow(view).to receive(:curation_concern).and_return(work)
-  end
-
-  let(:page) do
-    view.simple_form_for form do |f|
-      render 'curation_concerns/base/form', f: f
-    end
-    Capybara::Node::Simple.new(rendered)
-  end
-
-  context "when the work has been saved before" do
-    before do
-      allow(work).to receive(:new_record?).and_return(false)
-      assign(:form, form)
-    end
-
-    let(:work) { stub_model(GenericWork, id: '456', etag: '123456') }
-
-    it "renders the form with the version" do
-      expect(page).to have_selector("input#generic_work_version[value=\"123456\"]", visible: false)
-    end
-  end
-end