curation_concerns 1.5.0 → 1.6.0

data/spec/indexers/file_set_indexer_spec.rb

@@ -18,6 +18,7 @@ describe CurationConcerns::FileSetIndexer do
       subject: ['Theology'],
       language: ['Arabic'],
       rights: ['Wide open, buddy.'],
+      rights_statement: ['No Known Copyright'],
       resource_type: ['Book'],
       identifier: ['urn:isbn:1234567890'],
       based_near: ['Medina, Saudi Arabia'],
@@ -58,12 +59,14 @@ describe CurationConcerns::FileSetIndexer do
 
     it 'has fields' do
       expect(subject[Solrizer.solr_name('hasRelatedMediaFragment', :symbol)]).to eq 'foo123'
+      expect(subject[Solrizer.solr_name('hasRelatedImage', :symbol)]).to eq 'foo123'
       expect(subject[Solrizer.solr_name('part_of')]).to be_nil
       expect(subject[Solrizer.solr_name('date_uploaded')]).to be_nil
       expect(subject[Solrizer.solr_name('date_modified')]).to be_nil
       expect(subject[Solrizer.solr_name('date_uploaded', :stored_sortable, type: :date)]).to eq '2011-01-01T00:00:00Z'
       expect(subject[Solrizer.solr_name('date_modified', :stored_sortable, type: :date)]).to eq '2012-01-01T00:00:00Z'
       expect(subject[Solrizer.solr_name('rights')]).to eq ['Wide open, buddy.']
+      expect(subject[Solrizer.solr_name('rights_statement')]).to eq ['No Known Copyright']
       expect(subject[Solrizer.solr_name('related_url')]).to eq ['http://example.org/TheWork/']
       expect(subject[Solrizer.solr_name('contributor')]).to eq ['Mohammad']
       expect(subject[Solrizer.solr_name('creator')]).to eq ['Allah']

data/spec/indexers/work_indexer_spec.rb

@@ -22,7 +22,8 @@ describe CurationConcerns::WorkIndexer do
       expect(solr_document['member_ids_ssim']).to eq work.member_ids
       expect(solr_document['generic_type_sim']).to eq ['Work']
       expect(solr_document.fetch('thumbnail_path_ss')).to eq "/downloads/#{file.id}?file=thumbnail"
-      expect(subject.fetch('thumbnail_id_ssim')).to eq file.id
+      expect(subject.fetch('hasRelatedImage_ssim').first).to eq file.id
+      expect(subject.fetch('hasRelatedMediaFragment_ssim').first).to eq file.id
     end
 
     context "when thumbnail_field is configured" do

data/spec/javascripts/file_manager_member_spec.coffee

@@ -1,4 +1,5 @@
 describe "FileManagerMember", ->
+  filemm = require('curation_concerns/file_manager/member')
   file_manager_member = null
   save_manager = null
   beforeEach () ->
@@ -7,7 +8,7 @@ describe "FileManagerMember", ->
       push_changed: () -> {},
       mark_unchanged: () -> {}
     }
-    file_manager_member = new FileManagerMember($("li"), save_manager)
+    file_manager_member = new filemm.FileManagerMember($("li"), save_manager)
   describe "#is_changed", ->
     it "is true when the form's label input is changed", ->
       $("#file_set_title").val("testing")

data/spec/javascripts/file_manager_sorting_spec.coffee

@@ -0,0 +1,23 @@
+describe "FileManagerSorting", ->
+  sortm = require('curation_concerns/file_manager/sorting')
+  sort_manager = null
+  save_manager = null
+  titles = null
+  beforeEach () ->
+    loadFixtures('sortable.html')
+    save_manager = {
+      push_changed: () -> {},
+      mark_unchanged: () -> {}
+    }
+    sort_manager= new sortm(save_manager)
+  describe "sort_alpha", ->
+    it "sorts correctly, ignoring capitalization", ->
+      expect(sort_manager.order).toEqual(sort_manager.element.data("current-order"))
+      sort_manager.sort_alpha()
+      # order has changed
+      expect(sort_manager.order).not.toEqual(sort_manager.element.data("current-order"))
+      # order is now alphabetical
+      titles = $("input.title").map( ->
+        return $(@).val() 
+      ).get()
+      expect(titles).toEqual([ 'child1', 'child2', 'CIMG1815.JPG', 'CIMG1816 copy.JPG', 'zeldogbeach2.jpg' ])

data/spec/javascripts/fixtures/sortable.html

@@ -0,0 +1,182 @@
+<ul id="sortable" data-id="st74cq794" data-class-name="generic_works" data-singular-class-name="generic_work" class="list-unstyled grid clearfix ui-sortable">
+   <li data-reorder-id="m326m2125">
+    <div class="panel panel-default">
+      <form data-type="json" novalidate="novalidate" class="simple_form edit_file_set" id="edit_file_set_m326m2125" action="/concern/file_sets/m326m2125" accept-charset="UTF-8" data-remote="true" method="post"><input name="utf8" type="hidden" value="✓"><input type="hidden" name="_method" value="patch">
+        <div class="panel-heading ui-sortable-handle">
+          <div class="order-title">
+            <div class="form-group string required file_set_title"><input class="form-control string required title" name="file_set[title][]" type="text" value="CIMG1815.JPG" id="file_set_title"></div>
+          </div>
+          <div class="file-set-link pull-right">
+            <a title="Edit file" href="/concern/parent/st74cq794/file_sets/m326m2125">
+              <span class="glyphicon glyphicon-edit" aria-hidden="true"></span>
+</a>          </div>
+            <div class="order-filename">
+              <em title="CIMG1815.JPG">(CIMG1815.JPG)</em>
+            </div>
+        </div>
+        <div class="panel-body">
+          <div class="text-center thumbnail">
+            <a data-context-href="/catalog/m326m2125/track" href="/concern/file_sets/m326m2125"><img class="thumbnail-inner" src="/downloads/m326m2125?file=thumbnail" alt="M326m2125?file=thumbnail"></a>
+
+          </div>
+          <div class="attributes">
+            
+          </div>
+          <div class="spacer">
+          </div>
+        </div>
+</form>            <div class="form-group radio_buttons member_resource_options">
+        <span class="radio">
+          <input type="radio" name="thumbnail_id" id="thumbnail_id_m326m2125" value="m326m2125" class="radio_buttons" checked="checked">
+          <label for="thumbnail_id_m326m2125">Thumbnail</label>
+        </span>
+      </div>
+
+    </div>
+</li>
+
+   <li data-reorder-id="pr76f369j">
+    <div class="panel panel-default">
+      <form data-type="json" novalidate="novalidate" class="simple_form edit_file_set" id="edit_file_set_pr76f369j" action="/concern/file_sets/pr76f369j" accept-charset="UTF-8" data-remote="true" method="post"><input name="utf8" type="hidden" value="✓"><input type="hidden" name="_method" value="patch">
+        <div class="panel-heading ui-sortable-handle">
+          <div class="order-title">
+            <div class="form-group string required file_set_title"><input class="form-control string required title" name="file_set[title][]" type="text" value="zeldogbeach2.jpg" id="file_set_title"></div>
+          </div>
+          <div class="file-set-link pull-right">
+            <a title="Edit file" href="/concern/parent/st74cq794/file_sets/pr76f369j">
+              <span class="glyphicon glyphicon-edit" aria-hidden="true"></span>
+</a>          </div>
+            <div class="order-filename">
+              <em title="zeldogbeach2.jpg">(zeldogbeach2.jpg)</em>
+            </div>
+        </div>
+        <div class="panel-body">
+          <div class="text-center thumbnail">
+            <a data-context-href="/catalog/pr76f369j/track" href="/concern/file_sets/pr76f369j"><img class="thumbnail-inner" src="/downloads/pr76f369j?file=thumbnail" alt="Pr76f369j?file=thumbnail"></a>
+
+          </div>
+          <div class="attributes">
+            
+          </div>
+          <div class="spacer">
+          </div>
+        </div>
+</form>            <div class="form-group radio_buttons member_resource_options">
+        <span class="radio">
+          <input type="radio" name="thumbnail_id" id="thumbnail_id_pr76f369j" value="pr76f369j" class="radio_buttons">
+          <label for="thumbnail_id_pr76f369j">Thumbnail</label>
+        </span>
+      </div>
+
+    </div>
+</li>
+
+   <li data-reorder-id="3484zh205">
+    <div class="panel panel-default">
+      <form data-type="json" novalidate="novalidate" class="simple_form edit_file_set" id="edit_file_set_3484zh205" action="/concern/file_sets/3484zh205" accept-charset="UTF-8" data-remote="true" method="post"><input name="utf8" type="hidden" value="✓"><input type="hidden" name="_method" value="patch">
+        <div class="panel-heading ui-sortable-handle">
+          <div class="order-title">
+            <div class="form-group string required file_set_title"><input class="form-control string required title" name="file_set[title][]" type="text" value="CIMG1816 copy.JPG" id="file_set_title"></div>
+          </div>
+          <div class="file-set-link pull-right">
+            <a title="Edit file" href="/concern/parent/st74cq794/file_sets/3484zh205">
+              <span class="glyphicon glyphicon-edit" aria-hidden="true"></span>
+</a>          </div>
+            <div class="order-filename">
+              <em title="CIMG1816 copy.JPG">(CIMG1816 copy.JPG)</em>
+            </div>
+        </div>
+        <div class="panel-body">
+          <div class="text-center thumbnail">
+            <a data-context-href="/catalog/3484zh205/track" href="/concern/file_sets/3484zh205"><img class="thumbnail-inner" src="/downloads/3484zh205?file=thumbnail" alt="3484zh205?file=thumbnail"></a>
+
+          </div>
+          <div class="attributes">
+            
+          </div>
+          <div class="spacer">
+          </div>
+        </div>
+</form>            <div class="form-group radio_buttons member_resource_options">
+        <span class="radio">
+          <input type="radio" name="thumbnail_id" id="thumbnail_id_3484zh205" value="3484zh205" class="radio_buttons">
+          <label for="thumbnail_id_3484zh205">Thumbnail</label>
+        </span>
+      </div>
+
+    </div>
+</li>
+
+   <li data-reorder-id="sb397864f">
+    <div class="panel panel-default">
+      <form data-type="json" novalidate="novalidate" class="simple_form edit_generic_work" id="edit_generic_work_sb397864f" action="/concern/generic_works/sb397864f" accept-charset="UTF-8" data-remote="true" method="post"><input name="utf8" type="hidden" value="✓"><input type="hidden" name="_method" value="patch">
+        <div class="panel-heading ui-sortable-handle">
+          <div class="order-title">
+            <div class="form-group string required generic_work_title"><input class="form-control string required title" name="generic_work[title][]" type="text" value="child1" id="generic_work_title"></div>
+          </div>
+          <div class="file-set-link pull-right">
+            <a title="Edit file" href="/concern/parent/st74cq794/generic_works/sb397864f">
+              <span class="glyphicon glyphicon-edit" aria-hidden="true"></span>
+</a>          </div>
+            <div class="order-filename">
+              <em title="child1">(child1)</em>
+            </div>
+        </div>
+        <div class="panel-body">
+          <div class="text-center thumbnail">
+            <a data-context-href="/catalog/sb397864f/track" href="/concern/generic_works/sb397864f"><img class="thumbnail-inner" src="/assets/default-c6018ff301250c55bcc663293e1816c7daece4159cbc93fc03d9b35dbc3db30d.png" alt="Default"></a>
+
+          </div>
+          <div class="attributes">
+            
+          </div>
+          <div class="spacer">
+          </div>
+        </div>
+</form>            <div class="form-group radio_buttons member_resource_options">
+        <span class="radio">
+          <input type="radio" name="thumbnail_id" id="thumbnail_id_sb397864f" value="sb397864f" class="radio_buttons">
+          <label for="thumbnail_id_sb397864f">Thumbnail</label>
+        </span>
+      </div>
+
+    </div>
+</li>
+
+   <li data-reorder-id="bc386j55f">
+    <div class="panel panel-default">
+      <form data-type="json" novalidate="novalidate" class="simple_form edit_generic_work" id="edit_generic_work_bc386j55f" action="/concern/generic_works/bc386j55f" accept-charset="UTF-8" data-remote="true" method="post"><input name="utf8" type="hidden" value="✓"><input type="hidden" name="_method" value="patch">
+        <div class="panel-heading ui-sortable-handle">
+          <div class="order-title">
+            <div class="form-group string required generic_work_title"><input class="form-control string required title" name="generic_work[title][]" type="text" value="child2" id="generic_work_title"></div>
+          </div>
+          <div class="file-set-link pull-right">
+            <a title="Edit file" href="/concern/parent/st74cq794/generic_works/bc386j55f">
+              <span class="glyphicon glyphicon-edit" aria-hidden="true"></span>
+</a>          </div>
+            <div class="order-filename">
+              <em title="child2">(child2)</em>
+            </div>
+        </div>
+        <div class="panel-body">
+          <div class="text-center thumbnail">
+            <a data-context-href="/catalog/bc386j55f/track" href="/concern/generic_works/bc386j55f"><img class="thumbnail-inner" src="/assets/default-c6018ff301250c55bcc663293e1816c7daece4159cbc93fc03d9b35dbc3db30d.png" alt="Default"></a>
+
+          </div>
+          <div class="attributes">
+            
+          </div>
+          <div class="spacer">
+          </div>
+        </div>
+</form>            <div class="form-group radio_buttons member_resource_options">
+        <span class="radio">
+          <input type="radio" name="thumbnail_id" id="thumbnail_id_bc386j55f" value="bc386j55f" class="radio_buttons">
+          <label for="thumbnail_id_bc386j55f">Thumbnail</label>
+        </span>
+      </div>
+
+    </div>
+</li>
+
+</ul>

data/spec/javascripts/save_manager_spec.coffee

@@ -1,10 +1,11 @@
 describe "FileManager Save Button", ->
+  savem = require('curation_concerns/file_manager/save_manager')
   save_manager = null
   handler = null
   deferred_result = null
   beforeEach () ->
     loadFixtures('save_button.html')
-    save_manager = new SaveManager
+    save_manager = new savem
     deferred_result = $.Deferred()
     handler = {
       persist: () =>

data/spec/jobs/characterize_job_spec.rb

@@ -25,7 +25,7 @@ describe CharacterizeJob do
       expect(Hydra::Works::CharacterizationService).to receive(:run).with(file, filename)
       expect(file).to receive(:save!)
       expect(file_set).to receive(:update_index)
-      expect(CreateDerivativesJob).to receive(:perform_later).with(file_set, file.id)
+      expect(CreateDerivativesJob).to receive(:perform_later).with(file_set, file.id, filename)
       described_class.perform_now(file_set, file.id)
     end
   end
@@ -36,4 +36,21 @@ describe CharacterizeJob do
       expect { described_class.perform_now(file_set, file.id) }.to raise_error(LoadError, 'original_file was not found')
     end
   end
+
+  context "when the file set's work is in a collection" do
+    let(:work)       { build(:generic_work) }
+    let(:collection) { build(:collection) }
+    before do
+      allow(file_set).to receive(:parent).and_return(work)
+      allow(work).to receive(:in_collections).and_return([collection])
+      allow(Hydra::Works::CharacterizationService).to receive(:run).with(file, filename)
+      allow(file).to receive(:save!)
+      allow(file_set).to receive(:update_index)
+      allow(CreateDerivativesJob).to receive(:perform_later).with(file_set, file.id, filename)
+    end
+    it "reindexes the collection" do
+      expect(collection).to receive(:update_index)
+      described_class.perform_now(file_set, file.id)
+    end
+  end
 end

data/spec/jobs/ingest_file_job_spec.rb

@@ -20,28 +20,33 @@ describe IngestFileJob do
       Object.send(:remove_const, :FileSetWithExtras)
     end
     it 'uses the provided relationship' do
-      expect(CharacterizeJob).to receive(:perform_later).with(file_set, String)
-      described_class.perform_now(file_set, filename, 'image/png', 'bob', 'remastered')
+      expect(CharacterizeJob).to receive(:perform_later).with(file_set, String, filename)
+      described_class.perform_now(file_set, filename, user, mime_type: 'image/png', relation: 'remastered')
       expect(file_set.reload.remastered.mime_type).to eq 'image/png'
     end
   end
 
   context 'when given a mime_type' do
     it 'uses the provided mime_type' do
-      expect(CharacterizeJob).to receive(:perform_later).with(file_set, String)
-      described_class.perform_now(file_set, filename, 'image/png', 'bob')
+      expect(CharacterizeJob).to receive(:perform_later).with(file_set, String, filename)
+      described_class.perform_now(file_set, filename, user, mime_type: 'image/png')
       expect(file_set.reload.original_file.mime_type).to eq 'image/png'
     end
   end
 
   context 'when not given a mime_type' do
-    it 'does not decorate File when not given mime_type' do
-      # Mocking CC Versioning here as it will be the versioning machinery called by the job.
-      # The parameter versioning: false instructs the machinery in Hydra::Works NOT to do versioning. So it can be handled later on.
-      allow(CurationConcerns::VersioningService).to receive(:create)
-      expect(Hydra::Works::AddFileToFileSet).to receive(:call).with(file_set, instance_of(::File), :original_file, versioning: false).and_call_original
-      expect(CharacterizeJob).to receive(:perform_later).with(file_set, String)
-      described_class.perform_now(file_set, filename, nil, 'bob')
+    before { allow(CurationConcerns::VersioningService).to receive(:create) }
+    it 'passes a decorated instance of the file with a nil mime_type' do
+      # The parameter versioning: false instructs the machinery in Hydra::Works NOT to do versioning
+      # so it can be handled later on.
+      expect(Hydra::Works::AddFileToFileSet).to receive(:call).with(
+        file_set,
+        instance_of(Hydra::Derivatives::IoDecorator),
+        :original_file,
+        versioning: false
+      ).and_call_original
+      expect(CharacterizeJob).to receive(:perform_later).with(file_set, String, filename)
+      described_class.perform_now(file_set, filename, user)
     end
   end
 
@@ -53,8 +58,8 @@ describe IngestFileJob do
 
     before do
       allow(Hydra::Works::CharacterizationService).to receive(:run).with(any_args)
-      described_class.perform_now(file_set, file1, 'image/png', user.user_key)
-      described_class.perform_now(file_set, file2, 'text/plain', user2.user_key)
+      described_class.perform_now(file_set, file1, user.user_key, mime_type: 'image/png')
+      described_class.perform_now(file_set, file2, user2.user_key, mime_type: 'text/plain')
     end
 
     it 'has two versions' do

data/spec/models/admin_set_spec.rb

@@ -12,12 +12,14 @@ RSpec.describe AdminSet, type: :model do
   end
 
   describe "#to_solr" do
-    let(:admin_set) { build(:admin_set, title: ['A good title']) }
+    let(:admin_set) { build(:admin_set, title: ['A good title'],
+                                        creator: ['jcoyne@justincoyne.com']) }
     let(:solr_document) { admin_set.to_solr }
 
-    it "has title information" do
+    it "has title and creator information" do
       expect(solr_document).to include 'title_tesim' => ['A good title'],
-                                       'title_sim' => ['A good title']
+                                       'title_sim' => ['A good title'],
+                                       'creator_ssim' => ['jcoyne@justincoyne.com']
     end
   end
 

data/spec/models/file_set_spec.rb

@@ -27,10 +27,8 @@ describe FileSet do
   end
 
   context 'when it is initialized' do
-    it 'has empty arrays for all the properties' do
-      subject.attributes.each do |_k, v|
-        expect(Array.wrap(v)).to eq([])
-      end
+    it 'has empty arrays for the properties' do
+      expect(subject.title).to eq []
     end
   end
 

data/spec/models/solr_document_spec.rb

@@ -17,15 +17,29 @@ describe SolrDocument do
   end
 
   describe "thumbnail_id" do
-    let(:attributes) { { Solrizer.solr_name('thumbnail_id', :symbol) => ['one'] } }
+    let(:attributes) { { Solrizer.solr_name('hasRelatedImage', :symbol) => ['one'] } }
     subject { document.thumbnail_id }
     it { is_expected.to eq 'one' }
   end
 
   describe "creator" do
-    let(:attributes) { { Solrizer.solr_name('creator') => ['one', 'two'] } }
     subject { document.creator }
-    it { is_expected.to eq ['one', 'two'] }
+
+    context "for a work" do
+      let(:attributes) do
+        { Solrizer.solr_name('creator') => ['one', 'two'],
+          Solrizer.solr_name('has_model', :symbol) => ["GenericWork"] }
+      end
+      it { is_expected.to eq ['one', 'two'] }
+    end
+
+    context "for an admin set" do
+      let(:attributes) do
+        { Solrizer.solr_name('creator', :symbol) => ['foo@example.com'],
+          Solrizer.solr_name('has_model', :symbol) => ["AdminSet"] }
+      end
+      it { is_expected.to eq ['foo@example.com'] }
+    end
   end
 
   describe "contributor" do

data/spec/presenters/curation_concerns/collection_presenter_spec.rb

@@ -17,6 +17,11 @@ describe CurationConcerns::CollectionPresenter do
   # Mock bytes so collection does not have to be saved.
   before { allow(collection).to receive(:bytes).and_return(0) }
 
+  describe '#to_s' do
+    subject { presenter.to_s }
+    it { is_expected.to eq 'A clever title' }
+  end
+
   describe '#title' do
     subject { presenter.title }
     it { is_expected.to eq ['A clever title'] }

data/spec/renderers/curation_concerns/renderers/external_link_attribute_renderer_spec.rb

@@ -0,0 +1,22 @@
+require 'spec_helper'
+
+describe CurationConcerns::Renderers::ExternalLinkAttributeRenderer do
+  let(:field) { :name }
+  let(:renderer) { described_class.new(field, ['http://example.com']) }
+
+  describe "#attribute_to_html" do
+    subject { Nokogiri::HTML(renderer.render) }
+    let(:expected) { Nokogiri::HTML(tr_content) }
+
+    let(:tr_content) {
+      "<tr><th>Name</th>\n" \
+       "<td><ul class='tabular'>" \
+       "<li class=\"attribute name\">"\
+       "<a href=\"http://example.com\">"\
+       "<span class='glyphicon glyphicon-new-window'></span>&nbsp;"\
+       "http://example.com</a></li>\n" \
+       "</ul></td></tr>"
+    }
+    it { expect(subject).to be_equivalent_to(expected) }
+  end
+end

data/spec/search_builders/curation_concerns/admin_set_search_builder_spec.rb

@@ -1,17 +1,20 @@
 require 'spec_helper'
 
 describe CurationConcerns::AdminSetSearchBuilder do
-  let(:processor_chain) { [:filter_models] }
   let(:context) { double('context') }
-  let(:user) { double('user') }
   let(:solr_params) { { fq: [] } }
 
-  subject { described_class.new(context, :read) }
+  let(:builder) { described_class.new(context, :read) }
   describe '#filter_models' do
-    before { subject.filter_models(solr_params) }
+    before { builder.filter_models(solr_params) }
 
     it 'adds AdminSet to query' do
-      expect(solr_params[:fq].first).to include('{!field f=has_model_ssim}AdminSet')
+      expect(solr_params[:fq].first).to include('{!terms f=has_model_ssim}AdminSet')
     end
   end
+
+  describe ".default_processor_chain" do
+    subject { described_class.default_processor_chain }
+    it { is_expected.to include :filter_models }
+  end
 end

data/spec/search_builders/curation_concerns/file_set_search_builder_spec.rb

@@ -12,7 +12,7 @@ describe CurationConcerns::FileSetSearchBuilder do
     before { subject.filter_models(solr_params) }
 
     it 'adds FileSet to query' do
-      expect(solr_params[:fq].first).to include('{!field f=has_model_ssim}FileSet')
+      expect(solr_params[:fq].first).to include('{!terms f=has_model_ssim}FileSet')
     end
   end
 
@@ -23,7 +23,7 @@ describe CurationConcerns::FileSetSearchBuilder do
     end
 
     it 'adds id to query' do
-      expect(solr_params[:fq].first).to include('{!field f=id}12345')
+      expect(solr_params[:fq].first).to include('{!raw f=id}12345')
     end
   end
 end

data/spec/services/curation_concerns/admin_set_service_spec.rb

@@ -1,37 +1,68 @@
 require 'spec_helper'
 
 RSpec.describe CurationConcerns::AdminSetService do
-  describe ".select_options" do
-    let(:controller) { ::CatalogController.new }
+  let(:controller) { ::CatalogController.new }
 
-    let(:context) do
-      double(current_ability: Ability.new(user),
-             repository: controller.repository,
-             blacklight_config: controller.blacklight_config)
-    end
-    let(:service) { described_class.new(context) }
-    let(:user) { create(:user) }
-    let!(:as1) { create(:admin_set, :public, title: ['foo']) }
-    let!(:as2) { create(:admin_set, :public, title: ['bar']) }
-    let!(:as3) { create(:admin_set, edit_users: [user.user_key], title: ['baz']) }
+  let(:context) do
+    double(current_ability: Ability.new(user),
+           repository: controller.repository,
+           blacklight_config: controller.blacklight_config)
+  end
 
+  let(:service) { described_class.new(context) }
+  let(:user) { create(:user) }
+
+  describe "#select_options" do
     context "with default (read) access" do
       subject { service.select_options }
-      it { is_expected.to eq [['foo', as1.id],
-                              ['bar', as2.id],
-                              ['baz', as3.id]] }
-    end
+      let(:solr_doc1) { instance_double(SolrDocument, id: '123', to_s: 'foo') }
+      let(:solr_doc2) { instance_double(SolrDocument, id: '234', to_s: 'bar') }
+      let(:solr_doc3) { instance_double(SolrDocument, id: '345', to_s: 'baz') }
+
+      before do
+        allow(service).to receive(:search_results)
+          .with(:read)
+          .and_return([solr_doc1, solr_doc2, solr_doc3])
+      end
 
-    context "with explicit read access" do
-      subject { service.select_options(:read) }
-      it { is_expected.to eq [['foo', as1.id],
-                              ['bar', as2.id],
-                              ['baz', as3.id]] }
+      it { is_expected.to eq [['foo', '123'],
+                              ['bar', '234'],
+                              ['baz', '345']] }
     end
 
     context "with explicit edit access" do
       subject { service.select_options(:edit) }
-      it { is_expected.to eq [['baz', as3.id]] }
+      let(:solr_doc) { instance_double(SolrDocument, id: '123', to_s: 'baz') }
+
+      before do
+        allow(service).to receive(:search_results).with(:edit).and_return([solr_doc])
+      end
+
+      it { is_expected.to eq [['baz', '123']] }
+    end
+  end
+
+  describe "#search_results" do
+    subject { service.search_results(access) }
+    let!(:as1) { create(:admin_set, :public, title: ['foo']) }
+    let!(:as2) { create(:admin_set, :public, title: ['bar']) }
+    let!(:as3) { create(:admin_set, edit_users: [user.user_key], title: ['baz']) }
+    before do
+      create(:collection, :public) # this should never be returned.
+    end
+
+    context "with read access" do
+      let(:access) { :read }
+      it "returns three admin sets" do
+        expect(subject.map(&:id)).to match_array [as1.id, as2.id, as3.id]
+      end
+    end
+
+    context "with edit access" do
+      let(:access) { :edit }
+      it "returns one admin set" do
+        expect(subject.map(&:id)).to match_array [as3.id]
+      end
     end
   end
 end

data/spec/spec_helper.rb

@@ -34,8 +34,7 @@ if ENV['COVERAGE'] || $in_travis
   SimpleCov.formatters = $in_travis ? Coveralls::SimpleCov::Formatter : SimpleCov::Formatter::HTMLFormatter
   SimpleCov.start('rails') do
     add_filter '/spec'
-    add_filter '/lib/generators/curation_concerns/templates'
-    add_filter '/lib/generators/curation_concerns/install_generator.rb'
+    add_filter '/lib/generators/curation_concerns'
     add_filter '/.internal_test_app'
   end
   SimpleCov.command_name('spec')

data/spec/test_app_templates/Gemfile.extra

@@ -1,5 +1,9 @@
 # placeholder to use for pinning against specific gem commit references
 
+if ENV['RDF_VERSION']
+  gem 'rdf', ENV['RDF_VERSION']
+end
+
 group :development do
   gem 'better_errors'
   gem 'binding_of_caller'

data/spec/views/curation_concerns/base/_attributes.html.erb_spec.rb

@@ -6,10 +6,16 @@ describe 'curation_concerns/base/_attributes.html.erb' do
   let(:subject)     { 'history' }
   let(:description) { ['Lorem ipsum < lorem ipsum. http://my.link.com'] }
 
-  let(:solr_document) { SolrDocument.new(subject_tesim: subject,
-                                         contributor_tesim: contributor,
-                                         creator_tesim: creator,
-                                         description_tesim: description) }
+  let(:solr_document) { SolrDocument.new(attributes) }
+  let(:attributes) do
+    {
+      Solrizer.solr_name('has_model', :symbol) => ["GenericWork"],
+      subject_tesim: subject,
+      contributor_tesim: contributor,
+      creator_tesim: creator,
+      description_tesim: description
+    }
+  end
   let(:ability) { nil }
   let(:presenter) do
     CurationConcerns::WorkShowPresenter.new(solr_document, ability)