curation_concerns 1.4.0 → 1.5.0

data/spec/models/admin_set_spec.rb

@@ -0,0 +1,78 @@
+require 'spec_helper'
+
+RSpec.describe AdminSet, type: :model do
+  let(:gf1) { create(:generic_work, user: user) }
+  let(:gf2) { create(:generic_work, user: user) }
+  let(:gf3) { create(:generic_work, user: user) }
+
+  let(:user) { create(:user) }
+
+  before do
+    subject.title = ['Some title']
+  end
+
+  describe "#to_solr" do
+    let(:admin_set) { build(:admin_set, title: ['A good title']) }
+    let(:solr_document) { admin_set.to_solr }
+
+    it "has title information" do
+      expect(solr_document).to include 'title_tesim' => ['A good title'],
+                                       'title_sim' => ['A good title']
+    end
+  end
+
+  describe "#members" do
+    it "is empty by default" do
+      expect(subject.members).to be_empty
+    end
+
+    context "adding members" do
+      context "using assignment" do
+        subject { described_class.create!(title: ['Some title'], members: [gf1, gf2]) }
+
+        it "has many files" do
+          expect(subject.reload.members).to match_array [gf1, gf2]
+        end
+      end
+
+      context "using append" do
+        before do
+          subject.members = [gf1]
+          subject.save
+        end
+        it "allows new files to be added" do
+          subject.reload
+          subject.members << gf2
+          subject.save
+          expect(subject.reload.members).to match_array [gf1, gf2]
+        end
+      end
+    end
+  end
+
+  it "has a title" do
+    subject.title = ["title"]
+    subject.save
+    expect(subject.reload.title).to eq ["title"]
+  end
+
+  it "has a description" do
+    subject.title = ["title"]
+    subject.description = ["description"]
+    subject.save
+    expect(subject.reload.description).to eq ["description"]
+  end
+
+  describe "#destroy" do
+    before do
+      subject.members = [gf1, gf2]
+      subject.save
+      subject.destroy
+    end
+
+    it "does not delete member files when deleted" do
+      expect(GenericWork.exists?(gf1.id)).to be true
+      expect(GenericWork.exists?(gf2.id)).to be true
+    end
+  end
+end

data/spec/models/curation_concerns/file_set/characterization_spec.rb

@@ -16,7 +16,7 @@ describe CurationConcerns::FileSet do
   describe '::characterization_terms' do
     subject { file_set.class.characterization_terms }
     it { is_expected.to contain_exactly(:format_label, :file_size, :height, :width, :filename, :well_formed,
-                                        :page_count, :file_title, :last_modified, :original_checksum, :mime_type) }
+                                        :page_count, :file_title, :last_modified, :original_checksum, :mime_type, :duration, :sample_rate) }
   end
 
   describe 'characterization_proxy' do

data/spec/models/file_set_spec.rb

@@ -68,7 +68,8 @@ describe FileSet do
         { type: 'group', access: 'read', name: 'group2' },
         { type: 'person', access: 'read', name: 'user2' },
         { type: 'person', access: 'read', name: 'user3' },
-        { type: 'person', access: 'edit', name: 'user1' }]
+        { type: 'person', access: 'edit', name: 'user1' }
+      ]
     end
 
     it "has attached content" do
@@ -107,6 +108,8 @@ describe FileSet do
       expect(subject).to respond_to(:well_formed)
       expect(subject).to respond_to(:page_count)
       expect(subject).to respond_to(:file_title)
+      expect(subject).to respond_to(:duration)
+      expect(subject).to respond_to(:sample_rate)
       # :creator is characterization metadata?
       expect(subject).to respond_to(:creator)
     end

data/spec/models/generic_work_spec.rb

@@ -14,6 +14,28 @@ describe GenericWork do
     it { is_expected.to eq 'curation_concerns_generic_work' }
   end
 
+  describe '#state' do
+    let(:work) { described_class.new(state: inactive) }
+    let(:inactive) { ::RDF::URI('http://fedora.info/definitions/1/0/access/ObjState#inactive') }
+    subject { work.state.rdf_subject }
+    it { is_expected.to eq inactive }
+  end
+
+  describe '#suppressed?' do
+    let(:work) { described_class.new(state: state) }
+    subject { work.suppressed? }
+
+    context "when the state is 'pending'" do
+      let(:state) { 'pending' }
+      it { is_expected.to be true }
+    end
+
+    context "when the state is something else" do
+      let(:state) { ::RDF::URI('http://fedora.info/definitions/1/0/access/ObjState#active') }
+      it { is_expected.to be false }
+    end
+  end
+
   describe '.valid_child_concerns' do
     it "is all registered curation concerns by default" do
       expect(described_class.valid_child_concerns).to eq [described_class]
@@ -41,7 +63,8 @@ describe GenericWork do
   end
 
   describe 'to_solr' do
-    subject { build(:work, date_uploaded: Date.today).to_solr }
+    let(:work) { build(:work, date_uploaded: Date.today) }
+    subject { work.to_solr }
 
     it 'indexes some fields' do
       expect(subject.keys).to include 'date_uploaded_dtsi'

data/spec/models/solr_document_spec.rb

@@ -16,6 +16,12 @@ describe SolrDocument do
     it { is_expected.to eq 'one' }
   end
 
+  describe "thumbnail_id" do
+    let(:attributes) { { Solrizer.solr_name('thumbnail_id', :symbol) => ['one'] } }
+    subject { document.thumbnail_id }
+    it { is_expected.to eq 'one' }
+  end
+
   describe "creator" do
     let(:attributes) { { Solrizer.solr_name('creator') => ['one', 'two'] } }
     subject { document.creator }
@@ -64,4 +70,28 @@ describe SolrDocument do
       it { is_expected.to eq 'restricted' }
     end
   end
+
+  describe "#page_count" do
+    let(:attributes) { { page_count_tesim: ['1'] } }
+    subject { document.page_count }
+    it { is_expected.to eq ['1'] }
+  end
+
+  describe "#file_title" do
+    let(:attributes) { { file_title_tesim: ['title'] } }
+    subject { document.file_title }
+    it { is_expected.to eq ['title'] }
+  end
+
+  describe "#duration" do
+    let(:attributes) { { duration_tesim: ['time'] } }
+    subject { document.duration }
+    it { is_expected.to eq ['time'] }
+  end
+
+  describe "#sample_rate" do
+    let(:attributes) { { sample_rate_tesim: ['rate'] } }
+    subject { document.sample_rate }
+    it { is_expected.to eq ['rate'] }
+  end
 end

data/spec/presenters/curation_concerns/file_set_presenter_spec.rb

@@ -1,11 +1,12 @@
 require 'spec_helper'
 
 describe CurationConcerns::FileSetPresenter do
-  let(:solr_document) { SolrDocument.new("title_tesim" => ["foo bar"],
-                                         "human_readable_type_tesim" => ["File Set"],
-                                         "mime_type_ssi" => 'image/jpeg',
-                                         'label_tesim' => ['one', 'two'],
-                                         "has_model_ssim" => ["FileSet"]) }
+  let(:attributes) { { "title_tesim" => ["foo bar"],
+                       "human_readable_type_tesim" => ["File Set"],
+                       "mime_type_ssi" => 'image/jpeg',
+                       'label_tesim' => ['one', 'two'],
+                       "has_model_ssim" => ["FileSet"] } }
+  let(:solr_document) { SolrDocument.new(attributes) }
   let(:ability) { double }
   let(:presenter) { described_class.new(solr_document, ability) }
 
@@ -48,7 +49,10 @@ describe CurationConcerns::FileSetPresenter do
     let(:solr_properties) do
       ["date_uploaded", "depositor", "keyword", "title_or_label",
        "contributor", "creator", "title", "description", "publisher",
-       "subject", "language", "rights"]
+       "subject", "language", "rights", "format_label", "file_size",
+       "height", "width", "filename", "well_formed", "page_count",
+       "file_title", "last_modified", "original_checksum", "mime_type",
+       "duration", "sample_rate"]
     end
     it "delegates to the solr_document" do
       solr_properties.each do |property|
@@ -84,4 +88,125 @@ describe CurationConcerns::FileSetPresenter do
     subject { presenter.single_use_links }
     it { is_expected.to include(CurationConcerns::SingleUseLinkPresenter) }
   end
+
+  describe "characterization" do
+    describe "#characterization_metadata" do
+      subject { presenter.characterization_metadata }
+      it { is_expected.to be_kind_of(Hash) }
+
+      it "only has set attributes are in the metadata" do
+        expect(subject[:height]).to be_blank
+        expect(subject[:page_count]).to be_blank
+      end
+
+      context "when height is set" do
+        let(:attributes) { { height_is: '444' } }
+        it "only has set attributes are in the metadata" do
+          expect(subject[:height]).not_to be_blank
+          expect(subject[:page_count]).to be_blank
+        end
+      end
+    end
+
+    describe "#characterized?" do
+      subject { presenter }
+      context "when attributes are not set" do
+        let(:attributes) { {} }
+        it { is_expected.not_to be_characterized }
+      end
+
+      context "when height is set" do
+        let(:attributes) { { height_is: '444' } }
+        it { is_expected.to be_characterized }
+      end
+
+      context "when file_format is set" do
+        let(:attributes) { { file_format_tesim: ['format'] } }
+        it { is_expected.to be_characterized }
+      end
+    end
+
+    describe "#label_for_term" do
+      subject { presenter.label_for_term(:titleized_key) }
+      it { is_expected.to eq("Titleized Key") }
+    end
+
+    describe "with additional characterization metadata" do
+      let(:additional_metadata) do
+        {
+          foo: ["bar"],
+          fud: ["bars", "cars"]
+        }
+      end
+
+      before { allow(presenter).to receive(:additional_characterization_metadata).and_return(additional_metadata) }
+      subject { presenter }
+
+      specify do
+        expect(subject).to be_characterized
+        expect(subject.characterization_metadata[:foo]).to contain_exactly("bar")
+        expect(subject.characterization_metadata[:fud]).to contain_exactly("bars", "cars")
+      end
+    end
+
+    describe "characterization values" do
+      before { allow(presenter).to receive(:characterization_metadata).and_return(mock_metadata) }
+
+      context "with a limited set of short values" do
+        let(:mock_metadata) { { term: ["asdf", "qwer"] } }
+        describe "#primary_characterization_values" do
+          subject { presenter.primary_characterization_values(:term) }
+          it { is_expected.to contain_exactly("asdf", "qwer") }
+        end
+        describe "#secondary_characterization_values" do
+          subject { presenter.secondary_characterization_values(:term) }
+          it { is_expected.to be_empty }
+        end
+      end
+
+      context "with a value set exceeding the configured amount" do
+        let(:mock_metadata) { { term: ["1", "2", "3", "4", "5", "6", "7", "8"] } }
+        describe "#primary_characterization_values" do
+          subject { presenter.primary_characterization_values(:term) }
+          it { is_expected.to contain_exactly("1", "2", "3", "4", "5") }
+        end
+        describe "#secondary_characterization_values" do
+          subject { presenter.secondary_characterization_values(:term) }
+          it { is_expected.to contain_exactly("6", "7", "8") }
+        end
+      end
+
+      context "with values exceeding 250 characters" do
+        let(:mock_metadata) { { term: [("a" * 251), "2", "3", "4", "5", "6", ("b" * 251)] } }
+        describe "#primary_characterization_values" do
+          subject { presenter.primary_characterization_values(:term) }
+          it { is_expected.to contain_exactly(("a" * 247) + "...", "2", "3", "4", "5") }
+        end
+        describe "#secondary_characterization_values" do
+          subject { presenter.secondary_characterization_values(:term) }
+          it { is_expected.to contain_exactly("6", (("b" * 247) + "...")) }
+        end
+      end
+
+      context "with a string as a value" do
+        let(:mock_metadata) { { term: "string" } }
+        describe "#primary_characterization_values" do
+          subject { presenter.primary_characterization_values(:term) }
+          it { is_expected.to contain_exactly("string") }
+        end
+        describe "#secondary_characterization_values" do
+          subject { presenter.secondary_characterization_values(:term) }
+          it { is_expected.to be_empty }
+        end
+      end
+
+      context "with an integer as a value" do
+        let(:mock_metadata) { { term: 1440 } }
+        describe "#primary_characterization_values" do
+          subject { presenter.primary_characterization_values(:term) }
+          it { is_expected.to contain_exactly("1440") }
+        end
+      end
+    end
+  end
 end

data/spec/renderers/curation_concerns/renderers/attribute_renderer_spec.rb

@@ -19,7 +19,7 @@ describe CurationConcerns::Renderers::AttributeRenderer do
 
     context 'without microdata enabled' do
       before do
-        CurationConcerns.config.display_microdata = false
+        allow(CurationConcerns.config).to receive(:display_microdata).and_return(false)
       end
       let(:tr_content) {
         "<tr><th>Name</th>\n" \
@@ -44,9 +44,6 @@ describe CurationConcerns::Renderers::AttributeRenderer do
     end
 
     context 'with microdata enabled' do
-      before do
-        CurationConcerns.config.display_microdata = true
-      end
       let(:tr_content) {
         "<tr><th>Name</th>\n" \
          "<td><ul class='tabular'><li class=\"attribute name\" itemscope itemtype=\"http://schema.org/Person\" itemprop=\"name\">" \

data/spec/search_builders/curation_concerns/admin_set_search_builder_spec.rb

@@ -0,0 +1,17 @@
+require 'spec_helper'
+
+describe CurationConcerns::AdminSetSearchBuilder do
+  let(:processor_chain) { [:filter_models] }
+  let(:context) { double('context') }
+  let(:user) { double('user') }
+  let(:solr_params) { { fq: [] } }
+
+  subject { described_class.new(context, :read) }
+  describe '#filter_models' do
+    before { subject.filter_models(solr_params) }
+
+    it 'adds AdminSet to query' do
+      expect(solr_params[:fq].first).to include('{!field f=has_model_ssim}AdminSet')
+    end
+  end
+end

data/spec/services/curation_concerns/admin_set_service_spec.rb

@@ -0,0 +1,37 @@
+require 'spec_helper'
+
+RSpec.describe CurationConcerns::AdminSetService do
+  describe ".select_options" do
+    let(:controller) { ::CatalogController.new }
+
+    let(:context) do
+      double(current_ability: Ability.new(user),
+             repository: controller.repository,
+             blacklight_config: controller.blacklight_config)
+    end
+    let(:service) { described_class.new(context) }
+    let(:user) { create(:user) }
+    let!(:as1) { create(:admin_set, :public, title: ['foo']) }
+    let!(:as2) { create(:admin_set, :public, title: ['bar']) }
+    let!(:as3) { create(:admin_set, edit_users: [user.user_key], title: ['baz']) }
+
+    context "with default (read) access" do
+      subject { service.select_options }
+      it { is_expected.to eq [['foo', as1.id],
+                              ['bar', as2.id],
+                              ['baz', as3.id]] }
+    end
+
+    context "with explicit read access" do
+      subject { service.select_options(:read) }
+      it { is_expected.to eq [['foo', as1.id],
+                              ['bar', as2.id],
+                              ['baz', as3.id]] }
+    end
+
+    context "with explicit edit access" do
+      subject { service.select_options(:edit) }
+      it { is_expected.to eq [['baz', as3.id]] }
+    end
+  end
+end

data/spec/services/curation_concerns/license_service_spec.rb

@@ -0,0 +1,36 @@
+require 'spec_helper'
+
+describe CurationConcerns::LicenseService do
+  before do
+    # Configure QA to use fixtures
+    qa_fixtures = { local_path: File.expand_path('spec/fixtures/authorities') }
+    allow(Qa::Authorities::Local).to receive(:config).and_return(qa_fixtures)
+  end
+  let(:service) { described_class.new }
+
+  describe "#select_active_options" do
+    it "returns active terms" do
+      expect(service.select_active_options).to include(["First Active Term", "demo_id_01"], ["Second Active Term", "demo_id_02"])
+    end
+
+    it "does not return inactive terms" do
+      expect(service.select_active_options).not_to include(["Third is an Inactive Term", "demo_id_03"], ["Fourth is an Inactive Term", "demo_id_04"])
+    end
+  end
+
+  describe "#select_all_options" do
+    it "returns both active and inactive terms" do
+      expect(service.select_all_options).to include(["Fourth is an Inactive Term", "demo_id_04"], ["First Active Term", "demo_id_01"])
+    end
+  end
+
+  describe "#label" do
+    it "resolves for ids of active terms" do
+      expect(service.label('demo_id_01')).to eq("First Active Term")
+    end
+
+    it "resolves for ids of inactive terms" do
+      expect(service.label('demo_id_03')).to eq("Third is an Inactive Term")
+    end
+  end
+end