curation_concerns 0.5.0 → 0.6.0

data/app/search_builders/curation_concerns/single_use_link_search_builder.rb

@@ -0,0 +1,6 @@
+module CurationConcerns
+  class SingleUseLinkSearchBuilder < CurationConcerns::SearchBuilder
+    include CurationConcerns::SingleResult
+    self.default_processor_chain = [:find_one]
+  end
+end

data/app/search_builders/curation_concerns/work_search_builder.rb

@@ -0,0 +1,5 @@
+module CurationConcerns
+  class WorkSearchBuilder < CurationConcerns::SearchBuilder
+    include CurationConcerns::SingleResult
+  end
+end

data/app/services/curation_concerns/parent_service.rb

@@ -10,7 +10,7 @@ module CurationConcerns
     def self.ordered_by_ids(id)
       if id.present?
         ActiveFedora::SolrService.query("{!join from=proxy_in_ssi to=id}ordered_targets_ssim:#{id}")
-          .map { |x| x["id"] }
+                                 .map { |x| x["id"] }
       else
         []
       end

data/app/views/catalog/index.json.jbuilder

@@ -0,0 +1,9 @@
+# Overriding Blacklight so that the search results can be displayed in a way compatible with
+# tokenInput javascript library.  This is used for suggesting "Related Works" to attach.
+
+json.docs @presenter.documents do |solr_document|
+  title = solr_document['title_tesim'].first
+  title << " (#{solr_document['human_readable_type_tesim'].first})" if solr_document['human_readable_type_tesim'].present?
+  json.pid solr_document['id']
+  json.title title
+end

data/app/views/collections/_form.html.erb

@@ -14,10 +14,10 @@
   <div class="row">
     <div class="col-md-12 form-actions">
       <%= f.submit class: 'btn btn-primary require-contributor-agreement' %>
-      <% if action_name == 'new' %>
-        <%= link_to 'Cancel', main_app.root_path, class: 'btn btn-link' %>
-      <% else %>
+      <% if @form.persisted? %>
         <%= link_to 'Cancel', collections.collection_path(@form), class: 'btn btn-link' %>
+      <% else %>
+        <%= link_to 'Cancel', main_app.root_path, class: 'btn btn-link' %>
       <% end %>
     </div>
   </div>

data/app/views/collections/_search_collection_dashboard_form.html.erb

@@ -4,7 +4,7 @@
       <label class="accessible-hidden">Search Collection <%= @collection.title %></label>
       <%= text_field_tag :cq, params[:cq], class: "collection-query", placeholder: "Search Collection", size: '30', type: "search", id: "collection_search" %>
       <%= hidden_field_tag :sort, params[:sort], id: 'collection_sort' %>
-      <%= render_hash_as_hidden_fields(params_for_search.except(:cq, :sort, :qt, :page)) %>
+      <%= render_hash_as_hidden_fields(search_state.params_for_search.except(:cq, :sort, :qt, :page)) %>
       <button type="submit" class="btn btn-primary" id="collection_submit"><i class="icon-search"></i> Go</button>
   <% end %>
 </div>

data/app/views/collections/_search_form.html.erb

@@ -4,7 +4,7 @@
       <label class="accessible-hidden">Search Collection <%= @presenter.title %></label>
       <%= text_field_tag :cq, params[:cq], class: "collection-query", placeholder: "Search Collection", size: '30', type: "search", id: "collection_search" %>
       <%= hidden_field_tag :sort, params[:sort], id: 'collection_sort' %>
-      <%= render_hash_as_hidden_fields(params_for_search.except(:cq, :sort, :qt, :page)).html_safe %>
+      <%= render_hash_as_hidden_fields(search_state.params_for_search.except(:cq, :sort, :qt, :page)) %>
       <button type="submit" class="btn btn-primary" id="collection_submit"><i class="icon-search"></i> Go</button>
   <% end %>
 </div>

data/app/views/collections/_sort_and_per_page.html.erb

@@ -21,7 +21,7 @@
         <%= label_tag :per_page do %>
           Show <%= select_tag :per_page, options_for_select(['10', '20', '50', '100'], h(params[:per_page])), title: "Number of results to display per page" %> per page
         <% end %>
-        <%= render_hash_as_hidden_fields params_for_search.except(:per_page, :sort) %>
+        <%= render_hash_as_hidden_fields search_state.params_for_search.except(:per_page, :sort) %>
         &nbsp;&nbsp;&nbsp;
         <button class="btn btn-primary"><i class="icon-refresh"></i> Refresh</button>
         <%= render 'view_type_group' %>

data/app/views/shared/_site_search.html.erb

@@ -1,8 +1,8 @@
-<%= form_tag main_app.catalog_index_path, method: :get, class: "search-form" do %>
+<%= form_tag main_app.search_catalog_path, method: :get, class: "search-form" do %>
   <fieldset>
     <legend class="accessible-hidden">Search <%= t('curation_concerns.product_name') %></legend>
     <%= label_tag :catalog_search, t('curation_concerns.search.form.q.label'), class: "accessible-hidden" %>
-    <%= render_hash_as_hidden_fields(params_for_search.except(:q, :search_field, :qt, :page, :utf8)) %>
+    <%= render_hash_as_hidden_fields(search_state.params_for_search.except(:q, :search_field, :qt, :page, :utf8)) %>
     <%= text_field_tag(:q, params[:q], class: "q search-query", id: "catalog_search",
                        placeholder: t('curation_concerns.search.form.q.placeholder'), tabindex: "1", type: "search") %>
                       <button type="submit" class="search-submit btn btn-primary" id="keyword-search-submit" tabindex="2">

data/curation_concerns.gemspec

@@ -1,9 +1,6 @@
 # coding: utf-8
 version = File.read(File.expand_path("../VERSION",__FILE__)).strip
 
-# lib = File.expand_path('../lib', __FILE__)
-# $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
-
 Gem::Specification.new do |spec|
   spec.name          = "curation_concerns"
   spec.version       = version
@@ -19,13 +16,14 @@ Gem::Specification.new do |spec|
   spec.test_files    = spec.files.grep(%r{^(test|spec|features)/})
   spec.require_paths = ["lib"]
 
-  spec.add_dependency 'hydra-head', '~> 9.0'
+  spec.add_dependency 'hydra-head', '~> 9.6'
+  spec.add_dependency 'blacklight', '~> 6.0'
   spec.add_dependency "breadcrumbs_on_rails", "~> 2.3"
   spec.add_dependency "jquery-ui-rails"
   spec.add_dependency "simple_form", '~> 3.1'
   spec.add_dependency 'curation_concerns-models', version
   spec.add_dependency 'hydra-editor', '~> 1.1'
-  spec.add_dependency 'blacklight_advanced_search', ['>= 5.1.4', '< 6.0']
+  spec.add_dependency 'blacklight_advanced_search', '~> 6.0'
   spec.add_dependency 'rails_autolink'
 
   spec.add_development_dependency "devise", "~> 3.0"

data/lib/curation_concerns/rails/routes.rb

@@ -60,7 +60,7 @@ module ActionDispatch::Routing
     private
 
       # routing namepace arguments, for using a path other than the default
-      ROUTE_OPTIONS = { 'curation_concerns' => { path: :concern } }
+      ROUTE_OPTIONS = { 'curation_concerns' => { path: :concern } }.freeze
 
       # Namespaces routes appropriately
       # @example route_namespaced_target("curation_concerns/generic_work") is equivalent to

data/lib/curation_concerns/version.rb

@@ -1,3 +1,3 @@
 module CurationConcerns
-  VERSION = "0.5.0"
+  VERSION = "0.6.0".freeze
 end

data/lib/generators/curation_concerns/install_generator.rb

@@ -5,8 +5,7 @@ module CurationConcerns
     source_root File.expand_path('../templates', __FILE__)
 
     argument :model_name, type: :string, default: 'user'
-    desc ''"
-  This generator makes the following changes to your application:
+    desc 'This generator makes the following changes to your application:
    1. Runs installers for blacklight & hydra-head (which also install & configure devise)
    2. Runs curation_concerns:models:install
    3. Adds controller behavior to the application controller
@@ -15,7 +14,7 @@ module CurationConcerns
    6. Copies the catalog controller into the local app
    7. Adds CurationConcerns::SolrDocumentBehavior to app/models/solr_document.rb
    8. Adds config/authorities/rights.yml to the application
-         "''
+         '
 
     def run_required_generators
       say_status('warning', '[CurationConcerns] GENERATING BLACKLIGHT', :yellow)

data/lib/generators/curation_concerns/templates/catalog_controller.rb

@@ -79,7 +79,7 @@ class CatalogController < ApplicationController
       contributor_name = solr_name('contributor', :stored_searchable, type: :string)
       field.solr_parameters = {
         qf: "#{title_name} #{label_name} file_format_tesim #{contributor_name}",
-        pf: "#{title_name}"
+        pf: title_name.to_s
       }
     end
 

data/spec/actors/curation_concerns/work_actor_spec.rb

@@ -225,7 +225,8 @@ describe CurationConcerns::GenericWorkActor do
       before do
         curation_concern.apply_depositor_metadata(user.user_key)
         curation_concern.save!
-        collection1.add_member(curation_concern)
+        collection1.members << curation_concern
+        collection1.save!
       end
 
       it 'remove from the old collection and adds to the new collection' do

data/spec/controllers/catalog_controller_spec.rb

@@ -70,6 +70,7 @@ describe CatalogController do
 
     context 'when json is requested for autosuggest of related works' do
       let!(:work) { FactoryGirl.create(:generic_work, user: user, title: ["All my #{srand}"]) }
+      render_views
       it 'returns json' do
         xhr :get, :index, format: :json, q: work.title
         json = JSON.parse(response.body)

data/spec/controllers/curation_concerns/generic_works_controller_spec.rb

@@ -45,9 +45,8 @@ describe CurationConcerns::GenericWorksController do
     context 'when a ObjectNotFoundError is raised' do
       it 'returns 404 page' do
         allow(controller).to receive(:show).and_raise(ActiveFedora::ObjectNotFoundError)
+        expect(controller).to receive(:render_404) { controller.render nothing: true }
         get :show, id: 'abc123'
-        expect(response.status).to eq 404
-        expect(response.body).to match(/The page you were looking for doesn't exist/)
       end
     end
   end
@@ -186,7 +185,7 @@ describe CurationConcerns::GenericWorksController do
 
     it 'deletes the work' do
       delete :destroy, id: work_to_be_deleted
-      expect(response).to redirect_to main_app.catalog_index_path
+      expect(response).to redirect_to main_app.search_catalog_path
       expect(GenericWork).not_to exist(work_to_be_deleted.id)
     end
 

data/spec/controllers/downloads_controller_spec.rb

@@ -6,9 +6,9 @@ describe DownloadsController do
     let(:file_set) do
       FactoryGirl.create(:file_with_work, user: user, content: File.open(fixture_file_path('files/image.png')))
     end
-    it 'raise not_found if the object does not exist' do
+    it 'calls render_404 if the object does not exist' do
+      expect(controller).to receive(:render_404) { controller.render nothing: true }
       get :show, id: '8675309'
-      expect(response).to be_not_found
     end
 
     context "when user doesn't have access" do
@@ -61,15 +61,15 @@ describe DownloadsController do
 
         context "that isn't persisted" do
           it "returns 404 if the requested file does not exist" do
+            expect(controller).to receive(:render_404) { controller.render nothing: true }
             get :show, id: file_set, file: 'thumbnail'
-            expect(response.status).to eq 404
           end
         end
       end
 
       it "returns 404 if the requested association does not exist" do
+        expect(controller).to receive(:render_404) { controller.render nothing: true }
         get :show, id: file_set, file: 'non-existant'
-        expect(response.status).to eq 404
       end
     end
   end

data/spec/features/catalog_search_spec.rb

@@ -5,7 +5,7 @@ feature 'Catalog index page' do
   let!(:coll) { create(:collection, :public, title: 'My Collection') }
 
   scenario 'Browse the catalog using filter tabs' do
-    visit catalog_index_path
+    visit search_catalog_path
 
     # Filter on Works
     within '#type-tabs' do

data/spec/features/collection_spec.rb

@@ -56,6 +56,11 @@ describe 'collection' do
       expect(page).to have_content title
       expect(page).to have_content description
     end
+    it "fails if there's missing required fields" do
+      click_link 'Add a Collection'
+      click_button 'Create Collection'
+      expect(page).to have_content 'Please review the errors below'
+    end
   end
 
   describe 'delete collection' do
@@ -65,7 +70,7 @@ describe 'collection' do
       @collection.apply_depositor_metadata(user_key)
       @collection.save
       sign_in user
-      visit main_app.catalog_index_path('f[generic_type_sim][]' => 'Collection', works: 'mine')
+      visit main_app.search_catalog_path('f[generic_type_sim][]' => 'Collection', works: 'mine')
     end
 
     it 'deletes a collection' do
@@ -160,6 +165,17 @@ describe 'collection' do
       expect(page).to have_content(creators.first)
     end
 
+    context "when there are errors" do
+      it "displays them" do
+        within("#document_#{@collection.id}") do
+          click_link('Edit Collection')
+        end
+        fill_in 'Title', with: ''
+        click_button 'Update Collection'
+        expect(page).to have_content 'review the errors'
+      end
+    end
+
     it 'removes a work from a collection from edit page' do
       expect(page).to have_content(@collection.title)
       within("#document_#{@collection.id}") do

data/spec/helpers/catalog_helper_spec.rb

@@ -5,11 +5,15 @@ describe CurationConcerns::CatalogHelper do
     helper.params[:controller] = 'catalog'
     allow(helper).to receive(:blacklight_config).and_return(CatalogController.blacklight_config)
     allow(helper).to receive(:search_action_path) do |*args|
-      catalog_index_path(*args)
+      search_catalog_path(*args)
     end
   end
 
   describe 'all_type_tab' do
+    let(:search_state) { double('SearchState', remove_facet_params: {}) }
+    before do
+      allow(helper).to receive(:search_state).and_return(search_state)
+    end
     subject { helper.all_type_tab('All') }
 
     context 'when it is the active tab' do
@@ -43,6 +47,11 @@ describe CurationConcerns::CatalogHelper do
     end
 
     context 'when it is not the active tab' do
+      let(:search_state) { double('SearchState',
+                                  add_facet_params_and_redirect: { f: { generic_type_sim: ['Work'] } }) }
+      before do
+        allow(helper).to receive(:search_state).and_return(search_state)
+      end
       it { should eq "<li><a href=\"/catalog?f%5Bgeneric_type_sim%5D%5B%5D=Work\">Works</a></li>" }
     end
 

data/spec/helpers/render_constraints_helper_spec.rb

@@ -13,7 +13,7 @@ describe CurationConcernsHelper do
 
     it 'removes search_field' do
       node = Capybara::Node::Simple.new(subject)
-      expect(node).to have_link 'Remove constraint Foo: Simon', href: catalog_index_path
+      expect(node).to have_link 'Remove constraint Foo: Simon', href: search_catalog_path
     end
   end
 end

data/spec/helpers/url_helper_spec.rb

@@ -9,7 +9,7 @@ describe CurationConcerns::UrlHelper do
   it { is_expected.to eq "/concern/generic_works/#{work.id}" }
 
   it 'uses the curation_concern namespace' do
-    expect(helper.url_for_document document).to eq "/concern/generic_works/#{work.id}"
+    expect(helper.url_for_document(document)).to eq "/concern/generic_works/#{work.id}"
   end
 
   context 'when document is a FileSet' do

data/spec/models/curation_concerns/collection_behavior_spec.rb

@@ -63,48 +63,6 @@ describe CurationConcerns::CollectionBehavior do
     end
   end
 
-  context '.add_member' do
-    let(:collectible?) { nil }
-    let(:proposed_collectible) { double(collections: []) }
-    before(:each) do
-      allow(proposed_collectible).to receive(:can_be_member_of_collection?).with(subject).and_return(collectible?)
-      # Added for solrizing interface.
-      allow(proposed_collectible).to receive(:pcdm_object?).and_return(true)
-      allow(proposed_collectible).to receive(:collection?).and_return(false)
-      allow(proposed_collectible).to receive(:id).and_return("1")
-      allow(proposed_collectible).to receive(:save).and_return(true)
-    end
-
-    context 'with itself' do
-      it 'does not add it to the collection members' do
-        expect do
-          subject.add_member(subject)
-        end.to_not change { subject.members.size }
-      end
-    end
-
-    context 'with a non-collectible object' do
-      let(:collectible?) { false }
-      it 'does not add it to the collection\'s members' do
-        expect do
-          subject.add_member(proposed_collectible)
-        end.to_not change { subject.members.size }
-      end
-    end
-
-    context 'with a collectible object' do
-      let(:collectible?) { true }
-      before do
-        allow(collection).to receive(:members).and_return([])
-      end
-      it 'adds it to the collection\'s members' do
-        expect do
-          subject.add_member(proposed_collectible)
-        end.to change { subject.members.size }.by(1)
-      end
-    end
-  end
-
   describe 'intrinsic properties' do
     let(:collection1) { FactoryGirl.build(:collection) }
     let(:work1) { FactoryGirl.build(:work) }

data/spec/models/curation_concerns/file_set/derivatives_spec.rb

@@ -81,4 +81,18 @@ describe CurationConcerns::FileSet do
       end
     end
   end
+
+  describe "cleanup" do
+    let(:mime_type) { 'image/jpg' }
+    it "cleans up all created derivatives" do
+      allow(CurationConcerns::DerivativePath).to receive(:derivatives_for_reference).with(file_set).and_return([
+                                                                                                                 "tmp/1/2.jpg"
+                                                                                                               ])
+      allow(FileUtils).to receive(:rm_f).with("tmp/1/2.jpg")
+
+      file_set.destroy
+
+      expect(FileUtils).to have_received(:rm_f).with("tmp/1/2.jpg")
+    end
+  end
 end

data/spec/search_builders/curation_concerns/file_set_search_builder_spec.rb

@@ -0,0 +1,29 @@
+require 'spec_helper'
+
+describe CurationConcerns::FileSetSearchBuilder do
+  let(:processor_chain) { [:filter_models] }
+  let(:ability) { double('ability') }
+  let(:context) { double('context') }
+  let(:user) { double('user') }
+  let(:solr_params) { { fq: [] } }
+
+  subject { described_class.new(context) }
+  describe '#only_file_sets' do
+    before { subject.only_file_sets(solr_params) }
+
+    it 'adds FileSet to query' do
+      expect(solr_params[:fq].first).to include('{!raw f=has_model_ssim}FileSet')
+    end
+  end
+
+  describe '#find_one' do
+    before do
+      allow(subject).to receive(:blacklight_params).and_return(id: '12345')
+      subject.find_one(solr_params)
+    end
+
+    it 'adds id to query' do
+      expect(solr_params[:fq].first).to include('{!raw f=id}12345')
+    end
+  end
+end

data/spec/search_builders/curation_concerns/search_builder_spec.rb

@@ -9,25 +9,6 @@ describe CurationConcerns::SearchBuilder do
 
   subject { described_class.new(processor_chain, context) }
 
-  describe '#only_file_sets' do
-    before { subject.only_file_sets(solr_params) }
-
-    it 'adds FileSet to query' do
-      expect(solr_params[:fq].first).to include('{!raw f=has_model_ssim}FileSet')
-    end
-  end
-
-  describe '#find_one' do
-    before do
-      allow(subject).to receive(:blacklight_params).and_return(id: '12345')
-      subject.find_one(solr_params)
-    end
-
-    it 'adds id to query' do
-      expect(solr_params[:fq].first).to include('{!raw f=id}12345')
-    end
-  end
-
   describe '#gated_discovery_filters' do
     before do
       allow(subject).to receive(:current_ability).and_return(ability)

data/spec/services/derivative_path_spec.rb

@@ -13,4 +13,28 @@ describe CurationConcerns::DerivativePath do
 
     it { is_expected.to eq 'tmp/12/3-thumbnail.jpeg' }
   end
+
+  describe "#derivatives_for_reference" do
+    subject { described_class.derivatives_for_reference(object) }
+    before do
+      FileUtils.mkdir_p("tmp/12")
+      File.open("tmp/12/3-thumbnail.jpeg", 'w') do |f|
+        f.write "test"
+      end
+      File.open("tmp/12/4-thumbnail.jpeg", 'w') do |f|
+        f.write "test"
+      end
+    end
+    after do
+      FileUtils.rm_rf("tmp/12")
+    end
+
+    let(:object) { double(id: '123') }
+
+    it "lists all the paths to derivatives" do
+      expect(subject).to eq [
+        "tmp/12/3-thumbnail.jpeg"
+      ]
+    end
+  end
 end

data/spec/spec_helper.rb

@@ -52,11 +52,11 @@ RSpec.configure do |config|
   config.fixture_path = File.expand_path('../fixtures', __FILE__)
 
   config.before :each do
-    if Capybara.current_driver == :rack_test
-      DatabaseCleaner.strategy = :transaction
-    else
-      DatabaseCleaner.strategy = :truncation
-    end
+    DatabaseCleaner.strategy = if Capybara.current_driver == :rack_test
+                                 :transaction
+                               else
+                                 :truncation
+                               end
     DatabaseCleaner.start
   end
 

data/spec/test_app_templates/Gemfile.extra

@@ -2,6 +2,7 @@
 # gem 'hydra-works', github: 'projecthydra-labs/hydra-works', branch: 'master'
 # gem 'hydra-pcdm', github: 'projecthydra-labs/hydra-pcdm', branch: 'master'
 # gem 'activefedora-aggregation', github: 'projecthydra-labs/activefedora-aggregation', branch: 'master'
+gem 'kaminari', github: 'jcoyne/kaminari', branch: 'sufia'
 
 group :development do
   gem 'better_errors'

data/spec/views/catalog/index.html.erb_spec.rb

@@ -3,15 +3,17 @@ require 'spec_helper'
 describe 'catalog/index.html.erb' do
   let(:collection) { stub_model(Collection, title: 'collection1', id: 'abc123') }
   let(:doc) { SolrDocument.new(collection.to_solr) }
+  let(:search_state) { double('SearchState', to_h: {}) }
+  let(:blacklight_configuration_context) do
+    Blacklight::Configuration::Context.new(controller)
+  end
 
   before do
     view.extend CurationConcerns::CollectionsHelper
     view.extend CurationConcerns::CatalogHelper
-    allow(view).to receive(:search_action_path).and_return('/catalog')
-    allow(view).to receive(:has_search_parameters?).and_return(true)
 
-    allow(view).to receive(:current_users_collections).and_return([])
     allow(view).to receive(:blacklight_config).and_return(CatalogController.blacklight_config)
+    allow(view).to receive(:blacklight_configuration_context).and_return(blacklight_configuration_context)
     stub_template 'catalog/_search_sidebar.html.erb' => ''
     stub_template 'catalog/_search_header.html.erb' => ''
     allow(view).to receive(:render_opensearch_response_metadata).and_return('')
@@ -19,6 +21,8 @@ describe 'catalog/index.html.erb' do
     allow(view).to receive(:search_session).and_return({})
     allow(view).to receive(:current_search_session).and_return(nil)
     allow(view).to receive(:document_counter_with_offset).and_return(5)
+    allow(view).to receive(:type_tab).and_return("TYPE")
+    allow(view).to receive(:search_state).and_return(search_state)
 
     params[:view] = 'gallery'
 
@@ -44,8 +48,10 @@ describe 'catalog/index.html.erb' do
       expect(page).to have_content 'List of files deposited'
     end
   end
+
   context 'when user has all the permissions' do
     before { allow(view).to receive(:can?).and_return(true) }
+
     it 'appears on page without error' do
       render
       page = Capybara::Node::Simple.new(rendered)

data/spec/views/collections/_sort_and_per_page.html.erb_spec.rb

@@ -3,8 +3,10 @@ require 'spec_helper'
 describe 'collections/_sort_and_per_page.html.erb' do
   let(:collection) { double }
   let(:response) { double(response: { 'numFound' => 3 }) }
+  let(:search_state) { double('SearchState', params_for_search: {}) }
 
   before do
+    allow(view).to receive(:search_state).and_return(search_state)
     allow(view).to receive(:sort_fields).and_return(['title_sort', 'date_sort'])
     allow(view).to receive(:document_index_views).and_return(list: Blacklight::Configuration::ViewConfig.new)
     assign(:response, response)

data/spec/views/curation_concerns/base/_attributes.html.erb_spec.rb

@@ -24,9 +24,9 @@ describe 'curation_concerns/base/_attributes.html.erb' do
   end
 
   it 'has links to search for other objects with the same metadata' do
-    expect(rendered).to have_link(creator, href: catalog_index_path(search_field: 'creator', q: creator))
-    expect(rendered).to have_link(contributor, href: catalog_index_path(search_field: 'contributor', q: contributor))
-    expect(rendered).to have_link(subject, href: catalog_index_path(search_field: 'subject', q: subject))
+    expect(rendered).to have_link(creator, href: search_catalog_path(search_field: 'creator', q: creator))
+    expect(rendered).to have_link(contributor, href: search_catalog_path(search_field: 'contributor', q: contributor))
+    expect(rendered).to have_link(subject, href: search_catalog_path(search_field: 'subject', q: subject))
   end
   it 'shows links in the description' do
     a1 = doc.xpath("//li[@class='attribute description']/span/a").text

data/spec/views/curation_concerns/file_sets/_file_set.html.erb_spec.rb

@@ -11,9 +11,13 @@ describe 'curation_concerns/file_sets/_file_set.html.erb' do
   # Ability is checked in FileSetPresenter#link_name
   let(:ability) { double(can?: true) }
   let(:presenter) { CurationConcerns::FileSetPresenter.new(solr_document, ability) }
+  let(:blacklight_configuration_context) do
+    Blacklight::Configuration::Context.new(controller)
+  end
 
   before do
     assign(:presenter, presenter)
+    allow(view).to receive(:blacklight_configuration_context).and_return(blacklight_configuration_context)
     allow(view).to receive(:blacklight_config).and_return(CatalogController.blacklight_config)
     allow(view).to receive(:current_search_session).and_return nil
     allow(view).to receive(:search_session).and_return({})

data/tasks/release.rake

@@ -29,7 +29,7 @@ directory 'pkg'
         major, minor, tiny, pre = version.split('.')
         pre = pre ? pre.inspect : "nil"
 
-        ruby.gsub!(/^(\s*)VERSION = ".*?"$/, "\\1VERSION = \"#{version}\"")
+        ruby.gsub!(/^(\s*)VERSION = ".*?"\.freeze$/, "\\1VERSION = \"#{version}\".freeze")
         raise "Could not insert VERSION in #{file}" unless $1
         File.open(file, 'w') { |f| f.write ruby }
       end