curation_concerns 0.3.0 → 0.4.0

data/spec/controllers/curation_concerns/file_sets_controller_json_spec.rb

@@ -24,6 +24,7 @@ describe CurationConcerns::FileSetsController do
       end
       it { is_expected.to respond_unauthorized }
     end
+
     describe "forbidden" do
       before do
         sign_in create(:user)
@@ -31,14 +32,15 @@ describe CurationConcerns::FileSetsController do
       end
       it { is_expected.to respond_forbidden }
     end
+
     describe 'not found' do
       before { get :show, id: "non-existent-pid", format: :json }
-      it { is_expected.to respond_not_found(description: 'Object non-existent-pid not found in solr') }
+      it { is_expected.to respond_not_found(description: 'Could not find a resource that matches your request.') }
     end
 
     describe 'created' do
       it "returns 201, renders jq_upload json template and sets location header" do
-        expect(controller.send(:actor)).to receive(:create_metadata).with(nil, parent, hash_including(:files, title: ['a title']))
+        expect(controller.send(:actor)).to receive(:create_metadata).with(parent, hash_including(:files, title: ['a title']))
         expect(controller.send(:actor)).to receive(:create_content).with(file).and_return(true)
 
         allow_any_instance_of(FileSet).to receive(:persisted?).and_return(true)
@@ -53,25 +55,31 @@ describe CurationConcerns::FileSetsController do
         expect(response.location).to eq main_app.curation_concerns_file_set_path(created_resource)
       end
     end
+
     describe 'failed create: no file' do
       before { post :create, file_set: { title: ["foo"] }, parent_id: parent.id, format: :json }
       it { is_expected.to respond_bad_request(message: 'Error! No file to save') }
     end
+
     describe 'failed create: bad file' do
       before { post :create, file_set: { files: ['not a file'] }, parent_id: parent.id, format: :json }
       it { is_expected.to respond_bad_request(message: 'Error! No file for upload', description: 'unknown file') }
     end
+
     describe 'failed create: empty file' do
       before { post :create, file_set: { files: [empty_file] }, parent_id: parent.id, format: :json }
       it { is_expected.to respond_unprocessable_entity(errors: { files: "#{empty_file.original_filename} has no content! (Zero length file)" }, description: I18n.t('curation_concerns.api.unprocessable_entity.empty_file')) }
     end
+
     describe 'failed create: solr error' do
       before do
         allow(controller).to receive(:process_file).and_raise(RSolr::Error::Http.new(controller.request, response))
         post :create, file_set: { files: [file] }, parent_id: parent.id, format: :json
       end
-      it { is_expected.to respond_internal_error(message: 'Error occurred while creating generic file.') }
+
+      it { is_expected.to respond_internal_error(message: 'Error occurred while creating a FileSet.') }
     end
+
     describe 'found' do
       before { resource_request }
       it "returns json of the work" do
@@ -80,6 +88,7 @@ describe CurationConcerns::FileSetsController do
         expect(response.code).to eq "200"
       end
     end
+
     describe 'updated' do
       before { put :update, id: resource, file_set: { title: ['updated title'] }, format: :json }
       it "returns json of updated work and sets location header" do
@@ -90,6 +99,7 @@ describe CurationConcerns::FileSetsController do
         expect(response.location).to eq main_app.curation_concerns_file_set_path(created_resource)
       end
     end
+
     describe 'failed update' do
       before {
         expect(controller).to receive(:update_metadata) do
@@ -99,7 +109,7 @@ describe CurationConcerns::FileSetsController do
         post :update, id: resource, file_set: { title: nil, depositor: nil }, format: :json
       }
       it "returns 422 and the errors" do
-        expect(response).to respond_unprocessable_entity(errors: { "some_field": ["This is not valid. Fix it."] })
+        expect(response).to respond_unprocessable_entity(errors: { some_field: ["This is not valid. Fix it."] })
       end
     end
   end

data/spec/controllers/curation_concerns/file_sets_controller_spec.rb

@@ -21,7 +21,7 @@ describe CurationConcerns::FileSetsController do
         end
 
         it 'calls the actor to create metadata and content' do
-          expect(controller.send(:actor)).to receive(:create_metadata).with(nil, parent, files: [file], title: ['test title'], visibility: 'restricted')
+          expect(controller.send(:actor)).to receive(:create_metadata).with(parent, files: [file], title: ['test title'], visibility: 'restricted')
           expect(controller.send(:actor)).to receive(:create_content).with(file).and_return(true)
           xhr :post, :create, parent_id: parent,
                               file_set: { files: [file],
@@ -68,7 +68,7 @@ describe CurationConcerns::FileSetsController do
         it 'errors out of create after on continuous rsolr error' do
           xhr :post, :create, parent_id: parent, file_set: { files: [file] },
                               permission: { group: { 'public' => 'read' } }, terms_of_service: '1'
-          expect(response.body).to include('Error occurred while creating generic file.')
+          expect(response.body).to include('Error occurred while creating a FileSet.')
         end
       end
     end
@@ -121,6 +121,7 @@ describe CurationConcerns::FileSetsController do
             { title: ['new_title'], tag: [''], permissions_attributes: [{ type: 'person', name: 'archivist1', access: 'edit' }] }
           expect(response.status).to eq 422
           expect(response).to render_template('edit')
+          expect(assigns[:groups]).to be_kind_of Array
           expect(assigns[:file_set]).to eq file_set
         end
 
@@ -221,7 +222,6 @@ describe CurationConcerns::FileSetsController do
       end
 
       it 'allows access to public files' do
-        expect(controller).to receive(:additional_response_formats).with(ActionController::MimeResponds::Collector)
         get :show, id: public_file_set
         expect(response).to be_success
       end

data/spec/controllers/curation_concerns/generic_works_controller_json_spec.rb

@@ -36,7 +36,7 @@ describe CurationConcerns::GenericWorksController do
       before { post :create, generic_work: { title: ['a title'] }, format: :json }
       it "returns 201, renders show template sets location header" do
         # Ensure that @curation_concern is set for jbuilder template to use
-        expect(assigns[:curation_concern]).to be_instance_of ::GenericWork
+        expect(assigns[:curation_concern]).to be_instance_of GenericWork
         expect(controller).to render_template('curation_concerns/base/show')
         expect(response.code).to eq "201"
         created_resource = assigns[:curation_concern]
@@ -56,7 +56,7 @@ describe CurationConcerns::GenericWorksController do
       before { resource_request }
       it "returns json of the work" do
         # Ensure that @curation_concern is set for jbuilder template to use
-        expect(assigns[:curation_concern]).to be_instance_of ::GenericWork
+        expect(assigns[:curation_concern]).to be_instance_of GenericWork
         expect(controller).to render_template('curation_concerns/base/show')
         expect(response.code).to eq "200"
       end
@@ -66,7 +66,7 @@ describe CurationConcerns::GenericWorksController do
       before { put :update, id: resource, generic_work: { title: ['updated title'] }, format: :json }
       it "returns 200, renders show template sets location header" do
         # Ensure that @curation_concern is set for jbuilder template to use
-        expect(assigns[:curation_concern]).to be_instance_of ::GenericWork
+        expect(assigns[:curation_concern]).to be_instance_of GenericWork
         expect(controller).to render_template('curation_concerns/base/show')
         expect(response.code).to eq "200"
         created_resource = assigns[:curation_concern]
@@ -78,7 +78,7 @@ describe CurationConcerns::GenericWorksController do
       before { post :update, id: resource, generic_work: { title: [] }, format: :json }
 
       it "returns 422 and the errors" do
-        expect(response).to respond_unprocessable_entity(errors: { "title": ["Your work must have a title."] })
+        expect(response).to respond_unprocessable_entity(errors: { title: ["Your work must have a title."] })
       end
     end
   end

data/spec/controllers/curation_concerns/generic_works_controller_spec.rb

@@ -27,6 +27,7 @@ describe CurationConcerns::GenericWorksController do
     context 'someone elses public work' do
       let(:a_work) { create(:public_generic_work) }
       it 'shows me the page' do
+        expect(controller). to receive(:additional_response_formats).with(ActionController::MimeResponds::Collector)
         get :show, id: a_work
         expect(response).to be_success
       end
@@ -40,12 +41,22 @@ describe CurationConcerns::GenericWorksController do
         expect(response).to be_success
       end
     end
+
+    context 'when a ObjectNotFoundError is raised' do
+      it 'returns 404 page' do
+        allow(controller).to receive(:show).and_raise(ActiveFedora::ObjectNotFoundError)
+        get :show, id: 'abc123'
+        expect(response.status).to eq 404
+        expect(response.body).to match(/The page you were looking for doesn't exist/)
+      end
+    end
   end
 
   describe '#new' do
     context 'my work' do
       it 'shows me the page' do
         get :new
+        expect(assigns[:form]).to be_kind_of CurationConcerns::GenericWorkForm
         expect(response).to be_success
       end
     end
@@ -58,6 +69,16 @@ describe CurationConcerns::GenericWorksController do
       end.to change { GenericWork.count }.by(1)
       expect(response).to redirect_to main_app.curation_concerns_generic_work_path(assigns[:curation_concern])
     end
+
+    context 'when not authorized' do
+      before { allow(controller.current_ability).to receive(:can?).and_return(false) }
+
+      it 'shows the unauthorized message' do
+        post :create, generic_work: { title: ['a title'] }
+        expect(response.code).to eq '401'
+        expect(response).to render_template(:unauthorized)
+      end
+    end
   end
 
   describe '#edit' do

data/spec/controllers/curation_concerns/single_use_links_controller_spec.rb

@@ -2,7 +2,7 @@ require 'spec_helper'
 
 describe CurationConcerns::SingleUseLinksController, type: :controller do
   routes { CurationConcerns::Engine.routes }
-  let(:user) { FactoryGirl.find_or_create(:jill) }
+  let(:user) { create(:user) }
 
   let(:file) do
     FileSet.create do |file|
@@ -38,7 +38,7 @@ describe CurationConcerns::SingleUseLinksController, type: :controller do
 
   describe "logged in user without edit permission" do
     before do
-      @other_user = FactoryGirl.find_or_create(:archivist)
+      @other_user = create(:user)
       file.read_users << @other_user
       file.save
       sign_in @other_user

data/spec/controllers/curation_concerns/single_use_links_viewer_controller_spec.rb

@@ -32,7 +32,7 @@ describe CurationConcerns::SingleUseLinksViewerController do
       let(:expected_content) { ActiveFedora::Base.find(file.id).original_file.content }
 
       it "and_return http success" do
-        expect(controller).to receive(:send_file_headers!).with(filename: 'world.png', disposition: 'inline', type: 'image/png')
+        expect(controller).to receive(:send_file_headers!).with(filename: 'world.png', disposition: 'attachment', type: 'image/png')
         get :download, id: download_link_hash
         expect(response.body).to eq expected_content
         expect(response).to be_success

data/spec/controllers/upload_sets_controller_spec.rb

@@ -1,8 +1,8 @@
 require 'spec_helper'
 
 describe UploadSetsController do
-  let(:user) { FactoryGirl.find_or_create(:jill) }
-  let(:other_user) { FactoryGirl.find_or_create(:curator) }
+  let(:user) { create(:user) }
+  let(:other_user) { create(:user) }
   before do
     sign_in user
     allow_any_instance_of(User).to receive(:groups).and_return([])
@@ -14,7 +14,7 @@ describe UploadSetsController do
       it "enqueues a upload_set job and redirects to generic_works list with a flash message" do
         expect(UploadSetUpdateJob).to receive(:perform_later).with(user.user_key, upload_set.id, { '1' => 'foo' },
                                                                    { tag: [] }, 'open').once
-        post :update, id: upload_set.id, title: { '1' => 'foo' }, visibility: 'open', file_set: { tag: [""] }
+        post :update, id: upload_set.id, title: { '1' => 'foo' }, visibility: 'open', upload_set: { tag: [""] }
         expect(response).to redirect_to routes.url_helpers.curation_concerns_generic_works_path
         expect(flash[:notice]).to include("Your files are being processed")
       end
@@ -22,55 +22,48 @@ describe UploadSetsController do
 
     describe "when user has edit permissions on a file" do
       # TODO: all these tests could move to upload_set_update_job_spec.rb
-      let!(:file) { FileSet.create(upload_set: upload_set) { |f| f.apply_depositor_metadata(user) } }
+      let!(:work) { create(:generic_work, user: user, upload_set: upload_set) }
 
       it "they can set public read access" do
-        post :update, id: upload_set, visibility: "open", file_set: { tag: [""] }
-        expect(file.reload.read_groups).to eq ['public']
+        post :update, id: upload_set, visibility: "open", upload_set: { tag: [""] }
+        expect(work.reload.read_groups).to eq ['public']
       end
 
       it "they can set metadata like title" do
-        post :update, id: upload_set, file_set: { tag: ["footag", "bartag"] }, title: { file.id => ["New Title"] }
-        file.reload
-        expect(file.title).to eq ["New Title"]
+        post :update, id: upload_set, upload_set: { tag: ["footag", "bartag"] }, title: { work.id => ["New Title"] }
+        work.reload
+        expect(work.title).to eq ["New Title"]
         # TODO: is order important?
-        expect(file.tag).to include("footag", "bartag")
+        expect(work.tag).to include("footag", "bartag")
       end
 
       it "they cannot set any tags" do
-        post :update, id: upload_set, file_set: { tag: [""] }
-        expect(file.reload.tag).to be_empty
+        post :update, id: upload_set, upload_set: { tag: [""] }
+        expect(work.reload.tag).to be_empty
       end
     end
 
     describe "when user does not have edit permissions on a file" do
       # TODO: all these tests could move to upload_set_update_job_spec.rb
-      let(:file) do
-        FileSet.new(upload_set: upload_set, title: ['Original Title']) do |f|
-          f.apply_depositor_metadata('someone_else')
-          f.save!
-        end
-      end
+      let!(:work) { create(:generic_work, title: ['Original Title'], upload_set: upload_set) }
 
       it "they cannot modify the object" do
-        post :update, id: upload_set, "file_set" => { "tag" => [""] },
-                      "title" => { file.id => "Title Wont Change" }
-        file.reload
-        expect(file.title).to eq ["Original Title"]
+        post :update, id: upload_set, upload_set: { "tag" => [""] },
+                      title: { work.id => "Title Won't Change" }
+        work.reload
+        expect(work.title).to eq ["Original Title"]
       end
     end
   end
 
   describe "#edit" do
     let(:us1) { UploadSet.create }
-    let!(:file) { FileSet.create(upload_set: us1, label: 'f1') { |f| f.apply_depositor_metadata(user) } }
-    let!(:file2) { FileSet.create(upload_set: us1, label: 'f2') { |f| f.apply_depositor_metadata(user) } }
 
     it "sets up attributes for the form" do
       get :edit, id: us1
-      expect(assigns[:form]).not_to be_persisted
-      expect(assigns[:form].creator[0]).to eq user.user_key
-      expect(assigns[:form].title[0]).to eq 'f1'
+      expect(assigns[:form]).to be_kind_of CurationConcerns::UploadSetForm
+      expect(assigns[:form].model).to eq us1
+      expect(response).to be_success
     end
   end
 end

data/spec/factories/file_sets.rb

@@ -24,6 +24,7 @@ FactoryGirl.define do
         FactoryGirl.create(:generic_work, user: evaluator.user).members << file
       end
     end
+
     after(:build) do |file, evaluator|
       file.apply_depositor_metadata(evaluator.user.user_key)
     end

data/spec/factories/generic_works.rb

@@ -26,6 +26,7 @@ FactoryGirl.define do
     factory :work_with_files do
       before(:create) { |work, evaluator| 2.times { work.ordered_members << FactoryGirl.create(:file_set, user: evaluator.user) } }
     end
+
     factory :work_with_ordered_files do
       before(:create) do |work, evaluator|
         work.ordered_members << FactoryGirl.create(:file_set, user: evaluator.user)

data/spec/factories/users.rb

@@ -10,17 +10,5 @@ FactoryGirl.define do
         end
       end
     end
-
-    factory :jill do
-      email 'jilluser@example.com'
-    end
-
-    factory :archivist, aliases: [:user_with_fixtures] do
-      email 'archivist1@example.com'
-    end
-
-    factory :curator do
-      email 'curator1@example.com'
-    end
   end
 end

data/spec/features/collection_spec.rb

@@ -21,10 +21,8 @@ describe 'collection' do
   let(:user_key) { user.user_key }
   let(:generic_works) do
     (0..12).map do |x|
-      GenericWork.new.tap do |f|
-        f.title = ["title #{x}"]
+      GenericWork.create!(title: ["title #{x}"]) do |f|
         f.apply_depositor_metadata('user1@example.com')
-        f.save!
       end
     end
   end

data/spec/forms/collection_edit_form_spec.rb

@@ -9,10 +9,23 @@ describe CurationConcerns::Forms::CollectionEditForm do
     it do
       is_expected.to eq [:resource_type, :title, :creator, :contributor, :description,
                          :tag, :rights, :publisher, :date_created, :subject, :language,
-                         :identifier, :based_near, :related_url, :visibility]
+                         :representative_id, :thumbnail_id, :identifier, :based_near, :related_url, :visibility]
     end
   end
 
+  describe "#human_readable_type" do
+    subject { form.human_readable_type }
+    it { is_expected.to eq 'Collection' }
+  end
+
+  describe "#member_ids" do
+    before do
+      allow(collection).to receive(:member_ids).and_return(['9999'])
+    end
+    subject { form.member_ids }
+    it { is_expected.to eq ['9999'] }
+  end
+
   describe ".build_permitted_params" do
     subject { described_class.build_permitted_params }
     it { is_expected.to eq [{ resource_type: [] },
@@ -26,6 +39,8 @@ describe CurationConcerns::Forms::CollectionEditForm do
                             { date_created: [] },
                             { subject: [] },
                             { language: [] },
+                            :representative_id,
+                            :thumbnail_id,
                             { identifier: [] },
                             { based_near: [] },
                             { related_url: [] },

data/spec/forms/upload_set_form_spec.rb

@@ -0,0 +1,55 @@
+require 'spec_helper'
+
+describe CurationConcerns::UploadSetForm do
+  let(:form) { described_class.new(upload_set, ability) }
+  let(:user) { build(:user) }
+  let(:ability) { Ability.new(user) }
+  let(:upload_set) { UploadSet.create }
+  let!(:work1) { create(:work, upload_set: upload_set) }
+  let!(:work2) { create(:work, upload_set: upload_set) }
+
+  describe "#to_param" do
+    subject { form.to_param }
+    it { is_expected.to eq upload_set.id }
+  end
+
+  describe "#terms" do
+    subject { form.terms }
+    it { is_expected.to eq [:title,
+                            :creator,
+                            :contributor,
+                            :description,
+                            :tag,
+                            :rights,
+                            :publisher,
+                            :date_created,
+                            :subject,
+                            :language,
+                            :identifier,
+                            :based_near,
+                            :related_url,
+                            :representative_id,
+                            :thumbnail_id,
+                            :files,
+                            :visibility_during_embargo,
+                            :embargo_release_date,
+                            :visibility_after_embargo,
+                            :visibility_during_lease,
+                            :lease_expiration_date,
+                            :visibility_after_lease,
+                            :visibility] }
+  end
+
+  describe "works" do
+    let!(:work1) { create(:work_with_one_file, upload_set: upload_set, title: ['B title']) }
+    let!(:work2) { create(:work_with_one_file, upload_set: upload_set, title: ['A title']) }
+    subject { form.works }
+    it { is_expected.to eq [work2, work1] }
+  end
+
+  describe "creator" do
+    let(:user) { build(:user, email: 'bob@example.com') }
+    subject { form.creator }
+    it { is_expected.to eq ['bob@example.com'] }
+  end
+end

data/spec/forms/work_form_spec.rb

@@ -3,6 +3,7 @@ require 'spec_helper'
 describe CurationConcerns::Forms::WorkForm do
   before do
     class PirateShip < ActiveFedora::Base
+      include CurationConcerns::RequiredMetadata
       include CurationConcerns::BasicMetadata
       include CurationConcerns::HasRepresentative
     end
@@ -17,17 +18,25 @@ describe CurationConcerns::Forms::WorkForm do
     Object.send(:remove_const, :PirateShip)
   end
 
-  let(:curation_concern) { create(:work_with_one_file) }
-  let(:title) { curation_concern.file_sets.first.title.first }
-  let(:file_id) { curation_concern.file_sets.first.id }
+  let(:curation_concern) { create(:work) }
   let(:ability) { nil }
   let(:form) { PirateShipForm.new(curation_concern, ability) }
 
   describe "#select_files" do
+    let(:curation_concern) { create(:work_with_one_file) }
+    let(:title) { curation_concern.file_sets.first.title.first }
+    let(:file_id) { curation_concern.file_sets.first.id }
+
     subject { form.select_files }
     it { is_expected.to eq(title => file_id) }
   end
 
+  describe "#[]" do
+    it 'has one element' do
+      expect(form['description']).to eq ['']
+    end
+  end
+
   describe '.model_attributes' do
     let(:params) { ActionController::Parameters.new(
       title: ['foo'],
@@ -36,6 +45,7 @@ describe CurationConcerns::Forms::WorkForm do
       admin_set_id: '123',
       representative_id: '456',
       thumbnail_id: '789',
+      tag: ['derp'],
       rights: 'http://creativecommons.org/licenses/by/3.0/us/')
     }
     subject { PirateShipForm.model_attributes(params) }
@@ -45,10 +55,65 @@ describe CurationConcerns::Forms::WorkForm do
       expect(subject['description']).to be_empty
       expect(subject['visibility']).to eq 'open'
       expect(subject['rights']).to eq ['http://creativecommons.org/licenses/by/3.0/us/']
+      expect(subject['tag']).to eq ['derp']
     end
 
     it 'excludes non-permitted params' do
       expect(subject).not_to have_key 'admin_set_id'
     end
   end
+
+  describe "initialized fields" do
+    context "for :description" do
+      subject { form[:description] }
+      it { is_expected.to eq [''] }
+    end
+
+    context "for :embargo_release_date" do
+      subject { form[:embargo_release_date] }
+      it { is_expected.to be nil }
+    end
+  end
+
+  describe '#human_readable_type' do
+    subject { form.human_readable_type }
+    it { is_expected.to eq 'Generic Work' }
+  end
+
+  describe "#open_access?" do
+    subject { form.open_access? }
+    it { is_expected.to be false }
+  end
+
+  describe "#authenticated_only_access?" do
+    subject { form.authenticated_only_access? }
+    it { is_expected.to be false }
+  end
+
+  describe "#open_access_with_embargo_release_date?" do
+    subject { form.open_access_with_embargo_release_date? }
+    it { is_expected.to be false }
+  end
+
+  describe "#private_access?" do
+    subject { form.private_access? }
+    it { is_expected.to be true }
+  end
+
+  describe "#member_ids" do
+    subject { form.member_ids }
+    it { is_expected.to eq curation_concern.member_ids }
+  end
+
+  describe "#embargo_release_date" do
+    let(:curation_concern) { create(:work, embargo_release_date: 5.days.from_now) }
+    subject { form.embargo_release_date }
+    it { is_expected.to eq curation_concern.embargo_release_date }
+  end
+
+  describe "#lease_expiration_date" do
+    let(:curation_concern) { create(:work, lease_expiration_date: 2.days.from_now) }
+    subject { form.lease_expiration_date }
+    it { is_expected.to eq curation_concern.lease_expiration_date }
+  end
 end

data/spec/helpers/curation_concerns/ability_helper_spec.rb

@@ -0,0 +1,45 @@
+require 'spec_helper'
+
+describe CurationConcerns::AbilityHelper do
+  describe "#visibility_badge" do
+    subject { helper.visibility_badge visibility }
+    {
+      Hydra::AccessControls::AccessRight::VISIBILITY_TEXT_VALUE_PUBLIC =>
+        "<span class=\"label label-success\">Open Access</span>",
+      Hydra::AccessControls::AccessRight::VISIBILITY_TEXT_VALUE_AUTHENTICATED =>
+        "<span class=\"label label-info\">%s</span>",
+      Hydra::AccessControls::AccessRight::VISIBILITY_TEXT_VALUE_PRIVATE =>
+        "<span class=\"label label-danger\">Private</span>",
+      Hydra::AccessControls::AccessRight::VISIBILITY_TEXT_VALUE_EMBARGO =>
+        "<span class=\"label label-warning\">Embargo</span>",
+      Hydra::AccessControls::AccessRight::VISIBILITY_TEXT_VALUE_LEASE =>
+        "<span class=\"label label-warning\">Lease</span>"
+    }.each do |value, output|
+      context value do
+        let(:visibility) { value }
+        it { expect(subject).to eql(output % t('curation_concerns.institution_name')) }
+      end
+    end
+  end
+  describe "#visibility_options" do
+    let(:public_opt) { ['Open Access', Hydra::AccessControls::AccessRight::VISIBILITY_TEXT_VALUE_PUBLIC] }
+    let(:authenticated_opt) { [t('curation_concerns.institution_name'), Hydra::AccessControls::AccessRight::VISIBILITY_TEXT_VALUE_AUTHENTICATED] }
+    let(:private_opt) { ['Private', Hydra::AccessControls::AccessRight::VISIBILITY_TEXT_VALUE_PRIVATE] }
+    subject { helper.visibility_options(option) }
+    context 'all options' do
+      let(:options) { [public_opt, authenticated_opt, private_opt] }
+      let(:option) { nil }
+      it { is_expected.to eql(options) }
+    end
+    context 'restricting options' do
+      let(:options) { [private_opt, authenticated_opt] }
+      let(:option) { :restrict }
+      it { is_expected.to eql(options) }
+    end
+    context 'loosening options' do
+      let(:options) { [public_opt, authenticated_opt] }
+      let(:option) { :loosen }
+      it { is_expected.to eql(options) }
+    end
+  end
+end

data/spec/helpers/curation_concerns/permissions_helper_spec.rb

@@ -0,0 +1,12 @@
+require 'spec_helper'
+
+describe CurationConcerns::PermissionsHelper do
+  describe "#help_link" do
+    subject { helper.help_link 'curation_concerns/base/visibility', 'Visibility', 'Usage information for visibility' }
+
+    it "draws help_icon" do
+      expect(subject).to match(/data-content="<p>This setting will determine who can view your file/)
+      expect(subject).to have_selector 'a i.help-icon'
+    end
+  end
+end

data/spec/helpers/url_helper_spec.rb

@@ -1,9 +1,6 @@
 require 'spec_helper'
 
 describe CurationConcerns::UrlHelper do
-  before do
-    GenericWork.destroy_all
-  end
   let(:profile) { ["{\"datastreams\":{}}"] }
   let(:work) { create(:generic_work) }
   let(:document) { SolrDocument.new(work.to_solr) }

data/spec/indexers/collection_indexer_spec.rb

@@ -4,11 +4,16 @@ describe CurationConcerns::CollectionIndexer do
   let(:indexer) { described_class.new(collection) }
   let(:collection) { build(:collection) }
 
+  before { allow(collection).to receive(:bytes).and_return(1000) }
   describe "#generate_solr_document" do
     subject { indexer.generate_solr_document }
 
     it "has generic type" do
       expect(subject.fetch('generic_type_sim')).to eq ["Collection"]
     end
+
+    it "has bytes" do
+      expect(subject.fetch('bytes_is')).to eq(1000)
+    end
   end
 end