curation_concerns 0.14.0.pre2 → 0.14.0.pre3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 57de72e25be5af57715ccfdb367577a5ebd9b98b
-  data.tar.gz: 278a1dcc3a79d15ba8472222b04877c7c804aa5c
+  metadata.gz: 499d0f504305d4a3527b20952256ca5c479495f6
+  data.tar.gz: 198f23262a6af4305f350622678666ae444d4c9f
 SHA512:
-  metadata.gz: 03414390a8504f7001eaeea69c5929a41c27d3db1c191ea19266bd056a8e8666931c7e0a897e0a3a6f6519325a1aaae9c9ca33a4423f50af7bfe185c76a64e3a
-  data.tar.gz: 3d0b2327008ca3ce0b866d5faa07b8ddbde751e072f68b2126c6b222ef74e89f5fb03e7bb44d6b1cb4c4cae18519fbd45be2bfdc408216089c52c6354ce0e48b
+  metadata.gz: fc6d2a67ff1711383d698b083ccbd4e869f1031354fd302512787abddeb656a43ac12b6b87d1bb163230ee1db5da17684190deff4fa28f1f2dc99b240870c503
+  data.tar.gz: 48549fbe68acc204baf000be4464be9363b00dff9ebb77198deb2c8eb2f15115143881f2f07f80176ea38b5be71cf9c576fcb614f0e4c37573c985abd521a79f

data/RELEASING.md

@@ -1,3 +1,3 @@
 * Bump version number in `lib/curation_concerns/version.rb`
+* Commit and push your change to the master branch
 * Release the gem to rubygems.org: `rake build` then `rake release`
-* `git push`

data/app/actors/curation_concerns/file_set_actor.rb

@@ -69,10 +69,7 @@ module CurationConcerns
       stack = ActorStack.new(file_set,
                              user,
                              [InterpretVisibilityActor, BaseActor])
-      if result = stack.update(attributes)
-        CurationConcerns.config.callback.run(:after_update_metadata, file_set, user)
-      end
-      result
+      stack.update(attributes)
     end
 
     def destroy
@@ -123,6 +120,7 @@ module CurationConcerns
           # Save the work so the association between the work and the file_set is persisted (head_id)
           work.save
         end
+        CurationConcerns.config.callback.run(:after_create_fileset, file_set, user)
       end
 
       def assign_visibility?(file_set_params = {})

data/app/jobs/ingest_file_job.rb

@@ -24,6 +24,5 @@ class IngestFileJob < ActiveJob::Base
 
     # Do post file ingest actions
     CurationConcerns::VersioningService.create(file_set.send(relation.to_sym), user)
-    CurationConcerns.config.callback.run(:after_create_fileset, file_set, user)
   end
 end

data/lib/curation_concerns/version.rb

@@ -1,3 +1,3 @@
 module CurationConcerns
-  VERSION = "0.14.0.pre2".freeze
+  VERSION = "0.14.0.pre3".freeze
 end

data/spec/actors/curation_concerns/file_set_actor_spec.rb

@@ -35,7 +35,7 @@ describe CurationConcerns::FileSetActor do
     end
 
     context 'when a work is provided' do
-      let(:work) { FactoryGirl.create(:generic_work) }
+      let(:work) { create(:generic_work) }
 
       it 'adds the generic file to the parent work' do
         expect(subject.generic_works).to eq [work]
@@ -203,6 +203,7 @@ describe CurationConcerns::FileSetActor do
     end
 
     it "writes to the most up to date version" do
+      expect(CurationConcerns.config.callback).to receive(:run).with(:after_create_fileset, file_set3, user)
       # using send(), because attach_file_to_work is private
       actor.send(:attach_file_to_work, work_v1, file_set3, {})
       expect(work_v1.members.size).to eq 3

data/spec/jobs/ingest_file_job_spec.rb

@@ -67,12 +67,4 @@ describe IngestFileJob do
       expect(VersionCommitter.where(version_id: versions.last.uri).pluck(:committer_login)).to eq [user2.user_key]
     end
   end
-
-  describe "the after_create_fileset callback" do
-    subject { CurationConcerns.config.callback }
-    it 'runs with file_set and user arguments' do
-      expect(subject).to receive(:run).with(:after_create_fileset, file_set, user)
-      described_class.perform_now(file_set, filename, 'image/png', user)
-    end
-  end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: curation_concerns
 version: !ruby/object:Gem::Version
-  version: 0.14.0.pre2
+  version: 0.14.0.pre3
 platform: ruby
 authors:
 - Matt Zumwalt
@@ -10,7 +10,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-04-28 00:00:00.000000000 Z
+date: 2016-04-29 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: hydra-head