curate 0.6.5 → 0.6.6

data/spec/repository_models/generic_work_spec.rb

@@ -35,4 +35,96 @@ describe GenericWork do
     end
   end
 
+  describe 'Editor' do
+    let(:person) { FactoryGirl.create(:person_with_user) }
+    let(:another_person) { FactoryGirl.create(:person_with_user) }
+    let(:work) { FactoryGirl.create(:generic_work, user: person.user) }
+    let(:collection) { FactoryGirl.create(:collection) }
+    describe '#add_editor' do
+      it 'should add editor' do
+        work.editors.should == []
+
+        work.add_editor(person)
+        work.add_editor(another_person)
+
+        work.reload.editors.should == [person, another_person]
+        work.reload.edit_users.should == [person.depositor, another_person.depositor]
+      end
+
+      it 'should not add non-work objects' do
+        work.editors.should == []
+        work.add_editor(collection)
+        work.reload.editors.should == []
+      end
+    end
+
+    describe '#remove_editor' do
+      it 'should remove editor' do
+        work.editors.should == []
+        work.add_editor(another_person)
+
+        reload_work = GenericWork.find(work.pid)
+        work = reload_work
+
+        work.editors.should == [another_person]
+        work.edit_users.should include(another_person.depositor)
+
+        work.remove_editor(another_person)
+
+        reload_work = GenericWork.find(work.pid)
+        work = reload_work
+
+        work.editors.should == []
+        work.edit_users.should_not include(another_person.depositor)
+      end
+    end
+  end
+
+  describe 'EditorGroup' do
+    let(:person) { FactoryGirl.create(:person_with_user) }
+    let(:user) { person.user }
+    let(:group) { FactoryGirl.create(:group, user: user) }
+    let(:work) { FactoryGirl.create(:generic_work, user: person.user) }
+    let(:collection) { FactoryGirl.create(:collection) }
+    describe '#add_editor_group' do
+      it 'should add group' do
+        work.editor_groups.should == []
+
+        work.add_editor_group(group)
+
+        reload_work = GenericWork.find(work.pid)
+        work = reload_work
+
+        work.editor_groups.should == [group]
+        work.edit_groups.should == [group.title]
+      end
+
+      it 'should not add non-group objects' do
+        work.editor_groups.should == []
+        work.add_editor_group(collection)
+        work.reload.editor_groups.should == []
+      end
+    end
+
+    describe '#remove_editor_group' do
+      it 'should remove editor_group' do
+        work.editor_groups.should == []
+        work.add_editor_group(group)
+
+        reload_work = GenericWork.find(work.pid)
+        work = reload_work
+
+        work.editor_groups.should == [group]
+        work.edit_groups.should include(group.title)
+
+        work.remove_editor_group(group)
+
+        reload_work = GenericWork.find(work.pid)
+        work = reload_work
+
+        work.editor_groups.should == []
+        work.edit_groups.should_not include(group.title)
+      end
+    end
+  end
 end

data/spec/repository_models/hydramata/group_membership_form_spec.rb

@@ -0,0 +1,86 @@
+require 'spec_helper'
+
+describe Hydramata::GroupMembershipForm do
+
+
+  let!(:person_1) { FactoryGirl.create(:person_with_user) }
+  let!(:person_2) { FactoryGirl.create(:person_with_user) }
+  let(:user_1) { person_1.user }
+  let(:user_2) { person_2.user }
+  let!(:group) { FactoryGirl.create(:group, user: user_1) }
+
+  let(:params_1) {
+    { group_id: group.pid, title: "Title 1", description: "Description for Title 1", members: members_to_add }
+  }
+
+  let(:params_2) {
+    { group_id: group.pid, title: "Title 2", description: "Description for Title 2", members: members_to_remove }
+  }
+
+  let(:params_3) {
+    { group_id: group.pid, title: "Title 2", description: "Description for Title 2", members: members_with_changed_permission }
+  }
+
+  let(:members_to_add) {
+    [
+      { person_id: person_1.pid, action: "create", role: "manager" },
+      { person_id: person_2.pid, action: "create", role: "member" }
+    ]
+  }
+
+  let(:members_to_remove) {
+    [
+      { person_id: person_2.pid, action: "destroy", role: "member" }
+    ]
+  }
+
+  let(:members_with_changed_permission) {
+    [
+      { person_id: person_2.pid, action: "none", role: "manager" }
+    ]
+  }
+
+  context '#save' do
+
+    before(:each) do
+      @gmf = Hydramata::GroupMembershipForm.new(params_1)
+    end
+
+    it 'should append the member to the group' do
+      group.members.should == []
+      @gmf.save
+      group = Hydramata::Group.find(@gmf.group.pid)
+      group.members.should == [person_1, person_2]
+    end
+
+    it 'should remove member from the group' do
+      @gmf.save
+      group = Hydramata::Group.find(@gmf.group.pid)
+      group.members.should == [person_1, person_2]
+
+      @gmf_remove = Hydramata::GroupMembershipForm.new(params_2)
+      @gmf_remove.save
+      group = Hydramata::Group.find(@gmf_remove.group.pid)
+      group.members.should == [person_1]
+      @gmf.group.pid.should == @gmf_remove.group.pid
+    end
+
+    it 'should change group permission for the member' do
+      @gmf.save
+      group = Hydramata::Group.find(@gmf.group.pid)
+      group.members.should == [person_1, person_2]
+      group.edit_users.size.should == 1
+      group.read_users.size.should == 1
+
+      @gmf_change_perm = Hydramata::GroupMembershipForm.new(params_3)
+      @gmf_change_perm.save
+      group = Hydramata::Group.find(@gmf_change_perm.group.pid)
+      group.members.should == [person_1, person_2]
+      group.edit_users.size.should == 2
+      group.read_users.size.should == 0
+
+      @gmf.group.pid.should == @gmf_change_perm.group.pid
+    end
+  end
+
+end

data/spec/repository_models/hydramata/group_spec.rb

@@ -0,0 +1,91 @@
+require 'spec_helper'
+
+describe Group do
+
+  let(:person) { FactoryGirl.create(:person)}
+  let(:another_person) { FactoryGirl.create(:person)}
+  let(:work) { FactoryGirl.create(:generic_work)}
+  let(:test_group_1) { FactoryGirl.create(:group) }
+  let(:test_group_2) { FactoryGirl.create(:group) }
+  let(:test_group_3) { FactoryGirl.create(:group) }
+
+  describe 'contains no members' do
+    subject { FactoryGirl.create(:group) }
+    its(:title) { should_not be_nil }
+    its(:description) { should_not be_nil }
+    it '#dates' do
+      expect(subject.date_uploaded.to_s).to eq Date.today.to_s
+      expect(subject.date_modified.to_s).to eq Date.today.to_s
+    end
+    its(:members) { should eq []}
+  end
+
+  describe '.add_member' do
+    it 'should add members to the group with read permissions' do
+      test_group_1.add_member(person)
+      test_group_1.add_member(another_person)
+
+      test_group_1.reload
+      test_group_1.members.should == [person, another_person]
+      test_group_1.members.count.should eq 2
+
+      test_group_1.read_users.count.should == 2
+      test_group_1.edit_users.count.should == 0 
+
+      person.groups.count.should eq 1
+      another_person.groups.count.should eq 1
+    end
+
+    it 'should add members to the group with edit permissions' do
+      test_group_1.add_member(person, 'manager')
+      test_group_1.add_member(another_person, 'manager')
+
+      test_group_1.reload
+      test_group_1.members.should == [person, another_person]
+      test_group_1.members.count.should eq 2
+
+      test_group_1.read_users.count.should == 0
+      test_group_1.edit_users.count.should == 2
+
+      person.groups.count.should eq 1
+      another_person.groups.count.should eq 1
+    end
+  end
+
+  describe '.remove_member' do
+    it 'should work' do
+      test_group_2.add_member(person)
+      test_group_2.add_member(another_person)
+
+      test_group_2.reload
+      test_group_2.members.should == [person, another_person]
+
+      test_group_2.remove_member(another_person)
+      test_group_2.save!
+
+      test_group_2.reload
+      test_group_2.members.should include(person)
+      test_group_2.members.should_not include(another_person)
+      test_group_2.members.count.should eq 1
+
+      another_person.groups.count.should eq 0
+      person.groups.count.should eq 1
+
+    end
+  end
+
+  describe 'cannot add' do
+    it 'a non-person object' do
+      test_group_3.add_member(work)
+      test_group_3.members.count.should eq 0
+    end
+  end
+
+  describe '.can_be_member_of_collection' do
+    it 'should indicate a group cannot be added to a collection' do
+      group = Hydramata::Group.new
+      expect(group.can_be_member_of_collection?(Collection.new)).to be_false
+    end
+  end
+
+end

data/spec/repository_models/person_spec.rb

@@ -25,6 +25,50 @@ describe Person do
     end
   end
 
+  describe 'Work' do
+    let(:person) { FactoryGirl.create(:person_with_user) }
+    let(:another_person) { FactoryGirl.create(:person_with_user) }
+    let(:work) { FactoryGirl.create(:generic_work, user: person.user) }
+    let(:collection) { FactoryGirl.create(:collection) }
+    describe '#add_work' do
+      it 'should add work' do
+        person.works.should == []
+        work.reload.edit_users.should == [person.depositor]
+
+        person.add_work(work)
+        another_person.add_work(work)
+
+        person.reload.works.should == [work]
+        work.reload.edit_users.should == [person.depositor, another_person.depositor]
+      end
+
+      it 'should not add non-work objects' do
+        person.works.should == []
+        person.add_work(collection)
+        person.reload.works.should == []
+      end
+    end
+
+    describe '#remove_work' do
+      it 'should remove work' do
+        another_person.works.should == []
+
+        another_person.add_work(work)
+
+        reload_another_person = Person.find(another_person.pid)
+        another_person = reload_another_person
+
+        another_person.works.should == [work]
+        work.reload.edit_users.should include(another_person.depositor)
+
+        another_person.remove_work(work)
+
+        another_person.reload.works.should == []
+        work.reload.edit_users.should_not include(another_person.depositor)
+      end
+    end
+  end
+
   describe 'to_solr' do
     before do
       subject.name = "Aura D. Stanton"

data/spec/support/shared/shared_examples_is_a_curation_concern_controller.rb

@@ -11,7 +11,8 @@ shared_examples 'is_a_curation_concern_controller' do |curation_concern_class, o
   end
   its(:curation_concern_type) { should eq curation_concern_class }
 
-  let(:user) { FactoryGirl.create(:user) }
+  let(:person) { FactoryGirl.create(:person_with_user) }
+  let(:user) { person.user }
   before { sign_in user }
 
   def path_to_curation_concern
@@ -74,7 +75,11 @@ shared_examples 'is_a_curation_concern_controller' do |curation_concern_class, o
       it "should create a work" do
         controller.curation_concern.stub(:persisted?).and_return(true)
         controller.actor = double(:create => true)
+
+        setup_stubs
+
         post :create, accept_contributor_agreement: "accept"
+
         response.should redirect_to path_to_curation_concern
       end
     end
@@ -121,12 +126,14 @@ shared_examples 'is_a_curation_concern_controller' do |curation_concern_class, o
       let(:a_work) { FactoryGirl.create(default_work_factory_name, user: user) }
       it "should update the work " do
         controller.actor = double(:update => true, :visibility_changed? => false)
+        setup_stubs_for_update(a_work)
         patch :update, id: a_work
         response.should redirect_to path_to_curation_concern
       end
       describe "changing rights" do
         it "should prompt to change the files access" do
           controller.actor = double(:update => true, :visibility_changed? => true)
+          setup_stubs_for_update(a_work)
           patch :update, id: a_work
           response.should redirect_to confirm_curation_concern_permission_path(controller.curation_concern)
         end
@@ -134,6 +141,7 @@ shared_examples 'is_a_curation_concern_controller' do |curation_concern_class, o
       describe "failure" do
         it "renders the form" do
           controller.actor = double(:update => false, :visibility_changed? => false)
+          setup_stubs_for_update(a_work)
           patch :update, id: a_work
           expect(response).to render_template('edit')
         end
@@ -151,4 +159,18 @@ shared_examples 'is_a_curation_concern_controller' do |curation_concern_class, o
     end
   end
 
+  def setup_stubs
+    curation_concern_type = controller.curation_concern.class.to_s.underscore
+    work_editorship = CurationConcern::WorkPermission.new
+    CurationConcern::WorkPermission.any_instance.stub(:save).and_return(true)
+
+    controller.class.any_instance.stub(:add_depositor_as_editor).and_return(true)
+    controller.class.any_instance.stub(:get_class_name).and_return(curation_concern_type)
+    controller.class.any_instance.stub(:add_or_update_editors_and_groups).and_return(work_editorship)
+  end
+
+  def setup_stubs_for_update(work)
+    CurationConcern::WorkPermissionActionParser.stub(:convert_params).and_return({})
+    CurationConcern::WorkPermission.stub(:new).and_return(work)
+  end
 end

data/spec/support/shared/shared_examples_remotely_identified.rb

@@ -1,8 +1,16 @@
 shared_examples 'remotely_identified' do |remote_service_name|
   context "by #{remote_service_name}" do
     context 'with valid attributes' do
-      subject { FactoryGirl.create(described_class.name.underscore, attributes) }
-      let(:attributes) { { publisher: 'An Interesting Chap!' } }
+      subject { described_class.new(attributes) }
+      let(:attributes) {
+        {
+          publisher: 'An Interesting Chap!',
+          pid: "#{Sufia.config.id_namespace}:3t94g081v",
+          date_uploaded: Date.parse('2013-01-30'),
+          date_modified: Date.parse('2013-01-30'),
+          title: "A Title"
+        }
+      }
 
       it 'mints!', VCR::SpecSupport(cassette_name: "remotely_identified_#{remote_service_name}_mint_#{described_class.name.underscore}") do
         expect {