curate 0.0.1 → 0.1.0

data/spec/repository_models/generic_file_spec.rb

@@ -0,0 +1,38 @@
+require 'spec_helper'
+describe GenericFile do
+  subject { GenericFile.new }
+
+  include_examples 'with_access_rights'
+  include_examples 'is_embargoable'
+
+  it { should respond_to(:versions) }
+  it { should respond_to(:human_readable_type) }
+  it { should respond_to(:current_version_id) }
+  it { should respond_to(:file=) }
+  it { should respond_to(:filename) }
+  it { should respond_to(:visibility) }
+  it { should respond_to(:visibility=) }
+
+  it 'uses #noid for #to_param' do
+    subject.to_param.should == subject.noid
+  end
+
+  it 'has no title to display' do
+    subject.to_s.should == "No Title"
+  end
+
+  let(:user) { FactoryGirl.create(:user) }
+  let(:file) { Rack::Test::UploadedFile.new(__FILE__, 'text/plain', false) }
+  let(:persisted_generic_file) {
+    FactoryGirl.create_generic_file(:mock_curation_concern, user, file)
+  }
+
+  it 'has a current version id' do
+    persisted_generic_file.current_version_id.should == "content.0"
+  end
+
+  it 'has file_name as its title to display' do
+    expect(persisted_generic_file.to_s).to eq(File.basename(__FILE__))
+  end
+
+end

data/spec/services/anti_virus_scanner_spec.rb

@@ -0,0 +1,26 @@
+require 'spec_helper'
+
+describe AntiVirusScanner do
+  let(:object) { GenericFile.new }
+  let(:file_path) { __FILE__ }
+  subject { AntiVirusScanner.new(object) }
+  let(:always_clean_scanner) {
+    lambda {|o| AntiVirusScanner::NO_VIRUS_FOUND_RETURN_VALUE }
+  }
+  let(:always_has_virus_scanner) {
+    lambda {|o| 'virus found' }
+  }
+  describe '#call' do
+    it 'returns true if anti-virus is successful' do
+      subject.scanner_instance = always_clean_scanner
+      expect(subject.call(file_path)).to eq(true)
+    end
+
+    it 'raise an exception if anti-virus failed' do
+      subject.scanner_instance = always_has_virus_scanner
+      expect {
+        subject.call(file_path)
+      }.to raise_error(AntiVirusScanner::VirusDetected)
+    end
+  end
+end

data/spec/services/curation_concern/base_actor_spec.rb

@@ -0,0 +1,28 @@
+require 'spec_helper'
+
+describe CurationConcern::BaseActor do
+  let(:user) { User.new }
+  let(:curation_concern) { GenericFile.new }
+  let(:attributes) { {visibility: visibility} }
+  let(:visibility) { nil }
+  subject { CurationConcern.actor(curation_concern, user, attributes)}
+  describe 'with visibility "1"' do
+    let(:visibility) { "1" }
+    it 'should have visibility' do
+      subject.send(:visibility).should == visibility
+    end
+    it 'should have visibility' do
+      subject.send(:visibility_may_have_changed?).should == true
+    end
+
+  end
+  describe 'with missing visibility' do
+    let(:visibility) { nil }
+    it 'should have visibility' do
+      subject.send(:visibility).should be_nil
+    end
+    it 'should have visibility' do
+      subject.send(:visibility_may_have_changed?).should == false
+    end
+  end
+end

data/spec/services/curation_concern/generic_file_actor_spec.rb

@@ -0,0 +1,75 @@
+require 'spec_helper'
+
+describe CurationConcern::GenericFileActor do
+  let(:user) { FactoryGirl.create(:user) }
+  let(:parent) { FactoryGirl.create_curation_concern(:mock_curation_concern, user) }
+  let(:file_path) { __FILE__ }
+  let(:file) { Rack::Test::UploadedFile.new(file_path, 'text/plain', false)}
+  let(:file_content) { File.read(file)}
+  let(:title) { Time.now.to_s }
+  let(:attributes) {
+    { file: file, title: title, visibility: AccessRight::VISIBILITY_TEXT_VALUE_AUTHENTICATED }
+  }
+
+  subject {
+    CurationConcern::GenericFileActor.new(generic_file, user, attributes)
+  }
+
+  describe '#create!' do
+    let(:generic_file) { GenericFile.new.tap {|gf| gf.batch = parent } }
+    let(:reloaded_generic_file) {
+      generic_file.class.find(generic_file.pid)
+    }
+    describe 'with a file' do
+      it 'succeeds if attributes are given' do
+        expect {
+          subject.create!
+        }.to change {
+          parent.class.find(parent.pid).generic_files.count
+        }.by(1)
+
+        reloaded_generic_file.batch.should == parent
+        reloaded_generic_file.to_s.should == title
+        reloaded_generic_file.filename.should == File.basename(__FILE__)
+
+        expect(reloaded_generic_file.to_solr['read_access_group_t']).to eq(['registered'])
+      end
+
+      it 'fails if no batch is provided' do
+        generic_file.batch = nil
+        expect {
+          expect {
+            subject.create!
+          }.to raise_error(ActiveFedora::RecordInvalid)
+        }.to_not change { GenericFile.count }
+      end
+    end
+
+    describe 'without a file' do
+      let(:file) { nil }
+      it 'fails if no batch is provided' do
+        expect{
+          expect {
+            subject.create!
+          }.to raise_error(ActiveFedora::RecordInvalid)
+        }.to_not change { GenericFile.count }
+      end
+    end
+  end
+
+  describe '#update!' do
+    let(:generic_file) {
+      FactoryGirl.create_generic_file(parent, user)
+    }
+    it do
+      generic_file.title.should_not == title
+      generic_file.content.content.should_not == file_content
+      expect {
+        subject.update!
+      }.to change {generic_file.versions.count}.by(1)
+      generic_file.title.should == title
+      generic_file.to_s.should == title
+      generic_file.content.content.should == file_content
+    end
+  end
+end

data/spec/services/curation_concern_spec.rb

@@ -0,0 +1,34 @@
+require 'spec_helper'
+
+describe CurationConcern do
+  subject {CurationConcern}
+  it 'can mint_a_pid' do
+    subject.should respond_to(:mint_a_pid)
+  end
+
+  describe '.actor' do
+    it 'finds an actor by for a GenericFile' do
+      subject.actor(GenericFile.new, User.new, {}).should(
+        be_kind_of(CurationConcern::GenericFileActor)
+      )
+    end
+
+    it 'raise an exception if there is no actor' do
+      expect {
+        subject.actor("", User.new, {})
+      }.to raise_error(NameError)
+    end
+  end
+
+  describe '.attach_file' do
+    let(:file) { Rack::Test::UploadedFile.new(__FILE__, 'text/plain', false) }
+    let(:user) { FactoryGirl.create(:user) }
+    let(:generic_file) { GenericFile.new }
+    let(:curation_concern) { FactoryGirl.create_curation_concern(:mock_curation_concern, user) }
+    it 'works with a string' do
+      actor = CurationConcern.actor(generic_file, user, {batch_id: curation_concern.pid, file: file})
+      actor.create!
+      generic_file.content.content.should == file.read
+    end
+  end
+end

data/spec/spec_helper.rb

@@ -1,8 +1,23 @@
 # Configure Rails Environment
-ENV["RAILS_ENV"] = "test"
+ENV["RAILS_ENV"] ||= 'test'
+
+if ENV['COVERAGE']
+  require 'simplecov'
+  SimpleCov.start 'rails'
+  SimpleCov.command_name "spec"
+end
 
 require File.expand_path("../dummy/config/environment.rb",  __FILE__)
 require "rails/test_help"
+require 'rspec/rails'
+require 'webmock/rspec'
+require 'rspec-html-matchers'
+require 'rspec/autorun'
+require 'database_cleaner'
+require 'factory_girl'
+
+Dir["#{File.dirname(__FILE__)}/factories/**/*.rb"].each { |f| require f }
+
 
 Rails.backtrace_cleaner.remove_silencers!
 
@@ -13,3 +28,41 @@ Dir["#{File.dirname(__FILE__)}/support/**/*.rb"].each { |f| require f }
 if ActiveSupport::TestCase.method_defined?(:fixture_path=)
   ActiveSupport::TestCase.fixture_path = File.expand_path("../fixtures", __FILE__)
 end
+
+# This file was generated by the `rspec --init` command. Conventionally, all
+# specs live under a `spec` directory, which RSpec adds to the `$LOAD_PATH`.
+# Require this file using `require "spec_helper"` to ensure that it is only
+# loaded once.
+#
+# See http://rubydoc.info/gems/rspec-core/RSpec/Core/Configuration
+RSpec.configure do |config|
+  config.treat_symbols_as_metadata_keys_with_true_values = true
+  config.run_all_when_everything_filtered = true
+
+  # Run specs in random order to surface order dependencies. If you find an
+  # order dependency and want to debug it, you can fix the order by providing
+  # the seed, which is printed after each run.
+  #     --seed 1234
+  config.order = 'random'
+
+  config.include Devise::TestHelpers, type: :controller
+
+  config.use_transactional_fixtures = false
+
+  config.before(:all) do
+    WebMock.allow_net_connect!
+  end
+
+  config.before(:suite) do
+    DatabaseCleaner.strategy = :truncation
+    DatabaseCleaner.clean_with(:truncation)
+  end
+
+  config.before(:each) do
+    DatabaseCleaner.start
+  end
+
+  config.after(:each) do
+    DatabaseCleaner.clean
+  end
+end

data/spec/support/environment_override.rb

@@ -0,0 +1,17 @@
+module EnvironmentOverride
+  module_function
+  def with_anti_virus_scanner(success = true)
+    if ! Rails.configuration.respond_to?(:default_antivirus_instance)
+      raise RuntimeError, "Undefined Rails.configuration.default_antivirus_instance"
+    end
+    before_override = Rails.configuration.default_antivirus_instance
+
+    instance = success ? lambda {|f| 0 } : lambda {|f| 1 }
+    Rails.configuration.default_antivirus_instance = instance
+    yield
+  ensure
+    if Rails.configuration.respond_to?(:default_antivirus_instance)
+      Rails.configuration.default_antivirus_instance = before_override
+    end
+  end
+end

data/spec/support/matchers/raise_rescue_response_type_matcher.rb

@@ -0,0 +1,42 @@
+# RSpec matcher to spec delegations.
+
+RSpec::Matchers.define :raise_rescue_response_type do |expected_rescue_response|
+  match do |response|
+    @expected_rescue_response = expected_rescue_response.to_sym
+    @exception = nil
+
+    begin
+      @status = response.call.status
+    rescue Exception => e
+      @exception = e
+    end
+
+    if @exception.nil?
+      @actual_rescue_response = @status
+      @status == Rack::Utils.status_code(@expected_rescue_response)
+    else
+      response = ActionDispatch::ExceptionWrapper.rescue_responses[@exception.class.name]
+      @actual_rescue_response = ActionDispatch::ExceptionWrapper.rescue_responses[@exception.class.name].to_sym
+      @actual_rescue_response == @expected_rescue_response
+    end
+  end
+
+  description do
+    "expected to raise an exception with rescue_response #{@expected_rescue_response.inspect}"
+  end
+
+  failure_message_for_should do |text|
+    text = "expected to raise an exception with rescue_response"
+    text << " #{@expected_rescue_response.inspect} instead got #{@actual_rescue_response.inspect}"
+    text << " (Exception #{@exception.class}: #{@exception})" if @exception
+    text
+  end
+
+  failure_message_for_should_not do |text|
+    text = "expected to NOT raise an exception with rescue_response"
+    text << " #{@expected_rescue_response.inspect} but got #{@actual_rescue_response.inspect}"
+    text << " (Exception #{@exception.class}: #{@exception})" if @exception
+    text
+  end
+
+end

data/spec/support/mock_curation_concern.rb

@@ -0,0 +1,61 @@
+class MockCurationConcern < ActiveFedora::Base
+  class MetadataDatastream < ActiveFedora::NtriplesRDFDatastream
+  map_predicates do |map|
+    map.title(in: RDF::DC) do |index|
+      index.as :searchable, :displayable
+    end
+    map.created(in: RDF::DC)
+    map.creator(in: RDF::DC) do |index|
+      index.as :searchable, :facetable, :displayable
+    end
+    map.date_uploaded(to: "dateSubmitted", in: RDF::DC) do |index|
+      index.type :date
+      index.as :searchable, :displayable, :sortable
+    end
+    map.date_modified(to: "modified", in: RDF::DC) do |index|
+      index.type :date
+      index.as :searchable, :displayable, :sortable
+    end
+    map.part(:to => "hasPart", in: RDF::DC)
+    map.identifier({in: RDF::DC})
+  end
+end
+  include Hydra::ModelMixins::CommonMetadata
+  include Sufia::ModelMethods
+  include Sufia::Noid
+  include Sufia::GenericFile::Permissions
+  include CurationConcern::Embargoable
+  include CurationConcern::WithAccessRight
+
+  has_metadata name: "properties", type: PropertiesDatastream, control_group: 'M'
+  delegate_to :properties, [:relative_path, :depositor], unique: true
+
+  has_metadata name: "descMetadata", type: MockCurationConcern::MetadataDatastream, control_group: 'M'
+
+  delegate_to(
+    :descMetadata,
+    [
+      :title,
+      :date_uploaded,
+      :date_modified,
+      :creator,
+      :identifier,
+    ],
+    unique: true
+  )
+
+  has_many :generic_files, property: :is_part_of
+
+  after_destroy :after_destroy_cleanup
+  def after_destroy_cleanup
+    generic_files.each(&:destroy)
+  end
+
+  def human_readable_type
+    self.class.to_s.demodulize.titleize
+  end
+  def to_param
+    pid.split(':').last
+  end
+
+end

data/spec/support/shared/shared_examples_is_embargoable.rb

@@ -0,0 +1,9 @@
+require 'spec_helper'
+shared_examples 'is_embargoable' do
+
+  it "has an embargo_release_date attribute" do
+    expect(subject).to respond_to(:embargo_release_date)
+    expect(subject).to respond_to(:embargo_release_date=)
+  end
+
+end

data/spec/support/shared/shared_examples_with_access_rights.rb

@@ -0,0 +1,33 @@
+require 'spec_helper'
+shared_examples 'with_access_rights' do
+
+  it "has an under_embargo?" do
+    expect {
+      subject.under_embargo?
+    }.to_not raise_error(NoMethodError)
+  end
+
+  it "has a visibility attribute" do
+    expect(subject).to respond_to(:visibility)
+    expect(subject).to respond_to(:visibility=)
+  end
+
+  it "has an open_access?" do
+    expect {
+      subject.open_access?
+    }.to_not raise_error(NoMethodError)
+  end
+
+  it "has an authenticated_only_access?" do
+    expect {
+      subject.authenticated_only_access?
+    }.to_not raise_error(NoMethodError)
+  end
+
+  it "has an private_access?" do
+    expect {
+      subject.private_access?
+    }.to_not raise_error(NoMethodError)
+  end
+
+end

data/spec/workers/characterize_job_spec.rb

@@ -0,0 +1,26 @@
+require 'spec_helper'
+
+describe CharacterizeJob do
+
+  # I'm not entirely certain where I want to put this. Given that it is
+  # leaning on an actor, I'd like to put it there. But actors are going to
+  # push to a queue, so it is the worker that should choke.
+  describe '#run' do
+    let(:user) { FactoryGirl.create(:user) }
+    let(:curation_concern) {
+      MockCurationConcern.new.tap(&:save)
+    }
+    let(:generic_file) {
+      FactoryGirl.create_generic_file(curation_concern, user)
+    }
+    subject { CharacterizeJob.new(generic_file.pid) }
+
+    it 'deletes the generic file when I upload a virus' do
+      EnvironmentOverride.with_anti_virus_scanner(false) do
+        expect {
+          subject.run
+        }.to raise_error(AntiVirusScanner::VirusDetected)
+      end
+    end
+  end
+end