cuke_sniffer 0.0.1 → 0.0.2

data/lib/cuke_sniffer/step_definition.rb

@@ -1,116 +1,143 @@
-require 'cuke_sniffer/constants'
-require 'cuke_sniffer/rule_config'
-
-module CukeSniffer
-  class StepDefinition < RulesEvaluator
-    include CukeSniffer::Constants
-    include CukeSniffer::RuleConfig
-    
-    attr_accessor :start_line, :regex, :code, :parameters, :calls, :nested_steps
-
-    def initialize(location, raw_code)
-      super(location)
-
-      @parameters = []
-      @calls = {}
-      @nested_steps = {}
-      @start_line = location.match(/:(?<line>\d*)/)[:line].to_i
-
-      end_match_index = (raw_code.size - 1) - raw_code.reverse.index("end")
-      @code = raw_code[1...end_match_index]
-
-      raw_code.each do |line|
-        if line =~ STEP_DEFINITION_REGEX
-          matches = STEP_DEFINITION_REGEX.match(line)
-          @regex = Regexp.new(matches[:step])
-          @parameters = matches[:parameters].split(",") unless matches[:parameters].nil?
-        end
-      end
-
-      detect_nested_steps
-      evaluate_score
-    end
-
-    def add_call(location, step_string)
-      @calls[location] = step_string
-    end
-
-    def detect_nested_steps
-      multi_line_step_flag = false
-      counter = 1
-      @code.each do |line|
-        regex = nil
-        case line
-        when SIMPLE_NESTED_STEP_REGEX
-          regex = SIMPLE_NESTED_STEP_REGEX
-        when SAME_LINE_COMPLEX_STEP_REGEX
-          regex = SAME_LINE_COMPLEX_STEP_REGEX
-        when START_COMPLEX_WITH_STEP_REGEX
-          multi_line_step_flag = true
-          regex = START_COMPLEX_WITH_STEP_REGEX
-        when START_COMPLEX_STEP_REGEX
-          multi_line_step_flag = true
-        when END_COMPLEX_WITH_STEP_REGEX
-          regex = END_COMPLEX_WITH_STEP_REGEX
-          multi_line_step_flag = false
-        when STEP_REGEX
-          regex = STEP_REGEX if multi_line_step_flag
-        when END_COMPLEX_STEP_REGEX
-          multi_line_step_flag = false
-        else
-        end
-
-        if regex
-          match = regex.match(line)
-          nested_step_line = (@start_line + counter)
-          @nested_steps[location.gsub(/:\d*/, ":" + nested_step_line.to_s)] = match[:step_string]
-        end
-        counter += 1
-      end
-    end
-
-    def ==(comparison_object)
-      super(comparison_object)
-      comparison_object.regex == regex
-      comparison_object.code == code
-      comparison_object.parameters == parameters
-      comparison_object.calls == calls
-      comparison_object.nested_steps == nested_steps
-    end
-
-    def evaluate_score
-      super
-      rule_no_code
-      rule_too_many_parameters
-      rule_nested_steps
-      rule_recursive_nested_step
-      rule_commented_code
-    end
-
-    def rule_no_code
-      store_rule(STEP_DEFINITION_RULES[:no_code]) if code.empty?
-    end
-
-    def rule_too_many_parameters
-      rule = STEP_DEFINITION_RULES[:too_many_parameters]
-      store_rule(rule) if parameters.size >= rule[:max]
-    end
-
-    def rule_nested_steps
-      store_rule(STEP_DEFINITION_RULES[:nested_step]) unless nested_steps.empty?
-    end
-
-    def rule_recursive_nested_step
-      nested_steps.each_value do |nested_step|
-        store_rule(STEP_DEFINITION_RULES[:recursive_nested_step]) if nested_step =~ regex
-      end
-    end
-
-    def rule_commented_code
-      code.each do |line|
-        store_rule(STEP_DEFINITION_RULES[:commented_code]) if is_comment?(line)
-      end
-    end
-
-  end
-end
+module CukeSniffer
+  class StepDefinition < RulesEvaluator
+    include CukeSniffer::Constants
+    include CukeSniffer::RuleConfig
+
+    SIMPLE_NESTED_STEP_REGEX = /steps\s"#{STEP_STYLES}(?<step_string>.*)"$/
+    SAME_LINE_COMPLEX_STEP_REGEX = /^steps\s%Q?{#{STEP_STYLES}(?<step_string>.*)}$/
+    START_COMPLEX_STEP_REGEX = /^steps\s%Q?\{\s*/
+    END_COMPLEX_STEP_REGEX = /}$/
+    START_COMPLEX_WITH_STEP_REGEX = /steps\s%Q?\{#{STEP_STYLES}(?<step_string>.*)$/
+    END_COMPLEX_WITH_STEP_REGEX = /#{STEP_STYLES}(?<step_string>.*)}$/
+    attr_accessor :start_line, :regex, :code, :parameters, :calls, :nested_steps
+
+    def initialize(location, raw_code)
+      super(location)
+
+      @parameters = []
+      @calls = {}
+      @nested_steps = {}
+      @start_line = location.match(/:(?<line>\d*)/)[:line].to_i
+
+      end_match_index = (raw_code.size - 1) - raw_code.reverse.index("end")
+      @code = raw_code[1...end_match_index]
+
+      raw_code.each do |line|
+        if line =~ STEP_DEFINITION_REGEX
+          matches = STEP_DEFINITION_REGEX.match(line)
+          @regex = Regexp.new(matches[:step])
+          @parameters = matches[:parameters].split(",") unless matches[:parameters].nil?
+        end
+      end
+
+      detect_nested_steps
+      evaluate_score
+    end
+
+    def add_call(location, step_string)
+      @calls[location] = step_string
+    end
+
+    def detect_nested_steps
+      multi_line_step_flag = false
+      counter = 1
+      @code.each do |line|
+        regex = nil
+        case line
+          when SIMPLE_NESTED_STEP_REGEX
+            regex = SIMPLE_NESTED_STEP_REGEX
+          when SAME_LINE_COMPLEX_STEP_REGEX
+            regex = SAME_LINE_COMPLEX_STEP_REGEX
+          when START_COMPLEX_WITH_STEP_REGEX
+            multi_line_step_flag = true
+            regex = START_COMPLEX_WITH_STEP_REGEX
+          when START_COMPLEX_STEP_REGEX
+            multi_line_step_flag = true
+          when END_COMPLEX_WITH_STEP_REGEX
+            if line =~ /[#]{.*}$/ && multi_line_step_flag
+              regex = STEP_REGEX
+            else
+              regex = END_COMPLEX_WITH_STEP_REGEX
+              multi_line_step_flag = false
+            end
+          when STEP_REGEX
+            regex = STEP_REGEX if multi_line_step_flag
+          when END_COMPLEX_STEP_REGEX
+            multi_line_step_flag = false
+          else
+        end
+
+        if regex
+          index = 0
+          while line.include?('#{') and index <= line.length
+            index = line.index('#{')
+            replace_string = ""
+            while index <= line.length and line[index - 1] != "}"
+              replace_string << line[index]
+              index += 1
+            end
+            line.gsub!(replace_string, "variable")
+          end
+
+          match = regex.match(line)
+          nested_step_line = (@start_line + counter)
+          @nested_steps[location.gsub(/:\d*/, ":" + nested_step_line.to_s)] = match[:step_string]
+        end
+        counter += 1
+      end
+    end
+
+    def condensed_call_list
+      condensed_list = {}
+      @calls.each{|call, step_string|
+        condensed_list[step_string] ||= []
+        condensed_list[step_string] << call
+      }
+      condensed_list
+    end
+
+    def ==(comparison_object)
+      super(comparison_object)
+      comparison_object.regex == regex
+      comparison_object.code == code
+      comparison_object.parameters == parameters
+      comparison_object.calls == calls
+      comparison_object.nested_steps == nested_steps
+    end
+
+    def evaluate_score
+      super
+      rule_no_code
+      rule_too_many_parameters
+      rule_nested_steps
+      rule_recursive_nested_step
+      rule_commented_code
+    end
+
+    def rule_no_code
+      store_rule(STEP_DEFINITION_RULES[:no_code]) if code.empty?
+    end
+
+    def rule_too_many_parameters
+      rule = STEP_DEFINITION_RULES[:too_many_parameters]
+      store_rule(rule) if parameters.size >= rule[:max]
+    end
+
+    def rule_nested_steps
+      store_rule(STEP_DEFINITION_RULES[:nested_step]) unless nested_steps.empty?
+    end
+
+    def rule_recursive_nested_step
+      nested_steps.each_value do |nested_step|
+        store_rule(STEP_DEFINITION_RULES[:recursive_nested_step]) if nested_step =~ regex
+      end
+    end
+
+    def rule_commented_code
+      code.each do |line|
+        store_rule(STEP_DEFINITION_RULES[:commented_code]) if is_comment?(line)
+      end
+    end
+
+  end
+end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: cuke_sniffer
 version: !ruby/object:Gem::Version
-  version: 0.0.1
+  version: 0.0.2
   prerelease: 
 platform: ruby
 authors:
@@ -11,10 +11,10 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-01-15 00:00:00.000000000 Z
+date: 2013-02-15 00:00:00.000000000 Z
 dependencies: []
 description: A ruby library used to root out smells in your cukes.
-email: 
+email: ''
 executables:
 - cuke_sniffer.rb
 extensions: []
@@ -43,15 +43,21 @@ required_ruby_version: !ruby/object:Gem::Requirement
   - - ! '>='
     - !ruby/object:Gem::Version
       version: '0'
+      segments:
+      - 0
+      hash: -320967053
 required_rubygems_version: !ruby/object:Gem::Requirement
   none: false
   requirements:
   - - ! '>='
     - !ruby/object:Gem::Version
       version: '0'
+      segments:
+      - 0
+      hash: -320967053
 requirements: []
 rubyforge_project: 
-rubygems_version: 1.8.23
+rubygems_version: 1.8.24
 signing_key: 
 specification_version: 3
 summary: CukeSniffer