cuke_modeler 0.4.0 → 0.4.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 1b7765a28c904d7029be528292e466d45658e0d4
-  data.tar.gz: e9348d536a8e54578858e3e3ba1604f62494069b
+  metadata.gz: 414503e25b096ba139b0585a57db358e5874c263
+  data.tar.gz: c982a0ae8247c086de6a8af77fef5552bc744184
 SHA512:
-  metadata.gz: 43e9dafda2fd090bc707e3aa7af7b9522b9a2eb70e8769f00ed88c3b515724473dddcc7e881d31c62c2094ef4af9719faf2f2c5c79925b32647026a32fe5aa1d
-  data.tar.gz: 921be93201b8a2bc6aa4a22a77ce4aa177de988017db9885a802a1c535b02ca5952c972ec874fbb20284251d8cfeb035eb4404b46dd38295f1ed859e0bcc1d2c
+  metadata.gz: e3e67445b91027baa77694302656394837fce4e384cc213c4f1ba8127b5826a5d6d6c6105998030b1e429c7c71a26522df26e5cae044f0a1f62cf089aeaa7b9a
+  data.tar.gz: 499a61bbd3f475f9ad9cfb0f3f00903eaec01895b68eed7496c89404e2a1c8c4ef7fb8eda54deeaff9b49e1c8e0acc11d335fd0b54ea55c56711f55a7be034e2

data/History.rdoc

@@ -1,3 +1,9 @@
+=== Version 0.4.1 / 2016-05-12
+
+* Increased the flexibility of input when adding rows to an Example object.
+* Added some error checking around adding value rows to an Example object without adding a parameter row as well.
+
+
 === Version 0.4.0 / 2016-05-01
 
 * The path of a Directory object is now a changeable attribute instead of only being populated if the instance was

data/lib/cuke_modeler/example.rb

@@ -44,11 +44,22 @@ module CukeModeler
     # parameters and their corresponding values or as an Array of values which
     # will be assigned in order.
     def add_row(row)
+      raise('Cannot add a row. No parameters have been set.') if @parameters.empty?
+
+      # A quick 'deep clone' so that the input isn't modified
+      row = Marshal::load(Marshal.dump(row))
+
       case
         when row.is_a?(Array)
+          # 'stringify' input
+          row.collect! { |value| value.to_s }
+
           @rows << Hash[@parameters.zip(row.collect { |value| value.strip })]
           @row_elements << Row.new("|#{row.join('|')}|")
         when row.is_a?(Hash)
+          # 'stringify' input
+          row = row.inject({}) { |hash, (key, value)| hash[key.to_s] = value.to_s; hash }
+
           @rows << row.each_value { |value| value.strip! }
           @row_elements << Row.new("|#{ordered_row_values(row).join('|')}|")
         else

data/lib/cuke_modeler/version.rb

@@ -1,3 +1,3 @@
 module CukeModeler
-  VERSION = "0.4.0"
+  VERSION = "0.4.1"
 end

data/spec/unit/example_unit_spec.rb

@@ -173,7 +173,7 @@ describe 'Example, Unit' do
         clazz.new.should respond_to(:add_row)
       end
 
-      it 'can add a new row as a hash' do
+      it 'can add a new row as a hash, string values' do
         source = "Examples:\n|param1|param2|\n|value1|value2|"
         example = clazz.new(source)
 
@@ -185,7 +185,19 @@ describe 'Example, Unit' do
         example.row_elements.collect { |row| row.cells }[1..example.row_elements.count].should == [['value1', 'value2'], ['value3', 'value4']]
       end
 
-      it 'can add a new row as an array' do
+      it 'can add a new row as a hash, non-string values' do
+        source = "Examples:\n|param1|param2|\n|value1|value2|"
+        example = clazz.new(source)
+
+        new_row = {:param1 => 'value3', 'param2' => 4}
+        example.add_row(new_row)
+
+        #todo - remove once Hash rows are no longer supported
+        example.rows.should == [{'param1' => 'value1', 'param2' => 'value2'}, {'param1' => 'value3', 'param2' => '4'}]
+        example.row_elements.collect { |row| row.cells }[1..example.row_elements.count].should == [['value1', 'value2'], ['value3', '4']]
+      end
+
+      it 'can add a new row as an array, string values' do
         source = "Examples:\n|param1|param2|\n|value1|value2|"
         example = clazz.new(source)
 
@@ -197,7 +209,22 @@ describe 'Example, Unit' do
         example.row_elements.collect { |row| row.cells }[1..example.row_elements.count].should == [['value1', 'value2'], ['value3', 'value4']]
       end
 
+      it 'can add a new row as an array, non-string values' do
+        source = "Examples:\n|param1|param2|param3|\n|value1|value2|value3|"
+        example = clazz.new(source)
+
+        new_row = [:value4, 5, 'value6']
+        example.add_row(new_row)
+
+        #todo - remove once Hash rows are no longer supported
+        example.rows.should == [{'param1' => 'value1', 'param2' => 'value2', 'param3' => 'value3'}, {'param1' => 'value4', 'param2' => '5', 'param3' => 'value6'}]
+        example.row_elements.collect { |row| row.cells }[1..example.row_elements.count].should == [['value1', 'value2', 'value3'], ['value4', '5', 'value6']]
+      end
+
       it 'can only use a Hash or an Array to add a new row' do
+        source = "Examples:\n|param|\n|value|"
+        example = clazz.new(source)
+
         expect { example.add_row({}) }.to_not raise_error
         expect { example.add_row([]) }.to_not raise_error
         expect { example.add_row(:a_row) }.to raise_error(ArgumentError)
@@ -216,6 +243,31 @@ describe 'Example, Unit' do
         example.rows.should == [{'param1' => 'value1', 'param2' => 'value2'}, {'param1' => 'value3', 'param2' => 'value4'}, {'param1' => 'value5', 'param2' => 'value6'}]
         example.row_elements.collect { |row| row.cells }[1..example.row_elements.count].should == [['value1', 'value2'], ['value3', 'value4'], ['value5', 'value6']]
       end
+
+      #todo - remove once Hash rows are no longer supported
+      it 'will complain if a row is added and no parameters have been set' do
+        example = clazz.new
+        example.parameters = []
+
+        new_row = ['value1', 'value2']
+        expect { example.add_row(new_row) }.to raise_error('Cannot add a row. No parameters have been set.')
+
+        new_row = {'param1' => 'value1', 'param2' => 'value2'}
+        expect { example.add_row(new_row) }.to raise_error('Cannot add a row. No parameters have been set.')
+      end
+
+      #todo - remove once Hash rows are no longer supported
+      it 'does not modify its row input' do
+        source = "Examples:\n|param1|param2|\n|value1|value2|"
+        example = clazz.new(source)
+
+        new_row = ['value1'.freeze, 'value2'.freeze].freeze
+        expect { example.add_row(new_row) }.to_not raise_error
+
+        new_row = {'param1'.freeze => 'value1'.freeze, 'param2'.freeze => 'value2'.freeze}.freeze
+        expect { example.add_row(new_row) }.to_not raise_error
+      end
+
     end
 
     describe '#remove_row' do

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: cuke_modeler
 version: !ruby/object:Gem::Version
-  version: 0.4.0
+  version: 0.4.1
 platform: ruby
 authors:
 - Eric Kessler
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-05-02 00:00:00.000000000 Z
+date: 2016-05-12 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: gherkin