cuke_linter 1.0.0 → 1.0.1

data/lib/cuke_linter/linters/step_with_too_many_characters_linter.rb

@@ -15,8 +15,8 @@ module CukeLinter
     # The rule used to determine if a model has a problem
     def rule(model)
       return false unless model.is_a?(CukeModeler::Step)
-        
-      @linted_step_length = model.text&.length || 0
+
+      @linted_step_length = model.text.nil? ? 0 : model.text.length
 
       @linted_step_length > step_length_threshold
     end

data/lib/cuke_linter/linters/test_should_use_background_linter.rb

@@ -14,40 +14,48 @@ module CukeLinter
 
       return false unless parent_feature_model.tests.count > 1
 
-      matching_steps = parent_feature_model.tests.all? do |test|
+      matching_steps     = all_first_steps_match?(parent_feature_model, model_steps)
+      none_parameterized = no_parameterized_steps?(parent_feature_model)
+
+      matching_steps && none_parameterized
+    end
+
+    # The message used to describe the problem that has been found
+    def message
+      'Test shares steps with all other tests in feature. Use a background.'
+    end
+
+
+    private
+
+
+    def all_first_steps_match?(feature_model, model_steps)
+      feature_model.tests.all? do |test|
         test_steps = test.steps || []
         test_steps.first == model_steps.first
       end
+    end
 
-      none_parameterized = parent_feature_model.tests.none? do |test|
+    def no_parameterized_steps?(feature_model)
+      feature_model.tests.none? do |test|
         next false if test.is_a?(CukeModeler::Scenario)
 
         test_steps          = test.steps || []
         params_used_by_test = test.examples.map(&:parameters).flatten.uniq
 
         next false unless test_steps.any?
+
         parameterized_step?(test_steps.first, parameters: params_used_by_test)
       end
-
-      matching_steps && none_parameterized
     end
 
-    # The message used to describe the problem that has been found
-    def message
-      'Test shares steps with all other tests in feature. Use a background.'
-    end
-
-
-    private
-
-
     def parameterized_step?(step_model, parameters:)
       parameters.any? do |parameter|
         parameter_string = "<#{parameter}>"
 
         parameterized_text?(step_model, parameter_string) ||
-            parameterized_doc_string?(step_model, parameter_string) ||
-            parameterized_table?(step_model, parameter_string)
+          parameterized_doc_string?(step_model, parameter_string) ||
+          parameterized_table?(step_model, parameter_string)
       end
     end
 

data/lib/cuke_linter/linters/test_with_bad_name_linter.rb

@@ -9,10 +9,10 @@ module CukeLinter
       return false unless model.is_a?(CukeModeler::Scenario) || model.is_a?(CukeModeler::Outline)
 
       lowercase_name = model.name.downcase
-      return true if lowercase_name.include?('test') ||
-                     lowercase_name.include?('verif') ||
-                     lowercase_name.include?('check')
-      false
+
+      lowercase_name.include?('test') ||
+        lowercase_name.include?('verif') ||
+        lowercase_name.include?('check')
     end
 
     # The message used to describe the problem that has been found

data/lib/cuke_linter/linters/test_with_setup_step_as_final_step_linter.rb

@@ -27,7 +27,7 @@ module CukeLinter
     private
 
     def given_keywords
-       @given_keywords || [DEFAULT_GIVEN_KEYWORD]
+      @given_keywords || [DEFAULT_GIVEN_KEYWORD]
     end
 
   end

data/lib/cuke_linter/version.rb

@@ -1,4 +1,4 @@
 module CukeLinter
   # The release version of this gem
-  VERSION = '1.0.0'
+  VERSION = '1.0.1'.freeze
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: cuke_linter
 version: !ruby/object:Gem::Version
-  version: 1.0.0
+  version: 1.0.1
 platform: ruby
 authors:
 - Eric Kessler
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2020-03-09 00:00:00.000000000 Z
+date: 2020-05-06 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: cuke_modeler
@@ -44,6 +44,34 @@ dependencies:
     - - "<"
       - !ruby/object:Gem::Version
         version: '3.0'
+- !ruby/object:Gem::Dependency
+  name: childprocess
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '3.0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '3.0'
+- !ruby/object:Gem::Dependency
+  name: coveralls
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: 1.0.0
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: 1.0.0
 - !ruby/object:Gem::Dependency
   name: cucumber
   requirement: !ruby/object:Gem::Requirement
@@ -59,7 +87,27 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '3.0'
 - !ruby/object:Gem::Dependency
-  name: racatt
+  name: cuke_slicer
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 2.0.2
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: '3.0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 2.0.2
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: '3.0'
+- !ruby/object:Gem::Dependency
+  name: ffi
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
@@ -72,6 +120,34 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '1.0'
+- !ruby/object:Gem::Dependency
+  name: parallel
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '1.0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '1.0'
+- !ruby/object:Gem::Dependency
+  name: rainbow
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: 4.0.0
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: 4.0.0
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
@@ -115,7 +191,7 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '3.0'
 - !ruby/object:Gem::Dependency
-  name: simplecov
+  name: rubocop
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "<"
@@ -129,7 +205,7 @@ dependencies:
       - !ruby/object:Gem::Version
         version: 1.0.0
 - !ruby/object:Gem::Dependency
-  name: coveralls
+  name: simplecov
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "<"
@@ -142,20 +218,6 @@ dependencies:
     - - "<"
       - !ruby/object:Gem::Version
         version: 1.0.0
-- !ruby/object:Gem::Dependency
-  name: rainbow
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "<"
-      - !ruby/object:Gem::Version
-        version: 4.0.0
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "<"
-      - !ruby/object:Gem::Version
-        version: 4.0.0
 description: 
 email:
 - morrow748@gmail.com
@@ -170,7 +232,11 @@ files:
 - cuke_linter.gemspec
 - exe/cuke_linter
 - lib/cuke_linter.rb
+- lib/cuke_linter/configuration.rb
+- lib/cuke_linter/default_linters.rb
 - lib/cuke_linter/formatters/pretty_formatter.rb
+- lib/cuke_linter/gherkin.rb
+- lib/cuke_linter/linter_registration.rb
 - lib/cuke_linter/linters/background_does_more_than_setup_linter.rb
 - lib/cuke_linter/linters/element_with_common_tags_linter.rb
 - lib/cuke_linter/linters/element_with_duplicate_tags_linter.rb