cuke_linter 0.6.0 → 0.7.0

data/testing/rspec/spec/unit/linters/test_with_no_verification_step_linter_unit_spec.rb

@@ -0,0 +1,217 @@
+require_relative '../../../../../environments/rspec_env'
+
+
+RSpec.describe CukeLinter::TestWithNoVerificationStepLinter do
+
+  let(:good_data) do
+    CukeLinter::ModelFactory.generate_scenario_model(source_text: 'Scenario:
+                                                                     Then a verification step')
+  end
+
+  let(:bad_data) do
+    CukeLinter::ModelFactory.generate_scenario_model(source_text: 'Scenario:
+                                                                     * no verification step')
+  end
+
+
+  it_should_behave_like 'a linter at the unit level'
+
+
+  it 'has a name' do
+    expect(subject.name).to eq('TestWithNoVerificationStepLinter')
+  end
+
+  describe 'linting' do
+
+    ['scenario', 'outline'].each do |model_type|
+
+      context "with a #{model_type} that has no verification step" do
+
+        context 'because it has no steps' do
+
+          context 'because its steps are empty' do
+
+            let(:test_model) do
+              model       = CukeLinter::ModelFactory.send("generate_#{model_type}_model", parent_file_path: 'path_to_file')
+              model.steps = []
+
+              model
+            end
+
+            it 'records a problem' do
+              result = subject.lint(test_model)
+
+              expect(result[:problem]).to eq("Test does not have a 'Then' step.")
+            end
+
+            it 'records the location of the problem' do
+              test_model.source_line = 1
+              result                 = subject.lint(test_model)
+              expect(result[:location]).to eq('path_to_file:1')
+
+              test_model.source_line = 3
+              result                 = subject.lint(test_model)
+              expect(result[:location]).to eq('path_to_file:3')
+            end
+
+          end
+
+          context 'because its steps are nil' do
+
+            let(:test_model) do
+              model       = CukeLinter::ModelFactory.send("generate_#{model_type}_model", parent_file_path: 'path_to_file')
+              model.steps = nil
+
+              model
+            end
+
+            it 'records a problem' do
+              result = subject.lint(test_model)
+
+              expect(result[:problem]).to eq("Test does not have a 'Then' step.")
+            end
+
+            it 'records the location of the problem' do
+              test_model.source_line = 1
+              result                 = subject.lint(test_model)
+              expect(result[:location]).to eq('path_to_file:1')
+
+              test_model.source_line = 3
+              result                 = subject.lint(test_model)
+              expect(result[:location]).to eq('path_to_file:3')
+            end
+
+          end
+
+        end
+
+        context 'because none of its steps is a verification step' do
+
+          let(:test_model) do
+            model       = CukeLinter::ModelFactory.send("generate_#{model_type}_model", parent_file_path: 'path_to_file')
+            model.steps = [CukeModeler::Step.new('* not a verification step')]
+
+            model
+          end
+
+          it 'records a problem' do
+            result = subject.lint(test_model)
+
+            expect(result[:problem]).to eq("Test does not have a 'Then' step.")
+          end
+
+          it 'records the location of the problem' do
+            test_model.source_line = 1
+            result                 = subject.lint(test_model)
+            expect(result[:location]).to eq('path_to_file:1')
+
+            test_model.source_line = 3
+            result                 = subject.lint(test_model)
+            expect(result[:location]).to eq('path_to_file:3')
+          end
+
+        end
+
+      end
+
+      context "with a #{model_type} that does have a verification step" do
+
+        context 'that comes from its background' do
+
+          let(:test_model) do
+            model                         = CukeLinter::ModelFactory.send("generate_#{model_type}_model")
+            model.steps                   = []
+            background_model              = CukeModeler::Background.new
+            background_model.steps        = [CukeModeler::Step.new('Then a verification step')]
+            model.parent_model.background = background_model
+
+            model
+          end
+
+          it 'does not record a problem' do
+            expect(subject.lint(test_model)).to eq(nil)
+          end
+
+        end
+
+        context 'that is part of itself' do
+
+          let(:test_model) do
+            model       = CukeLinter::ModelFactory.send("generate_#{model_type}_model")
+            model.steps = [CukeModeler::Step.new('Then a verification step')]
+
+            model
+          end
+
+          it 'does not record a problem' do
+            expect(subject.lint(test_model)).to eq(nil)
+          end
+
+        end
+
+      end
+
+    end
+
+    ['scenario', 'outline'].each do |model_type|
+
+      context "with a #{model_type} that has a related background" do
+
+        let(:test_model) do
+          model                         = CukeLinter::ModelFactory.send("generate_#{model_type}_model")
+          model.parent_model.background = background_model
+
+          model
+        end
+
+        context 'that has no background steps' do
+          context 'because its steps are empty' do
+
+            let(:background_model) do
+              model       = CukeModeler::Background.new
+              model.steps = []
+
+              model
+            end
+
+            it 'can handle it' do
+              expect { subject.lint(test_model) }.to_not raise_error
+            end
+
+          end
+
+          context 'because its steps are nil' do
+
+            let(:background_model) do
+              model       = CukeModeler::Background.new
+              model.steps = nil
+
+              model
+            end
+
+            it 'can handle it' do
+              expect { subject.lint(test_model) }.to_not raise_error
+            end
+
+          end
+
+        end
+
+      end
+
+    end
+
+
+    context 'a non-test model' do
+
+      let(:test_model) { CukeModeler::Model.new }
+
+      it 'returns no result' do
+        result = subject.lint(test_model)
+
+        expect(result).to eq(nil)
+      end
+
+    end
+  end
+end

data/testing/rspec/spec/unit/linters/test_with_too_many_steps_linter_unit_spec.rb

@@ -78,11 +78,11 @@ RSpec.describe CukeLinter::TestWithTooManyStepsLinter do
         it 'includes the number of steps found in the problem record' do
           step_count = test_model.steps.count
           result     = subject.lint(test_model)
-          expect(result[:problem]).to eq("Test has too many steps. #{step_count} steps found (max 10)")
+          expect(result[:problem]).to eq("Test has too many steps. #{step_count} steps found (max 10).")
 
           test_model.steps << :another_step
           result = subject.lint(test_model)
-          expect(result[:problem]).to eq("Test has too many steps. #{step_count + 1} steps found (max 10)")
+          expect(result[:problem]).to eq("Test has too many steps. #{step_count + 1} steps found (max 10).")
         end
 
       end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: cuke_linter
 version: !ruby/object:Gem::Version
-  version: 0.6.0
+  version: 0.7.0
 platform: ruby
 authors:
 - Eric Kessler
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2019-06-25 00:00:00.000000000 Z
+date: 2019-07-12 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: cuke_modeler
@@ -177,30 +177,40 @@ files:
 - lib/cuke_linter.rb
 - lib/cuke_linter/formatters/pretty_formatter.rb
 - lib/cuke_linter/linters/background_does_more_than_setup_linter.rb
+- lib/cuke_linter/linters/element_with_too_many_tags_linter.rb
 - lib/cuke_linter/linters/example_without_name_linter.rb
 - lib/cuke_linter/linters/feature_without_description_linter.rb
+- lib/cuke_linter/linters/feature_without_name_linter.rb
 - lib/cuke_linter/linters/feature_without_scenarios_linter.rb
 - lib/cuke_linter/linters/linter.rb
 - lib/cuke_linter/linters/outline_with_single_example_row_linter.rb
 - lib/cuke_linter/linters/single_test_background_linter.rb
 - lib/cuke_linter/linters/step_with_end_period_linter.rb
 - lib/cuke_linter/linters/step_with_too_many_characters_linter.rb
+- lib/cuke_linter/linters/test_with_no_action_step_linter.rb
+- lib/cuke_linter/linters/test_with_no_name_linter.rb
+- lib/cuke_linter/linters/test_with_no_verification_step_linter.rb
 - lib/cuke_linter/linters/test_with_too_many_steps_linter.rb
 - lib/cuke_linter/version.rb
 - testing/cucumber/features/command_line.feature
 - testing/cucumber/features/configuration/configuring_linters.feature
 - testing/cucumber/features/configuration/using_configurations.feature
 - testing/cucumber/features/formatters/pretty_formatter.feature
-- testing/cucumber/features/linters/background_does_more_than_setup_linter.feature
+- testing/cucumber/features/linters/background_does_more_than_setup.feature
 - testing/cucumber/features/linters/custom_linters.feature
 - testing/cucumber/features/linters/default_linters.feature
+- testing/cucumber/features/linters/element_with_too_many_tags.feature
 - testing/cucumber/features/linters/example_without_name.feature
 - testing/cucumber/features/linters/feature_without_description.feature
+- testing/cucumber/features/linters/feature_without_name.feature
 - testing/cucumber/features/linters/feature_without_scenarios.feature
 - testing/cucumber/features/linters/outline_with_single_example_row.feature
-- testing/cucumber/features/linters/single_test_background_linter.feature
+- testing/cucumber/features/linters/single_test_background.feature
 - testing/cucumber/features/linters/step_too_long.feature
 - testing/cucumber/features/linters/step_with_end_period.feature
+- testing/cucumber/features/linters/test_with_no_action_step.feature
+- testing/cucumber/features/linters/test_with_no_name.feature
+- testing/cucumber/features/linters/test_with_no_verification_step.feature
 - testing/cucumber/features/linters/test_with_too_many_steps.feature
 - testing/cucumber/step_definitions/action_steps.rb
 - testing/cucumber/step_definitions/setup_steps.rb
@@ -214,8 +224,10 @@ files:
 - testing/rspec/spec/integration/formatters/formatter_integration_specs.rb
 - testing/rspec/spec/integration/formatters/pretty_formatter_integration_spec.rb
 - testing/rspec/spec/integration/linters/background_does_more_than_setup_linter_integration_spec.rb
+- testing/rspec/spec/integration/linters/element_with_too_many_tags_linter_integration_spec.rb
 - testing/rspec/spec/integration/linters/example_without_name_linter_integration_spec.rb
 - testing/rspec/spec/integration/linters/feature_without_description_linter_integration_spec.rb
+- testing/rspec/spec/integration/linters/feature_without_name_linter_integration_spec.rb
 - testing/rspec/spec/integration/linters/feature_without_scenarios_linter_integration_spec.rb
 - testing/rspec/spec/integration/linters/linter_integration_spec.rb
 - testing/rspec/spec/integration/linters/linter_integration_specs.rb
@@ -223,14 +235,19 @@ files:
 - testing/rspec/spec/integration/linters/single_test_background_linter_integration_spec.rb
 - testing/rspec/spec/integration/linters/step_with_end_period_linter_integration_spec.rb
 - testing/rspec/spec/integration/linters/step_with_too_many_characters_linter_integration_spec.rb
+- testing/rspec/spec/integration/linters/test_with_no_action_step_integration_spec.rb
+- testing/rspec/spec/integration/linters/test_with_no_name_integration_spec.rb
+- testing/rspec/spec/integration/linters/test_with_no_verification_step_integration_spec.rb
 - testing/rspec/spec/integration/linters/test_with_too_many_steps_linter_integration_spec.rb
 - testing/rspec/spec/unit/cuke_linter_unit_spec.rb
 - testing/rspec/spec/unit/formatters/formatter_unit_specs.rb
 - testing/rspec/spec/unit/formatters/pretty_formatter_unit_spec.rb
 - testing/rspec/spec/unit/linters/background_does_more_than_setup_linter_unit_spec.rb
 - testing/rspec/spec/unit/linters/configurable_linter_unit_specs.rb
+- testing/rspec/spec/unit/linters/element_with_too_many_tags_linter_unit_spec.rb
 - testing/rspec/spec/unit/linters/example_without_name_linter_unit_spec.rb
 - testing/rspec/spec/unit/linters/feature_without_description_linter_unit_spec.rb
+- testing/rspec/spec/unit/linters/feature_without_name_linter_unit_spec.rb
 - testing/rspec/spec/unit/linters/feature_without_scenarios_linter_unit_spec.rb
 - testing/rspec/spec/unit/linters/linter_unit_spec.rb
 - testing/rspec/spec/unit/linters/linter_unit_specs.rb
@@ -238,6 +255,9 @@ files:
 - testing/rspec/spec/unit/linters/single_test_background_linter_unit_spec.rb
 - testing/rspec/spec/unit/linters/step_with_end_period_linter_unit_spec.rb
 - testing/rspec/spec/unit/linters/step_with_too_many_characters_linter_unit_spec.rb
+- testing/rspec/spec/unit/linters/test_with_no_action_step_linter_unit_spec.rb
+- testing/rspec/spec/unit/linters/test_with_no_name_linter_unit_spec.rb
+- testing/rspec/spec/unit/linters/test_with_no_verification_step_linter_unit_spec.rb
 - testing/rspec/spec/unit/linters/test_with_too_many_steps_linter_unit_spec.rb
 homepage: https://github.com/enkessler/cuke_linter
 licenses: