cuke_linter 0.12.1 → 1.2.0

data/testing/rspec/spec/unit/linters/linter_unit_specs.rb

@@ -1,57 +0,0 @@
-shared_examples_for 'a linter at the unit level' do
-
-  it 'is named' do
-    expect(subject).to respond_to(:name)
-    expect(subject.name).to be_a_kind_of(String)
-    expect(subject.name).to_not be_empty
-  end
-
-  it 'can lint' do
-    expect(subject).to respond_to(:lint)
-  end
-
-  it 'lints a model' do
-    expect(subject.method(:lint).arity).to eq(1)
-  end
-
-end
-
-
-shared_examples_for 'a linter linting a good model' do
-
-  it 'returns no problem' do
-    expect(subject.lint(test_model)).to be_nil
-  end
-
-end
-
-
-shared_examples_for 'a linter linting a bad model' do
-
-  it 'returns a detected problem' do
-    expect(subject.lint(test_model)).to_not be_nil
-  end
-
-  it 'includes the problem and its location in its result' do
-    result = subject.lint(test_model)
-
-    expect(result).to_not be_nil
-    expect(result.keys).to match_array([:problem, :location])
-  end
-
-  it 'correctly records the location of the problem' do
-    if test_model.is_a?(CukeModeler::FeatureFile)
-      result                 = subject.lint(test_model)
-      expect(result[:location]).to eq("#{model_file_path}")
-    else
-      test_model.source_line = 1
-      result                 = subject.lint(test_model)
-      expect(result[:location]).to eq("#{model_file_path}:1")
-
-      test_model.source_line = 3
-      result                 = subject.lint(test_model)
-      expect(result[:location]).to eq("#{model_file_path}:3")
-    end
-  end
-
-end

data/testing/rspec/spec/unit/linters/outline_with_single_example_row_linter_unit_spec.rb

@@ -1,184 +0,0 @@
-require_relative '../../../../../environments/rspec_env'
-
-
-RSpec.describe CukeLinter::OutlineWithSingleExampleRowLinter do
-
-  let(:model_file_path) { 'some_file_path' }
-
-  it_should_behave_like 'a linter at the unit level'
-
-
-  it 'has a name' do
-    expect(subject.name).to eq('OutlineWithSingleExampleRowLinter')
-  end
-
-  describe 'linting' do
-
-    context 'an outline with only one example row' do
-
-      context 'with only one example set' do
-
-        let(:test_model) do
-          gherkin = 'Scenario Outline:
-                       * a step
-                     Examples:
-                       | param |
-                       | value |'
-
-          CukeLinter::ModelFactory.generate_outline_model(parent_file_path: model_file_path,
-                                                          source_text:      gherkin)
-        end
-
-        it_should_behave_like 'a linter linting a bad model'
-
-
-        it 'records a problem' do
-          result = subject.lint(test_model)
-
-          expect(result[:problem]).to eq('Outline has only one example row')
-        end
-
-      end
-
-      context 'with multiple example sets' do
-
-        let(:test_model) do
-          gherkin = 'Scenario Outline:
-                       * a step
-                     Examples:
-                       | param |
-                     Examples:
-                       | param |
-                       | value |'
-
-          CukeLinter::ModelFactory.generate_outline_model(parent_file_path: model_file_path,
-                                                          source_text:      gherkin)
-        end
-
-        it_should_behave_like 'a linter linting a bad model'
-
-
-        it 'records a problem' do
-          result = subject.lint(test_model)
-
-          expect(result[:problem]).to eq('Outline has only one example row')
-        end
-
-      end
-
-    end
-
-    context 'an outline with more than one example row' do
-
-      context 'with only one example set' do
-
-        let(:test_model) do
-          gherkin = 'Scenario Outline:
-                       * a step
-                     Examples:
-                       | param   |
-                       | value 1 |
-                       | value 2 |'
-
-          CukeLinter::ModelFactory.generate_outline_model(source_text: gherkin)
-        end
-
-        it_should_behave_like 'a linter linting a good model'
-
-      end
-
-      context 'with multiple example sets' do
-
-        let(:test_model) do
-          gherkin = 'Scenario Outline:
-                       * a step
-                     Examples:
-                       | param   |
-                       | value 1 |
-                     Examples:
-                       | param   |
-                       | value 1 |'
-
-          CukeLinter::ModelFactory.generate_outline_model(source_text: gherkin)
-        end
-
-        it_should_behave_like 'a linter linting a good model'
-
-      end
-
-    end
-
-    context 'an outline with no example rows' do
-
-      context 'because it has no example sets' do
-
-        context 'because its examples are nil' do
-
-          let(:test_model) do
-            model          = CukeLinter::ModelFactory.generate_outline_model
-            model.examples = nil
-
-            model
-          end
-
-          it_should_behave_like 'a linter linting a good model'
-
-        end
-
-        context 'because its examples are empty' do
-          let(:test_model) do
-            model          = CukeLinter::ModelFactory.generate_outline_model
-            model.examples = []
-
-            model
-          end
-
-          it_should_behave_like 'a linter linting a good model'
-
-        end
-
-      end
-
-      context 'with only one example set' do
-
-        let(:test_model) do
-          gherkin = 'Scenario Outline:
-                       * a step
-                     Examples:
-                       | param |'
-
-          CukeLinter::ModelFactory.generate_outline_model(source_text: gherkin)
-        end
-
-        it_should_behave_like 'a linter linting a good model'
-
-      end
-
-      context 'with multiple example sets' do
-
-        let(:test_model) do
-          gherkin = 'Scenario Outline:
-                       * a step
-                     Examples:
-                       | param |
-                     Examples:
-                       | param |'
-
-          CukeLinter::ModelFactory.generate_outline_model(source_text: gherkin)
-        end
-
-        it_should_behave_like 'a linter linting a good model'
-
-      end
-
-    end
-
-    context 'a non-outline model' do
-
-      let(:test_model) { CukeModeler::Model.new }
-
-      it_should_behave_like 'a linter linting a good model'
-
-    end
-  end
-end

data/testing/rspec/spec/unit/linters/single_test_background_linter_unit_spec.rb

@@ -1,89 +0,0 @@
-require_relative '../../../../../environments/rspec_env'
-
-
-RSpec.describe CukeLinter::SingleTestBackgroundLinter do
-
-  let(:model_file_path) { 'some_file_path' }
-
-  it_should_behave_like 'a linter at the unit level'
-
-
-  it 'has a name' do
-    expect(subject.name).to eq('SingleTestBackgroundLinter')
-  end
-
-  describe 'linting' do
-
-    context 'with a background that affects only one test' do
-
-      ['scenario', 'outline'].each do |model_type|
-
-        context "and that test is a #{model_type}" do
-
-          let(:test_model) do
-            background_model = CukeLinter::ModelFactory.generate_feature_model(parent_file_path: model_file_path,
-                                                                               source_text:      'Feature:
-                                                                                                    Background:
-                                                                                                      * a step').background
-
-            background_model.parent_model.tests.clear
-            background_model.parent_model.tests << CukeLinter::ModelFactory.send("generate_#{model_type}_model")
-
-            background_model
-          end
-
-          it_should_behave_like 'a linter linting a bad model'
-
-
-          it 'records a problem' do
-            result = subject.lint(test_model)
-
-            expect(result[:problem]).to match('Background used with only one test')
-          end
-
-        end
-
-      end
-
-    end
-
-    context 'with a background that affects multiple tests' do
-
-      let(:test_model) do
-        CukeLinter::ModelFactory.generate_feature_model(source_text: 'Feature:
-                                                                        Background:
-                                                                          * a step
-                                                                        Scenario:
-                                                                        Scenario Outline:
-                                                                          * a step
-                                                                        Examples:
-                                                                          |param|
-                                                                          |value|').background
-      end
-
-      it_should_behave_like 'a linter linting a good model'
-
-    end
-
-    context 'with a background that affects no tests' do
-
-      let(:test_model) do
-        CukeLinter::ModelFactory.generate_feature_model(source_text: 'Feature:
-                                                                        Background:
-                                                                          * a step').background
-      end
-
-      it_should_behave_like 'a linter linting a good model'
-
-    end
-
-    context 'with a non-background model' do
-
-      let(:test_model) { CukeModeler::Model.new }
-
-      it_should_behave_like 'a linter linting a good model'
-
-    end
-
-  end
-end

data/testing/rspec/spec/unit/linters/step_with_end_period_linter_unit_spec.rb

@@ -1,54 +0,0 @@
-require_relative '../../../../../environments/rspec_env'
-
-
-RSpec.describe CukeLinter::StepWithEndPeriodLinter do
-
-  let(:model_file_path) { 'some_file_path' }
-
-  it_should_behave_like 'a linter at the unit level'
-
-
-  it 'has a name' do
-    expect(subject.name).to eq('StepWithEndPeriodLinter')
-  end
-
-  describe 'linting' do
-
-    context "with a step that ends with a period" do
-
-      let(:test_model) do
-        CukeLinter::ModelFactory.generate_step_model(parent_file_path: model_file_path,
-                                                     source_text:      '* with a period.')
-      end
-
-      it_should_behave_like 'a linter linting a bad model'
-
-
-      it 'records a problem' do
-        result = subject.lint(test_model)
-
-        expect(result[:problem]).to match('Step ends with a period')
-      end
-
-    end
-
-    context "with a step that does not end with a period" do
-
-      let(:test_model) do
-        CukeLinter::ModelFactory.generate_step_model(source_text: '* without a period')
-      end
-
-      it_should_behave_like 'a linter linting a good model'
-
-    end
-
-    context 'with a non-step model' do
-
-      let(:test_model) { CukeModeler::Model.new }
-
-      it_should_behave_like 'a linter linting a good model'
-
-    end
-
-  end
-end

data/testing/rspec/spec/unit/linters/step_with_too_many_characters_linter_unit_spec.rb

@@ -1,155 +0,0 @@
-require_relative '../../../../../environments/rspec_env'
-
-
-RSpec.describe CukeLinter::StepWithTooManyCharactersLinter do
-
-  let(:model_file_path) { 'some_file_path' }
-
-  it_should_behave_like 'a linter at the unit level'
-  it_should_behave_like 'a configurable linter at the unit level'
-
-
-  it 'has a name' do
-    expect(subject.name).to eq('StepWithTooManyCharactersLinter')
-  end
-
-  describe 'linting' do
-
-    let(:default_character_threshold) { 80 }
-
-    context 'when the step is too long' do
-
-      let(:test_model) do
-        step = 'x' * (default_character_threshold + 1)
-        CukeLinter::ModelFactory.generate_step_model(parent_file_path: model_file_path,
-                                                     source_text:      "* #{step}")
-      end
-
-      it_should_behave_like 'a linter linting a bad model'
-
-
-      it 'reports a problem' do
-        result = subject.lint(test_model)
-
-        expect(result[:problem]).to match(/^Step is too long. \d+ characters found \(max 80\)/)
-      end
-
-      it 'includes the number of characters found in the problem record' do
-        character_count = test_model.text.length
-        result          = subject.lint(test_model)
-        expect(result[:problem]).to eq("Step is too long. #{character_count} characters found (max 80)")
-
-        test_model.text += 'x'
-        result          = subject.lint(test_model)
-        expect(result[:problem]).to eq("Step is too long. #{character_count + 1} characters found (max 80)")
-      end
-
-    end
-
-    context 'when the step is the maximum length' do
-
-      let(:test_model) do
-        step = 'x' * default_character_threshold
-        CukeLinter::ModelFactory.generate_step_model(source_text: "* #{step}")
-      end
-
-      it_should_behave_like 'a linter linting a good model'
-
-    end
-
-    context 'when the step is below the maximum length' do
-
-      let(:test_model) do
-        step = 'x' * (default_character_threshold - 1)
-        CukeLinter::ModelFactory.generate_step_model(source_text: "* #{step}")
-      end
-
-      it_should_behave_like 'a linter linting a good model'
-
-    end
-
-    context 'when the step has no text' do
-
-      let(:test_model) do
-        model      = CukeLinter::ModelFactory.generate_step_model
-        model.text = nil
-
-        model
-      end
-
-      it_should_behave_like 'a linter linting a good model'
-
-    end
-
-    context 'a non-step model' do
-
-      let(:test_model) { CukeModeler::Model.new }
-
-      it_should_behave_like 'a linter linting a good model'
-
-    end
-
-  end
-
-  describe 'configuration' do
-
-    context 'with no configuration' do
-
-      let(:default_character_threshold) { 80 }
-
-      context 'because configuration never happened' do
-
-        let(:default_model) do
-          step = 'x' * (default_character_threshold + 1)
-          CukeLinter::ModelFactory.generate_step_model(source_text: "* #{step}")
-        end
-
-        it 'defaults to a maximum of 80 characters' do
-          result = subject.lint(default_model)
-
-          expect(result[:problem]).to match(/^Step is too long. \d+ characters found \(max 80\)/)
-        end
-
-      end
-
-      context 'because configuration did not set a step threshold' do
-        let(:configuration) { {} }
-        let(:configured_model) do
-          subject.configure(configuration)
-          step = 'x' * (default_character_threshold + 1)
-          CukeLinter::ModelFactory.generate_step_model(source_text: "* #{step}")
-        end
-
-        it 'defaults to a maximum of 80 characters' do
-          result = subject.lint(configured_model)
-
-          expect(result[:problem]).to match(/^Step is too long. \d+ characters found \(max 80\)/)
-        end
-
-      end
-
-    end
-
-    context 'when configured' do
-      let(:character_threshold) { 10 }
-      let(:configuration) { { 'StepLengthThreshold' => character_threshold } }
-
-      subject { linter = CukeLinter::StepWithTooManyCharactersLinter.new
-                linter.configure(configuration)
-                linter }
-
-      let(:test_model) do
-        step = 'x' * (character_threshold + 1)
-        CukeLinter::ModelFactory.generate_step_model(source_text: "* #{step}")
-      end
-
-      it 'uses the maximum character length provided by configuration' do
-        result = subject.lint(test_model)
-
-        expect(result[:problem]).to match(/^Step is too long. \d+ characters found \(max 10\)/)
-      end
-
-    end
-
-  end
-end