cuke_linter 0.12.1 → 0.13.0

data/testing/cucumber/features/linters/test_with_setup_step_after_action_step.feature

@@ -23,8 +23,35 @@ Feature: Test with setup step after action step linter
       | linter                                 | problem                                  | location         |
       | TestWithSetupStepAfterActionStepLinter | Test has 'Given' step after 'When' step. | <path_to_file>:3 |
 
+  Scenario: Configuration of keywords for different dialect
+    Given a linter for tests with a setup step after an action step has been registered
+    And the following configuration file:
+      """
+      TestWithSetupStepAfterActionStepLinter:
+        Given:
+          - Dado
+          - Dadas
+        When:
+          - Quando
+        Then:
+          - Então
+      """
+    And the following feature:
+      """
+      # language:pt
+      Funcionalidade: Feature name
+
+        Cenário: scenario name
+          Quando this is an action in pt dialect
+          Dado some setup in pt dialect
+      """
+    When the configuration file is loaded
+    And it is linted
+    Then an error is reported:
+      | linter                                 | problem                                  | location         |
+      | TestWithSetupStepAfterActionStepLinter | Test has 'Given' step after 'When' step. | <path_to_file>:4 |
+
   @wip
   Scenario: Configuration
 
-  Configure the keyword(s) that count as setup/action/verification steps?
   Configure whether or not to include background steps?

data/testing/cucumber/features/linters/test_with_setup_step_after_verification_step.feature

@@ -23,8 +23,35 @@ Feature: Test with setup step after verification step linter
       | linter                                       | problem                                  | location         |
       | TestWithSetupStepAfterVerificationStepLinter | Test has 'Given' step after 'Then' step. | <path_to_file>:3 |
 
+  Scenario: Configuration of keywords for different dialect
+    Given a linter for tests with a setup step after a verification step has been registered
+    And the following configuration file:
+      """
+      TestWithSetupStepAfterVerificationStepLinter:
+        Given:
+          - Dado
+          - Dadas
+        When:
+          - Quando
+        Then:
+          - Então
+      """
+    And the following feature:
+      """
+      # language:pt
+      Funcionalidade: Feature name
+
+        Cenário: scenario name
+          Então this is an validation in pt dialect
+          Dado some setup in pt dialect
+      """
+    When the configuration file is loaded
+    And it is linted
+    Then an error is reported:
+      | linter                                       | problem                                  | location         |
+      | TestWithSetupStepAfterVerificationStepLinter | Test has 'Given' step after 'Then' step. | <path_to_file>:4 |
+
   @wip
   Scenario: Configuration
 
-  Configure the keyword(s) that count as verification steps?
   Configure whether or not to include background steps?

data/testing/cucumber/features/linters/test_with_setup_step_as_final_step.feature

@@ -22,7 +22,29 @@ Feature: Test with setup step as final step linter
       | linter                             | problem                             | location         |
       | TestWithSetupStepAsFinalStepLinter | Test has 'Given' as the final step. | <path_to_file>:3 |
 
-  @wip
-  Scenario: Configuration
+  Scenario: Configuration of keywords for different dialect
+    Given a linter for tests with a setup step as the final step has been registered
+    And the following configuration file:
+      """
+      TestWithSetupStepAsFinalStepLinter:
+        Given:
+          - Dado
+          - Dadas
+        When:
+          - Quando
+        Then:
+          - Então
+      """
+    And the following feature:
+      """
+      # language:pt
+      Funcionalidade: Feature name
 
-  Configure the keyword(s) that count as setup steps?
+        Cenário: scenario name
+          Dado some setup in pt dialect
+      """
+    When the configuration file is loaded
+    And it is linted
+    Then an error is reported:
+      | linter                             | problem                             | location         |
+      | TestWithSetupStepAsFinalStepLinter | Test has 'Given' as the final step. | <path_to_file>:4 |

data/testing/cucumber/step_definitions/setup_steps.rb

@@ -101,6 +101,34 @@ Given(/^a linter for tests with too many steps has been registered$/) do
   CukeLinter.register_linter(linter: CukeLinter::TestWithTooManyStepsLinter.new, name: 'TestWithTooManyStepsLinter')
 end
 
+Given(/^a linter for backgrounds that do more than setup has been registered$/) do
+  CukeLinter.register_linter(linter: CukeLinter::BackgroundDoesMoreThanSetupLinter.new, name: 'BackgroundDoesMoreThanSetupLinter')
+end
+
+Given(/^a linter for tests with an action step as the final step has been registered$/) do
+  CukeLinter.register_linter(linter: CukeLinter::TestWithActionStepAsFinalStepLinter.new, name: 'TestWithActionStepAsFinalStepLinter')
+end
+
+Given(/^a linter for tests with no action step has been registered$/) do
+  CukeLinter.register_linter(linter: CukeLinter::TestWithNoActionStepLinter.new, name: 'TestWithNoActionStepLinter')
+end
+
+Given(/^a linter for tests with no verification step has been registered$/) do
+  CukeLinter.register_linter(linter: CukeLinter::TestWithNoVerificationStepLinter.new, name: 'TestWithNoVerificationStepLinter')
+end
+
+Given(/^a linter for tests with a setup step after an action step has been registered$/) do
+  CukeLinter.register_linter(linter: CukeLinter::TestWithSetupStepAfterActionStepLinter.new, name: 'TestWithSetupStepAfterActionStepLinter')
+end
+
+Given(/^a linter for tests with a setup step after a verification step has been registered$/) do
+  CukeLinter.register_linter(linter: CukeLinter::TestWithSetupStepAfterVerificationStepLinter.new, name: 'TestWithSetupStepAfterVerificationStepLinter')
+end
+
+Given(/^a linter for tests with a setup step as the final step has been registered$/) do
+  CukeLinter.register_linter(linter: CukeLinter::TestWithSetupStepAsFinalStepLinter.new, name: 'TestWithSetupStepAsFinalStepLinter')
+end
+
 Given("a linter for features without a description") do
   @linter = CukeLinter::FeatureWithoutDescriptionLinter.new
 end

data/testing/rspec/spec/unit/cuke_linter_unit_spec.rb

@@ -25,6 +25,18 @@ RSpec.describe CukeLinter do
     expect(CukeLinter::VERSION).not_to be nil
   end
 
+  it "has a default keyword for 'Given'" do
+    expect(CukeLinter::DEFAULT_GIVEN_KEYWORD).to eq('Given')
+  end
+
+  it "has a default keyword for 'When'" do
+    expect(CukeLinter::DEFAULT_WHEN_KEYWORD).to eq('When')
+  end
+
+  it "has a default keyword for 'Then'" do
+    expect(CukeLinter::DEFAULT_THEN_KEYWORD).to eq('Then')
+  end
+
   it 'can lint' do
     expect(CukeLinter).to respond_to(:lint)
   end

data/testing/rspec/spec/unit/linters/background_does_more_than_setup_linter_unit_spec.rb

@@ -6,6 +6,7 @@ RSpec.describe CukeLinter::BackgroundDoesMoreThanSetupLinter do
   let(:model_file_path) { 'some_file_path' }
 
   it_should_behave_like 'a linter at the unit level'
+  it_should_behave_like 'a configurable linter at the unit level'
 
 
   it 'has a name' do
@@ -66,6 +67,114 @@ RSpec.describe CukeLinter::BackgroundDoesMoreThanSetupLinter do
 
     end
 
+
+    describe 'configuration' do
+
+      let(:test_model) do
+        CukeLinter::ModelFactory.generate_background_model
+      end
+
+      context 'with configuration' do
+
+        before(:each) do
+          subject.configure(configuration)
+        end
+
+        context "with a configured 'When' keyword" do
+
+          let(:when_keyword) { 'Foo' }
+          let(:configuration) { { 'When' => when_keyword } }
+
+          it "uses the configured 'When' keyword" do
+            test_model.steps.first.keyword = when_keyword
+
+            result = subject.lint(test_model)
+
+            expect(result).to_not be_nil
+          end
+
+        end
+
+        context "with a configured 'Then' keyword" do
+
+          let(:then_keyword) { 'Foo' }
+          let(:configuration) { { 'Then' => then_keyword } }
+
+          it "uses the configured 'Then' keyword" do
+            test_model.steps.first.keyword = then_keyword
+
+            result = subject.lint(test_model)
+
+            expect(result).to_not be_nil
+          end
+
+        end
+
+      end
+
+      context 'without configuration' do
+
+        context 'because configuration never happened' do
+
+          it "uses the default 'When' keyword" do
+            test_model.steps.first.keyword = CukeLinter::DEFAULT_WHEN_KEYWORD
+
+            result = subject.lint(test_model)
+
+            expect(result).to_not be_nil
+          end
+
+          it "uses the default 'Then' keyword" do
+            test_model.steps.first.keyword = CukeLinter::DEFAULT_THEN_KEYWORD
+
+            result = subject.lint(test_model)
+
+            expect(result).to_not be_nil
+          end
+
+        end
+
+        context "because configuration did not set a 'When' keyword" do
+
+          before(:each) do
+            subject.configure(configuration)
+          end
+
+          let(:configuration) { {} }
+
+          it "uses the default 'When' keyword" do
+            test_model.steps.first.keyword = CukeLinter::DEFAULT_WHEN_KEYWORD
+
+            result = subject.lint(test_model)
+
+            expect(result).to_not be_nil
+          end
+
+        end
+
+        context "because configuration did not set a 'Then' keyword" do
+
+          before(:each) do
+            subject.configure(configuration)
+          end
+
+          let(:configuration) { {} }
+
+          it "uses the default 'Then' keyword" do
+            test_model.steps.first.keyword = CukeLinter::DEFAULT_THEN_KEYWORD
+
+            result = subject.lint(test_model)
+
+            expect(result).to_not be_nil
+          end
+
+        end
+
+      end
+
+    end
+
+
     context 'a non-background model' do
 
       let(:test_model) { CukeModeler::Model.new }

data/testing/rspec/spec/unit/linters/test_with_action_step_as_final_step_linter_unit_spec.rb

@@ -6,6 +6,7 @@ RSpec.describe CukeLinter::TestWithActionStepAsFinalStepLinter do
   let(:model_file_path) { 'some_file_path' }
 
   it_should_behave_like 'a linter at the unit level'
+  it_should_behave_like 'a configurable linter at the unit level'
 
 
   it 'has a name' do
@@ -86,6 +87,72 @@ RSpec.describe CukeLinter::TestWithActionStepAsFinalStepLinter do
 
     end
 
+    describe 'configuration' do
+
+      let(:test_model) do
+        CukeLinter::ModelFactory.generate_scenario_model(source_text: 'Scenario:
+                                                                         * a step')
+      end
+
+      context 'with configuration' do
+
+        before(:each) do
+          subject.configure(configuration)
+        end
+
+        context "with a configured 'When' keyword" do
+
+          let(:when_keyword) { 'Foo' }
+          let(:configuration) { { 'When' => when_keyword } }
+
+          it "uses the configured 'When' keyword" do
+            test_model.steps.last.keyword = when_keyword
+
+            result = subject.lint(test_model)
+
+            expect(result).to_not be_nil
+          end
+
+        end
+
+      end
+
+      context 'without configuration' do
+
+        context 'because configuration never happened' do
+
+          it "uses the default 'When' keyword" do
+            test_model.steps.last.keyword = CukeLinter::DEFAULT_WHEN_KEYWORD
+
+            result = subject.lint(test_model)
+
+            expect(result).to_not be_nil
+          end
+
+        end
+
+        context "because configuration did not set a 'When' keyword" do
+
+          before(:each) do
+            subject.configure(configuration)
+          end
+
+          let(:configuration) { {} }
+
+          it "uses the default 'When' keyword" do
+            test_model.steps.last.keyword = CukeLinter::DEFAULT_WHEN_KEYWORD
+
+            result = subject.lint(test_model)
+
+            expect(result).to_not be_nil
+          end
+
+        end
+
+      end
+
+    end
+
 
     context 'a non-test model' do
 

data/testing/rspec/spec/unit/linters/test_with_no_action_step_linter_unit_spec.rb

@@ -6,6 +6,7 @@ RSpec.describe CukeLinter::TestWithNoActionStepLinter do
   let(:model_file_path) { 'some_file_path' }
 
   it_should_behave_like 'a linter at the unit level'
+  it_should_behave_like 'a configurable linter at the unit level'
 
 
   it 'has a name' do
@@ -165,6 +166,73 @@ RSpec.describe CukeLinter::TestWithNoActionStepLinter do
     end
 
 
+    describe 'configuration' do
+
+      let(:test_model) do
+        CukeLinter::ModelFactory.generate_scenario_model(source_text: 'Scenario:
+                                                                         When a step')
+      end
+
+      context 'with configuration' do
+
+        before(:each) do
+          subject.configure(configuration)
+        end
+
+        context "with a configured 'When' keyword" do
+
+          let(:when_keyword) { 'Foo' }
+          let(:configuration) { { 'When' => when_keyword } }
+
+          it "uses the configured 'When' keyword" do
+            test_model.steps.first.keyword = 'When'
+
+            result = subject.lint(test_model)
+
+            expect(result).to_not be_nil
+          end
+
+        end
+
+      end
+
+      context 'without configuration' do
+
+        context 'because configuration never happened' do
+
+          it "uses the default 'When' keyword" do
+            test_model.steps.first.keyword = CukeLinter::DEFAULT_WHEN_KEYWORD
+
+            result = subject.lint(test_model)
+
+            expect(result).to be_nil
+          end
+
+        end
+
+        context "because configuration did not set a 'When' keyword" do
+
+          before(:each) do
+            subject.configure(configuration)
+          end
+
+          let(:configuration) { {} }
+
+          it "uses the default 'When' keyword" do
+            test_model.steps.last.keyword = CukeLinter::DEFAULT_WHEN_KEYWORD
+
+            result = subject.lint(test_model)
+
+            expect(result).to be_nil
+          end
+
+        end
+
+      end
+
+    end
+
+
     context 'a non-test model' do
 
       let(:test_model) { CukeModeler::Model.new }