cuke_linter 0.11.0 → 0.11.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 2262e2bfc35fa228578832a6dcaaf98c414ae641316de99c0e4123d58951bbf6
-  data.tar.gz: 02334cd45f28a225cef180e451f95eac230bcbc7912ae41637e6e999abe539f8
+  metadata.gz: 05f9639710a8ee90502992efd3bf5a0cd23d989e10f8b2699ca2120c25729c64
+  data.tar.gz: 6aeae6c4a917210bc09de39b0d751de4c0c15c929478dd362f65c6ac3e88dc70
 SHA512:
-  metadata.gz: 93e8b329df051721fd6ca9405740863ca4c8bcee606cbfe33854ad9d57e63bb4d5c3da99c0a4345d349e77f3adb39d676cec088ed469a557f44c90dcff1b6111
-  data.tar.gz: 31bdfa3dcb5dd22066b481aa45d9499b2f5c96a2f31f79581a8c1d2afa5d0d2d136ef247199e2ee5846914779f6955fad373ce9783bf7c4907ad6df4102c621e
+  metadata.gz: 6e11d0529be4f2202de3f98bf2cf7149822fd2378f5ec18de2b4c2a0cbdc56f7b8534614de911ffd570823e4faf0ffb06ceed31df392a37ab7911c1edd1c3715
+  data.tar.gz: c5152f78a6092267fe7050445c72864807cd70ce61af044292c5af3be5a91e180d236680ca3e3622795417d08e1c47ada1bbfcaf8cb99a7607df8a22f91e5885

data/CHANGELOG.md

@@ -8,6 +8,13 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 Nothing yet... *(see development branch)*
 
+
+## [0.11.1] - 2019-11-07
+
+### Fixed
+ - Fixed the Pretty formatter so that it can handle linting problems whose locations do not have a line number.
+
+
 ## [0.11.0] - 2019-11-01
 
 ### Added
@@ -112,7 +119,8 @@ Nothing yet... *(see development branch)*
 - Custom linters, formatters, and command line usability
 
 
-[Unreleased]: https://github.com/enkessler/cuke_linter/compare/v0.11.0...HEAD
+[Unreleased]: https://github.com/enkessler/cuke_linter/compare/v0.11.1...HEAD
+[0.11.1]: https://github.com/enkessler/cuke_linter/compare/v0.11.0...v0.11.1
 [0.11.0]: https://github.com/enkessler/cuke_linter/compare/v0.10.0...v0.11.0
 [0.10.0]: https://github.com/enkessler/cuke_linter/compare/v0.9.0...v0.10.0
 [0.9.0]: https://github.com/enkessler/cuke_linter/compare/v0.8.0...v0.9.0

data/lib/cuke_linter/formatters/pretty_formatter.rb

@@ -21,10 +21,10 @@ module CukeLinter
           formatted_data << "  #{problem}" + "\n"
 
           sorted_locations = locations.sort do |a, b|
-            file_name_1   = a.match(/(.*):\d+$/)[1]
-            line_number_1 = a.match(/:(\d+)$/)[1].to_i
-            file_name_2   = b.match(/(.*):\d+$/)[1]
-            line_number_2 = b.match(/:(\d+)$/)[1].to_i
+            file_name_1   = a.match(/(.*?)(?::\d+)?$/)[1]
+            line_number_1 = a.match(/:(\d+)$/) ? a.match(/:(\d+)$/)[1].to_i : 0
+            file_name_2   = b.match(/(.*?)(?::\d+)?$/)[1]
+            line_number_2 = b.match(/:(\d+)$/) ? b.match(/:(\d+)$/)[1].to_i : 0
 
             case
               when (file_name_1 < file_name_2) ||

data/lib/cuke_linter/version.rb

@@ -1,4 +1,4 @@
 module CukeLinter
   # The release version of this gem
-  VERSION = '0.11.0'
+  VERSION = '0.11.1'
 end

data/testing/rspec/spec/unit/formatters/pretty_formatter_unit_spec.rb

@@ -12,7 +12,10 @@ RSpec.describe CukeLinter::PrettyFormatter do
                       location: 'path/to/the_file:1' },
                     { linter:   'SomeOtherLinter',
                       problem:  'Some other problem',
-                      location: 'path/to/the_file:1' }]
+                      location: 'path/to/the_file:1' },
+                    { linter:   'YetAnotherLinter',
+                      problem:  'Yet another problem',
+                      location: 'path/to/the_file' }]
 
     results = subject.format(linting_data)
 
@@ -22,8 +25,11 @@ RSpec.describe CukeLinter::PrettyFormatter do
                            'SomeOtherLinter',
                            '  Some other problem',
                            '    path/to/the_file:1',
+                           'YetAnotherLinter',
+                           '  Yet another problem',
+                           '    path/to/the_file',
                            '',
-                           '2 issues found'].join("\n"))
+                           '3 issues found'].join("\n"))
   end
 
   it 'groups data by linter and problem' do
@@ -50,7 +56,7 @@ RSpec.describe CukeLinter::PrettyFormatter do
                            '3 issues found'].join("\n"))
   end
 
-  it 'orders violations within the same category by file path' do
+  it 'orders violations within the same problem category by file path' do
     linting_data = [{ linter:   'SomeLinter',
                       problem:  'Some problem',
                       location: 'path/to/the_file:1' },
@@ -85,6 +91,9 @@ RSpec.describe CukeLinter::PrettyFormatter do
                     { linter:   'SomeLinter',
                       problem:  'Some problem',
                       location: 'path/to/the_file:3' }, # duplicate number
+                    { linter:   'SomeLinter',
+                      problem:  'Some problem',
+                      location: 'path/to/the_file' }, # no number
                     { linter:   'SomeLinter',
                       problem:  'Some problem',
                       location: 'path/to/the_file:1' }]
@@ -93,13 +102,14 @@ RSpec.describe CukeLinter::PrettyFormatter do
 
     expect(results).to eq(['SomeLinter',
                            '  Some problem',
+                           '    path/to/the_file',
                            '    path/to/the_file:1',
                            '    path/to/the_file:2',
                            '    path/to/the_file:3',
                            '    path/to/the_file:3',
                            '    path/to/the_file:11',
                            '',
-                           '5 issues found'].join("\n"))
+                           '6 issues found'].join("\n"))
   end
 
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: cuke_linter
 version: !ruby/object:Gem::Version
-  version: 0.11.0
+  version: 0.11.1
 platform: ruby
 authors:
 - Eric Kessler
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2019-11-01 00:00:00.000000000 Z
+date: 2019-11-07 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: cuke_modeler